2690230451
Stop working around issue 17083 in stack_trace.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//353073004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37762 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-26 21:42:23 +00:00
80c26b96d7
Properly handle synchronous errors in Chain.capture.
...
R=rnystrom@google.com
BUG=19542
Review URL: https://codereview.chromium.org//344953002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37520 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-19 21:12:35 +00:00
13acf5ae04
Use path.prettyUri in stack_trace.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//298873011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36599 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-24 00:08:21 +00:00
7cf1ba97ad
Properly handle errors thrown in [Chain.capture]'s [onError] handler.
...
The Zone infrastructure apparently doesn't automatically pipe errors
to the parent Zone (issue 18134).
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//232123003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34904 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-09 23:49:16 +00:00
1f6d349cf7
Add more docs about stack chains to the stack trace package.
...
BUG=
R=kathyw@google.com
Review URL: https://codereview.chromium.org//201183006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34199 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 19:56:06 +00:00
8e926e46ce
Support IE10 stack traces in pkg/stack_trace.
...
R=rnystrom@google.com
BUG=17633
Review URL: https://codereview.chromium.org//197283039
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34135 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 20:24:29 +00:00
8644dc9732
Add Chain.foldFrames to pkg/stack_trace.
...
R=rnystrom@google.com
BUG=17082
Review URL: https://codereview.chromium.org//180223005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33041 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 23:20:00 +00:00
61934b7d7d
Work around issue 17083 in pkg/stack_trace.
...
This also properly reports timer_impl.dart as being in dart:io rather
than dart:async.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//180363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33039 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-25 22:35:49 +00:00
a24587554f
Validate that Trace.from's argument isn't null.
...
R=rnystrom@google.com
BUG=16071
Review URL: https://codereview.chromium.org//137443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31762 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 22:37:40 +00:00
c7aeb3406e
Support Safari 6.1 stack traces with blank lines in pkg/stack_trace.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//136693006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31756 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-13 21:07:47 +00:00
64fe897e4e
Code review changes for r31644.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//132223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31679 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 22:02:27 +00:00
8135a4dede
Properly parse V8 lines involving eval in pkg/stack_trace.
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//130443002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31644 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-09 01:52:31 +00:00
e2f1ff9e27
Work around issue 15920 in pkg/stack_trace.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//112953004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31526 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-07 00:39:31 +00:00
50a0e3cf6e
Chain.terse shouldn't return an empty chain.
...
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//116913003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31177 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-17 01:09:29 +00:00
35dc712dd5
Add a stack chain class to the stack trace package.
...
This class uses zones to track stack traces across asynchronous boundaries. It
will aid considerably in debugging errors in heavily-asynchronous programs.
R=floitsch@google.com , rnystrom@google.com
BUG=7040
Review URL: https://codereview.chromium.org//75863004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30738 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 23:03:49 +00:00
510387d990
Make the stack_trace package print relative URLs for browser paths.
...
Prior to this, only console paths were printed as relative.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//75543013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30484 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 21:02:03 +00:00
baee87f63d
Work around issue 11901 in stack_trace.
...
For some reason, timer_impl.dart in dart:async has the incorrect URL
in VM stack traces. This adds manual handling for that in the
stack_trace package.
R=rnystrom@google.com
BUG=
Review URL: https://codereview.chromium.org//63393004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30318 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-15 22:16:10 +00:00
31ac89f049
Properly parse jsshell and d8 stack frames.
...
It turns out jsshell and d8 can use native paths where Firefox and
Chrome usually use URLs. This CL accommodates that.
R=rnystrom@google.com
BUG=14897
Review URL: https://codereview.chromium.org//63603005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30079 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-07 22:41:42 +00:00
9cb7129067
Support Safari 6.1's new stack trace format in pkg/stack_trace.
...
R=rnystrom@google.com
BUG=14534
Review URL: https://codereview.chromium.org//48273005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29399 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-28 21:50:23 +00:00
3c132b1e28
Properly parse friendly stack traces without columns.
...
Review URL: https://codereview.chromium.org//28783006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28892 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 22:57:06 +00:00
54d951a769
Make stack frames without columns print correctly.
...
This works around issue 14233.
R=alanknight@google.com
Review URL: https://codereview.chromium.org//29323004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28884 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-18 21:55:41 +00:00
66e568e6ce
Work around issue 14125 in stack_trace by adding a dummy setter.
...
R=rnystrom@google.com
BUG=13945
Review URL: https://codereview.chromium.org//27416002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28811 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 18:09:58 +00:00
c4be237e68
- Fix build.
...
Review URL: https://codereview.chromium.org//24249010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27854 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 21:15:04 +00:00
f18e12b5db
Address codereview comments:
...
- Update variable names.
- Add test case for column-free stack frame.
Review URL: https://codereview.chromium.org//24395014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27852 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 20:54:26 +00:00
8a9adf5656
- Use simplified token location call where appropriate.
...
R=asiva@google.com , hausner@google.com , mlippautz@google.com
Review URL: https://codereview.chromium.org//23850014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27833 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 17:32:40 +00:00
28790a8eba
Support "[as ...]" in V8 stack traces in pkg/stack_trace.
...
BUG=13431
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23533074
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27720 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 19:38:58 +00:00
2ff7bb2447
One-liners for unittest and matcher.
...
Also had to give a one-liner to stack_trace, to work around a doc generation issue (dartbug.com/13246).
R=gram@google.com
Review URL: https://codereview.chromium.org//23828006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27398 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-11 19:28:17 +00:00
43b08221c4
Fixing stack traces on IE10.
...
BUG=
R=nweiz@google.com
Review URL: https://codereview.chromium.org//23445005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26735 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 18:35:08 +00:00
56f9452f65
Fix a bad merge in pkg/stack_trace.
...
TBR
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//22880030
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26467 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 20:15:01 +00:00
202a7a3e00
Support IE and Safari stack traces.
...
R=rnystrom@google.com
BUG=12380
Review URL: https://codereview.chromium.org//23068019
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26464 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 19:58:07 +00:00
53275e8ec5
Properly parse V8 stack traces that contain the exception description.
...
R=rnystrom@google.com
BUG=12151
Review URL: https://codereview.chromium.org//23159007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26395 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 21:41:33 +00:00
a24a587bb0
Support "..." VM frames in pkg/stack_trace.
...
Also include the original stack trace when a parse error occurs.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//23133004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26132 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-14 18:10:23 +00:00
a9d24edd0f
Rename "pathos" package to "path".
...
R=ajohnsen@google.com
Review URL: https://codereview.chromium.org//18356011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24964 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-12 17:54:48 +00:00
a1dfaf542d
Make the Firefox trace RegExp not go exponential on V8.
...
BUG=11645
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//18339005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24829 260f80e4-7a28-3924-810f-c04153c831b5
2013-07-08 22:25:07 +00:00
031c343cae
Add a couple functions to package:stack_trace.
...
This adds a function to convert a Trace to a VM-style StackTrace
object, and to parse a Trace-style string into a Trace.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//18029023
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24611 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 22:24:01 +00:00
83d0bc07d2
Properly handle empty stack traces in package:stack_trace.
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org//18170002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24571 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 01:50:01 +00:00
e91e9182c5
Add support for V8 and Firefox stack traces in pkg/stack_trace.
...
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//18167002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24569 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-28 01:22:36 +00:00
5089f391d2
Revert "Add support for V8 and Firefox stack traces in pkg/stack_trace."
...
This reverts commit r24502.
Review URL: https://codereview.chromium.org//17998002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24506 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 02:16:12 +00:00
a92a52a4ff
Add support for V8 and Firefox stack traces in pkg/stack_trace.
...
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//17765004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24502 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-27 00:28:28 +00:00
25ec4666f0
Fix the pkg/stack_trace tests.
...
On Windows they're now (correctly) using relative URIs as opposed to
relative paths.
Review URL: https://codereview.chromium.org//17157009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24205 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-19 22:15:07 +00:00
66404438fc
Add toUri and fromUri functions to pathos.
...
This also replaces the ubiqutous pathToFileUri/fileUriToPath functions.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//16848002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24196 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-19 19:06:19 +00:00
25d42f64e6
Make the StackTrace library better handle core library frames.
...
Core library stack frames now have libraries and meaningful line numbers, so in
general we should preserve those. However, terse stack traces don't care about
the internal workings of the core libraries, so they now explicitly remove the
library and line number information.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//16097012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23621 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-04 23:36:31 +00:00
9d6a64e81b
Merge the dart:uri library into dart:core and update the Uri class
...
This merges the dart:uri library into dart:core removing the dart:uri library. Besides moving the library the Url class has been changed.
* Removed existing Uri constructor as it was equivalent with Uri.parse
* Remamed constructor Uri.fromComponents to Uri
* Moved toplevel function encodeUriComponent to static method Uri.encodeComponent
* Moved toplevel function decodeUriComponent to static method Uri.decodeComponent
* Moved toplevel function encodeUri to static method Uri.encodeFull
* Moved toplevel function decodeUri to static method Uri.decodeFull
* Rename domain to host
* Added static methods Uri.encodeQueryComponent and Uri.decodeQueryComponent
* Added support for path generation and splitting
* Added support for query generation and splitting
* Added some level of normalization
R=floitsch@google.com , lrn@google.com , nweiz@google.com , scheglov@google.com
BUG=
Review URL: https://codereview.chromium.org//16019002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@23266 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-28 13:35:01 +00:00
d548955117
Enable parsing of IPv6 form addresse (see rfc2373 and rfc2732).
...
This also wraps the 'domain' component in toString with [...], if it
contains any ':' characters.
BUG=
R=floitsch@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//14753005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22228 260f80e4-7a28-3924-810f-c04153c831b5
2013-05-01 09:27:50 +00:00
7523a1df0d
Be lazier when capturing stack traces.
...
It turns out that capturing stack traces is cheap; converting them to strings is
what's so expensive.
R=rnystrom@google.com
Review URL: https://codereview.chromium.org//14647003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22205 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-30 21:34:08 +00:00
0ff9830d88
Fix a bug in pathToFileUri.
...
TBR
Review URL: https://codereview.chromium.org//14287003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21916 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 01:00:03 +00:00
18ef5b5d80
Clean up various ways we find paths in pub.
...
This makes it so that it's never necessary to pass in DART_SDK.
Review URL: https://codereview.chromium.org//14449004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21914 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 23:55:46 +00:00
cdb1f717a3
Use UnmodifiableListView to expose read-only lists.
...
Review URL: https://codereview.chromium.org//14394003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21855 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-22 23:05:30 +00:00
8fd2c2e5ea
add installation instructions to pkg packages
...
BUG=
Review URL: https://codereview.chromium.org//14188048
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21770 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-19 20:51:10 +00:00
0f607e459c
Remove methods on StackTrace class.
...
The API is not ready for finalization, so we remove it for further
development after M4.
Makes dart2js's StackTrace object implement dart:core's StackTrace.
Marks dart2js stack-trace tests as Fail instead of Skip.
Review URL: https://codereview.chromium.org//14009004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21437 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 11:44:30 +00:00
nweiz@google.com