dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
88,473 Commits 2 Branches 0 Tags
2b7b4dc777284f10398cd75813cbdec89fea8da9
Commit Graph

382 Commits

Author SHA1 Message Date
Sam Rawlins 5f8ef7be53 Enable new linter rules in analyzer packages 
Change-Id: Id0182648a347a05cbf6e1483a0afe94219268853
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-11-21 23:02:38 +00:00
Danny Tuppeny 3f206da5e3 [analyzer] Propagate nullability in InterfaceType.allSupertypes 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4185.

Change-Id: Ic9fcd60ef3eae24e3921c25162ec405a56c62c53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-17 21:59:44 +00:00
Danny Tuppeny 1d64cba68e [analysis_server] Fix override completions being suppressed because of import edits 
Fixes https://github.com/Dart-Code/Dart-Code/issues/4116, although currently inserts the override without adding imports (imports will be added in a separate CL).

Change-Id: Ib78442c8a084928ff7da122a17d4b035b3fade8f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/270180
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-11-16 17:51:50 +00:00
Ahmed Ashour 98afb38b6a [analysis_server] add fixes for MISSING_OVERRIDE_OF_MUST_BE_OVERRIDDEN_* 
Fixes #50312

Change-Id: I0c599dede1c2c0710d35997144db5457360b096b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266140
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-28 14:42:57 +00:00
Brian Wilkerson 87185a7e83 Extend change builder to support imports with a prefix 
Change-Id: I7735ca52e7d34e876608460141e94693f3910f6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265582
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-25 20:59:45 +00:00
Konstantin Shcheglov 671bb192ab Remove domain 'kythe' from DAS. 
Change-Id: I66f0e538dce6eead6ba1c98b9cf0e3d747450130
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/264895
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-10-21 17:03:29 +00:00
Konstantin Shcheglov 683e2419da Deprecate 'DartType.element2' use 'element' instead. 
Change-Id: I6986a058616db489987789cfab09d53a450e3ab5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262666
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-10-05 16:30:09 +00:00
Konstantin Shcheglov fcc9473dab Deprecate CatchClause.exceptionParameter2/stackTraceParameter2 
Change-Id: I3f0ae9367f35fe514a125cb0f06ccbdc8fa0dc18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/262502
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-10-04 15:58:11 +00:00
Danny Tuppeny d97c3e8702 [analysis_server] Fix updating of selections in change builder when additional edits are made 
This fixes a few minor issues:

- Setting a new selection position did not remove a previously set selection range (which could result in a mismatched offset/length due to how the resulting change merges the position/range)
- Setting a new selection range did not update a previously set selection position
- Inserting new changes before a change that sets a selection range only updated the selection position, not selection range
- Setting a selection range/position after another change that inserts only updated the selection position to compensate and not the selection range

These issues led to cases where selection ranges could be incorrect, or even overlap with linked edit groups that could cause errors that caused code action requests to fail.

Fixes https://github.com/Dart-Code/Dart-Code/issues/4184

Change-Id: I43e2a8361c97b2eccb2d6b426a75eda5cc811e06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261682
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-28 17:32:24 +00:00
Konstantin Shcheglov 745d0ff64a Deprecate 'Element.enclosingElement3', use 'enclosingElement'. 
Change-Id: I6f4fd7e8c0f071bde10cb5e57ed6195ae517e575
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/261221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-26 23:58:14 +00:00
Konstantin Shcheglov 44316060f1 Deprecate 'get declaredElement2', use 'get declaredElement' instead. 
Change-Id: Ida7a9c2ac35943aed2d75f81f98ce7056b616aee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260741
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-23 20:05:29 +00:00
Konstantin Shcheglov e03170035a Deprecate 'get name2', use 'get name' instead. 
Change-Id: Iee8ef5fb6700d96c857a22a99dc61dac3da88572
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/260443
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-22 02:22:47 +00:00
Ahmed Ashour e09493b7bc [analyzer] use preferred quote-style when generating imports 
Bug #49559

Change-Id: Ib77ea67bb1ea15bfabb1c717cfb5abf13fd6d3cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/259720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-21 17:12:46 +00:00
Brian Wilkerson d6ff1193c5 Partial implementation of record types in DartEditBuilder 
While the work is incomplete (see the TODOs), this fixes an exception
that I saw this morning and is, I believe, a step in the right direction.

Change-Id: I6adc0e0df4ea9b64ea0c5d1dcd42a078d30c4a9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/258507
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-09-09 21:48:25 +00:00
Konstantin Shcheglov 3b3d061030 Completion in RecordTypeAnnotation. 
Change-Id: Ic3478551c39d5188e2de2a8245189e5e0674e722
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-02 19:05:53 +00:00
Konstantin Shcheglov a524f04c27 Completion in RecordLiteral(s). 
This also introduces CompletionResponsePrinter, which I'd like to use
instead of fluent APIs. At some point I decided that using easy to
produce, and easy to update expectations is better. Fluent API based
tests are too magical and require too many helper extensions. Also,
with textual dumps full actual results are visible, so it is easy to
compare them with expectations.

The missing key part for using textual dumps in completion tests, that
I realized only recently, was filtering. So, we don't need to dump
every available type, but we can focus on specifically named, or
specifically filtered, entities.

And configuration for `withX` flags lets us enable including features
that are interesting for a particular test suite.

Change-Id: I4a7f7ec99ed202333cf56cd3bb0dfec9ae5c39f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/257261
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-09-01 18:57:02 +00:00
Danny Tuppeny ece330a700 [analysis_server] Include annotation completions at end of class 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3182.

Change-Id: I93d7606cbbf9c527f31dcf9d0fb502dac581abc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/256068
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-24 19:25:39 +00:00
Konstantin Shcheglov 82e33cc598 Add DartType.element2 
Unfortunately my idea about checking for specific `DartType` subtype,
and only then asking for the element is too punitive. It almost
works in google3, but the amount and the kind of changes I had to
do make me realize that we should keep `get elementX` in `DartType`.

I guess this is the same as we had in AST when `get constructors`
does not make sense for mixins (?), but works for classes and enums,
and it is easier to pull it into the superclass.

Change-Id: Ibc4fac0b95d63748fa65de96d29300f477fdfc76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254482
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-11 16:01:48 +00:00
Konstantin Shcheglov f4c009dc33 Deprecate Declaration.declaredElement, use 'declaredElement2' instead. 
This is necessary to separate `ClassElement`, `EnumElement`, and `MixinElement`. And, in the future, augmentations like `ClassAugmentationElement`, etc.

Change-Id: Iecd2f8707212e53ef56f0e101880c7bab9e5d057
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254104
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-09 17:26:06 +00:00
Konstantin Shcheglov 75b8b916d6 Deprecate ClassOrMixinDeclaration, use ClassDeclaration or MixinDeclaration. 
Change-Id: I23e292e9f7c4413edf9b068f057dd02794db21a8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/254064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-08 21:40:40 +00:00
Konstantin Shcheglov cbfad8f802 Deprecate DartType.element, use specific element accessor for InterfaceType, TypeParameterType. 
For `InterfaceType` keep `element2` deprecated and define
`InterfaceElement get element2` instead. Most changes are because
of this.

Change-Id: I13b888610fc707438c3c97b676f1460e7fc2b040
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253564
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-08-04 16:18:06 +00:00
Konstantin Shcheglov 71ef76ddfd Deprecate Element.enclosingElement2, use 'enclosingElement3'. 
Change-Id: I0aba589bd42648eb420051cbe04bb3ef435081e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253400
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-02 18:00:14 +00:00
Konstantin Shcheglov 01173e2aa2 Deprecate 'name' in AST, use 'name2' token instead. 
Change-Id: I867f009dca12208f835199297d2ea85c203c8556
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252566
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-08-02 16:25:34 +00:00
Konstantin Shcheglov 33b672f789 Use CatchClauseParameter instead of SimpleIdentifier. 
Change-Id: Ib254d05954548d4101fef9c2545d18b2611b59dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253100
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-08-01 17:32:04 +00:00
Konstantin Shcheglov 5f96a8c7fb Deprecate disjoined 'uriX' properties in favor of 'DirectiveUri'. 
Change-Id: I6414f7e0f041a7a4454564195b2582e643f01b7b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/253024
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-30 19:39:42 +00:00
pq 1f02320791 use codestyle options (rather than lint enablement) 
Related to: https://github.com/dart-lang/sdk/issues/49558

Change-Id: Iac37649d58be88d7d26db179ac6b48958b0c1701
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-07-29 01:05:51 +00:00
Konstantin Shcheglov 2f3269faa1 Deprecate 'Element.enclosingElement', switch to enclosingElement2. 
We need this for:
1. CompilationUnitElement changes its enclosing element from LibraryElement to LibraryOrAugmentationElement
2. Similarly PrefixElement.

Change-Id: I5e3719b4ef59d03caab1b20c9172a8c0fd786bdf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251900
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-07-19 15:44:14 +00:00
Konstantin Shcheglov e23101a16f Rename to LibraryImportElement, LibraryExportElement. 
Change-Id: I0928ca5522d9c67142111a8f3a7eb4d84f114f56
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251844
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-07-18 20:01:18 +00:00
Konstantin Shcheglov a943d2707b Use ImportDirectiveState to build LibraryElement.imports2, add ImportElement2. 
Change-Id: I27a0e87a812eb3733ccfc7b98841c4169dc0a070
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250790
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2022-07-11 16:54:32 +00:00
Ahmed Ashour df1e5cce34 [analysis_server] Add FlutterConvertToStatelessWidget assist 
Fixes #46011

Change-Id: I14a4498831ed7d91a2ac1350824f5b7d8d0023c1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250087
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-07 16:19:31 +00:00
Devon Carew 9282573e2c [analyzer] use package:lints for pkg/analysis_server_client, pkg/analyzer_plugin 
Change-Id: I97d30af3930c3f65532d77dee06de57ce5f5fc20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250766
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-07-06 19:54:00 +00:00
Konstantin Shcheglov a8541852d5 Extract NullableObjectExtension. 
Change-Id: I2fe2704d875082d20e1586f924aeebd6653703ee
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250262
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-06-30 14:25:26 +00:00
Phil Quitslund 9a48d1b82f Reland "[data driven] support moving symbols across packages" 
This reverts commit f111a2df54.

Reason for revert: this change was mistakenly associated w/ a windows bot breakage (https://github.com/flutter/flutter/issues/105641)

Original change's description:
> Revert "[data driven] support moving symbols across packages"
>
> This reverts commit 3290d7a137.
>
> Reason for revert: flutter engine breakage (https://github.com/flutter/flutter/issues/105641)
>
> Original change's description:
> > [data driven] support moving symbols across packages
> >
> > See: https://github.com/dart-lang/sdk/issues/48997
> >
> > Change-Id: Iad16b9eae0523bc4bc14537af642b05efa75b6f7
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246663
> > Commit-Queue: Phil Quitslund <pquitslund@google.com>
> > Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Change-Id: I4a83d50497d6208b7f518ca1b381ece3aab192ad
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247606
> Reviewed-by: Siva Annamalai <asiva@google.com>
> Reviewed-by: Keerti Parthasarathy <keertip@google.com>
> Commit-Queue: Phil Quitslund <pquitslund@google.com>
> Reviewed-by: Phil Quitslund <pquitslund@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I769dec0d85fc0a41048b21deec0724d8509ef8e9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/248061
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-06-13 14:45:06 +00:00
Phil Quitslund f111a2df54 Revert "[data driven] support moving symbols across packages" 
This reverts commit 3290d7a137.

Reason for revert: flutter engine breakage (https://github.com/flutter/flutter/issues/105641)

Original change's description:
> [data driven] support moving symbols across packages
>
> See: https://github.com/dart-lang/sdk/issues/48997
>
> Change-Id: Iad16b9eae0523bc4bc14537af642b05efa75b6f7
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246663
> Commit-Queue: Phil Quitslund <pquitslund@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I4a83d50497d6208b7f518ca1b381ece3aab192ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/247606
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-08 21:35:22 +00:00
pq 3290d7a137 [data driven] support moving symbols across packages 
See: https://github.com/dart-lang/sdk/issues/48997

Change-Id: Iad16b9eae0523bc4bc14537af642b05efa75b6f7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246663
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-06-06 16:53:38 +00:00
Danny Tuppeny fa8a33f60e [analysis_server] Set Container() as final tabstop/selection in Flutter snippets 
Change-Id: I0f1fd31a051440ccc119188cccdb3168c9e58e20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245988
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-25 18:57:28 +00:00
Samuel Rawlins 5050f31b29 Revert "analyzer: Mark implicit-casts and implicit-dynamic as deprecated" 
This reverts commit 6a54fdd46e.

Reason for revert: broke flutter-analyze

Original change's description:
> analyzer: Mark implicit-casts and implicit-dynamic as deprecated
>
> Also add a fix which replaces 'implicit-casts' with 'strict-casts' and
> a fix which replaces 'implicit-dynamic' with 'strict-raw-types'.
>
> Fixes https://github.com/dart-lang/sdk/issues/47902
>
> Change-Id: I293c3c1fd671ac85c12f9c050465b4d77632f241
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224800
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Reviewed-by: Samuel Rawlins <srawlins@google.com>
> Commit-Queue: Samuel Rawlins <srawlins@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Ib2e9492716d3ff6da4fa4e1c64fd658451b16d88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239008
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-27 16:56:01 +00:00
Sam Rawlins 6a54fdd46e analyzer: Mark implicit-casts and implicit-dynamic as deprecated 
Also add a fix which replaces 'implicit-casts' with 'strict-casts' and
a fix which replaces 'implicit-dynamic' with 'strict-raw-types'.

Fixes https://github.com/dart-lang/sdk/issues/47902

Change-Id: I293c3c1fd671ac85c12f9c050465b4d77632f241
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/224800
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2022-03-25 14:58:50 +00:00
Danny Tuppeny 9a49921c6f [analyzer] Don't produce nested LinkedEditGroups 
Fixes https://github.com/dart-lang/sdk/issues/48612.

Change-Id: Ibe8e5036420e24a1dc5cc36f93e42eded607eaf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-18 16:08:40 +00:00
Danny Tuppeny 094c598703 [analysis_server] Change empty linked edit groups to have placeholder text 
Change-Id: Id687c4db11a1b43507f61e6d8ff5775ccccc819f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/237421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-15 20:03:33 +00:00
Danny Tuppeny 77c650433f [analysis_server] Add support for empty linked edits 
Change-Id: I8e3a57732ecb36712e754549333d551bb0a47e31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-09 16:38:25 +00:00
Konstantin Shcheglov 7b108fb226 Move code locations computing when supportsLocationLink into DefinitionHandler. 
The main reason to do this is that we add navigation regions while
visiting AST, so we will not able to call the async method to parse
a file.

An accidental improvement is also that we will not parse files
multiple times when the same element is referenced multiple times.
Although if different elements of the same file are referenced, we
don't have any improvement here.

Change-Id: Ic4d914e89515af31f2dc3c4f842f0313cc89fac8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-03-03 00:47:39 +00:00
Danny Tuppeny 0501b497bb [analysis_server] Ensure imports are not inserted after exports or between part directives 
Change-Id: Id5137f9a9a65cd66124d375ac4c43c6726714255
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234941
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-02 22:00:49 +00:00
Danny Tuppeny f5bd632abe [analysis_server] Ensure imports are always added before other code being inserted in DartFileEditBuilder 
Change-Id: I390f24ac10f7f061e79c9bfed616e9bcc908d240
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234604
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-03-02 16:37:26 +00:00
Konstantin Shcheglov 60b428e2b1 Deprecate superclass2, mixinTypes2, etc. 
Change-Id: Ieaaeab57930cb93f5b6b1323efe63c3395b79993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232742
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-17 02:20:42 +00:00
Danny Tuppeny 55fd24e6a6 [analysis_server] Refactor LSP snippet building in preparation for Snippet completions 
Change-Id: Ie39e2e803d17435b31246da07ed69eba7d7aba21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-16 20:01:00 +00:00
Danny Tuppeny 4f9a044418 [analyzer_plugin] Ensure FileEditBuilder updates linked positions correctly 
Without this change, any linked edit groups that fall between the offset and offset+length of the new edit are not updated, which means new edits can be inserted that overlap with the linked edit groups instead of pushing them along by the delta.

Change-Id: If3e60bfa1efa4736f91bb85eb29cd785e933e78c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232099
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-02-16 19:39:40 +00:00
Konstantin Shcheglov ea4f04f56d Support completion in enum constant argument list. 
Change-Id: Id483d6ea3715e567f1d2cc9a2051f615b750a8a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232684
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 23:07:25 +00:00
Konstantin Shcheglov 582bf2f230 Completion for constructors in enum constants. 
Change-Id: I3a68db8045d249f7459ec0dbf0fbd9c203fccade
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232683
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 21:41:37 +00:00
Konstantin Shcheglov 8b67b90016 A few tests for completion in class body and similar. 
Change-Id: Id8749e4c45d26a5e56de31ce0d8b117db60150a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/232486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-02-11 18:04:57 +00:00