dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
51,618 Commits 2 Branches 0 Tags
28793ea1301efb2dfdb3348fedc29bb20eb7e310
Commit Graph

67 Commits

Author SHA1 Message Date
Jacob Richman 8b221d13a4 Fix ddc debugger_test Fix regression in custom formatters due to change in metadata signatures to use Object.__proto__ instead of a null __proto__. 
Bug:
Change-Id: I68fdb980e777b7c3f335fd6b57181134e3159cc3
Reviewed-on: https://dart-review.googlesource.com/17060
Commit-Queue: Jacob Richman <jacobr@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-31 19:45:27 +00:00
Ben Konyi 41bda23a77 Migrated test block 214 to Dart 2.0. 
wrapping_collections_test was modified since JSNative is deprecated and
was causing the test to fail ('class js has no getter for JSNative').

Bug:
Change-Id: Icc8951bce4be1152984b66769676080f89e5f1f7
Reviewed-on: https://dart-review.googlesource.com/9420
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
 2017-10-11 20:22:31 +00:00
Terry Lucas 213830e122 Migrated Block 188 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I3a450b04becaef007cc81fda1dbca1fda58b3d19
Reviewed-on: https://dart-review.googlesource.com/12361
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-11 14:42:22 +00:00
Terry Lucas 8611852b81 Migrated Block 199 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic52e7afb489b15b2f2e45f5ad9191cf5e441c047
Reviewed-on: https://dart-review.googlesource.com/11342
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-10 13:53:24 +00:00
Terry Lucas 83ff87e4a3 Migrated Block 204 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I032f25969e75fb9966222da969e73a665bf35f44
Reviewed-on: https://dart-review.googlesource.com/12321
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-10-10 13:00:01 +00:00
Terry Lucas 0319fb1e87 Migrated Block 200 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I9d998f61c2bc3d4b9c6ea71cb1111c00983a80a5
Reviewed-on: https://dart-review.googlesource.com/11347
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-09 02:45:04 +00:00
Terry Lucas 61e6389f8a Migrated Block 202 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ibca90f46788ef86fdc57f746f48e8fd85b78aa5a
Reviewed-on: https://dart-review.googlesource.com/11361
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-08 23:19:49 +00:00
Terry Lucas 960fff771d Migrated Block 203 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I1f2769da1511570fa55e883a2997b8ceb4932217
Reviewed-on: https://dart-review.googlesource.com/11362
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-07 15:34:17 +00:00
Ben Konyi 7ea539a4c5 Migrated test block 190 to Dart 2.0. 
Migrated multiple tests from unittest->test, fixed small strong mode
issue in cross_frame_test.

Bug:
Change-Id: I1c504ab4ac45e487ff3d3d156416e579978adc20
Reviewed-on: https://dart-review.googlesource.com/4820
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-05 22:00:26 +00:00
Terry Lucas aeb7995355 Migrated Block 201 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Iad6df128725ffc81bbf352b02efc0412aa83272f
Reviewed-on: https://dart-review.googlesource.com/11360
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 18:01:10 +00:00
Terry Lucas 0beb87c853 Migrated Block 197 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic5ab3a1a5f300cc6df757ea03119595eac9dafc2
Reviewed-on: https://dart-review.googlesource.com/11340
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 10:46:21 +00:00
Terry Lucas c886f96a8a Migrated Block 198 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I2280e12ba6d01a40df735083820c0ba96874ded5
Reviewed-on: https://dart-review.googlesource.com/11341
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 08:41:08 +00:00
Jakob Roland Andersen 42e28ca782 Migrated test batch 213 to Dart 2.0. 
Bug:
Change-Id: I31f519c18ab62cc0aef969f60116ed518bcb77e3
Reviewed-on: https://dart-review.googlesource.com/11061
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-05 07:56:30 +00:00
Terry Lucas bd588dda54 Migrated Block 196 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I1c59698b9cb2d5fd7aac4dec4ddff3cf1a851478
Reviewed-on: https://dart-review.googlesource.com/8742
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 06:33:42 +00:00
Terry Lucas bbbb548e0a Migrated Block 195 to Dart 2.0 
R=bkonyi@google.com

Change-Id: Ic5622d23d3159016625cfc17785f140ba9df409e
Reviewed-on: https://dart-review.googlesource.com/8739
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 06:08:10 +00:00
Jakob Roland Andersen a46ee1294a Migrated test batch 212 to Dart 2.0. 
Bug:
Change-Id: I2a062b9c1c2889355cc85884243bac580f3dce09
Reviewed-on: https://dart-review.googlesource.com/10480
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-05 05:16:20 +00:00
Terry Lucas 7f137ca921 Migrated Block 194 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I4e77f837a26d37e2d8f650c941f72454e6536b8d
Reviewed-on: https://dart-review.googlesource.com/8737
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-10-05 04:19:10 +00:00
Jakob Roland Andersen 0955c0ca9e Migrated test batch 211 to Dart 2.0. 
Bug:
Change-Id: Iee8198332fd94ef708eab1aa34867c5d68054c6a
Reviewed-on: https://dart-review.googlesource.com/10420
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-04 21:27:40 +00:00
Jakob Roland Andersen 7091266045 Migrated test batch 207 to Dart 2.0. 
Bug:
Change-Id: Ia0bfee80bf788a6eda83813fc986182a0d56a648
Reviewed-on: https://dart-review.googlesource.com/9980
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-04 20:14:19 +00:00
Ben Konyi b4d5cbda31 Migrated test block 191 to Dart 2.0. 
WIP.

Fixed status file migration issues for html and isolate directories.

Bug:
Change-Id: Id84c7ee89a7eb283d3202f3018d008cede0fda56
Reviewed-on: https://dart-review.googlesource.com/4920
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2017-10-03 21:54:44 +00:00
Jakob Roland Andersen 7f34184508 Migrated test batch 210 to Dart 2.0. 
Bug:
Change-Id: I8552149b85676cba497d78a9f6e3861257b746bc
Reviewed-on: https://dart-review.googlesource.com/10361
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-03 14:39:09 +00:00
Jakob Roland Andersen d2cd2a4720 Migrated test batch 209 to Dart 2.0. 
Bug:
Change-Id: If23630da318547e3beaf417a5ad97b30f6ffcbd3
Reviewed-on: https://dart-review.googlesource.com/10340
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-10-03 13:02:49 +00:00
Jakob Roland Andersen 56c8922c7c Migrated test batch 208 to Dart 2.0. 
Bug:
Change-Id: I97b3ca0d43bf68a60cdc2959844888c82c6af9eb
Reviewed-on: https://dart-review.googlesource.com/10260
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-10-03 10:23:49 +00:00
Jakob Roland Andersen c930fc0781 Migrated test batch 206 to Dart 2.0. 
Bug:
Change-Id: I231aa434de41c55a290ab3e399c97b7dbbbb028d
Reviewed-on: https://dart-review.googlesource.com/9940
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
 2017-10-02 13:26:07 +00:00
Jakob Roland Andersen 07dfe1f802 Migrated test batch 205 to Dart 2.0. 
Bug:
Change-Id: I2bbcab02d7757f97f4ffdb2f74b7123def16af47
Reviewed-on: https://dart-review.googlesource.com/8861
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-09-28 08:27:49 +00:00
Terry Lucas e61c567d7b Re-Migrate Block 192 and 193 to original unittest usage and re-run migration tool to move over *.html files too. 
R=bkonyi@google.com

Change-Id: I7cb8019c7b6881b09b52333a0457744f877f7aa0
Reviewed-on: https://dart-review.googlesource.com/7780
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
 2017-09-26 18:44:04 +00:00
Terry Lucas 358b62cd77 Migrated block 192 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I742f39564a8faf2ddf76817b4e493909d141f49c
Reviewed-on: https://dart-review.googlesource.com/6083
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-17 20:24:40 +00:00
Terry Lucas 303e06be4c Migrated test block 189 to Dart 2.0 
R=bkonyi@google.com

Change-Id: I178251eea656777f8414cf2573f2bd146cdbab24
Reviewed-on: https://dart-review.googlesource.com/5920
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-15 14:19:50 +00:00
Leaf Petersen b78fea7129 Restore subtyping between Dart classes and anonymous JS classes 
Bug:
Change-Id: I9e7e78d1f309fb814644245d6fd281d3b9110589
Reviewed-on: https://dart-review.googlesource.com/4160
Reviewed-by: Jennifer Messerly <jmesserly@google.com>
 2017-09-07 23:56:38 +00:00
Alan Knight 4c9b6c8437 Fix some test suppressions for Chrome 60 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2986153002 .
 2017-07-28 12:39:04 -07:00
Kevin Moore 500f5cb324 2nd try: SDK dep cleanup 
Retry https://github.com/dart-lang/sdk/commit/7a9cc03c09
Which was reverted at https://github.com/dart-lang/sdk/commit/b6d15d87bc

R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2978233002 .
 2017-07-18 13:13:50 -07:00
Kevin Moore b6d15d87bc Revert "Remove several packages from DEPS" 
Looks like we have tests that require these

This reverts commit 7a9cc03c09.

Review-Url: https://codereview.chromium.org/2980303002 .
 2017-07-18 07:36:37 -07:00
Kevin Moore 7a9cc03c09 Remove several packages from DEPS 
Copied the corresponding code from pkg/web_components

R=whesse@google.com

Review-Url: https://codereview.chromium.org/2977333002 .
 2017-07-18 07:21:19 -07:00
Leaf Petersen 6f73694bb7 Generate better code for '==', core.identical, and dart.test. 
Avoid falling back to the dart.equal runtime helper where possible based on static types.  Also uses JS `==` or `===` in some cases.

Treat core.identical as a compiler intrinsic, based on type.

Make dart.test assume correct types, use dart.dtest for combined cast and nullability check only when required.

Fixes https://github.com/dart-lang/sdk/issues/29851
Fixes https://github.com/dart-lang/sdk/issues/29772
BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2926613003 .
 2017-06-30 15:04:29 -07:00
Vijay Menon fd6164cce4 Handle toString on DOM types 
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2952363003 .
 2017-06-27 09:22:25 -07:00
Erik Corry 029b1cb948 Spelling fixes e to i. 
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
 2017-06-24 13:41:39 +02:00
Vijay Menon febded6052 Fix mocked operator methods 
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2949123002 .
 2017-06-21 16:54:08 -07:00
Alan Knight a865f0ecf2 Update DDC libraries to match SDK, and debugger_test golden file 
BUG=
R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2903333002 .
 2017-05-25 15:00:51 -07:00
Alan Knight 0bb2d5e548 Update DDC html libraries to match SDK 
BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2899083007 .
 2017-05-25 09:33:23 -07:00
Alan Knight d60efa87fe Remove obsolete test in svgelement_test 
BUG=

Review-Url: https://codereview.chromium.org/2902973004 .
 2017-05-24 12:29:15 -07:00
Vijay Menon b82b0e29ed DDC fixes for SpeechRecognition 
R=alanknight@google.com

Review-Url: https://codereview.chromium.org/2896463002 .
 2017-05-18 17:05:51 -07:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d. 
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
 2017-05-01 08:28:10 +02:00
Erik Corry 4b9bba55b4 Stoppp using trippple consonants 
R=ahe@google.com
BUG=

Review-Url: https://codereview.chromium.org/2833073002 .
 2017-04-21 17:50:13 +02:00
Jacob Richman 7149b90c7c Tighten up handling of JS types and add test. 
Side effect of this:
Fix bug where helpers in js_mirrors were specifying that name had to have type String when it could really also be a JS Symbol as well.
Fix bug where top level JS interop members using the external keyword but no @JS keyword were not implemented.
Update js_typed_interop_test.dart so it can work in DDC.
Add regression test for jsify call with native function type arguments.

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2827333003 .
 2017-04-21 08:44:00 -07:00
Jacob Richman b280a7803d Dev compiler debugger related tweaks. 
Optimize dynamic call tracking using random sampling.
Apply source maps to improve dynamic call tracking accuracy.
Dynamic calls within the sdk are now attributed correctly.

Fix bug formatting modules where we were incorrectly flagging them as JS.

BUG=
R=jmesserly@google.com, vsm@google.com

Review-Url: https://codereview.chromium.org/2811343002 .
 2017-04-17 14:57:31 -07:00
Jacob Richman 2dcd56ef43 Format all tests. 
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
 2017-04-17 14:53:02 -07:00
Jennifer Messerly 8ada796a86 fix #29233, final fields can be settable in a mock 
also fix #29273, user mixins can override native methods

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2803673007 .
 2017-04-07 14:12:49 -07:00
Konstantin Shcheglov 7cd782db6e Issue 29186. Make several top-level variables explicitly 'dynamic'. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29186

Review-Url: https://codereview.chromium.org/2806543002 .
 2017-04-06 10:57:39 -07:00
Jacob Richman 509bcd58e1 Fix type checks and display for JS interop types. 
Re-enable formatter test that had been disabled when someone changed type
name display for Foo<dynamic> types.
Fix bug in how type names were displayed for JS interop types.

BUG=
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2789663005 .
 2017-04-03 08:34:20 -07:00
Jacob Richman 14531fa62d Re-land "Format all multitests" 
Only delta from the original is a bad merge of tests/corelib/list_test.dart

This reverts commit 44d8be0ed3.

BUG=

Review-Url: https://codereview.chromium.org/2774783002 .
 2017-03-23 12:40:21 -07:00