This is an initial step and some entries say "Pass", which indicates
that the test was marked earlier in some other (more general) section and that
we should split that section.
Change-Id: I0417d55dcdec352f730c298bb155d112eb341711
Reviewed-on: https://dart-review.googlesource.com/16322
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Currently, we have some tests that run with reified generic functions ON and
some with it OFF. However, this causes inconsistencies when running the Kernel
FE from snapshot in the VM, since the VM requires that the flag be consistent
with the snapshot. Our solution is to turn the reified generic functions flag
into a per-isolate flag, which is always disabled in the Kernel FE's isolate.
Bug:
Change-Id: Ia91e9f0ff5fc059edf4bdbd79ef14abb288b4a49
Reviewed-on: https://dart-review.googlesource.com/16020
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Removed html/ entries for kernel, since there's a html/* at the top.
Sorted newly added entries in lib_2_dartdevc.status, and added issue
number for webgl_extensions_test.
Bug:
Change-Id: I5bee92e992cd420e9d4b2c0629e2b75b6b22715e
Reviewed-on: https://dart-review.googlesource.com/11441
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
In kernel the loop level wasn't set correctly for for loops, resulting
in the loop variable not always being fresh.
Examples:
```
// Capture the loop variable, ensure we capture the right value.
for (int i = 0; i < 10; i++) { if (i == 7) f = () => "i = $i"; }
print(f());
// There is only one instance of k. The captured variable continues to change.
int k;
for (k = 0; k < 10; k++) { if (k == 7) f = () => "k = $k"; }
print(f());
```
resulted in
i = 10
k = 10
(i.e. it's wrong)
whereas
```
// Capture the loop variable, ensure we capture the right value.
for (int i = 0; i < 10; i++) { if (i == 7) { f = () => "i = $i"; } }
print(f());
{
// There is only one instance of k. The captured variable continues to change.
int k;
for (k = 0; k < 10; k++) { if (k == 7) { f = () => "k = $k"; } }
print(f());
}
```
resultet in
i = 7
k = 10
(i.e. it's correct).
Now both examples produce the correct result.
Change-Id: I1fb4c888c6a0eaa690f62226e093508992b33ed4
Reviewed-on: https://dart-review.googlesource.com/9961
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Fixed some errors in other_declarations_location_test, removed checks
for TypeError when passing invalid arguments to a method in
private_symbol_test.
Bug:
Change-Id: I82030f1189a7a370d15bef4fd284d92b0b2de5bb
Reviewed-on: https://dart-review.googlesource.com/3791
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Also share (almost identicial) code between
error_at_exit_spawn_test.dart
error_at_exit_spawnuri_test.dart
in
error_at_exit_spawning_shared.dart
Converted 3 tests away from package:unittest to use package:async_helper/package:expect.
Change-Id: I1b9bf7c895eb21f3c5be9246e69b784296610ce3
Reviewed-on: https://dart-review.googlesource.com/5261
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
This CL silences several tests for '$compiler = dartkp' configuration
in order to make vm-kernel-precomp-* buildbots greener.
These tests are already silenced for '$compiler = precompiler' or
'$compiler = dartk' configurations.
Change-Id: Ia3208853655868ae4cf39775d40db15218c1a1df
Reviewed-on: https://dart-review.googlesource.com/5286
Reviewed-by: Alexander Aprelev <aam@google.com>
Mirrors are not supported in precompiler/AOT, so all lib_2/mirrors/*
tests should be skipped for '$compiler = dartkp' configuration, like
they are skipped for '$compiler = precompiler' configuration in
lib_2_precompiled.status.
Change-Id: I65322c700375168b105d5e659de284216bc49f11
Reviewed-on: https://dart-review.googlesource.com/5281
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
lazy_static_test needed a field changed from var -> dynamic. Otherwise,
simple block.
Bug:
Change-Id: I5d685b5802da906d22f524466eb6794b75c0da62
Reviewed-on: https://dart-review.googlesource.com/3784
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Updated invoke_call_through* tests to make them strong mode clean, which
mostly involved changing var -> dynamic in some places.
Bug:
Change-Id: I3ac946bdfadd09d6459c7f104068be4cb0c49c1d
Reviewed-on: https://dart-review.googlesource.com/3781
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
This is a reland of 77a7ca98a2
Original change's description:
> Migrate test batch 226 to Dart 2.0
>
> Specifically skipped formatting these files, since there are tests that depend
> on non-standard source formatting.
>
> Bug:
> Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
> Reviewed-on: https://dart-review.googlesource.com/3440
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Change-Id: I083c07c08333909aaf5bce763601445ff9f0413f
Reviewed-on: https://dart-review.googlesource.com/3920
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Lasse R.H. Nielsen