dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
51,618 Commits 2 Branches 0 Tags
28793ea1301efb2dfdb3348fedc29bb20eb7e310
Commit Graph

482 Commits

Author SHA1 Message Date
Lasse R.H. Nielsen adcb6a7399 Make main invocation not fail strong-mode type checking. 
Bug: http://dartbug.com/31270
Change-Id: Id6ad2a429d5dc44b437a0fdd8fb4889d3dccf194
Reviewed-on: https://dart-review.googlesource.com/18480
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-03 16:06:00 +00:00
Sigmund Cherem a8d13565cd Add support for deferred loading in fasta 
Change-Id: I2a5489b618210935b4b21c583aba9738a5e3f645
Reviewed-on: https://dart-review.googlesource.com/13441
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-10-26 23:22:48 +00:00
William Hesse 601e822ce9 Update status for Chrome 62 stable 
Bug:
Change-Id: I3c554583dbd9fabc01664e21d86248768db551a4
R=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/14765
Reviewed-by: Morten Krogh-jespersen <mkroghj@google.com>
 2017-10-18 12:02:56 +00:00
Jens Johansen 2e75b6cce9 [kernel] Fix closure in for loop 
In kernel the loop level wasn't set correctly for for loops, resulting
in the loop variable not always being fresh.

Examples:

```
  // Capture the loop variable, ensure we capture the right value.
  for (int i = 0; i < 10; i++) { if (i == 7) f = () => "i = $i"; }

  print(f());
  // There is only one instance of k. The captured variable continues to change.
  int k;
  for (k = 0; k < 10; k++) { if (k == 7) f = () => "k = $k"; }
  print(f());
```

resulted in
i = 10
k = 10

(i.e. it's wrong)

whereas

```
  // Capture the loop variable, ensure we capture the right value.
  for (int i = 0; i < 10; i++) { if (i == 7) { f = () => "i = $i"; } }
  print(f());
  {
    // There is only one instance of k. The captured variable continues to change.
    int k;
    for (k = 0; k < 10; k++) { if (k == 7) { f = () => "k = $k"; } }
    print(f());
  }
```

resultet in

i = 7
k = 10

(i.e. it's correct).

Now both examples produce the correct result.

Change-Id: I1fb4c888c6a0eaa690f62226e093508992b33ed4
Reviewed-on: https://dart-review.googlesource.com/9961
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-03 07:56:13 +00:00
Siva Chandra 0ce90404e8 Adjust status file to get the vm-win-product bot green. 
TBR=whesse

Change-Id: Icb53a66e1f1e2c6346e5d9a1829b3114744b8c9b
Reviewed-on: https://dart-review.googlesource.com/9123
Reviewed-by: Siva Chandra <sivachandra@google.com>
 2017-09-27 23:29:02 +00:00
Stephen Adams 3ee12248ca isolate/kill_self_synchronously_test does not run on dart2js 
Unsupported operation: Platform._resolvedExecutable

Bug:
Change-Id: I626050631320ff2afb5f7c0db6bfc7c156c6a972
Reviewed-on: https://dart-review.googlesource.com/5904
Reviewed-by: Stephen Adams <sra@google.com>
 2017-09-14 21:50:08 +00:00
Beeravolu Siva Chandra Reddy 004a515217 Populate library imports and exports when loading library from kernel. 
Change-Id: If6cc94aa186948caa8798212d6161da650ff2d8e
Reviewed-on: https://dart-review.googlesource.com/4381
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2017-09-12 10:44:49 +00:00
Alexander Aprelev 7cbb96c199 Wholesale update tests status in attempt to make (fyi) dartkp buildbots green. 
Buildbots are here: https://build.chromium.org/p/client.dart.fyi/console.

BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/3000423002 .
 2017-08-28 18:32:21 -07:00
Ryan Macnak 29fe863c62 Skip non_fatal_exception_in_timer_callback_test with dart2js. 
Issue #23876

Review-Url: https://codereview.chromium.org/2996293002 .
 2017-08-18 16:50:45 -07:00
Alexander Markov bda3c9c2b2 Simplify and fix implicit closure check, speed up Closure_equals, v2 
This is the re-application of 44e8da3ecd
with fixes:
* Dartanalyzer error is fixed in the new test isolate/message4_test
* The new test is skipped in the status file in dart2j/non-d8 modes,
  issue #30247 is created.
* Minor tweak of Closure_equals: other.IsClosure() is tested earlier.

Original CL review:

https://codereview.chromium.org/2989493002/

Original CL description:

This CL introduces a new Function kind, kImplicitClosureFunction, in
order to simplify check for implicit closures and make it more
efficient.

This CL also fixes Function::IsImplicitStaticClosureFunction(RawFunction*)
to correctly handle implicit closures created from static native
functions.

Closes #30203.

As the result of a faster check for implicit closures and slight
refactoring of Closure_equals, micro-benchmark exercising Closure_equals
speeds up from 9618ms to 6700ms for implicit closures case and
insignificantly for other cases.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2987703002 .
 2017-07-24 09:43:52 -07:00
Terry Lucas d0d5d6cc25 Revert "Revert "Removed Dartium test exceptions"" 
This reverts commit b85f66253c.

TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2984613002 .
 2017-07-19 05:51:54 -07:00
Johnni Winther b85f66253c Revert "Removed Dartium test exceptions" 
This reverts commit 84f079f24c.

Review-Url: https://codereview.chromium.org/2983073002 .
 2017-07-19 13:31:32 +02:00
Terry Lucas 84f079f24c Removed Dartium test exceptions 
TBR=alanknight@google.com

Review-Url: https://codereview.chromium.org/2983033002 .
 2017-07-18 13:18:14 -07:00
Johnni Winther 2f5bdf9c30 Skip resolve_package_uri_test for Dartium on Windows 
Review-Url: https://codereview.chromium.org/2979953002 .
 2017-07-13 13:27:04 +02:00
Ryan Macnak f20b32b793 [vm] Enable mirrors in product mode. Allows building a product mode SDK. 
Fixes https://github.com/dart-lang/sdk/issues/29972

R=zra@google.com

Review-Url: https://codereview.chromium.org/2972883002 .
 2017-07-12 12:55:58 -07:00
Peter von der Ahé e3939aa96c Fix status file expression. 
Review-Url: https://codereview.chromium.org/2969843003 .
 2017-07-03 15:43:01 +02:00
Peter von der Ahé 45e4d848d2 [gardening] Update status files for kernel debug mode. 
Review-Url: https://codereview.chromium.org/2969883002 .
 2017-07-03 15:37:16 +02:00
Zachary Anderson ac16656161 Remove MIPS support 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2858623002 .
 2017-06-22 08:49:22 -07:00
Lasse R.H. Nielsen 5720e3556c Add negation to single-identifier tests in status files. 
Optimize some regegps too.

Fixes #29756

BUG= http://dartbug.com/29756
R=rnystrom@google.com

Review-Url: https://codereview.chromium.org/2913963002 .
 2017-06-02 10:38:14 +02:00
Asger Feldthaus f85091f5d7 Do not list Timeout as the only test outcome in isolate.status. 
BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2855223003 .
 2017-05-04 11:26:37 +02:00
Peter von der Ahé ba0e07846f Produce a compile-time error if there's no main method. 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2801853006 .
 2017-04-19 14:28:10 +02:00
Peter von der Ahé 1e70fef1a2 Small steps towards deferred loading. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2803833003 .
 2017-04-07 12:23:35 +02:00
Siva Annamalai c53e020e6c Adjust status files to account for running the Dart test cases through flutter engine on linux. 
Accounted for language, co19, lib, corelib, isolate and standalone tests.

Filed issues to track all failing tests

  https://github.com/flutter/flutter/issues/9109
  https://github.com/flutter/flutter/issues/9110
  https://github.com/flutter/flutter/issues/9111
  https://github.com/flutter/flutter/issues/9113
  https://github.com/flutter/flutter/issues/9114
  https://github.com/flutter/flutter/issues/9115

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2784293003 .
 2017-04-03 16:35:09 -07:00
Vyacheslav Egorov 536c610fd2 Update status files for all test suites for -c dartk / -c dartkp configuration. 
We are going to switch to testing all testsuites instead of just limiting ourselves to

co19 language kernel service

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2780943004 .
 2017-03-29 13:18:57 +02:00
Zachary Anderson 0111122ca0 [Fuchsia] Update test status files 
R=asiva@google.com, rmacnak@google.com

Review-Url: https://codereview.chromium.org/2693643002 .
 2017-02-10 21:34:33 -08:00
Brian Wilkerson 2ee2fe9b5c [Gardening] Disable running strong-mode analyzer tests in code that is not strong mode clean 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2679553003 .
 2017-02-06 13:26:39 -08:00
Martin Kustermann 89de0c9267 Reland "VM: Fix memory leaks during isolate spawning" 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2649283003 .
 2017-01-24 12:04:41 +01:00
Martin Kustermann 50150deaf6 Revert "VM: Fix memory leaks during isolate spawning" 
This reverts commit d7e884b05f.

Review-Url: https://codereview.chromium.org/2654443003 .
 2017-01-24 10:32:59 +01:00
Martin Kustermann d7e884b05f VM: Fix memory leaks during isolate spawning 
Fixes #28351

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2650693004 .
 2017-01-24 09:59:13 +01:00
Ryan Macnak 26a364f998 Support spawnUri in app snapshots. 
- Don't mark core_isolate_snapshot_buffer as a const pointer.
 - Update app snapshots without code to not rewrite the VM isolate snapshot, as already done by app snapshots with code.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2637193002 .
 2017-01-17 15:59:41 -08:00
Ryan Macnak 12a3699301 Revert "Support spawnUri in app snapshots." 
Failures on IA32.

This reverts commit c6ecfe1746.

Review-Url: https://codereview.chromium.org/2631893002 .
 2017-01-13 15:52:36 -08:00
Ryan Macnak c6ecfe1746 Support spawnUri in app snapshots. 
Don't mark core_isolate_snapshot_buffer as a const pointer.

Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2623423007 .
 2017-01-13 15:18:27 -08:00
Ryan Macnak f89056f6cd Revert "Support spawnUri in app snapshots." 
This reverts commit 593d4504b0.
This reverts commit 113aa64b98.
This reverts commit 422afa2ead.

Review-Url: https://codereview.chromium.org/2633543003 .
 2017-01-13 11:02:44 -08:00
Ryan Macnak 593d4504b0 Support spawnUri in app snapshots. 
Fixes #28368

R=asiva@google.com

Review-Url: https://codereview.chromium.org/2628283002 .
 2017-01-13 10:37:51 -08:00
Lasse Reichstein Holst Nielsen bd743e2187 Mark isolate/browser/package_resolve_browser_test as failing. 
Update status files wrt. issue #28382.

BUG= http://dartbug.com/28382

Review-Url: https://codereview.chromium.org/2628873008 .
 2017-01-13 16:11:36 +01:00
Terry Lucas 657720d125 Temporarily disable test under windows 
TBR=sigmund@google.com

Review-Url: https://codereview.chromium.org/2629573003 .
 2017-01-12 09:10:45 -08:00
Florian Schneider bef4967ea1 Remove dart_noopt and related parts from the VM. 
dart_noopt is not needed anymore because we have testing
and builbot integration of the real precompilation pipeline in place now.

Fixes #24569
Fixes #25726
Fixes #25845

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2624393002 .
 2017-01-11 16:55:55 -08:00
Ryan Macnak 68ac06f742 Triage isolate spawning ASAN failures. 
Issue #28351

Review-Url: https://codereview.chromium.org/2628113002 .
 2017-01-11 16:20:19 -08:00
Terry Lucas 559ae993d1 Added VMLibraryHooks setup for Dartium to support resolvePackageUri. 
BUG=25594
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2611353002 .
 2017-01-10 07:25:10 -08:00
Jennifer Messerly 816592a941 fixes #28236, generic methods should not cause warnings in Dart 1 
Instantiate universal functions in subtype tests & tear-offs. Also updates the status files and one Analyzer test that covered the tear-off type.

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2621433003 .
 2017-01-09 12:46:20 -08:00
Lasse R.H. Nielsen 44594277e1 Make core libraries use generic method syntax. 
Removes comment syntax where possible for the following platform libraries:
* async
* collection
* convert
* core
* internal
* io
* math

The HTML related libraries are not changed. The templates used to build them
must be changed as well.

R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/68818315b5cc6c63fea0e10e90f515f6083ec095
Committed: https://github.com/dart-lang/sdk/commit/3f74b8d82edca8c342c43306714e68ddf84548e1
Review-Url: https://codereview.chromium.org/2529393002 .
 2017-01-03 12:05:40 +01:00
Sigmund Cherem 98a3c52575 mark a couple flaky tests 
Review-Url: https://codereview.chromium.org/2600463004 .
 2016-12-22 16:21:06 -08:00
Sigmund Cherem 0cb170488c Update failing chrome tests after chrome 55 roll (issue #27991), also update a 
status comment.

Review URL: https://codereview.chromium.org/2557533002 .
 2016-12-05 14:38:01 -08:00
Ryan Macnak 1ebeb79942 Remove runtime 'dart_app' as it became identical to 'vm'. 
Merge compiler 'dart2app' and 'dart2appjit' and rename to 'app_jit' since they came to mean the same thing.

Update status files to reflect these changes.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2541533004 .
 2016-12-01 16:47:33 -08:00
William Hesse 6f7005ee71 Update status for co19 tests on browsers. 
BUG=
R=kustermann@google.com

Review URL: https://codereview.chromium.org/2538443002 .
 2016-11-28 16:32:41 +01:00
Ryan Macnak 12de13d1ae An isolate created with spawn function doesn't necessarily agree with its parent on the library private keys. 
(The long-standing issue that spawn function should use snapshots would also fix this.)

Encountered by the analyzer in https://codereview.chromium.org/2492933002/

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2509413002 .
 2016-11-23 15:36:01 -08:00
Sigmund Cherem 2bec7b5adb Skip package-resolution tests in dartium 
TBR=lrn@google.com

Review URL: https://codereview.chromium.org/2500203002 .
 2016-11-14 15:18:47 -08:00
Florian Schneider a74262c0e9 Enable now-passing tests for Android precompilation 
Remove other obsolete entries.

Fixes #26373.
Fixes #27378.

R=rmacnak@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2431163007 .
 2016-10-21 12:16:47 -07:00
Sigmund Cherem f6680d13a2 One more round of status file updates to get the bots green. 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2285213003 .
 2016-08-29 08:14:33 -07:00
Sigmund Cherem 342eb3f296 Additional status file fixes 
TBR=sra@google.com

Review URL: https://codereview.chromium.org/2283273002 .
 2016-08-26 18:29:19 -07:00