dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
51,618 Commits 2 Branches 0 Tags
28793ea1301efb2dfdb3348fedc29bb20eb7e310
Commit Graph

69 Commits

Author SHA1 Message Date
Stephen Adams 9338844b10 Fix for issue 28196 - constant interceptors for mixin applications 
BUG=
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2862433002 .
 2017-05-02 17:53:32 -07:00
Jacob Richman 2dcd56ef43 Format all tests. 
There are far too many files here to review everyone carefully.
Spot checking most of the diffs look good as test code is generally written
with less care than application code so lots of ugly formatting get through.
If people notice files where the automated formatting bothers them feel free
to comment indicating file names and I'll move spaces within comments to make
the formatting cleaner and use comments to force block formatting as I have
done for other case where formatting looked bad.

BUG=
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2771453003 .
 2017-04-17 14:53:02 -07:00
Sigmund Cherem 008da86c03 Support extending TemplateElement in IE11 + webcomponents-lite.js 
Addresses issue reported in the polymer repo: https://github.com/dart-lang/polymer-dart/issues/682

R=jakemac@google.com, sra@google.com

Review URL: https://codereview.chromium.org/2493703004 .
 2016-11-14 07:32:09 -08:00
Alan Knight f799386f88 Change test name so it's easier to suppress 
BUG=

Review URL: https://codereview.chromium.org/1404513002 .
 2015-10-12 13:31:44 -07:00
Alan Knight 1d5b657427 Make it easier and more efficient to use trusted HTML text 
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//1154423009.
 2015-06-22 09:41:01 -07:00
alanknight@google.com 4b119a94d8 Better way of fixing attribute_changed_callback_test, doesn't require a timer 
BUG=

Review URL: https://codereview.chromium.org//1061403002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44946 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-07 20:52:54 +00:00
alanknight@google.com 4adf68734b Fix attribute_changed_callback_test to expect event delivery either synchronously or asynchronously 
BUG=
R=terry@google.com

Review URL: https://codereview.chromium.org//1060103002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44942 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-07 18:23:59 +00:00
sra@google.com 2956fd8739 - Fork implementation for Dartium and dart2js. Dartium is working fine. 
- dart2js version uses Element.classList (DomTokenList) for 4x speedup.

- Fix bug where document.querySelectorAll(...).classes.add('x') fails for SVG elements.

- Add test for above.

For later:
- Identify a polyfill for IE SVGElements (they don't have classList)
- Simplify CssClassSet further to exploit uniform availability of classList. This should give another performance boost by enabling inlining.

R=alanknight@google.com

Committed: https://code.google.com/p/dart/source/detail?r=44888

Committed: https://code.google.com/p/dart/source/detail?r=44897

Review URL: https://codereview.chromium.org//1054863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44898 260f80e4-7a28-3924-810f-c04153c831b5
 2015-04-03 23:00:28 +00:00
jakemac@google.com 8fde04e0ba mark public package dependencies test as failing since web_components isn 't yet published 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//778923004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42118 260f80e4-7a28-3924-810f-c04153c831b5
 2014-12-04 21:24:10 +00:00
herhut@google.com cbbab468ba Filter abstract classes when computing candidate classes for custom elements. 
BUG= http://dartbug.com/20845
R=karlklose@google.com

Review URL: https://codereview.chromium.org//555123002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40027 260f80e4-7a28-3924-810f-c04153c831b5
 2014-09-09 13:31:40 +00:00
terry@google.com 12c4efb4c7 Removed template_wrappers_test 
Reviewers=blois@google.com
BUG=16656
R=blois@google.com

Review URL: https://codereview.chromium.org//313643003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36920 260f80e4-7a28-3924-810f-c04153c831b5
 2014-06-03 17:14:59 +00:00
jmesserly@google.com be1a190cd0 html/custom/created_callback_test.dart -- fix accidental replace 
TBR -- affecting analyzer/dartium bots

somehow had missed running this test.

Review URL: https://codereview.chromium.org//263013004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35832 260f80e4-7a28-3924-810f-c04153c831b5
 2014-05-06 21:33:57 +00:00
jmesserly@google.com 1102849f15 [dart:html] rename register to registerElement per spec 
BUG= https://code.google.com/p/dart/issues/detail?id=18621
R=jacobr@google.com

Review URL: https://codereview.chromium.org//268313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35829 260f80e4-7a28-3924-810f-c04153c831b5
 2014-05-06 20:41:07 +00:00
jmesserly@google.com 80038efd0a [dart:html] tests for attached/detached callback 
Did not change pkg:polymer yet, as it doesn't seem like it depends on Dart 1.4 SDK.

BUG= https://code.google.com/p/dart/issues/detail?id=17385
R=jacobr@google.com

Review URL: https://codereview.chromium.org//263213004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35823 260f80e4-7a28-3924-810f-c04153c831b5
 2014-05-06 20:00:59 +00:00
blois@google.com edf9910602 Re-apply "Adding a mechanism to 'upgrade' the Dart type of elements" 
With fixes for:
- Expected analyzer static error in the unittest.
- Added browser/interop.js to the HTML file

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//224113003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35080 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-15 20:50:46 +00:00
kevmoo@google.com 0300517879 Tests: remove usage of interop.js 
R=sigmund@google.com

Review URL: https://codereview.chromium.org//233063005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34957 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-11 01:18:32 +00:00
blois@google.com b4a3e6ced6 Revert "Adding a mechanism to 'upgrade' the Dart type of elements" 
This reverts commit 34615 because it's breaking some bots (not sure why).

TBR
BUG=

Review URL: https://codereview.chromium.org//220403008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34622 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-01 22:59:54 +00:00
blois@google.com 0e64dc971c Adding a mechanism to 'upgrade' the Dart type of elements 
This is to allow custom Dart wrappers for Polymer elements to provide improved JS custom element integration.

The Dartium portion of this is at https://codereview.chromium.org/188083002

BUG=
R=jmesserly@google.com, sra@google.com

Review URL: https://codereview.chromium.org//177113014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34615 260f80e4-7a28-3924-810f-c04153c831b5
 2014-04-01 20:17:31 +00:00
johnniwinther@google.com cc574e5db6 Add regression test for CL 194523002 
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//214443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34470 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-27 13:15:27 +00:00
kustermann@google.com 7e29f42833 Change tests to use test.py's test_controller.js, cleanup in browser_controller 
This change makes all remaining tests use test.py's test_controller.js:
We have our own way of testing using test.py and that might change any time.
It's therefore not wise to rely on functionality in the unittest framework. If
we kept test_controller.js in the unittest package, we'd need to make a breaking
change whenever we change the behavior of test_controller.js. So this file was
forked into tools/testing/dart/test_controller.js.

After this, all our tests will use tools/testing/dart/test_controller.js. It is
therefore no longer necessary for the browser_controller to support the old
mechanism of posting back results. By removing this legacy code, we can ensure,
that the driving page of browser_controller will only react on valid messages
which were ment for it.
Context:
Some tests (e.g. dromaeo) might use postMessage internally, maybe even for
testing that postMessage is working. But the driving window should only react
on valid messages ment for it, ignoring any other messages.

R=blois@google.com, efortuna@google.com, ricow@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//177333004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33365 260f80e4-7a28-3924-810f-c04153c831b5
 2014-03-06 10:37:53 +00:00
blois@google.com 22b82a2e29 Updating custom element wrapper test 
Behavior has changed since custom elements are no longer being upgraded when in templates.

BUG=16656
R=vsm@google.com

Review URL: https://codereview.chromium.org//151563006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32607 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-12 17:24:11 +00:00
jmesserly@google.com 7d71bc988d introduce web_components pkg to replace shadow_dom, html_import, custom_element. This new package is 100% compatible with the polyfills used by http://www.polymer-project.org/ 
Deletes:
  pkg/shadow_dom
  pkg/custom_element (except web_ui stuff)
  pkg/html_import

Adds:
  pkg/web_components, with README.md and build instructions

Changes:
  pkg/html5lib -- deprecate queryAll/query in favor of *Selector
  pkg/polymer -- test fixes & a few small changes to work with new polyfills, mostly in build
  tests/html/custom -- can't load the CE polyfill at runtime, must now be injected statically via an HTML page, similar to the style @blois used for some custom element tests.

R=blois@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//158083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32533 260f80e4-7a28-3924-810f-c04153c831b5
 2014-02-11 01:15:05 +00:00
blois@google.com 8a68b71569 Adding @MirrorsUsed to html/custom/mirrors test 
This is to cut down on dart2js compilation time, try to speed the test up some.

TBR
BUG=

Review URL: https://codereview.chromium.org//134623007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31728 260f80e4-7a28-3924-810f-c04153c831b5
 2014-01-11 02:20:05 +00:00
jmesserly@google.com 20b120eba2 Fix for dart2js mirrors caching with custom elements 
Custom elements code is from https://github.com/dart-lang/CustomElements/pull/4

R=sigmund@google.com

Review URL: https://codereview.chromium.org//112613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31296 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-19 19:55:57 +00:00
jmesserly@google.com d700bba3e4 fix custom elements that extend tags like "section" 
Some tags don't have their own HTMLElement subclass (because they lack unique DOM properties), but it should still be possible to extend them.

R=blois@google.com

Review URL: https://codereview.chromium.org//90113002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30833 260f80e4-7a28-3924-810f-c04153c831b5
 2013-12-03 23:46:43 +00:00
regis@google.com 7b18b7c4ff Second attempt at fixing html test. 
I really have no idea what I am doing here, but the test now passes.
Dartium folks, please have a look.

Review URL: https://codereview.chromium.org//59883004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29940 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-05 21:53:22 +00:00
regis@google.com 43d64b38f8 Fix typo in html test. 
Review URL: https://codereview.chromium.org//59843006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29936 260f80e4-7a28-3924-810f-c04153c831b5
 2013-11-05 21:08:25 +00:00
blois@google.com c49df8bd12 Commenting out template_wrappers test while investigating crashes 
TBR
BUG=

Review URL: https://codereview.chromium.org//55503002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29714 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 22:53:47 +00:00
blois@google.com 4525b95f8e Adding test for old wrappers causing multiple upgrades 
This is the test for https://codereview.chromium.org/54833003/

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//55153002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29704 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 21:16:23 +00:00
blois@google.com 39733ff298 Removing window.console.log from js_custom_test 
IE does not declare window.console when debugger is not open.

TBR
BUG=

Review URL: https://codereview.chromium.org//47073010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29625 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 01:48:08 +00:00
blois@google.com 366b2364da Tests for premature GC of custom elements within template contents 
BUG=14483
R=vsm@google.com

Review URL: https://codereview.chromium.org//49673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29612 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-31 00:29:22 +00:00
blois@google.com 02d745044d Adding tests for accessing custom elements from alternate script contexts 
BUG=14597
R=vsm@google.com

Review URL: https://codereview.chromium.org//52913003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29591 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-30 21:46:03 +00:00
blois@google.com c1a11e55d5 Adding validation that Custom element constructor has zero args 
BUG=13800
R=vsm@google.com

Review URL: https://codereview.chromium.org//30283002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29011 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 17:20:46 +00:00
blois@google.com 980834fe33 Validating that types which require extendsTag actually provide it 
BUG=14292
R=vsm@google.com

Review URL: https://codereview.chromium.org//32703006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29004 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-22 16:14:17 +00:00
efortuna@google.com 8e4205db3a Reapply remove upgradeCustomElement methods. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//33593003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28960 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 21:55:40 +00:00
efortuna@google.com 37989cf2ce "Reverting 28947" 
TBR
BUG=

Review URL: https://codereview.chromium.org//33643002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28949 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 20:48:18 +00:00
efortuna@google.com 3a4a3ba95f Remove Platform.upgrateCustomElements. 
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//31993005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28947 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-21 20:21:28 +00:00
blois@google.com e7aef33a2c Fixing custom element type extensions in Dartium to have correct native type ID 
This is in support of the recent change to write the native type ID to the Dart wrappers

Dart changes for https://codereview.chromium.org/27769002/

BUG=14190
R=vsm@google.com

Review URL: https://codereview.chromium.org//29033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28899 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-18 23:43:45 +00:00
blois@google.com e3b35dabb6 Renaming Node.document back to Node.ownerDocument 
With custom elements, the document instance variable creates an odd conflict with the document global.

BUG=14099
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//27602002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28810 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-17 17:55:38 +00:00
blois@google.com ceb07acde3 Fixing status of document.register test for dart2js tests 
I added this test for Dartium, but it's failing on dart2js.

TBR
BUG=

Review URL: https://codereview.chromium.org//27220003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28606 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-14 19:45:07 +00:00
blois@google.com 5a06040888 Dart changes for https://codereview.chromium.org/26571005/ 
Ensuring that custom elements have correct super classes.

BUG=

Review URL: https://codereview.chromium.org//27222003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28603 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-14 19:29:42 +00:00
blois@google.com 6d3acc0175 Test fixes for CustomElement upgrade changes 
This is the Dart portion of https://codereview.chromium.org/27183006

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//26700003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28598 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-14 18:38:28 +00:00
blois@google.com c2f5471669 Removing Element.createdCallback 
This was a placeholder for before dart2js converted to the constructor, can now be removed.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//26592009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28465 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-10 16:59:19 +00:00
blois@google.com 108dec86bd Fixing Node.clone not returning upgraded custom elements. 
This was an issue for Polymer as the templates are cloned with shallow clones.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//25719003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28363 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-08 16:02:49 +00:00
blois@google.com c6b1d91f34 Implementing custom element's attributeChanged callback in Dartium 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//25793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28232 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-03 17:37:51 +00:00
blois@google.com 05bb03642d Implementing CustomElement's attributeChanged callback in dart2js. 
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//25325004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28168 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-02 15:57:56 +00:00
blois@google.com c71f315c8d Fixing analyzer issues in tests. 
BUG=

Review URL: https://codereview.chromium.org//25614002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28124 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-01 22:01:25 +00:00
blois@google.com 1aa8a7be0e Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses. 
This is for post-construction custom element creation.

Element.created is public, then the base classes of that get private ._created constructors.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24653006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
 2013-10-01 21:26:06 +00:00
blois@google.com 5eed34b47d Running entered & left view events in Dartium 
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28023 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-27 19:48:53 +00:00
blois@google.com 354c4dd5ad Revert "Revert "Start of dartium custom element lifecycle event support."" 
Primary changes are that a fast-path has been added for the single-argument Document.createElement and the systemnative.py changes were split out to CL https://codereview.chromium.org/24661002/.

This is dependent on https://codereview.chromium.org/24677002/

First patch is the original, second is the updates.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24491003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27921 260f80e4-7a28-3924-810f-c04153c831b5
 2013-09-25 23:15:09 +00:00