71978a74b9
[gardening] Update dartkp status files in attempt to make dartkp-release green.
...
Bug:
Change-Id: Iff6435ba7f69180c0395d278fceb33fc084d8a8c
Reviewed-on: https://dart-review.googlesource.com/19040
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
2017-11-07 17:24:29 +00:00
b2721473aa
[VM,Kernel] Report an error on import of dart:mirrors when mirrors are disabled
...
Otherwise VM simply crashes further down in the pipeline.
Update corelib/apply3_test status to match this change.
R=kustermann@google.com
Bug:
Change-Id: Iffb4d2bc7e513d5a79123b029f7ea7c4e1033056
Reviewed-on: https://dart-review.googlesource.com/19003
Reviewed-by: Martin Kustermann <kustermann@google.com >
Commit-Queue: Vyacheslav Egorov <vegorov@google.com >
2017-11-07 15:37:09 +00:00
7559d79af3
Track offsets of unnamed mixins
...
Closes https://github.com/dart-lang/sdk/issues/30316
Change-Id: I858091104c4f13afb6d751f3d290a3127efb2b5f
Reviewed-on: https://dart-review.googlesource.com/15260
Reviewed-by: Dan Rubel <danrubel@google.com >
2017-10-20 12:24:37 +00:00
c8b2183bb5
[kernel] Disallow const x = [] and const y = {}
...
This CL makes fasta issue an error when trying to create a non-const
ListLiteral or MapLiteral in a context where const is required.
Bug:
Change-Id: I27ea151a38eb1198faa83a8cfa57453a4e225e1a
Reviewed-on: https://dart-review.googlesource.com/15460
Commit-Queue: Jens Johansen <jensj@google.com >
Reviewed-by: Peter von der Ahé <ahe@google.com >
2017-10-20 09:38:57 +00:00
f36b1f49d6
Only set model.scopeInfo for the outer member, not nested closures
...
Change-Id: I848e18e1000158b4a198782227bfb2524104e805
Reviewed-on: https://dart-review.googlesource.com/14700
Reviewed-by: Emily Fortuna <efortuna@google.com >
2017-10-18 21:00:06 +00:00
f690f6225e
Use the validating constructor when creating a Symbol.
...
Change-Id: Iae150ad036f8a72dcc853b86ecd01c569d28bd0b
Reviewed-on: https://dart-review.googlesource.com/11963
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-10-06 19:54:47 +00:00
f9cb6c4137
Remove dart2js_with_kernel_in_ssa test option
...
Change-Id: I2da692a4d458acc4b36e14beb99e1fb9d2bdec70
Reviewed-on: https://dart-review.googlesource.com/10861
Reviewed-by: Sigmund Cherem <sigmund@google.com >
2017-10-05 06:53:39 +00:00
0ed5cadad3
Update dart2js_with_kernel status
...
Change-Id: Ibb41fa04c4e05b56e908925f83c16e68cf8b68ed
Reviewed-on: https://dart-review.googlesource.com/10860
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2017-10-04 07:16:30 +00:00
2ea83486e1
dart2js kernel: generate constants for default arguments in Function.apply
...
Change-Id: I5bd0a8deaf16069749a574eb2ed132738e2e0747
Reviewed-on: https://dart-review.googlesource.com/8280
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2017-09-27 00:35:53 +00:00
772a0aff33
Handle and report erroneous compile time constants
...
Change-Id: I2ee86dbd714227e8e0894539ca64258fd11badfc
Reviewed-on: https://dart-review.googlesource.com/7820
Commit-Queue: Johnni Winther <johnniwinther@google.com >
Reviewed-by: Stephen Adams <sra@google.com >
2017-09-22 18:57:37 +00:00
aa0d5a428e
Hack to fix incorrect getMightBePassedToApply under --disable-type-inference
...
R=sigmund@google.com
Bug:
Change-Id: Ie0378a923473e2b5ff7eaabdff499ddb01050f3e
Reviewed-on: https://dart-review.googlesource.com/7489
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2017-09-22 02:47:23 +00:00
ec19f432cf
corelib.status fix for jsshell \xdf
...
TBR=rnystrom@google.com
Bug:
Change-Id: Ib69d7319333f04d856560e5ed12b3220f3ac2127
Reviewed-on: https://dart-review.googlesource.com/7684
Reviewed-by: Stephen Adams <sra@google.com >
2017-09-21 23:53:32 +00:00
fc48f21045
dart2js jsshell status
...
TBR=rnystrom@google.com
Change-Id: I911554cad36052ed46411c7db231e9b89adf4bac
Reviewed-on: https://dart-review.googlesource.com/7682
Reviewed-by: Stephen Adams <sra@google.com >
2017-09-21 23:38:20 +00:00
10f2f190c7
Update corelib dart2js kernel status
...
- Put all $dart2js_with_kernel results in two sections.
- Moved these sections to the end so our scripts don't malfunction.
TBR=rnystrom@google.com
Change-Id: I0bedc1ce334a4ce30e3c976a3e880bd2022de865
Reviewed-on: https://dart-review.googlesource.com/7680
Reviewed-by: Stephen Adams <sra@google.com >
2017-09-21 22:57:28 +00:00
ca4f84fba1
An old corelib test is passing on Firefox now.
...
Change-Id: Ied24ff209e39fbd9fdac486d81b58d0580d23aba
Reviewed-on: https://dart-review.googlesource.com/7632
Reviewed-by: Stephen Adams <sra@google.com >
2017-09-21 20:53:51 +00:00
879e34c2f2
Fix up the corelib statuses for dart2js with kernel.
...
Change-Id: I3ad63aade17d2962859940839e0f5774346ca39c
Reviewed-on: https://dart-review.googlesource.com/7629
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2017-09-21 20:35:21 +00:00
2d2af807f3
Mark a test failing on Safari.
...
It seems to round differently than expected.
Change-Id: Ibec5842063bf5de02bd6b4b34da4f66d824e9b62
Reviewed-on: https://dart-review.googlesource.com/7620
Reviewed-by: Bob Nystrom <rnystrom@google.com >
2017-09-21 19:09:08 +00:00
edee53f93d
Bring back the deleted 1.0 corelib tests.
...
What is dead may never die.
Change-Id: I80ef766b8ce2b6e1416df8e1f9b91fb74169dc79
Reviewed-on: https://dart-review.googlesource.com/7483
Reviewed-by: William Hesse <whesse@google.com >
2017-09-21 18:29:40 +00:00
51cc9689b3
Remove corelib and corelib_strong and migrate last two remaining tests.
...
This includes a migration of linked_hash_map_from_iterable_test and
stacktrace_current_test, which were migrated without changes.
BUG=
R=rnystrom@google.com , whesse@google.com
Review-Url: https://codereview.chromium.org/3004073002 .
2017-09-01 08:11:15 -07:00
043708d48c
Avoid Element-only assertions in generateParameterStubs
...
TBR=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/3008753002 .
2017-08-28 21:23:19 -07:00
3021706f87
More dart2js status duplicate removal
...
TBR=sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2996203002 .
2017-08-17 19:17:41 -07:00
09b215a2fd
Fix the local variable lookup in the locals handler.
...
BUG=
R=sra@google.com
Review-Url: https://codereview.chromium.org/2994363002 .
2017-08-16 16:08:21 -07:00
e89d0d2e14
Migrate test block 11 to Dart 2.0.
...
Interesting items in this block:
- Manually merged iterable_generate_test changes from both trees and
dropped some typeAssertionsEnabled/checked mode checking.
BUG=
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/3000543002 .
2017-08-16 10:16:42 -07:00
e6b3fb5b05
Migrate test block 10 to Dart 2.0.
...
Special bits in this block:
int_parse_radix_test: Converted to a check only on TypeError (since this is raised at runtime based on user data)
iterable_element_at_test.dart: Split into multitest with compile errors.
iterable_fold_test.dart: add4 and a couple of other cases here cause problems for some compilers, split out into multitests and annotated in
status file.
BUG=
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2997533002 .
2017-08-09 08:47:48 -07:00
e606525894
dedup tests/corelib_2/corelib_2.status dart2js entries
...
TBR=sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2993893002 .
2017-08-07 16:27:11 -07:00
352dc54191
Update status files to make bots green, minor changes to the script
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2990303002 .
2017-08-04 14:04:37 -07:00
234de19b22
Removed tests that have already been migrated as part of block 13.
...
TBR=jcollins@google.com , rnystrom@google.com
BUG=
Review-Url: https://codereview.chromium.org/2996553002 .
2017-08-04 13:52:21 -07:00
df3238ef2d
Migrated test block 12 to Dart 2.0.
...
Modified json_map_test to not expect the maps to be of type Map<int,
dynamic>, and marked iterable_to_list_test and iterable_to_set_test as
failing on DDC in the status files.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2996513002 .
2017-08-04 13:34:48 -07:00
5241f37143
Fixed test failures caused by overly aggressive merging of test block 13.
...
TBR=rnystrom@google.com ,jcollins@google.com
BUG=
Review-Url: https://codereview.chromium.org/2993103002 .
2017-08-04 12:56:13 -07:00
b1bca14dab
Migrated test block 13 to Dart 2.0.
...
Removed list_index_of2_test as it shouldn't be valid in Dart 2.0.
BUG=
R=jcollins@google.com , rnystrom@google.com
Review-Url: https://codereview.chromium.org/2994543002 .
2017-08-04 11:21:22 -07:00
edc1054ae1
Normalize status files for dart2js_with_kernel
...
This is only moving status lines around to ensure we only have 2 sections for
$dart2js_with_kernel per file: minified and host-checked. Some entries are now
duplicated because we no longer have the $dart2js_with_kernel (non-checked)
section.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2993083002 .
2017-08-04 09:41:08 -07:00
33f1fc8059
Update status files for double_round tests.
...
Review-Url: https://codereview.chromium.org/2999443002 .
2017-08-04 12:08:31 +02:00
4929f282b3
Make minification Entity-friendly.
...
BUG=
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2996463002 .
2017-08-03 19:19:21 -07:00
d7891cf587
Migrated test block 14 to Dart 2.0.
...
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2991363002 .
2017-08-03 13:46:54 -07:00
ce197702e4
Migrated test block 15 to Dart 2.0.
...
list_unmodifiable_test required some modifications so callbacks matched
the correct types. list_unmodifiable_test and list_test also needed to
be disabled on dartdevc due to some issue with List<int> not mapping to
JSArray.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2992833002 .
2017-08-03 11:12:26 -07:00
28a856828b
Migrate test block 7 to Dart 2.0.
...
duration2_test.dart converted to a static-only test and skipped where appropriate for non-strong. error_stack_trace_test converted to a multitest and error_stack_trace1_test modified to use more modern catch convention for stack traces.
R=bkonyi@google.com , rnystrom@google.com
Review-Url: https://codereview.chromium.org/2987793002 .
2017-08-03 08:55:30 -07:00
328c30324c
Migrate test block 8 to Dart 2.0.
...
This was a hairy test block, please review carefully. Special circumstances:
file_resource_test.dart: deleted, depends on Resource class which was moved outside the SDK
from_environment_const_type_undefined_test.dart, from_environment_const_type_test: change to expect compile-time errors for all error cases.
Hacked up status files to enable non-strong/checked/non-checked modes to work in all cases.
format_exception_test.dart: corelib is newer, has updated tests
growable_list_test.dart: corelib is newer, with updated comments. Stripped runtime checking of checked mode. Also, this doesn't work, but should, with dartdevc, so added to exclusion list
hash_map2_test.dart: corelib_strong version seems to be newer, has VM option comments
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2989643002 .
2017-08-03 08:37:46 -07:00
4d6f6a8bbd
Migrated test block 19 to Dart 2.0.
...
Added 'toString()' to lines 63 and 99 of regexp/global_test.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2989863002 .
2017-08-01 12:24:23 -07:00
f50a306875
Migrated test block 16 to Dart 2.0.
...
Lots of issues in map_test caused by the use of conflicting key types.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2990903002 .
2017-07-31 15:08:23 -07:00
8b36c83a10
Migrated test block 17 to Dart 2.0.
...
Fairly minor changes to print_test, and num_clamp_test was split into
two tests to isolate compile time errors.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2987203002 .
2017-07-31 15:04:00 -07:00
011c9b0f75
Migrated test block 19 to Dart 2.0.
...
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2985233002 .
2017-07-31 09:49:08 -07:00
b514995d69
Update status file after https://codereview.chromium.org/2989003002/ .
...
It looks like one test was left off the status file, especially since it's mentioned in the comment of the CL description.
BUG=
Review-Url: https://codereview.chromium.org/2989973002 .
2017-07-28 15:30:32 -07:00
4f33acda8a
Migrated test block 21 to Dart 2.0.
...
No changes made to tests.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2989843002 .
2017-07-28 13:10:40 -07:00
814edbe896
Migrated test block 20 to Dart 2.0.
...
No changes to tests, just the following status file updates:
Entries for status file /usr/local/google/home/bkonyi/sdk/tests/corelib/corelib.status:
[ (($compiler == dart2js) && (bool $dart2js_with_kernel)) ]
regexp/invalid-range-in-class_test: Crash
regexp/issue_19193_test: Crash
regexp/lastindex_test: Crash
regexp/lookahead_test: Crash
regexp/multiline_test: Crash
regexp/negative-special-characters_test: Crash
regexp/no-extensions_test: Crash
regexp/non-capturing-groups_test: Crash
[ ((($compiler == dart2js) && (bool $dart2js_with_kernel)) && (bool $minified)) ]
regexp/bol-with-multiline_test: Crash
regexp/look-ahead_test: Crash
regexp/loop-capture_test: Crash
regexp/malformed-escapes_test: Crash
regexp/many-brackets_test: Crash
regexp/non-bmp_test: Crash
regexp/non-capturing-backtracking_test: Crash
regexp/non-character_test: Crash
regexp/non-greedy-parentheses_test: Crash
Entries for status file /usr/local/google/home/bkonyi/sdk/tests/corelib_strong/corelib_strong.status:
[ ($compiler == dartdevc) ]
regexp/bol-with-multiline_test: RuntimeError # Issue 29921
regexp/invalid-range-in-class_test: RuntimeError # Issue 29921
regexp/look-ahead_test: RuntimeError # Issue 29921
regexp/loop-capture_test: RuntimeError # Issue 29921
regexp/malformed-escapes_test: RuntimeError # Issue 29921
regexp/many-brackets_test: RuntimeError # Issue 29921
regexp/negative-special-characters_test: RuntimeError # Issue 29921
regexp/no-extensions_test: RuntimeError # Issue 29921
regexp/non-bmp_test: RuntimeError # Issue 29921
regexp/non-capturing-backtracking_test: RuntimeError # Issue 29921
regexp/non-capturing-groups_test: RuntimeError # Issue 29921
regexp/non-character_test: RuntimeError # Issue 29921
regexp/non-greedy-parentheses_test: RuntimeError # Issue 29921
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2989003002 .
2017-07-28 12:52:08 -07:00
26c8479729
Migrated test block 22 to Dart 2.0
...
No updates made to tests.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2989723002 .
2017-07-28 11:28:08 -07:00
b1065335cd
Use dart2js_plaform.dill from the sdk.
...
This will enable --use-kernel tests in the dart2js bots.
After this change, running our tests will change a little bit, either of these
would work:
Option A: --use-sdk (host-checked not allowed)
python tools/test.py -m release \
-c dart2js -r d8 --dart2js-batch --report \
--dart2js-with-kernel --use-sdk \
language corelib library_2 corelib_2 \
dart2js_native dart2js_extra
Option B: pass --library-root, --host-check works here.
python tools/test.py -m release \
-c dart2js -r d8 --dart2js-batch --report \
--dart2js-with-kernel --host-checked \
--dart2js_options="--library-root=out/ReleaseX64/dart-sdk/" \
language corelib library_2 corelib_2 \
dart2js_native dart2js_extra
In the future, when fasta supports compiling sdk with @patch files, we will
be able to remove the --library-root option and simply compile the SDK from
sources at that point.
BUG=
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2988063002 .
2017-07-28 10:07:08 -07:00
4479a89467
Migrated test block 23 to Dart 2.0.
...
No major changes. Updated regexp_test.dart to not use the same variable
for Strings and Regexps.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2990603003 .
2017-07-27 12:10:01 -07:00
cbaaceca2f
Update checked-in d8 shell to version 6.2.0
...
BUG=https://github.com/dart-lang/sdk/issues/29794
R=rnystrom@google.com , sra@google.com
Review-Url: https://codereview.chromium.org/2979403002 .
2017-07-27 10:36:19 +02:00
8751f704d5
Remove references to 'dartium' and 'drt' in status files.
...
R=bkonyi@google.com
Review-Url: https://codereview.chromium.org/2986693002 .
2017-07-26 15:59:38 -07:00
b5caf1f5a0
Migrated test block 25 to Dart 2.0.
...
Simple block, no real changes.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2987773002 .
2017-07-25 17:00:21 -07:00
Vyacheslav Egorov