dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
51,618 Commits 2 Branches 0 Tags
28793ea1301efb2dfdb3348fedc29bb20eb7e310
Commit Graph

16220 Commits

Author SHA1 Message Date
Vyacheslav Egorov 71978a74b9 [gardening] Update dartkp status files in attempt to make dartkp-release green. 
Bug:
Change-Id: Iff6435ba7f69180c0395d278fceb33fc084d8a8c
Reviewed-on: https://dart-review.googlesource.com/19040
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2017-11-07 17:24:29 +00:00
Vyacheslav Egorov b2721473aa [VM,Kernel] Report an error on import of dart:mirrors when mirrors are disabled 
Otherwise VM simply crashes further down in the pipeline.

Update corelib/apply3_test status to match this change.

R=kustermann@google.com

Bug:
Change-Id: Iffb4d2bc7e513d5a79123b029f7ea7c4e1033056
Reviewed-on: https://dart-review.googlesource.com/19003
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2017-11-07 15:37:09 +00:00
Dmitry Stefantsov fe14ee8ac1 Update status files due to the recent strong-mode fix in sockets 
More tests are passing due to this commit:
https://github.com/dart-lang/sdk/commit/714dae5ac469ea530a382bad13b98c935110b193
Bug:
Change-Id: I72f572e01f1bc6ea9d68915fa8351b19d172cd88
Reviewed-on: https://dart-review.googlesource.com/19006
Reviewed-by: Jens Johansen <jensj@google.com>
 2017-11-07 15:01:22 +00:00
Dmitry Stefantsov 714dae5ac4 Fix a strong-mode issue in the io-library 
Help the compiler to infer types by adding the explicit type argument.

Bug:
Change-Id: I19f0caaf324801d887c6e7a8c782eca667fae069
Reviewed-on: https://dart-review.googlesource.com/18822
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-11-07 13:44:19 +00:00
Johnni Winther 0cb8876756 Extract a NoSuchMethodData object from NoSuchMethodRegistry 
Change-Id: Ie20797a25f61be4222278b26dcec9c31370c31b2
Reviewed-on: https://dart-review.googlesource.com/18821
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-07 09:03:38 +00:00
Harry Terkelsen 12baebc768 Set outer closure needs 'this' if inner needs 'this' for rti 
Change-Id: I46850f2a28abb499fa64266480fc108b38ecbfb9
Reviewed-on: https://dart-review.googlesource.com/18904
Commit-Queue: Harry Terkelsen <het@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-07 00:17:21 +00:00
Sigmund Cherem 14843eb067 Create deferred-load-task from the front-end strategy. 
This CL also moves code around a bit to prepare for the kernel implementation.
There are minimal changes, most of the code is the same. The refactor will make
the diff on the next CL much simpler

Change-Id: I4fff9c6511a5c19264c5573c4e2a0fffa2d61bfd
Reviewed-on: https://dart-review.googlesource.com/18681
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-11-06 23:34:00 +00:00
Paul Berry 3476edfcdb Update status file for issue #31288 
Change-Id: I7275502ba13ab8256a47c2c0be8e5818f005335e
Reviewed-on: https://dart-review.googlesource.com/18902
Reviewed-by: William Hesse <whesse@google.com>
 2017-11-06 21:51:34 +00:00
Brian Wilkerson 6553687296 Fix another path in type_checker_test 
Change-Id: I2b17a4227490e4abab02fe38e65d7ad77c6fb0dc
Reviewed-on: https://dart-review.googlesource.com/18920
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-11-06 21:26:12 +00:00
Brian Wilkerson caf3f19bcf Fix unparser test 
Change-Id: Ie70d4ff749c0e76df47ff76d5b9f888f00010b12
Reviewed-on: https://dart-review.googlesource.com/18862
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2017-11-06 19:50:00 +00:00
Erik Corry 3828f6ac10 Allow date_time11 to pass. 
R=brianwilkerson@google.com

Bug:
Change-Id: I58f115fce42dd8f6f1ca6df6d5dbbd538209937d
Reviewed-on: https://dart-review.googlesource.com/18545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-06 18:24:06 +00:00
Sigmund Cherem 46c859152a Add output unit data: an intermediate representation of the resuls of deferred loading 
Change-Id: I54fb3eb49338f137c127113fd884ce54a1187a64
Reviewed-on: https://dart-review.googlesource.com/18508
Reviewed-by: Stephen Adams <sra@google.com>
 2017-11-06 17:15:40 +00:00
Samir Jindel bc9645509e Revert "Revert "[kernel] Fix NoSuchMethod errors for generic functions."" 
This un-revert fixes the issues revealed in https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.dart%2Fvm-kernel-mac-release-x64-be%2F2217%2F%2B%2Frecipes%2Fsteps%2Fvm_tests%2F0%2Fstdout.

Patchset 1 contains the original revision unmodified.

This reverts commit 9029ee09c5.

Bug:
Change-Id: I109c011c2688144b00293ce50b3aad53e018a2f2
Reviewed-on: https://dart-review.googlesource.com/18340
Reviewed-by: Régis Crelier <regis@google.com>
 2017-11-06 17:07:38 +00:00
Samir Jindel edc4cb1f90 Fix incorrect type inference in Bigint.modInverse. 
Bug:
Change-Id: I73639d68c191d74815f7ac78bc98dc862efd319a
Reviewed-on: https://dart-review.googlesource.com/18841
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-06 17:04:28 +00:00
Erik Corry 0d4f518de0 Disable test that fails after DST ended 
R=floitsch@google.com

Bug:
Change-Id: I67f61526de019916d13578621f4f6926c03086a8
Reviewed-on: https://dart-review.googlesource.com/18521
Reviewed-by: Erik Corry <erikcorry@google.com>
 2017-11-06 14:46:08 +00:00
Erik Ernst 8d2b32df12 Removed status entry for test on issue 30997, issue fixed. 
Change-Id: Iee9d3189e73c2cc476847165a89f08e93d592213
Reviewed-on: https://dart-review.googlesource.com/18802
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-11-06 10:40:01 +00:00
Erik Ernst 40b6741778 Adds support for syntax error in tests to test.py. 
This CL modifies the Dart source used from test.py such that it takes
`syntax error` into account as an expected outcome in test files (so
that we can have `//# 01: syntax error` with a similar meaning as
`//# 01: compile-time error`).

For all tools except the spec_parser, `syntax error` is the same
outcome as `compile-time error`; that is, nobody else will see the
difference.

For the spec_parser, `syntax error` is the outcome where parsing has
failed; `compile-time error` is taken to mean some other compile-time
error, i.e., the spec_parser is expected to _succeed_ when the
expected outcome is `compile-time error`.

Test files in language and language_2 have been adjusted to use the
outcome `syntax error` where appropriate.

The status files in language and language_2 for the spec_parser have
been adjusted such that they fit all the new `syntax error` outcomes
in test files.

Other status files have been adjusted in a few cases where tests were
corrected (because a compile-time error which was clearly not intended
to be a syntax error turned out to be caused by a typo, which means
that the actual compile-time error has never been tested).

The spec grammar Dart.g was adjusted in a few cases, when some bugs
were discovered. In particular, the treatment of Function has been
changed: It is now known by the parser that Function does not take
any type arguments. This makes no difference for developers, because
they cannot declare a type named Function anyway, but it means that
a number of tricky parsing issues were resolved.

Dart.g was also adjusted to allow `qualified` to contain three
identifiers, which is an old bug (preventing things like metadata on
the form `@p.C.myConst`).

Change-Id: Ie420887d45c882ef97c84143365219f8aa0d2933
Reviewed-on: https://dart-review.googlesource.com/18262
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
 2017-11-06 08:56:09 +00:00
Johnni Winther 29f3cc0db1 Various fixes for erroneous cases 
Change-Id: I1c370dd220ff5e27196dcc8294d3c8eeda80462c
Reviewed-on: https://dart-review.googlesource.com/18483
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-06 08:42:46 +00:00
Jenny Messerly 384678e4b3 port DDC's code_generator to Kernel 
Change-Id: I2b6a5f56a69f5d3a965aefc3f8d4550d5940ac5a
Reviewed-on: https://dart-review.googlesource.com/17980
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2017-11-04 22:17:56 +00:00
Sigmund Cherem cfc1630f6e Mark jsinterop test slow 
Runs fine when run in isolation, but often times out when running the entire
suite on my local machine.

Change-Id: Iedbaa0fac5fc7191de9f3975c642769aff77c950
Reviewed-on: https://dart-review.googlesource.com/18680
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-11-03 23:56:04 +00:00
Paul Berry cd49cf1201 Insert implicit downcasts for compound assignments. 
Change-Id: I090594e16fa890864775b2ebc58842d861c134a4
Reviewed-on: https://dart-review.googlesource.com/18517
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-03 22:07:10 +00:00
Paul Berry e9e2ce7a38 Fix status file to account for fix to issue #31270 
Change-Id: Ibf94b0aa5d10fafd04b69512769c0474d94c733d
Reviewed-on: https://dart-review.googlesource.com/18507
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-03 19:23:50 +00:00
Sigmund Cherem c53c2f948d Support caching impacts with the kernel frontend. This is needed by deferred 
loading.

To make this possible, this CL explicitly models the impact cache and deleter.

Change-Id: I444625a7a14155d9c530a390854a42d277055aaa
Reviewed-on: https://dart-review.googlesource.com/18463
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-11-03 17:52:21 +00:00
Lasse R.H. Nielsen adcb6a7399 Make main invocation not fail strong-mode type checking. 
Bug: http://dartbug.com/31270
Change-Id: Id6ad2a429d5dc44b437a0fdd8fb4889d3dccf194
Reviewed-on: https://dart-review.googlesource.com/18480
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-11-03 16:06:00 +00:00
Jens Johansen 8463e79798 Update dart2js kernel status file 
It seems that e3c11c2703 missed this.

Bug:
Change-Id: I9573df4762ebc59706b88def2924bf72be5bdbcd
Reviewed-on: https://dart-review.googlesource.com/18560
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2017-11-03 15:34:10 +00:00
Aske Simon Christensen e3c11c2703 Retain erroneous import, export and part (of) directives 
If the URI of a directive is invalid, use a special URI with a
scheme marking it as malformed. In the loader, treat a file with
an invalid URI as empty.

Order all dependencies (imports and exports) by source position to
allow the DietListener to match them up properly with metadata.

For the same reason, add imports and exports within parts to
dependencies even though they are not permitted here.

Closes https://github.com/dart-lang/sdk/issues/30997
Closes https://github.com/dart-lang/sdk/issues/31004

Change-Id: Ic7efd0da058c246531c165508b7474475b4bdad2
Reviewed-on: https://dart-review.googlesource.com/17901
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-11-03 12:55:19 +00:00
Johnni Winther b7e53e4966 Detect non-nullness of postfix results in the old inferrer 
Change-Id: I51b0607371bfac4bead70bfc2852060aa3b1ed96
Reviewed-on: https://dart-review.googlesource.com/18280
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-03 10:29:59 +00:00
Johnni Winther 665694db89 Add test for postfix results. 
Change-Id: I24b860c31eb82e44ae7e3fd0b55536c076fddd9a
Reviewed-on: https://dart-review.googlesource.com/18260
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-11-03 09:41:52 +00:00
Samir Jindel 9029ee09c5 Revert "[kernel] Fix NoSuchMethod errors for generic functions." 
This reverts commit 52e1466588.

Bug:
Change-Id: Ic1b37a5df2f50ede4f6873b6d2a701663673bcbb
Reviewed-on: https://dart-review.googlesource.com/18261
Reviewed-by: Zach Anderson <zra@google.com>
 2017-11-02 16:52:32 +00:00
Samir Jindel 52e1466588 [kernel] Fix NoSuchMethod errors for generic functions. 
Bug:
Change-Id: I8ad90e34a7b1f77b29f1d711f158bcb69f5928f4
Reviewed-on: https://dart-review.googlesource.com/17941
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2017-11-02 15:16:08 +00:00
Johnni Winther d3f3846207 Remove .getClosureInfoForMember 
- and use ScopeInfo.forEachBoxedVariable instead of ClosureRepresentationInfo.forEachBoxedVariable.

Change-Id: I9d0c67eb06b7633a27d48745dc81d03d30f7e7ae
Reviewed-on: https://dart-review.googlesource.com/18186
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-11-02 14:06:38 +00:00
Johnni Winther 0373526d82 Fix refinements order on updates. 
Change-Id: I2677792bb23d90ce5c63f159156c27653ed69f5f
Reviewed-on: https://dart-review.googlesource.com/17800
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-02 13:03:47 +00:00
Johnni Winther 74022b9902 Refine receiver before arguments in method invocation 
Change-Id: I6c32ade4d2342489299b010c841fb5c928f96b9a
Reviewed-on: https://dart-review.googlesource.com/17783
Reviewed-by: Emily Fortuna <efortuna@google.com>
 2017-11-02 11:50:29 +00:00
Johnni Winther dc366e2c71 Test index access on this 
Change-Id: I9ce9e901ba7fed257c9035d40b9119bab1bbdc6e
Reviewed-on: https://dart-review.googlesource.com/17785
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-02 08:35:57 +00:00
Brian Wilkerson dd18ef841b Parser conversion, part 3 
Change-Id: Ibe48da9bfa89887fb04a4b958b913fe7c0087cf1
Reviewed-on: https://dart-review.googlesource.com/17600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-11-01 16:32:45 +00:00
Johnni Winther 42a6bfac51 Update infrastructure on inference_equivalence and equivalence-based tests. 
Reviewed in https://dart-review.googlesource.com/c/sdk/+/17440

Change-Id: I35c054517e72185d99eee2b438d62a5f5c52fdee
Reviewed-on: https://dart-review.googlesource.com/17782
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-11-01 09:28:31 +00:00
Johnni Winther 5017e573e3 Add test for index postfix/prefix 
Reviewed in https://dart-review.googlesource.com/c/sdk/+/17440

Change-Id: Ibf6399ca4c3ccf41ce8307833e5a300368c02299
Reviewed-on: https://dart-review.googlesource.com/17781
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-11-01 09:22:40 +00:00
Johnni Winther 1852cbab70 Use the right receiver mask in expose this computation 
Change-Id: I298eeb12fca7b1e78b904b63e64ceb6414d0996a
Reviewed-on: https://dart-review.googlesource.com/17440
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-11-01 09:14:59 +00:00
Jacob Richman 8b221d13a4 Fix ddc debugger_test Fix regression in custom formatters due to change in metadata signatures to use Object.__proto__ instead of a null __proto__. 
Bug:
Change-Id: I68fdb980e777b7c3f335fd6b57181134e3159cc3
Reviewed-on: https://dart-review.googlesource.com/17060
Commit-Queue: Jacob Richman <jacobr@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
 2017-10-31 19:45:27 +00:00
Paul Berry 8620e6b24a Insert implicit downcasts for ??= assignments. 
Change-Id: I272eeea96a19ad5c781113211ee466f844ffbe4b
Reviewed-on: https://dart-review.googlesource.com/17240
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-10-31 15:58:55 +00:00
Martin Kustermann 84dbb6e0b6 [VM] Do eager rehashing of [LinkedHashMap]s in order to avoid checking on every access 
This improves 
  * JIT performance by around 14% 
  * precompiled performance by around 2%
on a simple map microbenchmark.

Change-Id: I623e2a715a709f89f2514ae30fbb504ee2e31661
Reviewed-on: https://dart-review.googlesource.com/17165
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-31 13:42:15 +00:00
Vyacheslav Egorov 188746563d [gardening] Mark io/addlatexhash_test as flaky on reload bot 
Bug: https://github.com/dart-lang/sdk/issues/31252
Change-Id: I5738e849f6381b686461d76481528a4d072b4db0
Reviewed-on: https://dart-review.googlesource.com/17381
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-31 09:59:07 +00:00
Leaf Petersen 4270b99d75 Fix dynamic as bottom uses in front end and dart2js. 
Re-enable the dynamic as bottom hint in analysis_options.yaml and fix
the code to be hint clean again.

Fixes #30589
Fixes #30590

Bug:
Change-Id: Idb7910b3ab1c6d931a3ead3eed885d8bd172e621
Reviewed-on: https://dart-review.googlesource.com/17062
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-10-30 19:54:26 +00:00
Paul Berry 9cd3df3b29 Fix expectations for new test language_2/implicit_downcast_during_assignment_test 
Change-Id: I136ccca30eb30be8d911e70fd68bd10647297b85
Reviewed-on: https://dart-review.googlesource.com/17302
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-10-30 18:24:46 +00:00
Samir Jindel cde1996372 [kernel] Produce type error for 'AsExpression's marked as such. 
Bug:
Change-Id: I0c6ecc619f202867d17f5fbb28af0ef9dbc40d08
Reviewed-on: https://dart-review.googlesource.com/17260
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-30 18:05:04 +00:00
Paul Berry a08147a143 Add a language test to validate implicit downcasts during assignments. 
Change-Id: If960a713615283952167a7837bc2e5d46a7de9bd
Reviewed-on: https://dart-review.googlesource.com/17042
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-10-30 14:58:56 +00:00
Johnni Winther 395095b21d Make semantics of isExternal consistent between frontends 
Change-Id: Ieda4b47442d9e4ec7e4fcdef159e72bcf28c99e6
Reviewed-on: https://dart-review.googlesource.com/16946
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-10-30 10:03:32 +00:00
Dmitry Stefantsov 6ed3cd5a3d Change expectations for test top_level_main_t05 to Pass 
Bug:
Change-Id: If207e7dd5c7b04ee4e1a57acc3602a4cb925a8e0
Reviewed-on: https://dart-review.googlesource.com/17101
Reviewed-by: Karl Klose <karlklose@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2017-10-30 09:06:13 +00:00
Stephen Adams 72a1f622b2 dart2js kernel status update 
TBR=rnystrom@google.com

Bug:
Change-Id: I25b07112782773b90e25521cde03df2cfb89bcc7
Reviewed-on: https://dart-review.googlesource.com/17120
Reviewed-by: Stephen Adams <sra@google.com>
 2017-10-28 17:34:14 +00:00
Jenny Messerly 9bd19a49da Fixing renaming on top-level member 
Fixes #31117

Change-Id: I7210ceb505963a547e244ae743a99b8688af2e48
Reviewed-on: https://dart-review.googlesource.com/14240
Commit-Queue: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
 2017-10-28 01:29:38 +00:00