65c7fb4a96
Add correct type in Timer implementation
...
R=dmitryas@google.com
R=jacobr@google.com
Bug:
Change-Id: I30f2e177b956b7f05b4d580a4736587ec0f15751
Reviewed-on: https://dart-review.googlesource.com/17163
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com >
Commit-Queue: William Hesse <whesse@google.com >
2017-10-30 13:36:14 +00:00
e8aef37eac
Clean up patches so they can be compiled by Fasta.
...
Change-Id: Ie436375c78496366accf0ba82938e54cbe30b143
Reviewed-on: https://dart-review.googlesource.com/3001
Commit-Queue: Peter von der Ahé <ahe@google.com >
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com >
Reviewed-by: Vyacheslav Egorov <vegorov@google.com >
Reviewed-by: Johnni Winther <johnniwinther@google.com >
2017-10-05 14:05:50 +00:00
c8b6c19314
Revert "Add ticks counter to Timer."
...
Tests broken in DDC
Review-Url: https://codereview.chromium.org/3011503002 .
2017-08-28 13:14:09 +02:00
39c8f64ea3
Add ticks counter to Timer.
...
Avoid VM scheduling multiple timer events if it gets delayed. This doesn't
scale for processes that are suspended for extended amounts of time.
R=floitsch@google.com
Review-Url: https://codereview.chromium.org/3003853002 .
2017-08-28 12:57:45 +02:00
60a7160273
Reapply "[vm] Prevent non-fatal errors from causing timers to be dropped."
...
Fix Linux event handler to re-arm the timer_fd after handling a wakeup.
R=zra@google.com
Review-Url: https://codereview.chromium.org/2996243003 .
2017-08-18 13:38:08 -07:00
c536c82521
Revert "[vm] Prevent non-fatal errors from causing timers to be dropped."
...
This reverts commit 8692f618f6https://codereview.chromium.org/3001863002 .
2017-08-17 13:19:48 -07:00
8692f618f6
[vm] Prevent non-fatal errors from causing timers to be dropped.
...
Issue #30425
R=zra@google.com
Review-Url: https://codereview.chromium.org/2995103002 .
2017-08-17 11:34:30 -07:00
029b1cb948
Spelling fixes e to i.
...
R=kevmoo@google.com
BUG=
Review-Url: https://codereview.chromium.org/2957593002 .
2017-06-24 13:41:39 +02:00
4360e99d18
Revert "Fix observatory tests broken by running dartfmt."
...
This reverts commit b1f7e6d94673b098c93c187fe3efc45c15f27edc.
BUG=
Committed: https://github.com/dart-lang/sdk/commit/62be0eacfbb36bdc92a05c7c35bb4506621b6a3a
Review-Url: https://codereview.chromium.org/2767533002 .
2017-03-21 10:07:26 -07:00
62be0eacfb
Revert "Fix observatory tests broken by running dartfmt."
...
This reverts commit b1f7e6d94673b098c93c187fe3efc45c15f27edc.
BUG=
Review-Url: https://codereview.chromium.org/2767533002 .
2017-03-20 22:19:22 -07:00
88f8aacd5f
Re-apply rolled back CL to apply dartfmt to runtime.
...
Fix observatory tests broken by running dartfmt due to line and column changes.
Temporarily reverted formatting for evaluate_activation_test.dart as dartfmt doesn't yet handle multitests.
BUG=
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2759973004 .
2017-03-20 21:44:59 -07:00
ea4744a06f
Revert "Run dartfmt on all files under runtime."
...
This reverts commit 15f393f189TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2762583003 .
2017-03-20 13:42:55 -07:00
15f393f189
Run dartfmt on all files under runtime.
...
I've omitted files where the formatter output is significantly uglier
than the original code and I'll send those files in a separate CL
with options for how to make the code look reasonable while still
taking advantage of the formatter.
BUG=
R=johnmccutchan@google.com
Review-Url: https://codereview.chromium.org/2751423005 .
2017-03-20 13:13:50 -07:00
ae7319727a
Fix more lint style issues in runtime patches.
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2708663002 .
2017-02-20 14:17:14 +01:00
9387fead15
Use a monotonic clock in the implementation of Timer.
...
Ask the embedder for the current time, since it is the embedder who later compares the deadline with current time when deciding when to send a wake up message.
BUG=http://dartbug.com/25055
BUG=http://dartbug.com/25216
R=iposva@google.com , zra@google.com
Review URL: https://codereview.chromium.org/1519563003 .
2015-12-11 12:39:56 -08:00
e96a973492
Reduce timer stack overhead by getting immediate callback and run it, instead of calling through function.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//892963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45097 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-13 12:35:40 +00:00
4b1ba9eb69
- Make sure we schedule another wakeup when handling a timeout
...
from the event handler.
Review URL: https://codereview.chromium.org//971193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44191 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-03 19:14:30 +00:00
b4088d10c9
Adjust handling of timers:
...
- Every zero timer is enqueued individually in the event queue
and handled in sequence with other events.
- Non-zero timers and zero timers expire in order. Therefor a
due zero timer will also fire all preceding non-zero timers
to ensure this order.
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//958123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44095 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-27 16:45:23 +00:00
ad008bf8ba
- Move timer implementation closer to the rest of message handling.
...
R=zra@google.com
Review URL: https://codereview.chromium.org//878323002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43225 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-28 00:39:35 +00:00
William Hesse