dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
51,618 Commits 2 Branches 0 Tags
28793ea1301efb2dfdb3348fedc29bb20eb7e310
Commit Graph

1289 Commits

Author SHA1 Message Date
Peter von der Ahé 8bc6f7761f Add strong version of compile_platform_test. 
Change-Id: I18795293ca353a265b76f472ba2b567ab2b1ebbf
Reviewed-on: https://dart-review.googlesource.com/18540
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-11-03 13:17:39 +00:00
Brian Wilkerson c0f81029a3 Extract error translation and re-enable completeness test 
Change-Id: Ic78139f46a56f5b37d5569af712071ee8ae5fed9
Reviewed-on: https://dart-review.googlesource.com/18148
Reviewed-by: Dan Rubel <danrubel@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2017-11-02 16:34:09 +00:00
Paul Berry 08b0120186 Begin reporting "invalid assignment" errors. 
Change-Id: I1e47acd662032c63e56cb2349b2f349e9825b990
Reviewed-on: https://dart-review.googlesource.com/17680
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2017-11-01 16:28:35 +00:00
Florian Loitsch d2d8d35080 Mark checker test as slow. 
Change-Id: I43825a55d9fe0c3dc6b1e3a02d14d20678e6260c
Reviewed-on: https://dart-review.googlesource.com/16440
Reviewed-by: Florian Loitsch <floitsch@google.com>
 2017-10-25 08:20:18 +00:00
Peter von der Ahé fc2c2f251e front_end/tool/incremental_perf_test is slow 
Change-Id: I61414ff273ea3a5d39043598287bd89988f4625d
Reviewed-on: https://dart-review.googlesource.com/14440
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-10-17 12:23:10 +00:00
Peter von der Ahé b96ac4520a Update most clients to use computePlatformBinariesLocation. 
Change-Id: I6e6960c471b2fab3f0cd8a672da05d7699217410
Reviewed-on: https://dart-review.googlesource.com/12291
Commit-Queue: Peter von der Ahé <ahe@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-10-17 10:48:40 +00:00
Vyacheslav Egorov ac2cd68708 Skip pkg/kernel/test/metadata_test on pkg bots. 
This test needs platform.dill and can't run from SDK currently.

(Use correct path in the status file: without pkg/)

Bug:
Change-Id: I4e6e9ed2f713d51a68fe9f3caa59f65b6c0aaf04
Reviewed-on: https://dart-review.googlesource.com/11064
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-04 16:45:07 +00:00
Vyacheslav Egorov 7890aeef81 Skip pkg/kernel/test/metadata_test on pkg bots. 
This test needs platform.dill and can't run from SDK currently.

Bug: https://github.com/dart-lang/sdk/issues/28629
Change-Id: I7c3f1a20b74c9d09982e70dec07322cd9a454ca4
Reviewed-on: https://dart-review.googlesource.com/11063
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2017-10-04 16:41:38 +00:00
Sigmund Cherem d96b29378a Delete use of rasta and dartk from perf.dart scripts. 
Change-Id: Id8cd7f01c68dbcb6f814ef51627a2f4b377f6819
Reviewed-on: https://dart-review.googlesource.com/9790
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2017-10-03 23:12:21 +00:00
Konstantin Shcheglov 1018d6038c Mark hint_code_kernel_test as Slow, Pass. 
R=brianwilkerson@google.com

Bug:
Change-Id: Idaa96e6e75d4dfc40378705f8ebc98d12a466444
Reviewed-on: https://dart-review.googlesource.com/10580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-10-03 16:25:33 +00:00
Peter von der Ahé cefe4d5d65 Move compile_platform_test.dart to tool directory. 
This also reverts "Move command_line.dart and most of compile_platform.dart into lib/"

This reverts commit 1916dc75e6.

Change-Id: I2598514c6bb62eec392bd00f20b15aac72b6fa42
Reviewed-on: https://dart-review.googlesource.com/9600
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2017-10-02 16:23:56 +00:00
Konstantin Shcheglov b5fc2de3bf Keep sources for libraries of the current cycle. 
This should fix the issue 30917 flakiness.

The reason why the tests were failing is that the code in the tests
was not quite correct Dart code, so Fasta generated a synthetic
`#errors` top-level variable with fileUri == null. We should skip
this field because it is not a part of any unit, because its fileUri
is not the fileUri of any unit.

But we lose fileUri for a Node if Program.uriToSource does not
include this URI. So, if we clear uriToSource in KernelDriver, we
lose all the file URIs. So, now we keep sources for the cycle files.

The reason for flakiness is because of the same race condition
between analyzing AnalysisDriver.addFile() and getResult(). If
we process getResult() before, we don't have to read the library
kernel file, we just create in first time, and fileUri(s) are
valid.

R=ahe@google.com, paulberry@google.com, sigmund@google.com

Bug: https://github.com/dart-lang/sdk/issues/30917
Change-Id: Ie559cf2a8a778ebf4a9e297f5cb13d30a98b5a3c
Reviewed-on: https://dart-review.googlesource.com/9744
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-29 18:38:52 +00:00
William Hesse 392b89fb99 Update status of analyzer strong_mode_kernel unittest on Windows. 
Info in issue #30917
Bug: https://github.com/dart-lang/sdk/issues/30917
Change-Id: I13ba60350d0031a1f2b08cd22438e814c751bd1c
Reviewed-on: https://dart-review.googlesource.com/9621
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-29 16:24:33 +00:00
Peter von der Ahé ed34e41d0e Update status for slow front_end/tool/incremental_perf_test. 
Change-Id: Ie16775c322f29d1f715b85a263571ea47b6150fb
Reviewed-on: https://dart-review.googlesource.com/9560
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2017-09-29 12:08:50 +00:00
Sigmund Cherem 655d60f2c5 Add incremental_perf: a script to measure performance of the incremental kernel 
generator.

The script takes an input program Uri, and a file describing edits, and it mocks
applying the edits in multiple iterations.

incremental_perf_test illustrates how this can be used to do incremental
compiles of the dart2js source code.

Change-Id: I3518996a0faac34de8c6cef2f63468f4788b3c06
Reviewed-on: https://dart-review.googlesource.com/6026
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-29 05:17:41 +00:00
Dmitry Stefantsov 9df589eeae Mark pkg/analyzer_plugin/test/plugin/folding_mixin_test as Slow 
The bot had several timeouts during the day.  It may be similar to what
was fixed in
https://github.com/dart-lang/sdk/commit/5263d17f7480ff0648fa319ba1a8ed62d5116111
Change-Id: Ife4a1e6d2b40992d260ae03287d844ee9cceb79b
Reviewed-on: https://dart-review.googlesource.com/8600
Reviewed-by: Karl Klose <karlklose@google.com>
 2017-09-26 13:32:26 +00:00
Johnni Winther c0c63bf16e Fix handling of function type parameters 
Closes #30826

Change-Id: I804bff2a204aa210ba59f691c5d680d8a53aadeb
Reviewed-on: https://dart-review.googlesource.com/7553
Reviewed-by: Sigmund Cherem <sigmund@google.com>
 2017-09-26 08:23:34 +00:00
Konstantin Shcheglov 5263d17f74 Make more *_kernel_test Slow, Pass. 
R=brianwilkerson@google.com

Bug:
Change-Id: I306a311096093312faf817f2daded105821bd5ca
Reviewed-on: https://dart-review.googlesource.com/8241
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-25 20:00:51 +00:00
Konstantin Shcheglov f575c099b0 Run all *_driver tests also with Kernel. (attempt #2) 
With previous changes that fix finding dart:core on Windows and
flakyness of reporting import errors, I'd like to reland this CL.

Attempt #1: https://dart-review.googlesource.com/c/sdk/+/7624

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: If5ab2c5ebe2204df6643ee42cbee5b49fb2d8c31
Reviewed-on: https://dart-review.googlesource.com/7961
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-24 18:27:27 +00:00
Konstantin Shcheglov 8e94406288 Remove DirectoryBasedSourceContainer and its test. 
This is the only test from pkg/analyzer/test/test_all.dart suite
that fails on my Windows machine. Given that the class has not been
used for ages, it is easier to remove it.

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/21772
Change-Id: I110825f44915dde354af22e73e2d376231c08b0d
Reviewed-on: https://dart-review.googlesource.com/7943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-23 16:41:24 +00:00
Konstantin Shcheglov 3b632329f7 Fix source_factory_test to pass on Windows. (attempt #2) 
Attempt #1 was: https://dart-review.googlesource.com/c/sdk/+/7843

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/26828
Change-Id: Id5cb82883d25e5b51b8304cd152497535d7db48a
Reviewed-on: https://dart-review.googlesource.com/7940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-23 00:19:09 +00:00
Konstantin Shcheglov e929620072 Revert "Fix source_factory_test to pass on Windows." 
This reverts commit 11d2dfb915.

Reason for revert: There is still one failing test.
See https://build.chromium.org/p/client.dart/builders/analyzer-win7-release-be/builds/7264/steps/analyzer%20unit%20tests/logs/stdio

Original change's description:
> Fix source_factory_test to pass on Windows.
> 
> R=​brianwilkerson@google.com, paulberry@google.com
> 
> Bug: https://github.com/dart-lang/sdk/issues/26828
> Change-Id: I368bbeb1f96c970192b2004685297acce2fddd69
> Reviewed-on: https://dart-review.googlesource.com/7843
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>

TBR=paulberry@google.com,scheglov@google.com,brianwilkerson@google.com

Change-Id: I4f4e2f9a0c34fed26726a1d48ab1068ca8b6e16b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/26828
Reviewed-on: https://dart-review.googlesource.com/7920
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-22 22:25:18 +00:00
Konstantin Shcheglov 11d2dfb915 Fix source_factory_test to pass on Windows. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/26828
Change-Id: I368bbeb1f96c970192b2004685297acce2fddd69
Reviewed-on: https://dart-review.googlesource.com/7843
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2017-09-22 20:56:58 +00:00
William Hesse 2274739c3c Revert addition of kernel tests to analyzer unit tests 
These tests have flaky failures on the buildbots and commit queue.
Revert "Run all *_driver tests also with Kernel."

This reverts commit d2f887e37b.

Revert "Adjusted status for analyzer/test/generated/strong_mode_kernel_test"

This reverts commit 055654e96d.

Revert "Made status for strong_mode_kernel_test broader (flaky)."

This reverts commit 824c3f56cc.

Bug:
Change-Id: I341762671efc31f168df2f5806653d9548bd43ae
Reviewed-on: https://dart-review.googlesource.com/7708
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-22 11:37:21 +00:00
Erik Ernst 824c3f56cc Made status for strong_mode_kernel_test broader (flaky). 
Change-Id: Ia5ee7c6a06b34959760aef6771d608ad4431ffeb
Reviewed-on: https://dart-review.googlesource.com/7705
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-22 10:06:22 +00:00
Erik Ernst 055654e96d Adjusted status for analyzer/test/generated/strong_mode_kernel_test 
See https://github.com/dart-lang/sdk/issues/30863 for further
information.

Change-Id: I54adc4956db294e00c019366a83af082c029aae4
Reviewed-on: https://dart-review.googlesource.com/7704
Reviewed-by: Erik Ernst <eernst@google.com>
 2017-09-22 09:20:09 +00:00
Konstantin Shcheglov d2f887e37b Run all *_driver tests also with Kernel. 
R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I92a0f5f2192c20276b166a9211ab1064bc6f2b82
Reviewed-on: https://dart-review.googlesource.com/7624
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-21 22:44:39 +00:00
Alexander Thomas 55f98fef95 Change status for flaky tests 
Bug:
Change-Id: I2544efc246ce285222aa569990f23106dcee4d09
Reviewed-on: https://dart-review.googlesource.com/7557
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
 2017-09-21 20:46:18 +00:00
Florian Loitsch 38bf70d7ac Use generic functions in zones. 
Migrated from https://chromiumcodereview.appspot.com/2893893002/

Change-Id: I0bd6dc1438eb1e6762e7760a08b5a760b07d4b10
Reviewed-on: https://dart-review.googlesource.com/4942
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
 2017-09-20 15:46:06 +00:00
Johnni Winther 6976262fa1 [gardening] Skip analyzer/test/generated/non_error_resolver_kernel_test 
Change-Id: Ia175864e0bfa19c86d56d5135a6197a9917bedff
Reviewed-on: https://dart-review.googlesource.com/6861
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2017-09-19 10:34:25 +00:00
Konstantin Shcheglov 44c43773c9 Attempt to fix Windows bots for non_error_resolver_kernel_test. 
TBR

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I2b764c7a5bf020f0983c1e9abb226091c888571b
Reviewed-on: https://dart-review.googlesource.com/6768
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2017-09-19 01:36:34 +00:00
Konstantin Shcheglov cd2d54e1f3 Mark non_error_resolver_kernel_test as failing on Windows. 
R=brianwilkerson@google.com

Bug:
Change-Id: Id52df29076684b47b98d532d61ba4671b93eb2a7
Reviewed-on: https://dart-review.googlesource.com/6647
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-18 19:24:49 +00:00
Konstantin Shcheglov f43c54ff22 Issue 30785. Fix for file URI on Windows in KernelContext. 
R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/30785
Change-Id: Iacf9cda1f26a696a745802d14183d9f06e485324
Reviewed-on: https://dart-review.googlesource.com/6640
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2017-09-18 16:59:06 +00:00
Karl Klose 5bfb095aa6 Mark analyzer unit test as failing on Windows 
R=whesse@google.com

Change-Id: I4c20ca6aef3057a14e4930725dca80a13729a2c8
Reviewed-on: https://dart-review.googlesource.com/6468
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: William Hesse <whesse@google.com>
 2017-09-18 13:06:46 +00:00
Konstantin Shcheglov 50c964b819 Add option for AnalysisDriver to use KernelDriver and KernelResynthesizer. 
Run NonErrorResolverTest_Driver tests with this option enabled.
We fail 163 out of 478 tests, or 35%.

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: Iac6154a14a1357fe239b0140f9f66de792825693
Reviewed-on: https://dart-review.googlesource.com/6340
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2017-09-18 02:09:14 +00:00
Harry Terkelsen b7666dd327 dart2js: Remove lookup map support 
Change-Id: Id435dc0f54165285c0d291d2e1c984da92bfd22a
Reviewed-on: https://dart-review.googlesource.com/5284
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Harry Terkelsen <het@google.com>
 2017-09-12 20:16:12 +00:00
Ben Konyi 531fe49e94 Updated status file to expect lookup_map_test to pass on dart2js-jsshell. 
TBR=asiva@google.com
Bug:
Change-Id: Ib362b6dab5ce0bb34402e21a5a84e66dd924c0a7
Reviewed-on: https://dart-review.googlesource.com/4640
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2017-09-09 00:29:31 +00:00
Dmitry Stefantsov 0cf1f7685d Update status for front_end/test/mixin_export_test 
Commit 48503c8720 introduces test case
pkg/front_end/test/mixin_export_test.dart that passes on d8, but doesn't
work in browsers.  An issue is created for that (dartbug.com/30576).
This CL changes the status for the tests on browsers.

R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/3008893002 .
 2017-08-30 12:00:57 +02:00
Sigmund Cherem f4f13fe561 Skip mixin_export_test when using --use-sdk 
Review-Url: https://codereview.chromium.org/3007793002 .
 2017-08-29 12:30:28 -07:00
Peter von der Ahé bf55954dd1 Ensure front_end test cases aren't mistaken for tests. 
Review-Url: https://codereview.chromium.org/3003403002 .
 2017-08-25 14:26:57 +02:00
Kevin Millikin bae72c382a Fix the script analyzer/tool/generate_files 
* The script had stopped working due to a pair of changes in Dart.
  First, building Dart no longer produces a packages directory to use
  as a package-root.

  Second, generated Dart files are now formatted and the formatting
  code relies on invoking Dart from the Dart SDK in order to find
  dartfmt.  (Specifically: invoking Dart from the build directory does
  not work because there is no dartfmt there, and invoking Dart via
  sdk/bin/dart from the SDK repository does not work because it is a
  shell script that invokes Dart from the build directory.)

* Enable the test that the generated summary code has not changed.

* Regenerate the generated summary code.

BUG=
R=paulberry@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2997703002 .
 2017-08-11 12:05:47 +02:00
Sigmund Cherem 8d4af85333 Remove use of cwd in d8 preamble 
Fixes #30279
BUG= https://github.com/dart-lang/sdk/issues/30279
R=sra@google.com

Review-Url: https://codereview.chromium.org/2993153003 .
 2017-08-07 15:54:08 -07:00
Sigmund Cherem c80402ab67 Update .status file after move of byte_store 
TBR=paulberry@google.com

Review-Url: https://codereview.chromium.org/2993853002 .
 2017-08-07 12:16:43 -07:00
Sigmund Cherem 62f4509aa0 Update status file for libraries_specification_test 
The test fails in `d8` for unrelated reasons.
TBR=paulberry@google.com

Review-Url: https://codereview.chromium.org/2995593002 .
 2017-08-07 10:09:12 -07:00
Siva Annamalai 53cf85abc8 Fix for issue 29819 https://github.com/dart-lang/sdk/issues/29819 when a 'dill' file is loaded directly into the VM, set mode to dart front end mode and use that when reloading files too, this ensures that we reload correctly. 
Adjust pkg.status to account for the hot_reload_e2e_test passing.

R=aam@google.com

https://github.com/dart-lang/sdk/issues/29819
Review-Url: https://codereview.chromium.org/2990833002 .
 2017-07-27 10:06:54 -07:00
Erik Ernst 94669b4811 Added status for d8 failures, cf. issue 30279. 
Review-Url: https://codereview.chromium.org/2988023002 .
 2017-07-27 16:08:51 +02:00
Bob Nystrom 796eb21071 Move the status file parser into its own package. 
This required munging a bit of test.dart code too to tease out some
dependencies, but the changes are minor. I considered moving all of
test.dart out into a package and making the status file library a
public one that other packages in the repo could import but this seemed
like the less intrusive change.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2984203002 .
 2017-07-25 15:29:59 -07:00
Sigmund Cherem 0d49519988 Mark front-end analyze tests as passing again. Actual fixes were submitted in strong mode checker and dart2js (Fixes #30244) 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2990553002 .
 2017-07-24 17:33:32 -07:00
William Hesse 33f919f8c7 Update status for correct fasta test. 
Previous commit changed the status for the wrong test.

BUG=https://github.com/dart-lang/sdk/issues/30244

Review-Url: https://codereview.chromium.org/2989543002 .
 2017-07-24 15:26:08 +02:00
William Hesse 1bfcfa4560 Update status for failing tests 
Issues have been filed for these tests.

BUG=https://github.com/dart-lang/sdk/issues/30245
BUG=https://github.com/dart-lang/sdk/issues/30244

Review-Url: https://codereview.chromium.org/2991523002 .
 2017-07-24 14:18:09 +02:00