Commit Graph

172 Commits

Author SHA1 Message Date
Brian Wilkerson b5ba13202d Add a description of the packages used to implement a plugin
Change-Id: Ibb5207e93e7c12560cd9be6845c63a3d50e23df5
Reviewed-on: https://dart-review.googlesource.com/18780
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2017-11-06 14:11:59 +00:00
Brian Wilkerson c6c7580c92 Add error detection and reporting for errors related to plugins
Change-Id: If17e88b64022fe71c992c5867c80263c0e6b953b
Reviewed-on: https://dart-review.googlesource.com/18781
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-11-05 19:21:07 +00:00
P.Y. Laligand ce79a77331 Remove Fuchsia-specific build files.
Also fix Fuchsia tools to account for new project location (//third_party/dart).

Change-Id: If89a934729c4fa44229eaca83219dbdf8bb700a8
Bug:
Reviewed-on: https://dart-review.googlesource.com/14800
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-19 17:52:37 +00:00
Devon Carew 47a861ca85 Add two new element types to the protocol.
Bug:
Change-Id: I5a60081d7c8500590bbabb9ee6dce74fa611b0a3
Reviewed-on: https://dart-review.googlesource.com/14883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-10-18 19:02:47 +00:00
Devon Carew a5c2256455 Send test element kinds for test outline items.
Bug:
Change-Id: Iebea8d4b9705c726e297722ef1678e1a2cd1ea96
Reviewed-on: https://dart-review.googlesource.com/12841
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-10-11 17:00:41 +00:00
Brian Wilkerson b3439aa20b Guard against broken code (issue 31023)
Change-Id: I9f53abb1257a3ffc86dc4bf46e2591c7f936d1fe
Reviewed-on: https://dart-review.googlesource.com/11940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2017-10-06 17:28:04 +00:00
Konstantin Shcheglov e925eb125c Fix type code for typedefs after switching to GenericTypeAliasElement.
https://dart-review.googlesource.com/c/sdk/+/9421

R=brianwilkerson@google.com, paulberry@google.com

Bug:
Change-Id: I25d60ff904f15e6eeefff97b08ba9870d69733db
Reviewed-on: https://dart-review.googlesource.com/9460
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2017-09-29 04:27:53 +00:00
Brian Wilkerson 3ee522935d Add suffix to remove the possibility of contention over byte stores in plugins
Change-Id: I448eaac6d9525432a6b154729abcaef62f0332ee
Reviewed-on: https://dart-review.googlesource.com/8260
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2017-09-25 21:19:39 +00:00
Konstantin Shcheglov 455984bbf9 Fix fuzzy arrow warnings in analyzer and analysis_server.
There is one warning which I'd like to fix in a separate CL.

The rest is because of package:test predicate().
I think Leaf fixed it in https://github.com/dart-lang/matcher/commit/3625f13698346576da0f5baf44e95abc9c56fb49


R=brianwilkerson@google.com

Bug:
Change-Id: I060f7ced55dbcc460185916251c47ebbd5c838d3
Reviewed-on: https://dart-review.googlesource.com/3404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-06 00:26:18 +00:00
Brian Wilkerson 2d204c548b Documentation for the kythe support
R=jwren@google.com

Review-Url: https://codereview.chromium.org/3004743002 .
2017-08-28 10:14:47 -07:00
Brian Wilkerson 37042bb59b Add an integration test for kythe support with bug fixes
R=jwren@google.com

Review-Url: https://codereview.chromium.org/3006693002 .
2017-08-28 10:07:04 -07:00
Brian Wilkerson 608bf972b0 Add folding support for plugins and update the main tutorial page
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3004733002 .
2017-08-28 08:05:37 -07:00
Brian Wilkerson d1a2a43d54 Add plugin support for occurrences (and fix typo)
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3006703002 .
2017-08-28 08:04:42 -07:00
Brian Wilkerson 86918d713b Add SourceRange support to navigation collector
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3002343002 .
2017-08-27 12:31:13 -07:00
Konstantin Shcheglov f78d43c3d3 Convert GeneratedContent to async and use AnalysisDriver for tasks graph.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/3002293003 .
2017-08-26 07:51:34 -07:00
Brian Wilkerson 1f552d8c96 More clean-up prior to publishing
Review-Url: https://codereview.chromium.org/3006633002 .
2017-08-25 14:11:42 -07:00
Brian Wilkerson f64000374d Update pubspecs prior to publishing
R=devoncarew@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/3006623002 .
2017-08-25 13:24:17 -07:00
Brian Wilkerson dd00fc7750 Add support for highlights notification
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3004613002 .
2017-08-25 09:21:36 -07:00
Konstantin Shcheglov dc60566293 Make finalize() async and await adding imports, if any.
There were two flaky tests for assists because sometimes we managed
to execute adding imports before performing checks in the test. And
in this case there was additional (unexpected) empty file edit for
the library file (the only expected file edit was for the part).

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/3009563002 .
2017-08-24 21:07:34 -07:00
Brian Wilkerson efd4051c7e Add utilities to support the outline notification
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3002233002 .
2017-08-24 11:59:06 -07:00
Brian Wilkerson 4c8fbfad81 Add documentation for the new notification support
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3008493002 .
2017-08-24 11:26:36 -07:00
Brian Wilkerson c6b206a2d9 Clean up after some recent code changes
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3009513002 .
2017-08-24 10:01:11 -07:00
Brian Wilkerson e8010e4a44 Enhance NavigationMixin to handle notifications
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3008443002 .
2017-08-24 07:44:51 -07:00
Brian Wilkerson c53bc9f628 Unify lots of copied code in one utility method
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3008433002 .
2017-08-23 14:25:03 -07:00
Brian Wilkerson 0a50effce5 Add minimal support for sending notifications
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/3003573002 .
2017-08-23 13:26:59 -07:00
Brian Wilkerson 4463d646fe Minor enhancement to the plugin tutorials
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2998083002 .
2017-08-18 12:21:44 -07:00
Brian Wilkerson ebe2ce681e Fix ClassElement.allSupertypes to include interfaces of mixins (issue 29767)
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/3000183002 .
2017-08-18 07:30:05 -07:00
Brian Wilkerson d87fcfd233 Correctly update positions when adding edits before them (issue 30444)
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2997073002 .
2017-08-16 10:29:26 -07:00
Brian Wilkerson 6f81034a73 Initial Kythe support for plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2997833002 .
2017-08-14 08:24:15 -07:00
Brian Wilkerson ecc72d6be5 Initial implementation of the kythe domain
R=jwren@google.com

Review-Url: https://codereview.chromium.org/2999783002 .
2017-08-10 11:49:22 -07:00
Brian Wilkerson 579a032564 Add kythe support to plugins and format the spec files
R=jwren@google.com

Review-Url: https://codereview.chromium.org/2994103002 .
2017-08-10 11:24:40 -07:00
Brian Wilkerson 1abf749b77 Fix more uses of generic method comments and increment the data version (TBR)
Review-Url: https://codereview.chromium.org/2996653002 .
2017-08-08 11:27:02 -07:00
Paul Berry e2f77056a5 Eliminate dependencies on pkg/front_end.
The API for pkg/front_end is still in flux so we want to avoid having
any packages depend directly on it (other than analyzer and
back-ends).

This CL re-exports some of the critical pieces of front_end needed by
analyzer clients so that those clients can access them via analyzer,
without having to directly depend on front_end.  It also updates
pkg/analyzer_plugin to make use of those re-exports.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2993123002 .
2017-08-07 09:46:30 -07:00
Brian Wilkerson 4e1644f12a Add more documentation for plugins
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2992843002 .
2017-08-02 07:45:45 -07:00
Brian Wilkerson adb482002b Prevent exception with isolate failed to start
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2986123002 .
2017-07-28 08:26:31 -07:00
Brian Wilkerson 9a6b134d33 Improve name generation for indexed expressions
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2990793002 .
2017-07-27 07:58:34 -07:00
Brian Wilkerson cc7b83f4da Mark refactoring support for plugins as experimental
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2990573003 .
2017-07-26 07:43:55 -07:00
Brian Wilkerson 8bbf373a5e Remove the analysus.reanalyze request from the plugin API
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988743002 .
2017-07-25 12:10:52 -07:00
Brian Wilkerson 1e0e351406 Fix a typo in the docs
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2988683002 .
2017-07-24 09:54:23 -07:00
Brian Wilkerson 8a275e6df8 Add utility method to SubscriptionManager
R=mfairhurst@google.com

Review-Url: https://codereview.chromium.org/2983913002 .
2017-07-21 07:24:55 -07:00
Konstantin Shcheglov 00d5012906 Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt.
...instead of mixing formatting with actual changes in many CLs.

R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=

Review-Url: https://codereview.chromium.org/2975253002 .
2017-07-13 16:28:18 -07:00
Brian Wilkerson 0c775ae412 Guard against an AST node with no end token (issue 30089)
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2974533002 .
2017-07-06 12:51:23 -07:00
Konstantin Shcheglov 19265a82b4 Move findElementsByName() into shared analyzer/element_search.dart file.
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2965133003 .
2017-07-06 11:51:17 -07:00
Brian Wilkerson 0484f28335 Initial documentation for the plugin package
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2973753003 .
2017-07-06 11:37:52 -07:00
Konstantin Shcheglov 6323bedc58 Stop depending on LabelElement(s) to be reported in visitChildren().
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2973093002 .
2017-07-06 11:28:06 -07:00
danrubel 8cca317118 fix completion test expectation for fasta scanner
Review-Url: https://codereview.chromium.org/2972063002 .
2017-07-06 14:07:49 -04:00
Brian Wilkerson 75504c2b25 Remove references to AnalysisDriver from the plugin mixin classes
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2970203002 .
2017-07-06 09:07:10 -07:00
Brian Wilkerson 6a7b9f441b Convert DartChangeBuilder to use AnalysisSession
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2969833002 .
2017-07-03 08:41:40 -07:00
Brian Wilkerson aadafd1bd5 Use DartEditBuilder to write types and remove dead code
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2972463003 .
2017-07-01 12:03:44 -07:00
Brian Wilkerson 6f4420562c Clean up some code in plugins
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2967683002 .
2017-06-30 10:39:20 -07:00