6b1658906e
Support for Flutter is not limited to code correction. Move to utilities.
...
R=brianwilkerson@google.com
Bug:
Change-Id: Idaa90946710fcbec2a35a91eb35b5ead68cf4170
Reviewed-on: https://dart-review.googlesource.com/16621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-25 19:11:38 +00:00
c0bf4ab395
Handle recursive import/export graph in completions
...
Change-Id: Ia164c13f3119f569d781292353acc17243c8a464
Reviewed-on: https://dart-review.googlesource.com/7000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-09-19 18:01:04 +00:00
28381b8f06
Add completion of keywords in partial field declarations
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/3006033002 .
2017-09-03 13:04:06 -07:00
c38c97def3
Reduce duplicated code
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3002303002 .
2017-08-25 08:18:39 -07:00
84a36f1b77
flag to limit file and package URI completion suggestions
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3003233002 .
2017-08-23 13:39:32 -04:00
ebe2ce681e
Fix ClassElement.allSupertypes to include interfaces of mixins (issue 29767)
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/3000183002 .
2017-08-18 07:30:05 -07:00
5b88eef0af
Suggest covariant in parameter lists
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2986133002 .
2017-07-28 10:33:07 -07:00
bdd69ccd6c
Remove UriReferencedElement with its uri/uriOffset/uriEnd properties.
...
The 'Move File' refactoring does not work, so I comment out most
of its code.
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/2982993003 .
2017-07-19 09:31:03 -07:00
00d5012906
Format analyzer, analysis_server, analyzer_plugin, front_end and kernel with the latest dartfmt.
...
...instead of mixing formatting with actual changes in many CLs.
R=ahe@google.com , paulberry@google.com , sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2975253002 .
2017-07-13 16:28:18 -07:00
e454986288
Add code to run more tests from test_all
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2968233002 .
2017-07-06 12:24:01 -07:00
c26c2774ca
This defines some postfix completion templates for use in the IntelliJ editor.
...
R=brianwilkerson@google.com
To use it, you'll need a version of the Dart plugin with this PR patched in:
https://github.com/JetBrains/intellij-plugins/pull/534
Review-Url: https://codereview.chromium.org/2917943002 .
2017-06-26 09:53:02 -07:00
029b1cb948
Spelling fixes e to i.
...
R=kevmoo@google.com
BUG=
Review-Url: https://codereview.chromium.org/2957593002 .
2017-06-24 13:41:39 +02:00
ec8505fc79
Fix hints and clean-up obsolete comment syntax (TBR)
...
Review-Url: https://codereview.chromium.org/2952233002 .
2017-06-22 10:59:26 -07:00
b502bb6956
Prioritize required name param completions (flutter-intellij#1049).
...
R=danrubel@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/1049
Review-Url: https://codereview.chromium.org/2927343002 .
2017-06-09 10:20:16 -07:00
0e6586492d
Make common tests consistent
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2925273003 .
2017-06-09 08:40:16 -07:00
aa33d71071
Another attempt to fix the windows tests
...
Review-Url: https://codereview.chromium.org/2927873002 .
2017-06-07 12:35:56 -07:00
a8919b8237
Support a short-hand way to create linked edit groups
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2928723003 .
2017-06-07 09:07:39 -07:00
db0a8a76ae
Move CompletionTarget and OpType for use by plugins
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2924703002 .
2017-06-06 07:07:19 -07:00
1c4cee9a82
Remove an obsolete test
...
Review-Url: https://codereview.chromium.org/2925723002 .
2017-06-05 14:45:11 -07:00
dc972240d4
Remove unused IdeOptions
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2924633002 .
2017-06-05 14:12:17 -07:00
e8a5e404c3
Move LocalDeclarationVisitor for use by contributors that will be moved to analyzer_plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2918343002 .
2017-06-05 10:24:54 -07:00
ab9ee72a34
Switch server tests to strong mode.
...
R=brianwilkerson@google.com
BUG=
Review-Url: https://codereview.chromium.org/2903523003 .
2017-05-23 14:58:53 -07:00
7d26ff6d4f
Remove some more library directives
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2884233004 .
2017-05-17 08:02:08 -07:00
aa491e7133
Support tear-off completions for named params (in constructors) (flutter-intellij#836)
...
R=danrubel@google.com
Fixes: https://github.com/flutter/flutter-intellij/issues/836
Review-Url: https://codereview.chromium.org/2883363002 .
2017-05-16 13:40:33 -07:00
fb982f5476
Make server use the common protocol classes
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
4afc0aeb73
Fix some analysis issues.
...
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2882003002 .
2017-05-13 16:24:47 -07:00
69cc6c3183
convert completion tests to use new analysis driver
...
Update more tests and remove dead code from tests
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2875223003 .
2017-05-12 11:48:20 -07:00
66bb2d618e
Remove unused analysisContext from completion request and contributors
...
Now that the analysis server uses the new analysis driver,
the CompletionRequest analysisContext field is always null.
This change removes that field and much of the unused code.
R=brianwilkerson@google.com , pquitslund@google.com
Review-Url: https://codereview.chromium.org/2877653002 .
2017-05-11 09:38:50 -07:00
6798cdfcd1
cleanup dart code completion contributors
...
Remove the following unnecessary methods now that analysis driver
resolves everything in the compilation unit upfront.
DartCompletionRequest
* resolveUnits
* resolveImports
* resolveContainingStatement
* resolveContainingExpression
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2873943003 .
2017-05-11 09:12:36 -07:00
55097a44b3
Recover from merge problem
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2868383002 .
2017-05-10 13:12:14 -07:00
fbc3f3708d
Remove unused reference to SearchEngine
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2872803003 .
2017-05-09 14:32:12 -07:00
959b7c14b8
improve completion for formal param initializers
...
R=pquitslund@google.com
Review-Url: https://codereview.chromium.org/2864233002 .
2017-05-08 06:50:46 -07:00
6b8a56cd7f
Switch the default from non-driver to driver in several tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2864813002 .
2017-05-07 08:34:16 -07:00
863bd921e1
Remove the non-driver versions of several tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2863593004 .
2017-05-05 13:46:03 -07:00
0b59d3f650
Convert some tests to use the driver and prepare for others to be converted
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2859993004 .
2017-05-05 13:20:38 -07:00
a51af38461
Widget details for Flutter children: param completions.
...
R=brianwilkerson@google.com
See: https://github.com/flutter/flutter-intellij/issues/463
Review-Url: https://codereview.chromium.org/2855883003 .
2017-05-02 13:50:34 -07:00
28b7710190
Complete declarations; detect invalid blocks
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2852073002 .
2017-05-01 08:45:41 -07:00
e55812a3f2
Unify the server and plugin versions of the generators
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2844273003 .
2017-04-28 07:46:29 -07:00
daa399499d
Fix following comma detection in code completion ( #29503 ).
...
BUG=
R=brianwilkerson@google.com
Fixes: https://github.com/dart-lang/sdk/issues/29503
Review-Url: https://codereview.chromium.org/2849703002 .
2017-04-27 16:52:33 -07:00
efb5c5ddc5
Trailing commas for named args in Flutter cons invocations (flutter-intellij#551).
...
* adds trailing commas to named params in Flutter instance creations
* adds trailing commas to default value boilerplate
See https://github.com/flutter/flutter-intellij/issues/551 for action shots. :)
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2850693002 .
2017-04-27 14:58:02 -07:00
e02902578b
Fix selectionOffset testing.
...
Follow-up from: https://codereview.chromium.org/2839273002/ .
BUG=
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2848643003 .
2017-04-27 10:54:24 -07:00
bfc071e515
Named arg completion fixes.
...
Related to: https://github.com/flutter/flutter-intellij/issues/551
* fixes named arg selection offset to precede comma
* fixes inconsistent trailing commas between completions w/ and w/o prefixes
BUG=
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2839273002 .
2017-04-27 10:12:47 -07:00
3b790e5311
new TokenType and Keyword API
...
This adds two new methods and adapts most of the old references
to use these new API. Once all call sites have been updated,
the old API can be removed.
This is part one of https://codereview.chromium.org/2842643004/
* replace type == TokenType.KEYWORD with type.isKeyword
* change Keyword.syntax --> Keyword.lexeme
R=paulberry@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2842213003 .
2017-04-26 15:53:58 -04:00
17360ffa6d
Add colon to switch cases and default
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2837063003 .
2017-04-25 11:13:54 -07:00
8c2aae7dee
Fix detection of bad catch-clauses and try-statements
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2842523002 .
2017-04-24 12:00:14 -07:00
00d04dda08
Add special completion for control-flow block exits
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2834913002 .
2017-04-21 14:51:45 -07:00
6407af5dcb
Clean up TODOs
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2830793007 .
2017-04-20 15:19:16 -07:00
b9c214f374
Compete try-statements
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2834513004 .
2017-04-20 13:09:23 -07:00
0829174516
Complete for-each and switch statements
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2826283002 .
2017-04-19 14:44:41 -07:00
6a19d96ee2
Complete for-statement
...
R=brianwilkerson@google.com , scheglov@google.com
Review-Url: https://codereview.chromium.org/2824233002 .
2017-04-18 15:20:31 -07:00
Konstantin Shcheglov