Commit Graph

51 Commits

Author SHA1 Message Date
Konstantin Shcheglov cb9e334572 Type return Future for AnalysisServer integration tests send().
R=brianwilkerson@google.com

Bug:
Change-Id: Idced4d4a43723abe10a848856b9a83fa27b58531
Reviewed-on: https://dart-review.googlesource.com/3347
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-06 16:07:49 +00:00
Konstantin Shcheglov 455984bbf9 Fix fuzzy arrow warnings in analyzer and analysis_server.
There is one warning which I'd like to fix in a separate CL.

The rest is because of package:test predicate().
I think Leaf fixed it in https://github.com/dart-lang/matcher/commit/3625f13698346576da0f5baf44e95abc9c56fb49


R=brianwilkerson@google.com

Bug:
Change-Id: I060f7ced55dbcc460185916251c47ebbd5c838d3
Reviewed-on: https://dart-review.googlesource.com/3404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-06 00:26:18 +00:00
Devon Carew a714187898 Tweaks to the analysis server benchmarks.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2998813002 .
2017-08-10 12:35:06 -07:00
Devon Carew e164b2a820 ignore errors deleting the analysis driver cache.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2992203002 .
2017-08-02 10:33:00 -07:00
Devon Carew f383c17bc2 Redo our benchmarks; add a benchmark/benchmarks.dart tool.
BUG=
R=brianwilkerson@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2986293002 .
2017-08-02 08:07:38 -07:00
Brian Wilkerson 9ddb832e10 Generate constants in server as we do in plugin
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2960073002 .
2017-06-28 08:21:33 -07:00
Erik Corry 029b1cb948 Spelling fixes e to i.
R=kevmoo@google.com
BUG=

Review-Url: https://codereview.chromium.org/2957593002 .
2017-06-24 13:41:39 +02:00
Brian Wilkerson 7d26ff6d4f Remove some more library directives
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2884233004 .
2017-05-17 08:02:08 -07:00
Brian Wilkerson fb982f5476 Make server use the common protocol classes
R=danrubel@google.com

Review-Url: https://codereview.chromium.org/2879273002 .
2017-05-15 09:35:46 -07:00
Erik Corry aa6353b6da Dart SDK Spelling b, c, and d.
R=kmillikin@google.com
BUG=

Review-Url: https://codereview.chromium.org/2850783002 .
2017-05-01 08:28:10 +02:00
Brian Wilkerson e55812a3f2 Unify the server and plugin versions of the generators
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2844273003 .
2017-04-28 07:46:29 -07:00
Devon Carew 9a852506c6 Tweaks to the analysis server --help output.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2810553002 .
2017-04-10 07:06:19 -07:00
Jacob Richman a993294503 Format all analyzer packages
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2753923003 .
2017-03-16 16:11:43 -07:00
Brian Wilkerson 203cf1d057 Remove unused import
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2549993002 .
2016-12-04 16:03:47 -08:00
Michael R Fairhurst 7e04b119aa Add a performance benchmark for the angular analyzer plugin (#27932) 2016-12-02 12:06:10 -08:00
Konstantin Shcheglov 33ecec5d4f Replace expect() with outOfTestExpect() in Analysis Server performance benchmark.
In package:test function expect() does not want to be used outside of
test() methods. So, we need a partial copy for using it in integration
tesitng code, and performance benchmarks.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2413573003 .
2016-10-12 12:57:03 -07:00
Konstantin Shcheglov 05a86a7495 Remove 'initializeTestEnvironment' from 'analysis_server'.
Also fixes the server_options_test.dart:22 test broken in https://codereview.chromium.org/2394683006/

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2402483002 .
2016-10-06 10:26:17 -07:00
Konstantin Shcheglov de4d8b3a78 Switch analysis_server to use 'package:test'.
I'm changing DEPS in the corresponding analyzer CL.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/2394683006 .
2016-10-06 08:47:15 -07:00
Brian Wilkerson ab9ba20c04 Fix recently introduced strong-mode errors
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/2344933002 .
2016-09-15 14:37:37 -07:00
Brian Wilkerson 6c448b6938 Move exception support to its own library
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2328043002 .
2016-09-10 11:04:19 -07:00
Konstantin Shcheglov 34ae48a6b0 Don't run Analysis Server performance tests in checked mode.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2153163002 .
2016-07-15 09:05:09 -07:00
Konstantin Shcheglov ce55b927fc Print min/max element in memory benchmarks.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2150033002 .
2016-07-14 12:20:41 -07:00
Konstantin Shcheglov e279c1de27 Rework local benchmarks into benchmarks on the Flutter codebase.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2150793003 .
2016-07-14 08:45:54 -07:00
Brian Wilkerson d8dfab5217 Fix comments in benchmark
R=scheglov@google.com

Review URL: https://codereview.chromium.org/2124053002 .
2016-07-06 11:06:03 -07:00
Brian Wilkerson f3dc748db5 Add two memory usage benchmarks
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/2111743002 .
2016-06-30 07:44:41 -07:00
Brian Wilkerson 221e92f172 Add a flutter benchmark; refactor
R=pquitslund@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2110443002 .
2016-06-28 10:27:22 -07:00
Konstantin Shcheglov 929cdf8e02 New scenario and local benchmark - refactoring after change.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2087763002 .
2016-06-21 08:38:33 -07:00
Konstantin Shcheglov 716f3fe041 Analysis and completion benchmarks with a set of local uses.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/2081483002 .
2016-06-20 09:02:30 -07:00
Florian Loitsch fe1fda0766 Make dart:convert strong mode clean.
Also removes the ChunkedConverter.

R=lrn@google.com

Review URL: https://codereview.chromium.org/1964953003 .
2016-05-11 16:15:31 +02:00
Florian Loitsch 50bdab3841 Steps towards making the convert library strong-mode compliant.
This version has a few deprecated methods. In a future release they will be removed.

See https://codereview.chromium.org/1827803002 for the final patch (once the deprecated methods have been removed).

R=leafp@google.com, lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/4ab1219bf93a33a2a3d4803e053ccd70ce190371
Reverted: https://github.com/dart-lang/sdk/commit/045a3753665268761508c8053e0ee84372d9ef35

Review URL: https://codereview.chromium.org/1847843002 .
2016-04-12 20:59:21 +02:00
Brian Wilkerson 97c613aad4 More strong mode changes in analysis_server
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1852113002 .
2016-04-03 17:56:30 -07:00
Brian Wilkerson f9b575e5b3 More strong mode changes to analysis_server
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1855643002 .
2016-04-01 18:00:04 -07:00
Brian Wilkerson 8c22a5f807 Format code in analysis_server
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1838933003 .
2016-03-29 08:27:14 -07:00
Brian Wilkerson 338c95be8c Sort the files in analysis_server
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1834423002 .
2016-03-28 18:25:29 -07:00
Paul Berry bc551cb308 Beef up analysis server integration test messages.
When an integration test fails, in can be difficult to figure out why,
especially if the test had to forcibly terminate the analysis server
process.  These messages should help debug the problem.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1669473004 .
2016-02-04 12:48:21 -08:00
Konstantin Shcheglov 2f0f398c73 Fix lints: unnecessary_brace_in_string_interp
Also fixes two cases of empty_constructor_bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1521883002 .
2015-12-13 13:05:00 -08:00
Brian Wilkerson c5f82b8376 Additional clean-up after moving to the new task model; a breaking change needed to allow a bug to be fixed
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1503203002 .
2015-12-07 12:02:42 -08:00
Brian Wilkerson b9644af695 Remove the old task model
Review URL: https://codereview.chromium.org/1490233007 .
2015-12-03 10:14:06 -08:00
keertip 2a88bdac4a refactor timing tests to not use the test framework
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1419503002 .
2015-10-19 16:34:56 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
2015-10-11 07:34:28 -07:00
Keerti Parthasarathy 6352acfaa8 add completion tests
BUG=
R=pquitslund@google.com

Review URL: https://codereview.chromium.org/1393693003 .
2015-10-09 11:08:07 -07:00
pq 37d4be8f61 Improved AS benchmarking metrics.
Notably:
  * adds support for multiple metrics via the `--metric` flag  (e.g., `--metric outline,navigation,highlighting`).
  * captures timings in a list in case there are multiple results (e.g., outline before and after resolution).

R=keertip@google.com

Review URL: https://codereview.chromium.org/1395573002 .
2015-10-07 13:09:15 -07:00
pq df52deea9f More pluggable AS benchmarks.
R=keertip@google.com

Review URL: https://codereview.chromium.org/1387823005 .
2015-10-06 13:02:46 -07:00
pq d21c6ef67e Benchmarking for navigation results.
R=keertip@google.com

Review URL: https://codereview.chromium.org/1386003002 .
2015-10-05 15:46:28 -07:00
keertip 56e39e99eb rename _test => _tests
BUG=

Review URL: https://codereview.chromium.org//1358243005 .
2015-09-25 09:07:15 -07:00
Keerti Parthasarathy 6f775acc7b add performance tests
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1366923003 .
2015-09-25 08:35:42 -07:00
Brian Wilkerson 42d1d4532d Reformat code to minimize churn
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1310263003 .
2015-09-09 08:19:18 -07:00
danrubel ddf17fa575 performance measurement improvements and README update
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1250343002 .
2015-07-24 10:14:11 -04:00
danrubel 5397035e2f performance measurement readme
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1244023003 .
2015-07-23 15:34:23 -04:00
danrubel e196c15ca1 performance measurement mods:
* apply source path translation in the order in which they are defined
* print elapse times in milliseconds
* log overlay content if server exception occurs
* simplify diagnostic port initialization
* add option to start server using new task model

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1249793007 .
2015-07-22 12:17:04 -04:00