c6c7580c92
Add error detection and reporting for errors related to plugins
...
Change-Id: If17e88b64022fe71c992c5867c80263c0e6b953b
Reviewed-on: https://dart-review.googlesource.com/18781
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-11-05 19:21:07 +00:00
454088ae28
Fix a typo in the status pages
...
Change-Id: I516a70537d850b94de60dcf63f832518753e5b11
Reviewed-on: https://dart-review.googlesource.com/18760
Reviewed-by: Devon Carew <devoncarew@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-11-04 21:57:37 +00:00
5ea30b4e3d
Rename performace_logger.dart to performance_logger.dart
...
R=paulberry@google.com , sigmund@google.com
Bug:
Change-Id: Ib7b6d122dff3ddabde3db2270daa777a269e04ed
Reviewed-on: https://dart-review.googlesource.com/18512
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-11-03 20:24:00 +00:00
c5722c682b
Don't propose the 'Remove Type' Quick Assist when there is no initializer.
...
R=brianwilkerson@google.com
Bug:
Change-Id: If87a9b171ac0672772ee971051687a171c0bcd06
Reviewed-on: https://dart-review.googlesource.com/18510
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-11-03 20:13:00 +00:00
223a78d7bf
Listen for watch events and notify AnalysisServer.
...
So, AnalysisServer can serve a broadcast Stream and let EditDomain
reset a pending refactoring.
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/flutter/flutter-intellij/issues/1465
Change-Id: I9462ad623ef261a658655a7445ee0ad9b0029a18
Reviewed-on: https://dart-review.googlesource.com/18426
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-11-03 15:59:45 +00:00
f5904eae38
Fix for SimpleFormalParameter exception in the Dart Kythe indexer.
...
Change-Id: Ibf0a8468bc154d97a7d2f84d2947aabc5e960ab7
Reviewed-on: https://dart-review.googlesource.com/18142
Reviewed-by: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-11-02 16:37:38 +00:00
2470d9fc74
Don't suggest to/from expression body Quick Assist when selection is in the expression.
...
Flutter return expressions in build() methods can be quite long,
and it is surprising to see this Quick Assist, and not clear to
what it will be applied. Especially when the method is so long that you
don't even see its beginning.
R=brianwilkerson@google.com , devoncarew@google.com
Bug:
Change-Id: Ib245c34f3cbc51add23810c025ebda9d8471ee9b
Reviewed-on: https://dart-review.googlesource.com/17621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-31 18:51:37 +00:00
68a89d10ef
Fix for EOL when adding missing overrides for not empty classes.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I95a801fed5925959fd9db58c96ecb60fbf7e6899
Reviewed-on: https://dart-review.googlesource.com/17540
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-31 17:46:35 +00:00
c084df4747
Remove deprecated DirectoryBasedDartSdk.
...
This class has been deprecated for over a year, and I believe all uses
of it have been removed.
Change-Id: I42c39339b08bb98271000c2a459d3045388ec9ce
Reviewed-on: https://dart-review.googlesource.com/17520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2017-10-31 17:13:40 +00:00
b9cb5aea84
If Icon or Text creation does not have the required argument, ignore this.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug:
Change-Id: I953448c9fe4fe4693c298ea0f0842651f7900cf2
Reviewed-on: https://dart-review.googlesource.com/17300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-30 21:53:27 +00:00
6b1658906e
Support for Flutter is not limited to code correction. Move to utilities.
...
R=brianwilkerson@google.com
Bug:
Change-Id: Idaa90946710fcbec2a35a91eb35b5ead68cf4170
Reviewed-on: https://dart-review.googlesource.com/16621
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-25 19:11:38 +00:00
577bb2dc7e
Extract shorten() into string utils.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I68d17461b4b5b478df5713cadb120a130f492406
Reviewed-on: https://dart-review.googlesource.com/16602
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-25 18:54:34 +00:00
4c86f98d7a
Drop the 'Flutter' word from names, expect that clients will use the 'flutter' import prefix.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I0275557bad66f03ed0d1b8388119b168d70bfad4
Reviewed-on: https://dart-review.googlesource.com/16600
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-25 17:14:01 +00:00
c2f1af6378
First steps for computing Flutter outlines.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug:
Change-Id: Ib8151df40439a28da536d467a5c0e7354fcfba51
Reviewed-on: https://dart-review.googlesource.com/16338
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-25 17:00:56 +00:00
1f41c3778c
Extract more unit-test like OutlineComputerTest.
...
R=brianwilkerson@google.com
Bug:
Change-Id: Ibdadbd656d6cd85cd01a6a68d425dbd20a0b07ea
Reviewed-on: https://dart-review.googlesource.com/16420
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-25 04:27:39 +00:00
82d90f6773
Add tests for isFlutterWidget() and isFlutterWidgetCreation().
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug:
Change-Id: I7946941e458e1ba538921b0e8552dbe555fb0aab
Reviewed-on: https://dart-review.googlesource.com/16303
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-24 21:26:48 +00:00
ce79a77331
Remove Fuchsia-specific build files.
...
Also fix Fuchsia tools to account for new project location (//third_party/dart).
Change-Id: If89a934729c4fa44229eaca83219dbdf8bb700a8
Bug:
Reviewed-on: https://dart-review.googlesource.com/14800
Commit-Queue: Zach Anderson <zra@google.com >
Reviewed-by: Zach Anderson <zra@google.com >
2017-10-19 17:52:37 +00:00
47a861ca85
Add two new element types to the protocol.
...
Bug:
Change-Id: I5a60081d7c8500590bbabb9ee6dce74fa611b0a3
Reviewed-on: https://dart-review.googlesource.com/14883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-18 19:02:47 +00:00
56feddec9e
Bump the version of intl used by analysis-server.
...
This aligns it with the version in third_party.
Change-Id: I0246f321e6540b6061e0b9f6c804c669f3a9596f
Bug:
Reviewed-on: https://dart-review.googlesource.com/14020
Reviewed-by: Zach Anderson <zra@google.com >
Commit-Queue: Zach Anderson <zra@google.com >
2017-10-16 20:09:57 +00:00
462542b734
Report UNUSED_ELEMENT for top-level variables.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/25323
Change-Id: I751ee82742ff622a9b28b3cb05886b5ee775f9ed
Reviewed-on: https://dart-review.googlesource.com/13929
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-16 17:44:06 +00:00
7cc0fcb8cd
Added build target for the analysis service.
...
Change-Id: I8e249db3b3dab87ed74d16a45534d2a30acc2872
Bug:
Reviewed-on: https://dart-review.googlesource.com/13103
Reviewed-by: Zach Anderson <zra@google.com >
2017-10-11 21:28:26 +00:00
a5c2256455
Send test element kinds for test outline items.
...
Bug:
Change-Id: Iebea8d4b9705c726e297722ef1678e1a2cd1ea96
Reviewed-on: https://dart-review.googlesource.com/12841
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-10-11 17:00:41 +00:00
e6a34d78f1
Improve the extract method refactoring for flutter build() methods.
...
Bug:
Change-Id: Ic957eede0989b9cd171212425d5da0aad83bc941
Reviewed-on: https://dart-review.googlesource.com/11740
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-08 01:41:41 +00:00
fcecf07f92
Make names suggestions for index operator to use only 's' suffix.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I69d60eb23a1100e8776199dfb3082314062e231a
Reviewed-on: https://dart-review.googlesource.com/12220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-07 01:40:16 +00:00
31cf7dda06
Do not create parameters for non-final fields
...
Change-Id: Id7d213d3408739301217c1638d050d0b3946fc76
Reviewed-on: https://dart-review.googlesource.com/12100
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-06 18:39:11 +00:00
b3439aa20b
Guard against broken code (issue 31023)
...
Change-Id: I9f53abb1257a3ffc86dc4bf46e2591c7f936d1fe
Reviewed-on: https://dart-review.googlesource.com/11940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-06 17:28:04 +00:00
6a19e794b1
Don't create single line closing labels.
...
Bug:
Change-Id: I1ced51a7b5e5aee6db03a77a788c0eeaef101469
Reviewed-on: https://dart-review.googlesource.com/10820
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-05 05:23:20 +00:00
082bbdb6a7
Remove flag and enable asserts in initializers by default
...
Change-Id: Ia81f5ec936981dc08ff4c740f3511c6b7c9e6eb6
Reviewed-on: https://dart-review.googlesource.com/10740
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-10-04 18:45:09 +00:00
8ce5c45fff
Fix for copying constructor return types.
...
R=brianwilkerson@google.com
Bug:
Change-Id: Iaa1039b85549fb2daa3d90ea11f4756363c6c358
Reviewed-on: https://dart-review.googlesource.com/10163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-10-02 21:37:47 +00:00
e925eb125c
Fix type code for typedefs after switching to GenericTypeAliasElement.
...
https://dart-review.googlesource.com/c/sdk/+/9421
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: I25d60ff904f15e6eeefff97b08ba9870d69733db
Reviewed-on: https://dart-review.googlesource.com/9460
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-29 04:27:53 +00:00
d4dec4e1a4
Create GenericTypeAliasElement for both FunctionTypeAlias and GenericTypeAlias nodes.
...
Some pain points are:
1. It is a breaking change. I think I will break it even more by removing
FunctionTypeAliasElement altogether.
2. We lose ability to keep track that this FunctionType is instantiation
of a typedef. Just like in Kernel.
3. We sometimes have to look up to see if the GenericFunctionTypeElement
is a function in a named GenericTypeAliasElement.
R=brianwilkerson@google.com , paulberry@google.com
Bug:
Change-Id: Ib250cc446a0ed5b8969f16f7cc6293ef4acf01a8
Reviewed-on: https://dart-review.googlesource.com/9421
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-29 00:39:05 +00:00
fd4528fffb
Make closing labels slightly less noisy.
...
Bug:
Change-Id: If916adb1cceab14c9260f288bf59878c6955f3ce
Reviewed-on: https://dart-review.googlesource.com/9000
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-27 18:52:25 +00:00
472f64b005
Check for _serverFuture is null in HttpAnalysisServer.
...
R=brianwilkerson@google.com
Bug:
Change-Id: I54dc00d5a0b29e60a0825e6dcc46daae382ad302
Reviewed-on: https://dart-review.googlesource.com/8243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-25 21:08:59 +00:00
bb026e5d29
Fix typing error.
...
Change-Id: Ib10a42863316ce6f15648345cf980236871c2f01
Reviewed-on: https://dart-review.googlesource.com/7361
Reviewed-by: Florian Loitsch <floitsch@google.com >
2017-09-20 16:16:27 +00:00
f6e3e1f549
Add outline support for the test package
...
Change-Id: Iff938d55082b3b222cf801ea53d4eaf5feb1e094
Reviewed-on: https://dart-review.googlesource.com/6980
Reviewed-by: Devon Carew <devoncarew@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-09-19 18:59:54 +00:00
c0bf4ab395
Handle recursive import/export graph in completions
...
Change-Id: Ia164c13f3119f569d781292353acc17243c8a464
Reviewed-on: https://dart-review.googlesource.com/7000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-09-19 18:01:04 +00:00
a715f60d51
Guard against race condition
...
Change-Id: Ie689e8e47559760c5955987005def7aef67e8e09
Reviewed-on: https://dart-review.googlesource.com/6262
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2017-09-15 21:27:40 +00:00
8db9995c65
Fix an exception when a package is not defined
...
Change-Id: Id2469b4e0c4aaa8acb63c0186e7b53ec4acea95d
Reviewed-on: https://dart-review.googlesource.com/5885
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-09-14 19:42:50 +00:00
2b3b0272c4
Switch to using specific throws calls instead of general throwsA() calls.
...
Bug:
Change-Id: Id604dca1b8c3060c1d12c9ed0b1493771d2eb0d6
Reviewed-on: https://dart-review.googlesource.com/5883
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Kevin Moore <kevmoo@google.com >
2017-09-14 18:04:44 +00:00
b12d010064
Remove the use of deprecated package:test API.
...
Bug:
Change-Id: I671678117f72efac5efd60d7b4e459dffcce47c6
Reviewed-on: https://dart-review.googlesource.com/5542
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2017-09-13 21:55:00 +00:00
f7eba2359b
Create new style GenericFunctionTypeElementImpl for function typed parameters.
...
ParameterElement.parameters/typeParameters always return empty lists.
This was initially landed as https://dart-review.googlesource.com/c/sdk/+/3401 ,
but was rolled back because of dartdoc breakage.
R=brianwilkerson@google.com
Bug:
Change-Id: I328355fa4520536dfd0029966ad9f9af2e63a7d2
Reviewed-on: https://dart-review.googlesource.com/5000
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2017-09-11 19:15:11 +00:00
1b4239d2e4
Export ByteStore and its implementations from front_end.
...
R=ahe@google.com , paulberry@google.com , sigmund@google.com
Bug:
Change-Id: Ie2e3413a7f143e270cec2bd3ae4564ad7cc315b1
Reviewed-on: https://dart-review.googlesource.com/3840
Reviewed-by: Sigmund Cherem <sigmund@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2017-09-07 19:23:21 +00:00
cb9e334572
Type return Future for AnalysisServer integration tests send().
...
R=brianwilkerson@google.com
Bug:
Change-Id: Idced4d4a43723abe10a848856b9a83fa27b58531
Reviewed-on: https://dart-review.googlesource.com/3347
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-06 16:07:49 +00:00
76a3b431bb
Revert "Create new style GenericFunctionTypeElementImpl for function typed parameters."
...
This CL broke the SDK API-doc generation.
See https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fclient.dart%2Fdart-sdk-linux-be%2F15242%2F%2B%2Frecipes%2Fsteps%2Fgenerate_API_docs%2F0%2Fstdout
Change-Id: I2b4acd766fb65e82a29b73412833e04112ba9dc4
Reviewed-on: https://dart-review.googlesource.com/3460
Reviewed-by: Jonas Termansen <sortie@google.com >
2017-09-06 10:43:11 +00:00
a3f8740bbd
Create new style GenericFunctionTypeElementImpl for function typed parameters.
...
ParameterElement.parameters/typeParameters always return empty lists.
R=brianwilkerson@google.com
Bug:
Change-Id: I5200df9e891031437d6e597f30fa54399b7d00e1
Reviewed-on: https://dart-review.googlesource.com/3401
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-06 02:31:11 +00:00
455984bbf9
Fix fuzzy arrow warnings in analyzer and analysis_server.
...
There is one warning which I'd like to fix in a separate CL.
The rest is because of package:test predicate().
I think Leaf fixed it in https://github.com/dart-lang/matcher/commit/3625f13698346576da0f5baf44e95abc9c56fb49
R=brianwilkerson@google.com
Bug:
Change-Id: I060f7ced55dbcc460185916251c47ebbd5c838d3
Reviewed-on: https://dart-review.googlesource.com/3404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2017-09-06 00:26:18 +00:00
28381b8f06
Add completion of keywords in partial field declarations
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/3006033002 .
2017-09-03 13:04:06 -07:00
0db33f7053
Add fixes for more lints
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3009063002 .
2017-09-02 15:11:29 -07:00
aab7af12e9
Add fixes for two more lint rules
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/3004293002 .
2017-09-02 15:10:56 -07:00
8f1b6d0aab
Dart Kythe indexer refactoring to gather all variable declaration logic into one method
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/3004273002 .
2017-09-01 12:12:37 -07:00
Brian Wilkerson