dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
85,476 Commits 2 Branches 0 Tags
1fbbbf3c97fc4aa52c329a1d31bc9c149fd4ff08
Commit Graph

5077 Commits

Author SHA1 Message Date
Brian Wilkerson c038e3b3c1 Clean up in analytics 
This
- converts PercentileCalculator to sort entries, as previously suggested,
- adds the number of values to the dump of a PercentileCalculator, and
- fixes the name of a class to conform to conventions.

Change-Id: Icb25a3adfc922b6d5b394883853eeeff968e4b89
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245460
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-19 21:53:01 +00:00
Ahmed Ashour 2bb220a95d [analyzer] CreateConstructor to handle undefined enum constructor 
Fixes #48481

Change-Id: I237bcbf1cb3202435c9bda31467a76f27e3dc896
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245169
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-19 20:52:21 +00:00
Danny Tuppeny aae961063f [analysis_server] Move LSP JSON-RPC types to custom generation 
Change-Id: Ie84f7aa099bdeeb1be2a565faf1ffa0bb3ef4b21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245365
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-19 18:18:01 +00:00
Brian Wilkerson b088f98e05 Add the hooks to capture analytics for requests and responses 
In the process of testing this I found (and fixed) a couple of bugs
introduced in the recent conversion of the legacy code to handler
classes. I wanted to validate that I'd added hooks in all the right
places, so I wrote an AnalysisManager to keep track of request/response
pairs. It showed that some extra responses were being generated. I'm
still debating how best to add this to the normal tests to prevent
regressions, so you'll probably see it in another CL at some point.

Change-Id: Ib203c02ef27b6efb53a41a48696a3a39e61ed800
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245260
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Danny Tuppeny <danny@tuppeny.com>
 2022-05-19 13:24:40 +00:00
pq 5ee3a6f07a bump to linter 1.24.0 
(I did a `find_violations` run internally against cl/449544481 and all clear 🟢.)

Change-Id: I2375a42244902ee2da515417cb463f74d9949387
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245224
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-05-19 00:20:30 +00:00
Brian Wilkerson a5e40e4916 Apply the changes from the previous CL 
I forgot to upload these before I clicked submit.

Change-Id: I112eb9a1c3bd1ce8980f87dc92b8ebb39b72d075
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245080
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2022-05-17 22:12:17 +00:00
Brian Wilkerson d4c4408f10 Add initial support for gathering analytics in the analysis server 
I'm primarily interested in feedback on the general approach, which is
to have a single object to which all significant events are reported and
which is responsible for reporting or aggregating the data as
appropriate.

I removed a getter from AnalysisServer that should no longer be used,
though I haven't changed the code that directly references the
underlying analytics object so that existing code won't be impacted.

I also added a couple of references to the new class, but because we're
always creating a noop version there won't be any impact on users at
this point.

Once the overall approach has landed I'll start wiring up the existing
methods and adding new methods as appropriate.

Change-Id: I419f409c9df82fdc62a14128bb1f67723e9cf55f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244983
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-17 20:46:16 +00:00
Danny Tuppeny a34deb2587 [analysis_server] Move super.dispose() to end of stanim snippet's dispose method 
Equiv change for extension-shipped snippet in https://github.com/Dart-Code/Dart-Code/pull/3965.

Change-Id: Ief61a7d11f19edac6f4f4a14f311d7789add8d80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245003
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-17 14:55:40 +00:00
Ahmed Ashour 36acc59dcb [analyser] support code completion for errors and enable-experiment 
Fixes #48904

Change-Id: I45a4f5feefe066dabeaab3f754d6d0e091a4aea5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-16 21:20:36 +00:00
Ahmed Ashour 8a5eb80d8a [analyzer] ConvertToInitializingFormal to handle DefaultFormalParameter 
Fixes #48994

Change-Id: Iff632f9509d07dc5cca7510b18f4d16b23751226
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244926
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-16 16:52:15 +00:00
Danny Tuppeny 6f0af2090f [analysis_server] Rename some LSP types to match upcoming JSON model 
+ handle some missing methods, and exclude an unused deprecated class.

Change-Id: I1a75b7c8637bf1ac736bcc48e7585de0a4d1eb4e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244924
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-16 16:41:58 +00:00
Ahmed Ashour cbd12a4672 [analyzer] AddMissingEnumCaseClauses to handle final and static fields. 
Fixes #49003

Change-Id: I2df2f4bef2dc63645497f9070807c12d0dd9acf5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244626
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-16 14:32:15 +00:00
Konstantin Shcheglov edc54c55dc Deprecate LibraryElement.getImportsWithPrefix, use PrefixElement.imports instead. 
Change-Id: Iaed2124e04c60be79b97f7dec85a091fec9d9f45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244866
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-15 22:12:21 +00:00
Konstantin Shcheglov 07aeba2286 Add implementations for LibraryAugmentationElementImpl and friends. 
Change-Id: I575332526eebd7cd2d87054f3b1395fabbd4d574
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244724
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-12 22:05:05 +00:00
Konstantin Shcheglov 292e92be2d Move more completion override tests to run on both protocols. 
Change-Id: I082fdd06918cc6589314f9e3e0bab68ee52e28d9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244726
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2022-05-12 21:52:37 +00:00
Danny Tuppeny bcc7bda3d8 [analysis_server] Sort fields, enum members and base types consistently 
To reduce changes in upcoming migration from TypeScript to JSON LSP models.

Change-Id: Id437fff5ecbaea4010482f21d5b5bdccfe0f56fb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244625
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-12 18:45:05 +00:00
Danny Tuppeny a9804e3259 [analysis_server] Simplify types for LSP documentChanges 
+ add ToJsonable to enums.

Change-Id: I1c51258f84d3aa27f82986be759483d7985475d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244624
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-12 15:46:25 +00:00
Danny Tuppeny a93a648e7f [analysis_server] Rename some LSP spec classes to match upcoming JSON models 
Change-Id: Icbb071762ca86fd0ba75e4653e80ae480ce3e1a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244406
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-11 19:06:04 +00:00
Konstantin Shcheglov 85615ce2e8 Fix override suggestions with protocol2, a few tests. 
Change-Id: I0f49c01d68abdf695cc08a466495f7754c6eb91f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244363
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-11 16:02:34 +00:00
Danny Tuppeny cd71694342 [analysis_server] Sort types in LSP Unions consistently 
This simplifies an upcoming change switching from parsing LSP TypeScript definitions to using a new JSON definition (where items are not all in the same order).

Change-Id: I773ce9ab174288ef5226b5f82f8ad7b8fb5f3693
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244245
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-11 15:36:34 +00:00
Danny Tuppeny 80fb1a56db [analysis_server] Add shared protocol.dart file for LSP 
In an upcoming change some types will between these files. To reduce the size of that (already very large) CL and because the distinction between spec-generated/custom-generated types was unnecessary anyway, this adds a single import for LSP protocol-related types.

Change-Id: I322447d6c979538c12014d87875176e1bf2adca7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244244
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-11 15:28:35 +00:00
Konstantin Shcheglov b5241f8c4f Use 'parsedUnit' of the file as a starting point for the completion. 
When we start identifying this synthetic `FieldDeclaration` with code `fo;`
as something that needs resolution (actually enclosing nodes require
declared elements), and use this `FieldDeclaration` as a starting point to
find the `CompletionTarget.entity`, we find the `VariableDeclaration` `fo`.
But if we start with `CompilationUnit` (as we used to), we find
`FieldDeclaration` `fo;`. Which gives different starting points for
contributors, and changes the resulting suggestions.

So, for  now I will switch to using the whole parsed unit.

Change-Id: I153ae4de9faad2f8147f413b36dd8f2dd7bc5a6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-11 14:16:44 +00:00
Ahmed Ashour e630a3adef [analyzer] fix for use_key_in_widget_constructors should use super parameters when possible. 
Fixes #48946

Change-Id: I45afc5717eb17845f50ef4aa77fb554fb88e2ec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244242
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-05-10 18:20:33 +00:00
Danny Tuppeny 6b6a199806 [analysis_server] Switch to LSP v3.17 spec + regenerate types 
Change-Id: I6e1b79f3e814c44784dbf37d859ae46d303db2dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244243
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-10 18:08:35 +00:00
Ahmed Ashour a67c07c40f Fix for use_key_in_widget_constructors to add key at the end 
Fixes #48917

Change-Id: Ie9a1e06188ad958ba89cd7b37081878211b3e90b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243905
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-10 14:15:43 +00:00
Konstantin Shcheglov 359e597cec Switch Workspace to Packages. 
PackageMapUriResolver is still based on Map.

Change-Id: I7d68f9dbc7d970b22c8e1a01d8e816b3e5723f34
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244047
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-09 22:42:32 +00:00
Danny Tuppeny 3c0289d618 [analysis_server] Improve performance of LSP textDocument/codeActions with no range 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3952.

Change-Id: Ie523dc628ab72705259810baccafa949af96280e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-09 22:20:42 +00:00
Danny Tuppeny 091454876e [analysis_server] Record more granular timings for LSP textDocument/codeAction request 
Change-Id: I29d16b4e4f077cc0bfa9bff6a930dce506ba100c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244100
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-09 18:35:43 +00:00
Ahmed Ashour 087c57f488 [analyzer] fix for use_key_in_widget_constructors to handle non-constant value 
Fixes #48915

Change-Id: I9103f02f6b5a7668e0a937e27e237b310fa22958
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243462
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-09 15:54:25 +00:00
Alexandre Ardhuin 04bcc30c58 add trailing comma fix for literals 
This PR extends the`add_trailing_comma` fix to handle for the [upcoming support of list/set/map literals in `require_trailing_commas`](https://github.com/dart-lang/linter/pull/3340).

It's likely the tests in this PR will fail until sdk update the linter dependency to include https://github.com/dart-lang/linter/pull/3340

Closes https://github.com/dart-lang/sdk/pull/48968

GitOrigin-RevId: 24b374ec39b313640f7c06fbf8f725c09d3ed7ac
Change-Id: I066a8524d18a4213eb5300b9310bdb4a562f0e27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243920
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-06 15:07:20 +00:00
Konstantin Shcheglov d78797d014 Replace DartType.resolveToBound() with TypeSystem.resolveToBound() 
Bug: https://github.com/dart-lang/sdk/issues/48952
Change-Id: I38add3e0d633f947640283eda46b5399f4559ef8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243702
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2022-05-05 20:35:16 +00:00
Konstantin Shcheglov 838b68914f Add more data for CastError in _ContextTypeVisitor. 
Bug: https://github.com/dart-lang/sdk/issues/48965
Change-Id: I50ac5baef607071f5b32df4aa63fb4327645a781
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243840
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-05 18:09:56 +00:00
Danny Tuppeny 5f15aefcab [analysis_server] Record timings for recent LSP requests and show in server diagnostics 
Change-Id: I1bfb03faa9ce3240c700c93cb4ab677dc1aff520
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-05 15:29:55 +00:00
Danny Tuppeny 7d6216940f [analysis_server] Always include exact matches in completion when truncating 
Change-Id: I21b56392961217482dbcf5c67b9594709b27bcc0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243721
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-05 15:29:25 +00:00
Danny Tuppeny 4261df2dbd [analysis_server] Remove qualified static members from code completion 
Change-Id: Ia8ef009fa99cd495ca0ed3f825f3d951136341e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-04 14:22:24 +00:00
Danny Tuppeny 98d74c1d54 [analysis_server] Filter completion items by prefix before mapping to LSP classes 
Change-Id: Idcc8d91903185e274524d4cb7c4e81c4a750e27e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243463
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-03 20:47:44 +00:00
Danny Tuppeny e82d6d1a4f [analysis_server] Improve performance of LSP completions 
Change-Id: I5405b65c611cec2f97f425d2efdef83180fa0d05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243461
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-03 15:45:50 +00:00
Danny Tuppeny 519a83dd29 [analysis_server] Apply fuzzy prefix matching to LSP YAML completions 
Change-Id: I4b6a45d2601c10ed08c3bdcf4e5c007d5063dbff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243328
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-03 15:37:44 +00:00
Danny Tuppeny ace4135fa7 [analysis_server] Don't truncate unranked items from LSP code completion 
Change-Id: I12ce64185c5008b48e40bac82a000c687220dc7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243327
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-03 14:02:54 +00:00
Keerti Parthasarathy 630ad11de4 Add rename constructor 
Change-Id: Ie4815ed4b4db93cfad9307702fc86172685cfb17
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242160
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2022-05-03 04:51:37 +00:00
Danny Tuppeny b7facb36d2 [analysis_server] Record more time in LSP completions 
+ add a simple page to render the timings in server diagnostics pages.

Change-Id: Ie8537cd38166677967ebe461b91334259b8883ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-02 15:50:50 +00:00
Danny Tuppeny a6042d20f9 [analysis_server] Include client-server latency in completion diagnostics 
Change-Id: I0e8d47baca89e072a042b0c86bd36aa59996a251
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242877
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-01 19:48:05 +00:00
Danny Tuppeny ec34f0c160 [analysis_server] Fix recording of LSP completion timings 
Change-Id: I6ca490bce95e042dad35c7db7b58ba65c2a50718
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242876
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-01 16:50:52 +00:00
Danny Tuppeny 4c18ca6a0e [analysis_server] Allow LSP server to capture request latency 
Change-Id: Ib1cd0313b4391792ad872085a49d115384cabeea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242875
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2022-05-01 16:48:43 +00:00
Brian Wilkerson f484e2e5db Remove some dead code related to handler domains 
Change-Id: I4e96188349b726e144c5a799db5f019be7d809eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/243040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-29 13:34:33 +00:00
Danny Tuppeny 6a35b62adf [analysis_server] Don't insert default argument values when already present 
Fixes https://github.com/Dart-Code/Dart-Code/issues/3906.

Change-Id: Ia6bec7e9924114de5428ef6474c8ba44a202a45f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242549
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-27 15:58:45 +00:00
pq 68fa0e96d0 rename local functions with _s 
These will be flagged by the next linter release which updates `non_constant_identifier_names` to flag local functions.

Change-Id: If663698d9cab270accd477a507071232905bc083
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2022-04-27 00:23:06 +00:00
Brian Wilkerson a4dceb5ec1 Remove ServerDomainHandler 
Change-Id: Id32d55b7e8b14c9dd63d843bb463cc6559600ff4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242482
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-26 18:28:24 +00:00
Brian Wilkerson b922aa00f2 Remove CompletionDomainHandler 
Change-Id: I242358ec168fd047576117f2cbfe6e380e9c86c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242480
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-26 16:02:17 +00:00
Brian Wilkerson 0927b5bfd7 Remove the SearchDomainHandler and FlutterDomainHandler classes 
Change-Id: I4673664068296f9a42fc2e1797f64db4022e8537
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/242387
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2022-04-26 04:24:33 +00:00