dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
61,218 Commits 2 Branches 0 Tags
169331abb18f7dff514b198cd36d0700dd66ff75
Commit Graph

592 Commits

Author SHA1 Message Date
Aske Simon Christensen 1842020a69 Fix empty set/map literal disambiguation rule. 
The criterion for an empty set/map literal without type arguments to
become a set literal was implemented as "superclass of Set and not
superclass of Map". This CL changes it to the rule now stated in the
spec: "subtype of Iterable and not subtype of Map".

Change-Id: I52d3a11e29ed9b1feb0f2b52a3f4beebe3833e31
Reviewed-on: https://dart-review.googlesource.com/c/88828
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-11 15:14:05 +00:00
Ben Konyi b0900cf494 [ VM / Service ] Fixed issue where VMOptions were not being passed to app_jitk tests. 
Fixes #35512.

Change-Id: I34abbf0f73215b6695a0aa4ec6af6cb1c219d5e9
Reviewed-on: https://dart-review.googlesource.com/c/88429
Auto-Submit: Ben Konyi <bkonyi@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-01-08 00:44:38 +00:00
Daco Harkes 7fd0c78c15 [gardening] Unmark language/vm/optimized_stacktrace_test 
Re-enable language/vm/optimized_stacktrace_test to determine whether it is still a flaky issue.

Issue: https://github.com/dart-lang/sdk/issues/28276
Issue: https://github.com/dart-lang/sdk/issues/30198
Change-Id: I4b63e38f130f8320dc38564129a67b08ac5f1866
Reviewed-on: https://dart-review.googlesource.com/c/88450
Commit-Queue: Martin Kustermann <kustermann@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2019-01-04 16:29:48 +00:00
Aske Simon Christensen 5a29552002 Enable set literal tests for Fasta 
Change-Id: I1c6cad6822d5528172e3ba036774fa58e7fd6432
Reviewed-on: https://dart-review.googlesource.com/c/88185
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2019-01-03 13:45:36 +00:00
Martin Kustermann 52f7e9ed71 [VM] Ensure the start of the entrypoints is also 2-byte aligned 
Fixes https://github.com/dart-lang/sdk/issues/35419

Change-Id: I1e4478573c6fc032485ad7c1ec3069e4fa946733
Reviewed-on: https://dart-review.googlesource.com/c/87404
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
 2018-12-17 12:45:35 +00:00
asiva f0babb648b [VM] status file for dartkp failure for issue 35419 
Change-Id: I4a285dc8d4763cbacde02d89f6d237a05a198ac9
Reviewed-on: https://dart-review.googlesource.com/c/87383
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-12-14 21:26:12 +00:00
Martin Kustermann 08c386a33e [VM] Do not use the contents of the megamorphic miss code in stack_frame 
The megamorphic miss stub might not be initialized at the point in time
when we access it.

Fixes https://github.com/dart-lang/sdk/issues/35405

Change-Id: If20622bd4f3b14d6ece5a8de6f006d7081d6cf76
Reviewed-on: https://dart-review.googlesource.com/c/87322
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-12-14 15:06:10 +00:00
Dmitry Stefantsov e98701ea33 [fasta] Allow const constructors in mixin applications 
Closes #33644, closes #33645, closes #32223.

Bug: http://dartbug.com/33644
Bug: http://dartbug.com/33645
Bug: http://dartbug.com/32223
Change-Id: Ia30efb8f450e62bfeb65c8b7fd7e23871ef0e87e
Reviewed-on: https://dart-review.googlesource.com/c/68368
Reviewed-by: Peter von der Ahé <ahe@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-12-14 12:37:30 +00:00
asiva d2578dee91 Mark language_2/deferred_optimized_test as flaky. 
Change-Id: Iceb3ed11955fcb1e2cee88bdd87f3ac183857a46
Reviewed-on: https://dart-review.googlesource.com/c/87281
Reviewed-by: Siva Annamalai <asiva@google.com>
 2018-12-14 00:21:48 +00:00
asiva 9d99b4a5ba [Gardening] Update status file to workaround issue 
https://github.com/dart-lang/sdk/issues/35405

Change-Id: I3c556e93dad628fe213458fe4ad91e999b842874
Reviewed-on: https://dart-review.googlesource.com/c/87262
Reviewed-by: Ryan Macnak <rmacnak@google.com>
 2018-12-13 21:08:35 +00:00
Ryan Macnak 30896b87f1 [vm] Fix crash when enum initialization hits a stack overflow. 
Give the compiler more headroom.

Have the simulators and interpreters distinguish between the true stack limit and the limit for trigger an overflow exception.

Bug: https://github.com/dart-lang/sdk/issues/35224
Bug: https://github.com/flutter/flutter/issues/25041
Change-Id: I048d73b649b4ce1f3d9b5a33d898ee9cfe54f6ca
Reviewed-on: https://dart-review.googlesource.com/c/86821
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-12-10 23:40:21 +00:00
Ryan Macnak 4463aa0038 Revert "[vm] Fix crash when enum initialization hits a stack overflow." 
This reverts commit e59312dafa.

Reason for revert: Broken arm and arm64 simulators

Original change's description:
> [vm] Fix crash when enum initialization hits a stack overflow.
> 
> Give the compiler more headroom.
> 
> Have the KBC and DBC interpreters distinguish between the true stack limit and the limit for trigger an overflow exception.
> 
> Bug: https://github.com/dart-lang/sdk/issues/35224
> Bug: https://github.com/flutter/flutter/issues/25041
> Change-Id: I85e72e1d3cceb70858c53567a4c8d3635e42165b
> Reviewed-on: https://dart-review.googlesource.com/c/86684
> Reviewed-by: Régis Crelier <regis@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>

TBR=rmacnak@google.com,regis@google.com,ajcbik@google.com

Change-Id: I923cca32d34de37b761196f536873aaf81dcbc92
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/35224, https://github.com/flutter/flutter/issues/25041
Reviewed-on: https://dart-review.googlesource.com/c/86782
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-12-10 18:52:10 +00:00
Ryan Macnak e59312dafa [vm] Fix crash when enum initialization hits a stack overflow. 
Give the compiler more headroom.

Have the KBC and DBC interpreters distinguish between the true stack limit and the limit for trigger an overflow exception.

Bug: https://github.com/dart-lang/sdk/issues/35224
Bug: https://github.com/flutter/flutter/issues/25041
Change-Id: I85e72e1d3cceb70858c53567a4c8d3635e42165b
Reviewed-on: https://dart-review.googlesource.com/c/86684
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-12-10 18:29:43 +00:00
Lasse Reichstein Holst Nielsen a957c4351a Add more tests for async*/await-for operations. 
Change-Id: Icadb9edfe2ef40aff3808295685f961897d63c9a
Reviewed-on: https://dart-review.googlesource.com/c/86181
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
 2018-12-10 14:38:34 +00:00
Ryan Macnak 4191437ccc Revert "[vm] Fix crash when enum initialization hits a stack overflow." 
This reverts commit 67b5c878b3.

Reason for revert: Failures on KBC and ASAN.

Original change's description:
> [vm] Fix crash when enum initialization hits a stack overflow.
> 
> Also, give the compiler more headroom.
> 
> Bug: https://github.com/dart-lang/sdk/issues/35224
> Bug: https://github.com/flutter/flutter/issues/25041
> Change-Id: I51b24cdd79ac790c0ee951e14738a6e7b6f65647
> Reviewed-on: https://dart-review.googlesource.com/c/86584
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Aart Bik <ajcbik@google.com>

TBR=rmacnak@google.com,ajcbik@google.com

Change-Id: I1d4c2297154f93f16d2e33756713b30ebe024901
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/35224, https://github.com/flutter/flutter/issues/25041
Reviewed-on: https://dart-review.googlesource.com/c/86683
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-12-07 21:08:33 +00:00
Ryan Macnak 67b5c878b3 [vm] Fix crash when enum initialization hits a stack overflow. 
Also, give the compiler more headroom.

Bug: https://github.com/dart-lang/sdk/issues/35224
Bug: https://github.com/flutter/flutter/issues/25041
Change-Id: I51b24cdd79ac790c0ee951e14738a6e7b6f65647
Reviewed-on: https://dart-review.googlesource.com/c/86584
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
 2018-12-07 19:54:41 +00:00
William Hesse c71a5279c5 Revert "Add more tests for async*/await-for operations." 
This reverts commit a0d576e6cd.

Reason for revert: Turned many buildbot builders red. Use the "Choose tryjobs" button to run more configurations on this type of commit.  Use the "tools/bots/approve_results.dart" tool to update expectations for builders running the new workflow

Original change's description:
> Add more tests for async*/await-for operations.
> 
> Change-Id: I2c8ffb8a6738b8dee43cfdf85be0c54d2735b6cc
> Reviewed-on: https://dart-review.googlesource.com/c/85391
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Leaf Petersen <leafp@google.com>

TBR=lrn@google.com,leafp@google.com

Change-Id: I81830c3fc565b62e98538feba9bd64c6dd11dd51
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/86023
Reviewed-by: William Hesse <whesse@google.com>
 2018-12-04 20:09:46 +00:00
Lasse Reichstein Holst Nielsen a0d576e6cd Add more tests for async*/await-for operations. 
Change-Id: I2c8ffb8a6738b8dee43cfdf85be0c54d2735b6cc
Reviewed-on: https://dart-review.googlesource.com/c/85391
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-12-04 13:58:03 +00:00
Sigmund Cherem 8d41ec30c0 Remove obsolete comment in status files. 
I added these when we were maintaining the .status files with a script at the
time strong-mode was being implemented in the CFE. The comments are no longer
relevant.

TBR=paulberry@google.com

Change-Id: I3d37da32cd611731e3e0d91a5aa751fa550cc179
Reviewed-on: https://dart-review.googlesource.com/c/85408
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
 2018-11-27 01:25:51 +00:00
Samir Jindel 733b53d971 [vm] Mark enum_private_test/01 as flaky. 
Change-Id: I1d5b597f051808f4ef5dfbe5cc5a8e4bf77016b5
Reviewed-on: https://dart-review.googlesource.com/c/84533
Reviewed-by: Samir Jindel <sjindel@google.com>
 2018-11-15 16:20:50 +00:00
Samir Jindel 6914a86177 [vm] Update status file for enum_private_test/01. 
Change-Id: I9c666c22a4f6e5eae9f98fa20f37480e9c6e940b
Reviewed-on: https://dart-review.googlesource.com/c/84530
Auto-Submit: Samir Jindel <sjindel@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2018-11-15 15:16:49 +00:00
Alexander Markov ed48cfeb47 [vm/bytecode] Support source positions when executing bytecode 
This includes both interpreted and compiled bytecode.

Change-Id: I6309ec4f0687f68caf6260cc57dacf94f027177d
Reviewed-on: https://dart-review.googlesource.com/c/84481
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
 2018-11-15 00:48:04 +00:00
Vyacheslav Egorov 5db3314a86 [gardening] Update status for language_2/type_constants_test/none 
Hot reload does not support deferred libraries.

TBR=lrn@google.com

Change-Id: Ie33966404d1274b8cbec7a54c284fd9c0022b5af
Reviewed-on: https://dart-review.googlesource.com/c/83981
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
 2018-11-09 11:28:02 +00:00
Lasse R.H. Nielsen 4f5bc1ea22 Add test for constant type literals being valid in switch cases and constant maps. 
Implementations already allow type constants, some just do not have the correct semantics.

See: https://dart-review.googlesource.com/c/sdk/+/81274/2..4
Change-Id: I2f535e4609b9d3b002ba33f579f3b840d70e0fdb
Reviewed-on: https://dart-review.googlesource.com/c/82981
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
 2018-11-09 10:22:00 +00:00
Aart Bik abe8794605 Revert "[Gardening] Mark language_2/vm/mult_int_test as failing on windows-dartkp-simarm64" 
This reverts commit 3f585d1b78.

Reason for revert: underlying issue (spilling) has been fixed

Original change's description:
> [Gardening] Mark language_2/vm/mult_int_test as failing on windows-dartkp-simarm64
> 
> Issue https://github.com/dart-lang/sdk/issues/35091
> 
> Change-Id: I129c05994223fc5067ec720290fff9cc317f8bb4
> Reviewed-on: https://dart-review.googlesource.com/c/83386
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Martin Kustermann <kustermann@google.com>
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
> Auto-Submit: Martin Kustermann <kustermann@google.com>

TBR=vegorov@google.com,kustermann@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: Idc8fbe3397e393813fffcab1336f74f324bc70bd
Reviewed-on: https://dart-review.googlesource.com/c/83880
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
 2018-11-08 21:32:56 +00:00
Martin Kustermann 3f585d1b78 [Gardening] Mark language_2/vm/mult_int_test as failing on windows-dartkp-simarm64 
Issue https://github.com/dart-lang/sdk/issues/35091

Change-Id: I129c05994223fc5067ec720290fff9cc317f8bb4
Reviewed-on: https://dart-review.googlesource.com/c/83386
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Auto-Submit: Martin Kustermann <kustermann@google.com>
 2018-11-07 12:13:48 +00:00
Lasse R.H. Nielsen 095d694add Add tests for set literals. 
Change-Id: Ia5e576e801bd4c9dd3fabca5f11c8e4f86e98803
Reviewed-on: https://dart-review.googlesource.com/c/82840
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-11-06 13:47:35 +00:00
Erik Ernst 4cf179bcf1 Corrected outdated tests string_split_test and string_supertype_checked 
Change-Id: I9ecb49d921b3df1bb5cda63b65e6ae07e618110d
Reviewed-on: https://dart-review.googlesource.com/c/82721
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Erik Ernst <eernst@google.com>
 2018-11-05 14:21:19 +00:00
Martin Kustermann 6d9dc93d0e [VM] Follow-up status file update after landing changes to kernel2kernel constant evaluator 
Change-Id: Ia99a27ce81eed0a6f74b669217c5d998f157ace4
Reviewed-on: https://dart-review.googlesource.com/c/82584
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
 2018-11-02 11:14:15 +00:00
Martin Kustermann 8953788993 [VM] Convert const Symbol("..") to SymbolConstants in kernel2kernel transformation 
Issue https://github.com/dart-lang/sdk/issues/34911

Change-Id: Ib504d57b5a529a04f511f737af4cec0ff0590250
Reviewed-on: https://dart-review.googlesource.com/c/82069
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-11-02 09:28:15 +00:00
Alexander Markov 056fdb8734 [vm/kernel] Fix kernel tree shaker after FunctionType.typedefType change 
Fixes https://github.com/dart-lang/sdk/issues/34995

Change-Id: Ieef2696ea9cfe689a661dc7d1ebd86b257b49bbb
Reviewed-on: https://dart-review.googlesource.com/c/82261
Auto-Submit: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
 2018-11-01 15:41:12 +00:00
Peter von der Ahé ba73aa9452 Update status file for VM precompiler 
Change-Id: I57c4dc2e5effd62bdddbe69c711070bd31a6c2ea
Reviewed-on: https://dart-review.googlesource.com/c/82220
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-31 11:17:31 +00:00
Ryan Macnak 2085277771 [vm, reload] On the path for no shape changes, defer freeing the old class table until the next safepoint. 
Compare the reload rollback path.

Bug: https://github.com/dart-lang/sdk/issues/34888
Change-Id: I5b9e7cd8392f9c9d61df31481956a9fa67435b33
Reviewed-on: https://dart-review.googlesource.com/c/81940
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2018-10-30 21:53:54 +00:00
Jens Johansen a1293f1591 test.py -c fasta: Enable asserts and verify 
Change-Id: Ie7ff93cb552a0b2ae8e11078dd19358d199889d1
Reviewed-on: https://dart-review.googlesource.com/c/82040
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2018-10-30 08:34:03 +00:00
Alexander Aprelev 821b5fe72a [gardening] Mark language_2/disassemble_test flaky 
Bug: dartbug.com/34971
Change-Id: Iafc435a472b6f112cc812813ed90690318b98d2e
Reviewed-on: https://dart-review.googlesource.com/c/81920
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2018-10-29 20:55:33 +00:00
Samir Jindel e23acaaf90 [vm/aot] Fix obfuscation. 
Test Plan:

Make vm-kernel-precomp-obfuscate-linux-release-x64-try green, ensuring status file changes
reflect design gaps and not bugs.

Tested locally that obfuscated Flutter Gallery runs.

Change-Id: Ifcdc334de58f43c310e15b58dbcf6fe1597206f2
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-obfuscate-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/81009
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-10-26 13:00:33 +00:00
Martin Kustermann dec268cfae [VM] Catch non-instantiated type arguments for constant partial instantiation expression 
This makes us report the following error

  * in JIT:

  Unhandled exception:
  'test.dart': error: Type arguments must be instantiated in partial instantiation.
  #0      main (...)
  ...

  * in AOT:

  test.dart:7:28: Error: The type '#lib1::C::T' is not a constant, only instantiated types are ...
    const C({this.callback = _defaultCallback});
                           ^
  test.dart:7:17: Context: While analyzing:
    const C({this.callback = _defaultCallback});
                ^
  test.dart:5:37: Error: The type '#lib1::C::T' is not a constant, only instantiated types are ...
    void foo([dynamic Function(T) f = _defaultCallback]) {}
                                    ^
  test.dart:5:33: Context: While analyzing:
    void foo([dynamic Function(T) f = _defaultCallback]) {}
                                ^
  test.dart:11:38: Error: The type '#lib1::bar::T' is not a constant, only instantiated types are ...
  void bar<T>([dynamic Function(T) f = _defaultCallback]) {}
                                     ^
  test.dart:11:34: Context: While analyzing:
  void bar<T>([dynamic Function(T) f = _defaultCallback]) {}



Issue https://github.com/dart-lang/sdk/issues/32912

Change-Id: I05c7019119a50a9cc38939d9cb41aeaa06c853bc
Reviewed-on: https://dart-review.googlesource.com/c/81278
Auto-Submit: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
 2018-10-25 09:23:18 +00:00
Lasse R.H. Nielsen 03765ed6ec Update old mixin tests. Remove the --super-mixins flag from the tests. 
Bug: http://dartbug.com/34781
Change-Id: Ib07e1927e7de35ff0c48514b9e89da65a5f192dd
Reviewed-on: https://dart-review.googlesource.com/c/79700
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
 2018-10-23 08:35:49 +00:00
Martin Kustermann 349adc5b1f Reland "[VM] Use c++/kernel2kernel constant evaluator for const StaticInvocation in the kernel IR" 
Fixes https://github.com/dart-lang/sdk/issues/34770

Change-Id: I55b02e6ce327f4a08d96612fea44f7b03bddcbb5
Reviewed-on: https://dart-review.googlesource.com/c/79680
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
 2018-10-16 11:22:56 +00:00
Dmitry Stefantsov bf270577cc [fasta] Report errors on generic function types in type arguments 
Fixes #30931

Bug: http://dartbug.com/30931
Change-Id: Ia44f8ff95e85547997912c7dd1403ae1f77aec33
Reviewed-on: https://dart-review.googlesource.com/c/79720
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-15 13:48:03 +00:00
Dmitry Stefantsov 22b11717ac [fasta] Fix bounds checking: non-generic types are always well-bounded 
Change-Id: I745450f0d4c9a41f9df3e1dc97dd42cf25d69edc
Reviewed-on: https://dart-review.googlesource.com/c/79681
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-15 12:50:23 +00:00
Johnni Winther dc9d6785de Report compile-time errors on invalid switch cases 
This is a temporary fix for issue 32557 until CFE handles it.

Change-Id: I4f0cfa5a98af6b25536f0c8e0a257940f8ce708b
Reviewed-on: https://dart-review.googlesource.com/c/79561
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Auto-Submit: Johnni Winther <johnniwinther@google.com>
 2018-10-12 17:52:12 +00:00
Kevin Millikin 69cf0ec97c Signal an error if a class extends a mixin 
Declared mixins are not classes and should not be able to be
extended.  This was not allowed by the analyzer anyway and since the
mixin declaration feature is not launched, we are not breaking any
code by making this bug fix.

Change-Id: Ia49dd207213accb16ad8dd819a22844d65ccfcab
Reviewed-on: https://dart-review.googlesource.com/c/79524
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-12 14:45:28 +00:00
Daniel Hillerström eee8787a8d Generate noSuchMethod forwarders for private members inherited from a 
class in a foreign library.

This CL changes the predicate which is used to decide whether to
generate noSuchMethod forwarders such that it returns true whenever
the class in question has a user defined no such method or the
enclosing library of the class is different from that of the member.

Closes https://github.com/dart-lang/sdk/issues/33727

Change-Id: I0ffcbb8c8bdd69e4261bcefce2251d31babc19cf
Reviewed-on: https://dart-review.googlesource.com/c/79209
Commit-Queue: Daniel Hillerström <hillerstrom@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-12 13:58:10 +00:00
Aske Simon Christensen 5cbb640f7c Error for type arguments after named constructor with implicit new 
Closes https://github.com/dart-lang/sdk/issues/34403

Change-Id: I18a55b8f33ed313c048add4a8b49f5f98fc26cf5
Reviewed-on: https://dart-review.googlesource.com/c/78080
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
 2018-10-12 09:48:02 +00:00
Kevin Millikin 2fa1143600 Check classes at mixin applications 
When a declared mixin is applied to a class, the class must implement
the superclass constraint interfaces named in the mixin declaration.

Change-Id: I6ace9fe244c1c87860b69c2c5e68f2c31ae73d7c
Reviewed-on: https://dart-review.googlesource.com/c/79206
Commit-Queue: Kevin Millikin <kmillikin@google.com>
Reviewed-by: Daniel Hillerström <hillerstrom@google.com>
 2018-10-12 08:34:07 +00:00
Sigmund Cherem 0cdd5b9ff3 Raise warning to error: duplicate key in a const map is now an error in Dart. 
Eventually the plan is to handle this in the CFE when it performs
constant-evaluation, but for now we can check this in dart2js
(see https://github.com/dart-lang/sdk/issues/32983)

Change-Id: Ic2e5cfd96961094e634da201c55f82398c060aca
Reviewed-on: https://dart-review.googlesource.com/c/79421
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
 2018-10-12 00:18:34 +00:00
Dmitry Stefantsov 265d0d9ec1 Update status files after 8648d782 
Change-Id: I14f42755ed1101a837ea13bd8de425bcb9b422cb
Reviewed-on: https://dart-review.googlesource.com/c/79210
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2018-10-11 11:33:02 +00:00
Dmitry Stefantsov 8648d782ae Reland "[fasta] Report errors for bounds violations" 
The original commit:
https://github.com/dart-lang/sdk/commit/aa6fb2d3a4298e60b5635f26507d5b39f4e531cb

Change-Id: I34287ec856fde16d56e9369ef2620311ba9bb722
Reviewed-on: https://dart-review.googlesource.com/c/79200
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Aske Simon Christensen <askesc@google.com>
 2018-10-11 10:20:01 +00:00
Peter von der Ahé dfb8e97b86 Report errors on members hiding prefixes 
Fixes https://github.com/dart-lang/sdk/issues/34498

Change-Id: I7aef905f88502805e15deed8ebd453f7896daac1
Reviewed-on: https://dart-review.googlesource.com/c/79047
Auto-Submit: Peter von der Ahé <ahe@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
 2018-10-11 07:30:13 +00:00