dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
8,495 Commits 2 Branches 0 Tags
166d2b2d866bdef042acadeb5e6a8aa8ca49abc6
Commit Graph

58 Commits

Author SHA1 Message Date
vsm@google.com 166d2b2d86 Fix some type narrowing 
I think I 'broke' this is an earlier CL.

Review URL: https://codereview.chromium.org//11086017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13430 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-09 19:29:55 +00:00
vsm@google.com c40edf6954 Wrap Window in case it's a window from a different page / frame. 
I also refactored inner_frame_test to explicitly notify if the subframe tests pass or fail.  This should make them more robust and (if they break) fail quickly instead of timing out.

BUG=1913

Review URL: https://codereview.chromium.org//11074005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13331 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 23:07:08 +00:00
blois@google.com caa43082d6 Fixes to get SelectElement working properly on IE. 
BUG=

Review URL: https://codereview.chromium.org//11031076

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13307 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 18:13:13 +00:00
blois@google.com bc5a9328bb Fixing SelectElement.selectedOptions to work on all platforms. 
This is a fixup of the original CL which broke dartium because I mistakenly applied the polyfill to both dart2js and dartium.

Fix was to move impl_SelectElement.darttemplate to dart2js.

BUG=4503

Review URL: https://codereview.chromium.org//11035032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13304 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-05 17:03:28 +00:00
antonm@google.com fa3dba72b2 Override CSSStyleDeclaration.getPropertyValue in general way. 
Hide actual implementation and check returned value.

R=efortuna@google.com
BUG=5617

Review URL: https://codereview.chromium.org//11065014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13253 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 18:38:43 +00:00
vsm@google.com a1d9180d98 New cross frame base types. 
Local types (LocalWindow, LocalLocation, LocalHistory) now subtype the corresponding "safe" base type.  The _CrossFrameImpl classes implement the safe types.

This also fills out Location and History for dart2js.

Note for dart2js, I still need to trap returned windows.  That's a separate bug.

BUG=3836

Review URL: https://codereview.chromium.org//11047021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13252 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 18:16:03 +00:00
podivilov@google.com 87cda6aa97 Move Dart type narrowing to TypeRegistry. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11027033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13248 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 17:55:30 +00:00
podivilov@google.com f892f55ecb Refactor idl to dart renaming logic for interfaces. 
Make sure all types that comes to TypeRegistry.TypeInfo are either registered
or present in database. That is to fix the mess with idl vs. dart types.
Also, InterfaceIDLTypeInfo.dart_type now returns an already renamed type.

R=antonm@google.com

Review URL: https://codereview.chromium.org//11026039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13247 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 17:54:04 +00:00
blois@google.com 4198b9d3a8 Revert "Fixing SelectElement.selectedOptions to work across all platforms." 
This reverts commit #13239 because it breaks the dartium build.

TBR=vsm
BUG=

Review URL: https://codereview.chromium.org//11032033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13242 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 16:16:51 +00:00
podivilov@google.com 4f396585c4 Remove global DartType function. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11030027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13241 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 16:13:57 +00:00
blois@google.com 25f67482f2 Fixing SelectElement.selectedOptions to work across all platforms. 
BUG=4503

Review URL: https://codereview.chromium.org//11049012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13239 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-04 16:10:12 +00:00
efortuna@google.com bffc05a1b1 CSSStyleDeclaration.getPropertyValue returns empty string instead of null. 
Review URL: https://codereview.chromium.org//11047008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13189 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 18:05:41 +00:00
blois@google.com f36360ec8b Converting NodeList to List<Node>. 
This keeps the NodeList class because other classes depend on it (notably RadioNodeList), but converts all APIs over to List<Node>.

BUG=2712

Review URL: https://codereview.chromium.org//11055009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13188 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 17:47:48 +00:00
podivilov@google.com 5169ef12d7 Extract common logic for emitting implementation classes. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11051014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13181 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 16:04:30 +00:00
podivilov@google.com b9e0a92118 Merge BaseGenerator into HtmlDartInterfaceGenerator. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11045020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13180 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 15:58:03 +00:00
podivilov@google.com f37795b15d Remove constants declaration from dart2js implementation classes. 
They aren't used anymore.

R=antonm@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//11053016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13173 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 14:41:59 +00:00
efortuna@google.com a6efb0872e Provide a fallback for AudioBufferSourceNode.start to noteOn and stop to 
noteOff.
Review URL: https://codereview.chromium.org//11043013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13156 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-03 00:49:37 +00:00
podivilov@google.com a800e16aeb Cleanup html events generation. 
Get rid of HtmlSystemShared and move event interfaces and implementations
generation to HtmlEventGenerator class.

R=antonm@google.com,sra@google.com

Review URL: https://codereview.chromium.org//11020008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13107 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-02 10:22:37 +00:00
podivilov@google.com 315a0f88c0 Get rid of System class. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11018012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13106 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-02 10:11:47 +00:00
efortuna@google.com d0aa4f7409 Remove systeminterface from scripts. 
Review URL: https://codereview.chromium.org//11027011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13091 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-02 00:22:06 +00:00
podivilov@google.com 10af1132b4 Remove dart:dom scripts. 
R=antonm@google.com

Review URL: https://codereview.chromium.org//11016009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13070 260f80e4-7a28-3924-810f-c04153c831b5
 2012-10-01 14:37:26 +00:00
podivilov@google.com b001a58bca Get rid of System classes for backend generators. 
They introduce unnecessary level of indirection with no added value.

R=antonm@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//10986048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12946 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-27 10:25:08 +00:00
efortuna@google.com e73afc3647 Reapply FooList -> List<Foo> with Gamepad fix for dartium. 
Review URL: https://codereview.chromium.org//10982053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12939 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-26 23:23:54 +00:00
vsm@google.com 700da179e7 Roll IDL to multivm@910, Take #2 
I had to suppress the Window.indexedDB and Element.remove methods in favor of the existing custom code.

Review URL: https://codereview.chromium.org//10993053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12937 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-26 23:05:10 +00:00
vsm@google.com 7488109fc1 Revert "Roll IDL to multivm@910" 
This change is breaking Safari and Chrome bots.  Investigating.

Review URL: https://codereview.chromium.org//11000007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12931 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-26 21:05:04 +00:00
vsm@google.com c9d56a6967 Roll IDL to multivm@910 
TBR=sra

Review URL: https://codereview.chromium.org//10983049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12927 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-26 20:47:57 +00:00
efortuna@google.com 192ca09005 webkitRequestAimationFrame->requestAnimationFrame with hand edits to 
html_dartium.
Review URL: https://codereview.chromium.org//10990061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12926 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-26 18:39:53 +00:00
blois@google.com eada8aa043 Fixing up WheelEvent to follow W3C standards and work on all platforms. 
There were a couple of problems here:
- The name of the event is different between platforms, logic to handle this has been added.
- The event object was not getting wrapped on Firefox.
- The wheel event parameters were different across all platforms.

The event name ('mouseWheel' vs 'DOMMouseScroll' vs 'wheel') has been fixed on ElementEvents, but not BodyElementEvents or DocumentElementEvents. I've opened bug #5414 to track fixing those up.

BUG=5186

Review URL: https://codereview.chromium.org//10969073

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12921 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-26 17:54:39 +00:00
podivilov@google.com 21cb9f8668 Refactor file paths handling in generator. 
Introduce DartLibraryGenerator and CPPLibraryGenerator classes
that are responsible for creating per-interface files and importing
them into single library file at the end.

System and BaseGenerator implementations don't have to deal with file paths anymore.

R=antonm@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//10987019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12898 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-26 10:22:54 +00:00
jmesserly@google.com b935f8f03e "Reverting 12887" 
R=efortuna@google.com

Review URL: https://codereview.chromium.org//10979030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12892 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-26 01:28:35 +00:00
blois@google.com bf978d4873 Adding constructor to ContentElement. 
This is the same CL as http://code.google.com/p/dart/source/detail?r=12852, but changing the test status to pass/fail on Chrome since the test works on very new builds, but fails on the version on the bots.

BUG=3870

Review URL: https://codereview.chromium.org//10977017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12888 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-26 00:56:55 +00:00
efortuna@google.com f54390cbb6 Reapply webkitRequestAimationFrame->requestAnimationFrame with fix for dartium 
and IE.
Review URL: https://codereview.chromium.org//10990013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12887 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-26 00:52:57 +00:00
antonm@google.com 6717e8b430 Emit static IDL members. 
R=blois@google.com,podivilov@chromium.org,sra@google.com

Review URL: https://codereview.chromium.org//10980015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12859 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-25 17:46:46 +00:00
blois@google.com 8b9d9b7990 Revert "Adding constructor to ContentElement." 
This reverts commit 12851. The test is failing on Chrome Win7 dart2js for some reason.

TBR=vsm
BUG=

Review URL: https://codereview.chromium.org//10989021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12852 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-25 17:10:35 +00:00
blois@google.com d270006100 Adding constructor to ContentElement. 
BUG=3870

Review URL: https://codereview.chromium.org//10967028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12851 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-25 16:48:38 +00:00
antonm@google.com f527595489 Roll Chrome forward. 
TBR=podivilov@chromium.org

Review URL: https://codereview.chromium.org//10993003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12833 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-25 10:18:16 +00:00
efortuna@google.com 55d7ab1fac Revert r12819 to look at IE fix offline. 
Review URL: https://codereview.chromium.org//10986013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12823 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-25 00:13:02 +00:00
efortuna@google.com c9ea6ff843 Remove Webkit prefix for RequestAnimationFrame. 
Review URL: https://codereview.chromium.org//10965044

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12819 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-24 23:24:16 +00:00
efortuna@google.com 3f3417c68d Revert r12808. 
Review URL: https://codereview.chromium.org//10981005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12810 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-24 21:43:42 +00:00
efortuna@google.com 42a03cb5a3 Reapply 12799. 
Review URL: https://codereview.chromium.org//10957066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12808 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-24 21:23:36 +00:00
efortuna@google.com 23a4b72d67 Revert 12799. 
Review URL: https://codereview.chromium.org//10957064

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12802 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-24 19:54:37 +00:00
efortuna@google.com a41389ac03 Don't generate FooList if it behaves like List<Foo> exactly. 
Review URL: https://codereview.chromium.org//10941047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12799 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-24 19:42:16 +00:00
antonm@google.com 3b1061c5e4 Revert "Emit static IDL members." 
TBR=blois@google.com,podivilov@chromium.org,sra@google.com

Review URL: https://codereview.chromium.org//10973017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12797 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-24 18:51:18 +00:00
antonm@google.com 5bec20abdc Emit static IDL members. 
R=blois@google.com,podivilov@chromium.org,sra@google.com

Review URL: https://codereview.chromium.org//10963057

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12795 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-24 18:36:12 +00:00
blois@google.com 46c4f39719 Fixing up Table.createTBody et al. 
BUG=4342

Review URL: https://codereview.chromium.org//10942017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12662 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-20 22:53:57 +00:00
blois@google.com e5caa173b5 Removing interfaces. 
This converts all interfaces in dart:html to abstract classes and changes the factory providers from factory methods to static methods.

This CL represents the minimal initial change to remove interfaces, but there's quite a bit of further cleanup which can be done after this (eliminating the factory providers in favor of redirecting factory constructors).

Also I'll be splitting the dartdoc changes out to a separate CL since that's a fairly large change in itself.

BUG=4525

Review URL: https://chromiumcodereview.appspot.com//10915245

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12580 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-19 17:30:49 +00:00
podivilov@google.com 54071750b6 Fix generating html_dart2js.dart and html_dartium.dart files. 
R=efortuna@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//10950007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12506 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-18 17:18:41 +00:00
blois@google.com 03166989b9 Fixing up setting styles to invalidate on IE9. 
This CL fixes a bug with the original CL where setProperty was defined twice for dartium.

BUG=2772

Review URL: https://codereview.chromium.org//10908269

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12454 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-17 19:51:21 +00:00
podivilov@google.com a742f0476e Add _Merged suffix to merged dartium implementation files. 
TBR=antonm@google.com

Review URL: https://codereview.chromium.org//10910305

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12429 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-17 10:59:27 +00:00
podivilov@google.com f1b4f7ed25 Fix dart:html generated directory structure and unify file names between backends. 
New structure looks like this:
generated
├── dart2js
│   ├── dart
│   │   └── (interfaces, implementations, factory providers)
│   └── html_dart2js.dart
└── dartium
    ├── cpp
    │   └── (native bindings)
    ├── dart
    │   └── (interfaces, implementations, factory providers)
    ├── DartDerivedSources.cpp
    ├── DartResolver.cpp
    └── html_dartium.dart

R=antonm@google.com,vsm@google.com

Review URL: https://codereview.chromium.org//10917264

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12426 260f80e4-7a28-3924-810f-c04153c831b5
 2012-09-17 09:35:45 +00:00