Commit Graph

29 Commits

Author SHA1 Message Date
nweiz@google.com d860ee4794 Switch various transformers and libraries they use over to source_span.
This would release html5lib 0.12.0 and code_transformers 0.2.0.

BUG=19930
R=blois@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//421503004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38754 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-30 21:36:43 +00:00
blois@google.com fb8c208df2 Exposing code_transformer's Resolvers options
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//431443003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38713 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-29 23:30:59 +00:00
nweiz@google.com 4ac8e0563a Roll forward revision 37912.
Both polymer and code_transformers test flakes should now be fixed.

R=rnystrom@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//367023003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37965 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-02 23:53:57 +00:00
sigmund@google.com c6a19ab344 Use parseDirectives were possible. Also mark analyzer ready to be released.
R=blois@google.com, brianwilkerson@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//318983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37063 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-06 02:04:07 +00:00
sigmund@google.com b965e3368f Fix bug in code_transformers. Apparently mock SDK needs to have a source factory
too. I only run into this in some external projects, I'm not sure yet how to
create a small repro/test for it, though.

R=blois@google.com

Review URL: https://codereview.chromium.org//311403003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37044 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 18:23:09 +00:00
sigmund@google.com 7e25a0c74a Support using a mock SDK with the resolver in code-transformers, and switch
polymer to do so.

This makes TodoMVC compile in 2.8s instead of 4.8s on my machine.

R=blois@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//315813003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37026 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-05 01:47:52 +00:00
sigmund@google.com 73e23be2b6 Bring back initPolymer, allow boot.js only if using "polymer_experimental.html".
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//293023008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36578 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-23 18:30:52 +00:00
blois@google.com b9c11164ca Updating code_transformer's ResolverTransform to allow filtering on Dart entry points in apply.
This is to allow Angular's transformers to continue to filter the assets considered entry points based on whether they contain a main() rather than just the asset ID.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//235483002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34985 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-11 17:44:21 +00:00
sigmund@google.com c903017f1b Deal better with missing sources in code_transformers and polymer
R=blois@google.com

Review URL: https://codereview.chromium.org//233673003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34978 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-11 16:15:17 +00:00
sigmund@google.com 088dfc5fbc Use warning instead of error in a couple places. In polymer we are hitting
scenarios where the resolution was incorrect, but we were still able to generate
valid code. We should not stop the whole build process on these cases.
(see for example https://code.google.com/p/dart/issues/detail?id=17914).

R=blois@google.com

Review URL: https://codereview.chromium.org//221673005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34656 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 17:57:37 +00:00
sigmund@google.com 596c3da6ad Enables codegen support in polymer
R=blois@google.com, jmesserly@google.com

Review URL: https://codereview.chromium.org//211393006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34531 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 22:11:28 +00:00
blois@google.com 8c3fe62c85 Code transformers fixes for latest analyzer update
This fixes some incompatibilities with the newest analyzer around how deleted files are handled. The resolver was removing the source completely, but the analyzer expects the source to remain as long as it is being referenced by a URI.

This also fixes an issue where resolver were not being released when an exception was thrown from within the applyResolvers call.

** NOTE ** see the commented line which needs to be removed with the updated analyzer.

BUG=
R=brianwilkerson@google.com, scheglov@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//217163005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34512 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 18:36:39 +00:00
kevmoo@google.com 876cfa32a9 pkg/code_transformers: removed unused imports, require latest unittest
R=sigmund@google.com

Review URL: https://codereview.chromium.org//216233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34505 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 16:31:05 +00:00
sigmund@google.com a8b174a5a2 Include exports in resolver.libraries
R=blois@google.com

Review URL: https://codereview.chromium.org//208623008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34275 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 22:21:26 +00:00
sigmund@google.com fc7a4ce392 Fixes how to lookup sdk dir to support tests deeper inside test/ folders.
R=blois@google.com

Review URL: https://codereview.chromium.org//203723006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34091 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 01:13:27 +00:00
blois@google.com 2c034bfe3f Updating code_transformers to not fail on syntax errors
Recent changes started using the Analyzer's parseCompilationUnit method which throws exceptions on syntax errors, but this is undesirable in many cases. Adding an option to disable this behavior and using that in code_transformers.

BUG=
R=scheglov@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//204033003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34070 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 22:09:17 +00:00
blois@google.com d57c0b055b Adding some asset-related utilities to code_transformers
Including dart entry point checks and URI->asset resolution.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//196943024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34055 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 19:54:51 +00:00
sigmund@google.com 169394ce8b Allow multiple-entry libraries in code_transformers
R=blois@google.com

Review URL: https://codereview.chromium.org//200543006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33772 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 20:30:12 +00:00
sigmund@google.com dcd5a3348c Fixes code_transformers after the latest analyzer changes
BUG=http://dartbug.com/17502
R=blois@google.com

Review URL: https://codereview.chromium.org//199413020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33768 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 20:05:15 +00:00
scheglov@google.com 844751f9ed Support for DartBlockBody, DartExpressionBody, DartOmit in java2dart.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189433006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33468 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 23:53:28 +00:00
scheglov@google.com 151c4c3a7d Improved 'has' properties translation.
New analyzer snapshot.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//189043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33399 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:18:26 +00:00
scheglov@google.com 1f8c20a04d Update and analyzer snapshot with AST -> Ast rename.
R=brianwilkerson@google.com, rnystrom@google.com, blois@google.com, karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//185603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33296 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 20:02:28 +00:00
scheglov@google.com 7f73657ad6 New analyzer snapshot.
No 'isInstanceOf' changes yet.
Just current state with changes required to adopt to the API changes in Java.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//184893003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33176 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 22:52:15 +00:00
blois@google.com 86f6fac791 Refactoring resolvers to make them able to be run in parallel.
With pub build and pub serve the same transformer can be run on the same asset in parallel. We want to maintain the cache between the runs, so making the resolver pipeline these requests.

In addition, refactoring to dramatically change the role of ResolverTransformer- previously it was a transformer that automatically kept the AST up to date, but this does not work well when in a pipeline of transformers that are generating or modifying code. What was ResolverTransformer is Resolvers- a cache of resolvers for which individual transformers now need to request the resolver from.

ResolverTransformer is now a mixin which can be used to automatically release a Resolver when it's done being used.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//181383015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33163 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 16:58:18 +00:00
blois@google.com 96d8be7a9e Fixing non-posix path issue on Window
The code dealing with paths in Resolver should always use URI paths, but was instead using native path syntax in a few places.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//174313004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32972 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-24 17:15:04 +00:00
blois@google.com fceda92eaf Extending logic to find Dart's SDK directory for resolver tests
Previous logic was failing when executing from VM tests where the dart-sdk folder is not built in the output directory.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//174663006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32922 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 20:09:35 +00:00
blois@google.com 993a917ff4 Revert "Revert "Adding package:code_transformers for unifying common transformers code""
This is a re-submission of adding code_transformers with a fix for resolving the sdk directory.

The resolution was failing when executing tests with the --use-sdk flag.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//172633006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32908 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 17:27:22 +00:00
blois@google.com fa4ee4753a Revert "Adding package:code_transformers for unifying common transformers code"
This reverts commit 32859. It's failing to find the Dart SDK under a number of cases.

TBR
BUG=

Review URL: https://codereview.chromium.org//174053004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32866 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 19:21:15 +00:00
blois@google.com 730b3c6137 Adding package:code_transformers for unifying common transformers code
There's quite a bit of code which would be great to share between Polymer and Angular, adding this as the starting point for some of that code.

This CL is primarily a transformer that resolves the AST which can be used by other transformers when modifying code.

BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org//140203007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32859 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 18:37:00 +00:00