Commit Graph

17 Commits

Author SHA1 Message Date
Matthias Hausner 1a6d1eca32 Implement @patch annotation for patch class members
Allow members of patch classes to be annotated with @patch. The VM
ignores the annotation. I simply replaces the original method
if the name matches, or reports an error if field names match.

Adding a bit is_patched to members to do more checking remains a
TODO. There are currently no unused bits available, and I don’t want
to increase the size of Function objects for this.

BUG=
R=asiva@google.com

Review URL: https://codereview.chromium.org/2230383003 .
2016-08-10 12:54:57 -07:00
Matthias Hausner e11ca24053 Use metadata annotation @patch for patch classes
Annotate patch classes and top-level patch functions with @patch
instead of the pseudo-keyword patch. This allows the analyzer
to read patch files, and matches the syntax that dart2js uses.

The deprecated syntax is still supported, but a warning is printed when detected.

BUG=

Review URL: https://codereview.chromium.org/2220883004 .
2016-08-09 09:48:03 -07:00
lrn@google.com 3b3e87cabc Revert "Rename internal library dart:_collection-dev to dart:_internal."
Dartium needs updating too.

Committed: https://code.google.com/p/dart/source/detail?r=31827

R=floitsch@google.com

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31877 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 12:06:38 +00:00
lrn@google.com ead87f47e9 Revert "Rename internal library dart:_collection-dev to dart:_internal."
Dartium needs updating too.

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31827 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 12:27:44 +00:00
lrn@google.com 0098710559 Rename internal library dart:_collection-dev to dart:_internal.
BUG= http://dartbug.com/14140
R=floitsch@google.com

Review URL: https://codereview.chromium.org//133893007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31823 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 09:24:46 +00:00
asiva@google.com ae2ab93835 Avoid yet another import of dart:_collection_dev in the core patch library. Use the prefix _collection_dev (already set up in dart:core imports) when accessing Symbol in the core patch library.
R=ahe@google.com, floitsch@google.com

Review URL: https://codereview.chromium.org//14004003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@22128 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-29 16:23:58 +00:00
ahe@google.com 45ad548837 Update dart:mirrors to use Symbol.
Review URL: https://codereview.chromium.org//14173005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21460 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 15:00:45 +00:00
floitsch@google.com bebe3ac2cd Refactor List.setRange function.
Review URL: https://codereview.chromium.org//13863012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21452 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 13:52:29 +00:00
ahe@google.com 601686b901 Update Function.apply to use Symbol.
Review URL: https://codereview.chromium.org//14107006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21451 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-15 13:48:25 +00:00
lrn@google.com 6b4f4b1bab Change new List(n) to return fixed length list.
Deprecate List.fixedLength, add List.filled.

Make Iterable.toList and List.from take "growable" argument,
defaulting to false.

Review URL: https://codereview.chromium.org//12328104

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@19112 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-27 08:45:04 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge.
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
regis@google.com 849585ef7c Implement Function.apply in vm (issue 5670).
Fix a closure parameter count check bug (unveiled by an apply test).
Review URL: https://codereview.chromium.org//11564029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16175 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 19:04:01 +00:00
floitsch@google.com 3e2f323981 Dynamic -> dynamic.
Review URL: https://codereview.chromium.org//11312237

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14898 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-14 15:33:25 +00:00
lrn@google.com 2208fcd208 Change NotImplementedException to UnimplementedError.
Retain a NotImplementedException type for backwards compatibility.
This class will be removed soon.
The constructor of UnimplementedError is currently const in order to
support the NotImplementedException. That will be fixed too.

Review URL: https://codereview.chromium.org//11358060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14467 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 13:18:37 +00:00
efortuna@google.com 2262eaa5ed Reapply r13292 WITH a fix to dartc test status for apply_test.dart
Review URL: https://codereview.chromium.org//11035069

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13335 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 23:42:27 +00:00
efortuna@google.com 461f7fb95e Revert r13292. This is when the first failure showed up on dartc, but dartc
didn't actually turn red. Investigating why.
Review URL: https://codereview.chromium.org//11081002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13330 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 23:05:20 +00:00
lrn@google.com 181dc5d3b4 Add apply method signature to Function class.
This does not include an implementation for any backend. The
current implementation throws a NotImplementedException when
called.

BUG=5419

Review URL: https://codereview.chromium.org//11027059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13292 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 12:57:51 +00:00