antonm@google.com
663662028e
Clean sort_helper.dart a bit: remove printing.
...
R=ngeoffrey@google.com
Review URL: https://chromiumcodereview.appspot.com//10692157
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9580 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-12 07:24:07 +00:00
floitsch@google.com
de90cce3e2
Inline compareTo for numbers into min and max.
...
Review URL: https://chromiumcodereview.appspot.com//10690086
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9564 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-11 19:00:40 +00:00
floitsch@google.com
affb3cdf0f
capital case OK in status file.
...
Review URL: https://chromiumcodereview.appspot.com//10693121
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9462 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-09 09:20:32 +00:00
floitsch@google.com
608cf10ba8
Update status file.
...
Review URL: https://chromiumcodereview.appspot.com//10689127
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9460 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-09 08:15:58 +00:00
floitsch@google.com
4a4532d205
Fix int.compareTo.
...
In particular we want:
0.compareTo(-0.0) => 1
Review URL: https://chromiumcodereview.appspot.com//10692099
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9459 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-09 07:57:29 +00:00
sra@google.com
8d52ae8d46
Update corelib.statis: list_sort_test and sort_test magically started working on IE.
...
Review URL: https://chromiumcodereview.appspot.com//10696106
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9382 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-04 00:14:34 +00:00
antonm@google.com
5d3e6fd7d3
Print even less.
...
That helped for Linux and Mac. Let's see if it'll help on Windows.
R=ricow@google.com
BUG=3834
Review URL: https://chromiumcodereview.appspot.com//10701078
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9335 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-03 09:45:39 +00:00
ricow@google.com
d112a4a5cc
Mark corelib/list_sort_test as flaky on dartium. Reoppening dartbug.com/3834
...
This test has been flaky on dartium-win-inc, e.g.,
http://build.chromium.org/p/client.dart/builders/dartium-win-inc/builds/2345/steps/annotated_steps/logs/stdio
Review URL: https://chromiumcodereview.appspot.com//10689085
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9329 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-03 07:09:42 +00:00
antonm@google.com
90c58141ad
Suppress printing while testing.
...
I suspect that's the reason why test sometimes times out under DRT.
R=podivilov@chromium.org
BUG=2667,3834
Review URL: https://chromiumcodereview.appspot.com//10690039
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9245 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-29 12:01:21 +00:00
floitsch@google.com
a51dc25968
Make isUtc a getter, change some method names in Date. Weekday is now 1 based.
...
isUtc is now a getter.
Date.hours -> Date.hour
Date.minutes -> Date.minute
Date.seconds -> Date.second
Date.milliseconds -> Date.millisecond
Date.fromEpoch -> Date.fromMillisecondsSinceEpoch
Date.value -> Date.millisecondsSinceEpoch
Date.MON == 1 (up to Date.SUN == 7).
Fixes issue 3444, 1985.
Review URL: https://chromiumcodereview.appspot.com//10538105
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8899 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-20 11:43:46 +00:00
kasperl@google.com
feb05c33c3
Stop mapping indexOf/lastIndexOf directly to the JavaScript native on indexable primitives.
...
Fixes http://dartbug.com/3689 .
R=ahe@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10553034
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8790 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-18 13:17:17 +00:00
floitsch@google.com
dd61a23829
Reapply "Refactor Date implementation in VM."
...
This reapplies fixed versions of commit 7542 and commit 8544.
Original review URLs:
https://chromiumcodereview.appspot.com//10533068
https://chromiumcodereview.appspot.com//10544109
Review URL: https://chromiumcodereview.appspot.com//10534114
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8655 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-14 13:05:22 +00:00
rnystrom@google.com
4d0a44ad2c
Update Future tests to match new "stackTrace" property.
...
Review URL: https://chromiumcodereview.appspot.com//10546131
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8571 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 20:15:13 +00:00
rnystrom@google.com
491a5b6263
Allow optional callStack argument to Future.completeException().
...
A corresponding getter returns the value provided. transform() and chain()
are both updated to provide this when an exception is thrown from
their callbacks.
Review URL: https://chromiumcodereview.appspot.com//10542117
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8569 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 19:44:56 +00:00
floitsch@google.com
eb92af4080
Revert "Refactor Date implementation in VM."
...
Also revert "Round days-computation to get rid of daylight-savings differences."
This reverts commit 7542 and commit 8544.
Review URL: https://chromiumcodereview.appspot.com//10534111
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8547 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 13:44:45 +00:00
floitsch@google.com
17de58fbaf
Reapply "Refactor Date implementation in VM."
...
This reapplies a fixed version of commit 8533.
https://chromiumcodereview.appspot.com//10533068
Review URL: https://chromiumcodereview.appspot.com//10536116
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8542 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 12:04:36 +00:00
floitsch@google.com
02f39238ae
Revert "Refactor Date implementation in VM."
...
This reverts commit 8533.
Review URL: https://chromiumcodereview.appspot.com//10536114
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8535 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 10:33:36 +00:00
floitsch@google.com
0e297362a2
Refactor Date implementation in VM.
...
Less (and simpler) native functions. More precise semantics (for both the
native functions as well as for the Date class itself).
Fixes issue 3201.
Review URL: https://chromiumcodereview.appspot.com//10533068
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8533 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 10:24:58 +00:00
kasperl@google.com
9df12e2a76
Add experimental expando support.
...
R=iposva@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10534089
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8522 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-12 05:22:16 +00:00
sigmund@google.com
2bb9af7322
Revert changes to Future.chain() and Future.transform() from http://codereview.chromium.org/10517006
...
Since onComplete swallows exceptions, the new implementation doesn't propagate exceptions thrown by the transforming function, where there's a then() handler but no handleException() handler.
The right fix is to invoke handlers (including the default 'throw the exception' error handler) on the event loop rather than synchronously, but there's no API for that in corelib yet.
BUG=3489
Review URL: https://chromiumcodereview.appspot.com//10537096
Patch from Sam McCall <sammccall@google.com >.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8501 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-11 16:07:27 +00:00
kasperl@google.com
b21cfb024e
Unskip the last tests covered by http://dartbug/3304 .
...
TBR'ed.
R=ngeoffray@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10532083
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8484 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-11 08:49:10 +00:00
floitsch@google.com
cde1a8e09a
new Date.now() should be in local timezone.
...
This error probably slipped in during the refactoring.
Review URL: https://chromiumcodereview.appspot.com//10537086
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8483 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-11 08:35:31 +00:00
kasperl@google.com
2f7b4b9185
Stop skipping for Safari and Firefox and allow even more stuff pass on IE.
...
TBR'ed.
R=ngeoffray@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10536089
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8481 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-11 08:24:51 +00:00
sigmund@google.com
c51d81231b
More tests and doc for futures (followup to http://codereview.chromium.org/10517006/ )
...
Review URL: https://chromiumcodereview.appspot.com//10544063
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8448 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-08 16:57:12 +00:00
kasperl@google.com
20d1b84d15
Mark another test as failing on IE.
...
R=ngeoffray@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10542070
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8419 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-08 07:08:28 +00:00
kasperl@google.com
0a2dab9423
Mark test as failing on Safari.
...
R=ngeoffray@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10543072
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8418 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-08 05:42:39 +00:00
jmesserly@google.com
3f81d4f899
Adds a callback to Future that is invoked upon completion, whether success or failure.
...
I'm not totally happy with the method name (in an ideal world, I'd like to call this
method then(), and have onSuccess and onFailure). But this should be backwards-compatible.
Review URL: https://chromiumcodereview.appspot.com//10517006
Patch from Sam McCall <sam.mccall@gmail.com >.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8303 260f80e4-7a28-3924-810f-c04153c831b5
2012-06-05 18:41:13 +00:00
hausner@google.com
f6c776dcbe
Eliminate unary plus with hex literals
...
The spec says unary + is only allowed with integer and floating point literals, not with hex literals. Somebody noticed that the VM accepted
+0x10 as well.
Consequently, the Math.parseInt(str) library function should fail with
a BadNumberFormatException if it is called with a hex number that is preceded by a +.
Fixes issue 1540.
This change exposed that the dart2js core library implementation is
falsely accepting +0xNNN hex numbers. I filed issue 3333.
Review URL: https://chromiumcodereview.appspot.com//10456060
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8177 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-31 22:35:29 +00:00
ngeoffray@google.com
78f19042ff
Do not wrap the exception if we could not translate it to one of our internal exceptions.
...
Review URL: https://chromiumcodereview.appspot.com//10444086
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8099 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-30 11:46:50 +00:00
ngeoffray@google.com
80194ed0e1
Fix check in exception unwrapping and update status files.
...
Review URL: https://chromiumcodereview.appspot.com//10448074
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8097 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-30 11:38:12 +00:00
kasperl@google.com
d9d1eb2a75
Update status files to make IE build bots green.
...
R=ngeoffray@google.com
BUG=
TEST=
Review URL: https://chromiumcodereview.appspot.com//10453074
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8086 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-30 07:30:26 +00:00
ngeoffray@google.com
e2c7c6eaee
Update status files for dart2js/mac/safari.
...
Review URL: https://chromiumcodereview.appspot.com//10442081
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8085 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-30 07:26:01 +00:00
kasperl@google.com
5d23a99d71
Skip tests that time out on IE.
...
R=ngeoffray@google.com
BUG=http://dartbug.com/3304
TEST=
Review URL: https://chromiumcodereview.appspot.com//10444084
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8084 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-30 05:59:16 +00:00
ngeoffray@google.com
2cb4416340
Use the typedef arity to know how to invoke a closure given by the dom.
...
Review URL: https://chromiumcodereview.appspot.com//10441071
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8067 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-29 15:53:54 +00:00
ngeoffray@google.com
5ca4106a51
Skip dart2js/firefox until we fix issue 2615.
...
Review URL: https://chromiumcodereview.appspot.com//10449049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8045 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-29 09:41:29 +00:00
floitsch@google.com
a88e304d29
Deprecate use of timezones.
...
Review URL: https://chromiumcodereview.appspot.com//10411057
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7911 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-23 16:07:35 +00:00
efortuna@google.com
d3c56ab08d
The string_replace_dollar_test must have been added aroun the same time
...
ngeoffray submitted his 7788 (will check).
Review URL: https://chromiumcodereview.appspot.com//10387221
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7820 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-21 20:30:24 +00:00
efortuna@google.com
1b806d29a5
Revert 7788. These tests were marked as fail/flaky with no further action to be
...
taken on them, when in reality they are all passing with the latest Chrome/DRT
rolled update. Please don't change status files arbitrarily.
Review URL: https://chromiumcodereview.appspot.com//10416015
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7819 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-21 20:11:29 +00:00
floitsch@google.com
cc15d26cf7
Reapply "Add support for timezone offset and timezone name."
...
This reapplies commit 7800.
Review URL: https://chromiumcodereview.appspot.com//10417009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7805 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-21 16:11:20 +00:00
floitsch@google.com
77ade89e4a
Revert "Add support for timezone offset and timezone name."
...
This reverts commit 7803.
Review URL: https://chromiumcodereview.appspot.com//10416008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7804 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-21 15:13:46 +00:00
floitsch@google.com
618c649c33
Reapply "Add support for timezone offset and timezone name."
...
This reapplies commit 7800.
Original CL: https://chromiumcodereview.appspot.com/10383218/
Don't write *foo += x.
Review URL: https://chromiumcodereview.appspot.com//10413031
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7803 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-21 15:07:11 +00:00
floitsch@google.com
5b99866ecd
Revert "Add support for timezone offset and timezone name."
...
This reverts commit 7801..
Review URL: https://chromiumcodereview.appspot.com//10399106
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7802 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-21 14:40:27 +00:00
floitsch@google.com
36d9c69461
Add support for timezone offset and timezone name.
...
Review URL: https://chromiumcodereview.appspot.com//10383218
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7801 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-21 14:36:43 +00:00
ngeoffray@google.com
d57f64f9e3
Update status files to fix bot redness.
...
Review URL: https://chromiumcodereview.appspot.com//10417005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7788 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-21 10:37:21 +00:00
ngeoffray@google.com
da3f7fc3cb
Fix issue 2756 where '$' has as special meaning in Javascript String.replace.
...
Review URL: https://chromiumcodereview.appspot.com//10411048
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7787 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-21 10:15:16 +00:00
hausner@google.com
048b8bde32
More String + elimination in tests
...
Worst offender was standalone test suite
Review URL: https://chromiumcodereview.appspot.com//10414002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7762 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-18 21:03:59 +00:00
floitsch@google.com
7f06db21d2
Add comparison operators to Date class.
...
Review URL: https://chromiumcodereview.appspot.com//10399027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7653 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-15 13:15:03 +00:00
floitsch@google.com
d89f228708
Make most arguments to Date constructor optional.
...
Fixes issue 2582.
Review URL: https://chromiumcodereview.appspot.com//10382171
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7652 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-15 12:50:15 +00:00
floitsch@google.com
1805e79fcb
Support up to 6 digits after the decimal point in Date.fromString.
...
Fixes comment 10 of issue 1728.
Review URL: https://chromiumcodereview.appspot.com//10391111
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7648 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-15 10:59:53 +00:00
floitsch@google.com
86859d3324
Fix typo in Date.toString.
...
We emitted an extra 0 for Dates that had ms == 10.
Fixes issue 1386.
Review URL: https://chromiumcodereview.appspot.com//10310145
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7647 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-15 10:56:31 +00:00