0b870e2ff6
Update RemoveMethodDeclarationTest to be consistent.
...
The actual motivator is though that test_method was failing.
I suspect that this is a linter issue, `super.toString()`, when called
from legacy library and referencing NNBD SDK, is MethodMember, and
probably linter does not handle this right. I believe that this is
not a problem we should test or fix in analysis_server, so I update
the test to verify what is implemented in the server.
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: Iffe896deb138cd8f2da15ccf67a571491b544512
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134406
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2020-02-05 20:35:59 +00:00
0617d85227
Add a fix for the prefer_contains lint
...
Change-Id: I296bf15939b8dafd514db927859602ed91cb800d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134501
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-02-05 19:45:29 +00:00
af4b6014f6
Move createAnalysisOptionsFile() call to setUp().
...
So, that individual tests call call it with different options,
and don't be overwritten in resolveTestUnit().
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I75f5d40b36b78b62eee7ed3f64ef49d1c30752ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134541
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-05 19:26:28 +00:00
e2a528d976
Remove the lint marker from more fix tests
...
Some of the tests were fairly seriously broken, so this fixes them.
Some of the tests were testing that we don't provide a fix when there is
no lint, but I don't think that it's useful to test that.
One test required no changes other than removing the marker.
Change-Id: I6d85fd98506fa20d8bf4996d30603feb8b1ff252
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134500
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-02-05 18:10:49 +00:00
44814d320f
Final fix for analyzer windows bots; don't canonicalize
...
Something is weird with our ResourceProviders and Context.canonicalize.
It causes the following:
newFolder(convertPath("/p3"));
resourceProvider.getResource(convertPath("/p3")) is File; // false
resourceProvider.getResource(
context.canonicalize(convertPath("/p3"))) is File; // true
Change-Id: Iafbfb6ad1bfc912a6850faf063778879dc97fe62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134143
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-02-03 23:03:56 +00:00
00e4d8f33d
Change the tests of quick fixes so they can use real lint results
...
This adds support so that tests of lint-based quick fix tests can use
the output of the linter rather than cons-ing up a fake lint to drive
the test. It also converts many of the existing tests to use real lints.
There were/are an amazing number of tests that were invalid and needed
to be fixed. This includes fixes for some of them, but there are still
several tests that have not been converted because they fail when run
using the output of the linter. Some of these are invalid tests, but
some might indicate bugs in the quick fix generation that should be
fixed.
Change-Id: Iea806849ea111dc8454073e8fe44fd42c5208652
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134141
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-02-03 15:34:55 +00:00
e4ddd90cd1
NNBD Preview: Fixes for a few edit details
...
These are bugs found while looking at the collection package.
Change-Id: I5527c873cbe015e723f59f743952b5dc493c5c97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134108
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-02-02 03:33:53 +00:00
89edf6443b
Fix another windows test in analyzer
...
Change-Id: I675efd198ce7e803e2f9e7bdb62385116da22032
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133438
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-31 23:55:22 +00:00
147ed9e9e1
Load navigation programatically; use badges for edit counts; #40115
...
Change-Id: I83b1db7c95ea0edb8a8d3af0f125219659c6df1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134080
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-01-31 22:06:12 +00:00
8d874bbb1e
NNBD preview: Add 'view' links to Edit List; #40115
...
Change-Id: Ia365fb43c6efc12c78a82841bcecffceefb501f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134086
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-31 18:06:52 +00:00
9517c22b39
Improve the fix for empty_catch
...
The fix for empty_catch should not remove the catch clause if doing so
would leave the try statement invalid. It could remove the whole try
statement in such a case, but it isn't clear that that's a good solution
in general. This at least patches the issue until we can decide whether
additional work should be done.
Change-Id: I7c5190faba9fd5632c04708007bc65bb18d3db6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134087
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-31 17:37:22 +00:00
26fec2ef66
Add return types to methods in analysis_server
...
Change-Id: I6149cd21df4df44aee0374db32e47e849aa9a960
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134047
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-31 00:26:49 +00:00
58a9c22f80
Add return types to more methods in analysis_server
...
Change-Id: I65bed353bcff4f991faf8c3bdde979789a8d962b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-30 21:43:34 +00:00
fccae66fa6
require type for dynamic var decl splits
...
Fixes: https://github.com/dart-lang/sdk/issues/40239
Change-Id: I67da61874bdba2f27381436b009687ed2f3810e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133960
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-30 17:50:28 +00:00
bad477ded3
NNBD preview: properly render deleted regions
...
Fixes #40295 ; fixes #40314
Change-Id: I28d60754d601cbf8cd3403cc576d55e7a0c12e9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133870
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-30 17:33:28 +00:00
ca3c83b654
remove unneeded <Widget> assist/fix annotations
...
See: https://github.com/dart-lang/sdk/issues/40378
Change-Id: If404a3c248ee671f6f3ac9e07848ad71faf45e67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-01-30 16:50:28 +00:00
1d4651f119
NNBD preview: Fix test for generic function types; typedefs still not fixed
...
This goes a long way to address #40034 , but typedefs still don't work.
Change-Id: Ice6a9111a793def151d10bb3fa3d1a8e7db8d3a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133862
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-30 00:29:50 +00:00
0d3571b52f
Add return types to more methods in analysis_server
...
Change-Id: Ib61c92d65e6170a1b5cd3e3d24affb3a3fa16bb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-29 20:18:20 +00:00
a6e01c23e2
Fix more windows tests in migration tool
...
No need to HTML-escape the root path; no HTML will be included.
Change-Id: Ibf9a19000a11207782b7b0d0f9222397f6d042fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133426
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-27 19:08:56 +00:00
81c5d11691
Change tests of lint-based quick fixes to not require the lint marker in the result
...
Change-Id: I2a7e35c9754a5108e3d664684b8c2109b5689c58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133409
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-27 01:48:25 +00:00
bc9348829e
NNBD preview: change the Edit Details response to be JSON
...
* Also changes Edit Details to be an ordered list
* Also changed explanation to not include a `.` at the end;
append it in JS if needed
* Also add POST click handler to unblock the POST edit work.
Change-Id: Ifc11f8d9e0194b58cd7d81028bac19e89887c7e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133169
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-24 04:33:01 +00:00
0263d4daf3
NNBD preview: Make navigation directories collapsible; closes #40109
...
Change-Id: Icc6ef0627533ac1ff925bd69c3e5b172fca9c514
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133140
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-01-23 22:17:19 +00:00
2ffe48efd9
Update a preview site after adding or removing a hint
...
The code to update the graph is still missing, but I believe that this
gets us closer to having everything plumbed through.
Change-Id: If3e66e3c77a04a8f043dcccf4346b379d16e573f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133000
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-23 16:43:57 +00:00
e0f97cda30
Migration: switch to using the FixBuilder.
...
Change-Id: I41e978439d36a26e55be71071a931390eb3dbf57
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133020
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Paul Berry <paulberry@google.com >
2020-01-23 16:06:57 +00:00
00125a5815
NNBD preview: Fix windows tests
...
Change-Id: Ib0f8767d45f9ffeb9864149899b057f6e5bba9fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132810
Auto-Submit: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-22 19:40:48 +00:00
6b32a519bf
Add an Edits panel, listing all edits in a page; #40115
...
Change-Id: I7e6f60d25bf85030fd4d3a700677d789f3978345
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132803
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-22 16:02:08 +00:00
a32e4363cb
Fix some lints from function typed parameters that were not converted automatically
...
Change-Id: I926b54c298d398e9a316b9c042fcae98f9210815
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132622
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-21 18:01:13 +00:00
5584c96fde
Enable prefer_single_quotes in analysis_server
...
All of the changes except in the analysis options file are from dartfix.
Change-Id: Icd9bf02ad07f71d1fc365979c7dfe18a792dc595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132624
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-21 17:52:52 +00:00
c790eccdf4
NNBD preview: Load region details when requested; Closes #40112
...
Change-Id: Ibcda2aa18c340c070e32160a470545b99d7751f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132560
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-20 18:46:28 +00:00
c9324972e8
NNBD preview: Fix html-escaping bug in region text
...
Change-Id: Icc6e52bf6f49f92fa67cd39f3985804e533b2972
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132305
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-17 19:08:17 +00:00
43694c3db1
NNBD preview: Move reasons/details into separate fixed panel
...
#40112 , still needs more work before closing
Change-Id: Ic963e4678ca0692ebcbf1c8cf3ab955d9ae81427
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132028
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-16 20:43:39 +00:00
f4f890ed30
Highlight null and throw keywords
...
DartUnitHighlightsComputer2 does not highlight the "null" and "throw" keywords.
This will highlight them both as keywords.
Change-Id: I38a45435f7a35e9a56f289e7797c4a5d00134f08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131071
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Simon Binder <simolus3@gmail.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 19:36:58 +00:00
e08e18f369
Add edits for more fixes in the preview tool
...
Change-Id: Ice5cff20f4df1215265b75cf2b1c1fad83aec2a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131946
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 14:16:06 +00:00
9937277327
NNBD preview: Change navigation to be a tree; not interactive yet #40109
...
Change-Id: I42550b89533d4c1acba7998887f7601de2569f18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131903
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-16 06:37:29 +00:00
fe666ce592
Report unused public static members of private classes
...
Also of private mixins, enums, and extensions.
Fixes #39988
Change-Id: I646205cba64da1a9837585a5af2c4c2b8d41824c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129860
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-14 06:09:04 +00:00
c6d6eed0aa
Include type arguments when converting to a stateful widget (issue 40095)
...
Change-Id: I5a4060f070cbd58165edb2515b29c9a3648d6a6b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131420
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-01-13 22:09:44 +00:00
5b1065ac60
Enable avoid_init_to_null in analysis_server
...
Change-Id: I1909b0d8939d9b436fce772bd97dc4835f1093ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131322
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-13 00:35:34 +00:00
f1c81dafbb
Add a fix for unnecessary_null_in_of_null_operators
...
Change-Id: I95852c5de13bd54d3c5ad7c475ec562c5a9ce61a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131301
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-01-12 21:48:44 +00:00
7ed7bffd2b
Fix some hints caused by previous CL and add some failing tests
...
Change-Id: I1e0c1fe0561525c230aed4e4009f49025c4d3cfc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131260
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-01-12 05:27:23 +00:00
32ce9c7872
Enable prefer_collection_literals in three packages
...
Other than the following changes, all of the changes were made by dartfix:
- the analysis options files
- one line to enable the fix through dartfix (missed in an earlier CL)
- three places where a bug in the fix produced invalid code (issue and fix TBD)
Change-Id: If8660700792561805f4d1c96ccecd81abcebfeb8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131209
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-11 20:39:02 +00:00
3c22953172
Hook up the fix for use_function_type_syntax_for_parameters
...
Change-Id: I66263bec75bb893002254a8a99966a910f09aa55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131208
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-11 20:36:12 +00:00
bc99e4be7c
Add a fix for prefer_iterable_whereType
...
Change-Id: Icd0c1f0865f1ae9dfae2a884eef1926b816f237c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131206
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-11 19:51:52 +00:00
9e9c14cae3
quickfix for hash_and_equals
...
Fixes: https://github.com/dart-lang/sdk/issues/40012
Fixes: https://github.com/flutter/flutter-intellij/issues/4264
Change-Id: I21c343e04468669cf2910bd8769a29ac5c849fe4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130933
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-10 23:41:12 +00:00
693c3c444d
[nnbd_migration] Make list constructor nullable if specified length
...
Change-Id: Ia65768ddf6c7da11a44b362d3c99cc0372a14e84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130891
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-10 20:41:01 +00:00
2199e94d37
Migration: begin integrating FixBuilder.
...
Since the FixBuilder-based implementation is not yet fully baked, we
only enable the integration in api_test.dart for now. The remaining
failing test cases are marked with a `@FailingTest` annotation
pointing to https://github.com/dart-lang/sdk/issues/38472 , which is
the tracking bug for the FixBuilder implementation.
Change-Id: I761350fff125cec8067a96fdfc593b381e5feb3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130882
Commit-Queue: Paul Berry <paulberry@google.com >
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-01-09 20:01:16 +00:00
327b1eb24f
analysis_server: Make private fields final where possible
...
Change-Id: Ibdeb7e66f07bf81205d70ac5d1c4cb4aa5a97671
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-08 22:08:02 +00:00
d9570f907e
fix for avoid_redundant_argument_values
...
UPDATE (1/3): blocked until new linter lands.
See: https://github.com/dart-lang/linter/issues/1927
Change-Id: I432f7c61aa9d5b6b0c0abda798f3d731e5fc93b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130160
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-08 20:36:20 +00:00
e85e203e73
Deprecate DartType.name
...
Change-Id: If3a967bba976aa78493764513edbb3d406b08d27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130625
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-08 07:00:59 +00:00
accd08fa64
Resolve with Never and Never? receivers.
...
Change-Id: I388c05d09238a20fc5a84503816b9102c51a573a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130620
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-08 04:07:46 +00:00
6d826735af
Report unused constructors
...
Fixes #35108
Change-Id: I639f1165ec626fc0e8eadf6fa501200ec98af053
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127205
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-07 21:49:59 +00:00
Konstantin Shcheglov