8439158668
completion driver wip
...
Gotta start somewhere.
All subject to revision. (Names especially.)
This gets us an end-to-end test and a starting point for client algorithm implementations.
Note that this was designed to run outside `test/`. We should be able to move it out if so desired.
Needless to say any thoughts on any of it are welcome!
Change-Id: Iecf5c7ce854f619aa5677454091ceb68dd45827b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134542
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-06 00:33:10 +00:00
204a70d4bd
[nnbd migration] add an initial readme to describe the workflow and tool
...
Change-Id: I6d1614aafd0b722c633fba0aa128f90acb4ea006
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134560
Reviewed-by: Janice Collins <jcollins@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-02-05 21:48:49 +00:00
0b870e2ff6
Update RemoveMethodDeclarationTest to be consistent.
...
The actual motivator is though that test_method was failing.
I suspect that this is a linter issue, `super.toString()`, when called
from legacy library and referencing NNBD SDK, is MethodMember, and
probably linter does not handle this right. I believe that this is
not a problem we should test or fix in analysis_server, so I update
the test to verify what is implemented in the server.
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: Iffe896deb138cd8f2da15ccf67a571491b544512
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134406
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2020-02-05 20:35:59 +00:00
0631e949b2
[migration tool] fail the CI if the generated files haven't been rebuilt
...
Change-Id: I824f8528b5b2bf2efec4121e017d77bab5b6ab60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134468
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Devon Carew <devoncarew@google.com >
2020-02-05 20:25:39 +00:00
0617d85227
Add a fix for the prefer_contains lint
...
Change-Id: I296bf15939b8dafd514db927859602ed91cb800d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134501
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-02-05 19:45:29 +00:00
af4b6014f6
Move createAnalysisOptionsFile() call to setUp().
...
So, that individual tests call call it with different options,
and don't be overwritten in resolveTestUnit().
R=brianwilkerson@google.com , pquitslund@google.com
Change-Id: I75f5d40b36b78b62eee7ed3f64ef49d1c30752ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134541
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-05 19:26:28 +00:00
5d3c91b68e
Fix the MeanReciprocalRankComputer computation math, the computed MRR computation was not the MRR, follow up tests coming soon.
...
Change-Id: I3ae4486eada3ab41b21190050a7a7a2368432004
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134414
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-05 19:18:51 +00:00
e2a528d976
Remove the lint marker from more fix tests
...
Some of the tests were fairly seriously broken, so this fixes them.
Some of the tests were testing that we don't provide a fix when there is
no lint, but I don't think that it's useful to test that.
One test required no changes other than removing the marker.
Change-Id: I6d85fd98506fa20d8bf4996d30603feb8b1ff252
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134500
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-02-05 18:10:49 +00:00
eff4807eef
[analysis_server] Fix #36352 , cannot stop a plugin that isn't running
...
Report it as a silent exception. This way it will show up in log files
and (in the future) over crash reporting (since we haven't solved the
underlying cause), but *not* to users, because it currently appears to
be harmless.
In the future we should consider a "logged-only" type of exception, once
we are confident this isn't causing secondary issues, if we don't intend
to or think we are able to solve this at a deeper level.
Change-Id: I2ee339718fbd6e7c684ccc42718fbb57742f2dd7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134467
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Mike Fairhurst <mfairhurst@google.com >
2020-02-05 17:13:59 +00:00
34893faa60
Use DartType.getDisplayString() instead of toString().
...
Change-Id: I982a4fff312593e6788afcbc9200a83793fefb97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2020-02-05 07:41:22 +00:00
f51187a18d
[migration tool] convert the javascript code in the migration tool to dart
...
Change-Id: I5145be275dda77de3c25d80a13812803217d6452
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134403
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-04 21:46:08 +00:00
270829d7eb
Refactor the CompletionMetricsComputer class into three classes: a subclass and two concrete classes, AbstractCompletionMetricsComputer, CompletionCoverageMetrics and RelevanceAnalyzerMetrics.
...
This change breaks up the lengthy algorithm, and greatly speeds up the Relevance Analyzer tests.
Change-Id: I4273bcabe7399f80aa751c5963a53fa04e1b4d25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134381
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-02-04 19:34:56 +00:00
44814d320f
Final fix for analyzer windows bots; don't canonicalize
...
Something is weird with our ResourceProviders and Context.canonicalize.
It causes the following:
newFolder(convertPath("/p3"));
resourceProvider.getResource(convertPath("/p3")) is File; // false
resourceProvider.getResource(
context.canonicalize(convertPath("/p3"))) is File; // true
Change-Id: Iafbfb6ad1bfc912a6850faf063778879dc97fe62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134143
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-02-03 23:03:56 +00:00
e5d5434715
Standard output improvement from metrics_util.dart to print "<no counts>" if the counter has no counts.
...
Change-Id: I3d01f539670bb8d57f6b04b16cc4f92aaa2aa1c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-02-03 22:50:07 +00:00
78fe10c3be
Completion metrics change- add missing documentation in the relevance_analyzers.dart file, as well as adding DartCompletionRequest as an input to the analyzers
...
Change-Id: I31c2523252f2574f092b44ec8b67d346804ac856
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134220
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-03 20:50:26 +00:00
00e4d8f33d
Change the tests of quick fixes so they can use real lint results
...
This adds support so that tests of lint-based quick fix tests can use
the output of the linter rather than cons-ing up a fake lint to drive
the test. It also converts many of the existing tests to use real lints.
There were/are an amazing number of tests that were invalid and needed
to be fixed. This includes fixes for some of them, but there are still
several tests that have not been converted because they fail when run
using the output of the linter. Some of these are invalid tests, but
some might indicate bugs in the quick fix generation that should be
fixed.
Change-Id: Iea806849ea111dc8454073e8fe44fd42c5208652
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134141
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-02-03 15:34:55 +00:00
5f5e1db141
[nnbd tool] move nnbd preview tool resources to individual files
...
Change-Id: I7f3690e34d94e3d7f361b31447a5ae60cf01a1ea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134140
Commit-Queue: Devon Carew <devoncarew@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-02-03 00:38:34 +00:00
e4ddd90cd1
NNBD Preview: Fixes for a few edit details
...
These are bugs found while looking at the collection package.
Change-Id: I5527c873cbe015e723f59f743952b5dc493c5c97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134108
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-02-02 03:33:53 +00:00
89edf6443b
Fix another windows test in analyzer
...
Change-Id: I675efd198ce7e803e2f9e7bdb62385116da22032
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133438
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-31 23:55:22 +00:00
147ed9e9e1
Load navigation programatically; use badges for edit counts; #40115
...
Change-Id: I83b1db7c95ea0edb8a8d3af0f125219659c6df1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134080
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Paul Berry <paulberry@google.com >
2020-01-31 22:06:12 +00:00
d772141960
Initial RelevanceAnalyzer support in the completion_metrics.dart algorithm with an initial example implementation of RHSOfAsExpression
...
Change-Id: Icaf3e80cb4d634f5871d576d3344210d631641c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134092
Commit-Queue: Jaime Wren <jwren@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-31 21:41:47 +00:00
8d874bbb1e
NNBD preview: Add 'view' links to Edit List; #40115
...
Change-Id: Ia365fb43c6efc12c78a82841bcecffceefb501f3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134086
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-31 18:06:52 +00:00
bff11ba6ec
Enable always_declare_return_types in analysis_server
...
Change-Id: I9b06753cf552c9f50ea2abd7f3fa5ba9adecb526
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134085
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-31 17:45:24 +00:00
d1ca36aa83
Enable empty_catches in analysis_server
...
Change-Id: Ic21556e8118a5b5d3b4a06ed6d3a7002f606f2ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134084
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-31 17:38:02 +00:00
9517c22b39
Improve the fix for empty_catch
...
The fix for empty_catch should not remove the catch clause if doing so
would leave the try statement invalid. It could remove the whole try
statement in such a case, but it isn't clear that that's a good solution
in general. This at least patches the issue until we can decide whether
additional work should be done.
Change-Id: I7c5190faba9fd5632c04708007bc65bb18d3db6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134087
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-31 17:37:22 +00:00
26fec2ef66
Add return types to methods in analysis_server
...
Change-Id: I6149cd21df4df44aee0374db32e47e849aa9a960
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134047
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-31 00:26:49 +00:00
5d7f3093fd
Update the lsp generator to generate return types for all methods
...
Change-Id: Id1a90d770aa772327011ee8ccc7a13f0ca6f8de4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133961
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-30 21:43:43 +00:00
58a9c22f80
Add return types to more methods in analysis_server
...
Change-Id: I65bed353bcff4f991faf8c3bdde979789a8d962b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134000
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-30 21:43:34 +00:00
fccae66fa6
require type for dynamic var decl splits
...
Fixes: https://github.com/dart-lang/sdk/issues/40239
Change-Id: I67da61874bdba2f27381436b009687ed2f3810e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133960
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2020-01-30 17:50:28 +00:00
9a572c70fa
call() suggestions for FunctionTypes
...
Fixes: https://github.com/dart-lang/sdk/issues/40270
Change-Id: Ic6f882391d1450b43cc224d5ec908589239c590e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133941
Commit-Queue: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2020-01-30 17:43:40 +00:00
bad477ded3
NNBD preview: properly render deleted regions
...
Fixes #40295 ; fixes #40314
Change-Id: I28d60754d601cbf8cd3403cc576d55e7a0c12e9c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133870
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-30 17:33:28 +00:00
ca3c83b654
remove unneeded <Widget> assist/fix annotations
...
See: https://github.com/dart-lang/sdk/issues/40378
Change-Id: If404a3c248ee671f6f3ac9e07848ad71faf45e67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Phil Quitslund <pquitslund@google.com >
2020-01-30 16:50:28 +00:00
d6206fbbc7
Add return types to more tests in analysis_server
...
Change-Id: Ib85d299a34cfda6bc4772d53f16d9ba44251bfbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133900
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-30 14:30:18 +00:00
7a3e1e7384
NNBD Preview: Fix region detail links to _not_ be POST links
...
Additionally fix un-highlighting upon new highlight.
Change-Id: I4ee85371bec11ed70cc31798519cdea3061474d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133864
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-30 05:02:30 +00:00
1d4651f119
NNBD preview: Fix test for generic function types; typedefs still not fixed
...
This goes a long way to address #40034 , but typedefs still don't work.
Change-Id: Ice6a9111a793def151d10bb3fa3d1a8e7db8d3a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133862
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-30 00:29:50 +00:00
0d3571b52f
Add return types to more methods in analysis_server
...
Change-Id: Ib61c92d65e6170a1b5cd3e3d24affb3a3fa16bb9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133760
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-29 20:18:20 +00:00
a49dce0631
Migration: remove the "propagation step" part of the instrumentation interface.
...
It didn't wind up being used, and its presence limits our ability to
modify the graph propagation algorithm (which I plan to do in a
follow-up CL).
Change-Id: I48a9b879f25295075e8d95eb3fb0185839303957
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133425
Reviewed-by: Mike Fairhurst <mfairhurst@google.com >
2020-01-29 18:30:46 +00:00
1ec1b4d68b
Completion metrics cleanup for FieldFormalParameters.
...
Change-Id: Id9151e182446ea0cb21141230e0378cc8cd6efa8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133668
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-29 17:47:56 +00:00
1aea141b6e
In completion_metrics.dart, skip files that have analysis errors
...
Change-Id: Iae95f7370b6dd6725af607bcc794373b675d6914
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133666
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-29 17:40:16 +00:00
34e271a64b
Don't include library directives in the completion metrics computations.
...
Change-Id: Ic86383ad23a55c92b079f8b55d24ce7c33f29c5f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133681
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-29 07:36:02 +00:00
8efdee06d6
Begin adding return types in analysis_server
...
Change-Id: Id0daa52236bdc90cba6bfd7cf81d1b4cf47603c0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133544
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-28 21:18:30 +00:00
b1be0d58a1
completion_metrics.dart change, don't expect completions when the completed token would be a dynamic type.
...
This change improves the number of successful completions from 96.2% to 98.2% on the collection library.
Change-Id: I6dffa3b6ad6c92be482ca0810c1c0aa558fdcbde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-28 19:25:29 +00:00
213c80c5dd
Add a new counter in completion_metrics.dart to count and report the number of each token that was a miss.
...
Change-Id: Id78b1f65b4e75b3321f18be04e0589d521852c12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133502
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-28 17:21:03 +00:00
ff1cd53725
completion_metrics.dart improvement with named arguments in method invocations.
...
Named arguments, i.e. the 'foo' in 'method_call(foo: 1)' should not be included, by design, the completion engine won't suggest named arguments already it the source.
This improvement changes the percent of successful completions from 95.4% to 96.2% with the collection package.
Change-Id: I182c09b62acfc28ed3ae852e1c8e500c6a2f4f3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133501
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-28 17:12:58 +00:00
85083ca5ab
Enable avoid_return_types_on_setters in analysis_server
...
Change-Id: Idc4a05c30ce153d59d3b9e96b3803b18dc8c6edb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133437
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-28 16:25:18 +00:00
59e8068169
Introduce and use a new class to compute the mean reciprocal rank after a run of the code completion metrics execution.
...
Change-Id: I72ee7fdc500d6310231b3b03a2722e63feee251a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133439
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-28 07:43:37 +00:00
c352c6c0b8
Cleanup and refactoring in completion_metrics.dart
...
Change-Id: I46dd8b9f05d44dcb1d3d2f1088b95845427005c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133428
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Jaime Wren <jwren@google.com >
2020-01-27 19:41:19 +00:00
a6e01c23e2
Fix more windows tests in migration tool
...
No need to HTML-escape the root path; no HTML will be included.
Change-Id: Ibf9a19000a11207782b7b0d0f9222397f6d042fc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133426
Reviewed-by: Paul Berry <paulberry@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-27 19:08:56 +00:00
548127daa1
Fix Windows analyzer tests.
...
Don't map the unit path in the region renderer.
Change-Id: I2c947302626e320dea587efc0240316fc62d0dc1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133164
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2020-01-27 16:16:06 +00:00
81c5d11691
Change tests of lint-based quick fixes to not require the lint marker in the result
...
Change-Id: I2a7e35c9754a5108e3d664684b8c2109b5689c58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133409
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2020-01-27 01:48:25 +00:00
pq