c7d0e325d7
[Elements.migrate] Migrate CandidateSuggestion.
...
Change-Id: I664ab34e7c674582d98f3c75d3fffe41d8cf8be5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-11-19 18:14:27 +00:00
d38e0ff148
[analysis_server] Migrate LSP "Go to Type Definition" to new element model
...
Change-Id: I4de207adc9301b2533885d51329ccc0b6600b86d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-11-19 18:07:04 +00:00
6dac184012
Adds library result
...
R=scheglov@google.com
Fixes https://github.com/dart-lang/sdk/issues/57092
Change-Id: I125c53e138c97e57fc22d69b2362351ddcbb6b4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395420
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
2024-11-19 15:50:42 +00:00
779a433d55
Migrate four computer classes
...
Change-Id: I9d5a9cd8c85ef703938aecb4e233467917f73aac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396101
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-11-19 01:05:45 +00:00
ad8c44f3d9
[Elements.migrate] Migrate LibraryElementSuggestionBuilder
...
Change-Id: I56dde963754fbaf5012f7229fa5a37441c210c4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396140
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-11-18 23:47:10 +00:00
478aba8bf2
Migrate flutter support
...
Change-Id: I52899ecc30b2db3e4990df523c2b0bbd19d46e95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395704
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-11-18 22:39:18 +00:00
e5274a522e
DAS: Use new package:args API for less casting
...
Change-Id: Ib0fbdebb6c703202f13330d7bf53eade26fa73de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/396040
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Auto-Submit: Samuel Rawlins <srawlins@google.com >
2024-11-18 19:34:39 +00:00
17a2f16926
Elements. Add PropertyAccessorElement2 and PropertyAccessorFragment.
...
I found a number of places where we need to access `variable3`, so
it might be convenient to have a common interface that provides it.
Still, there are many places where we want to know that this is
specifically `GetterElement`, to separate interfaces for them are
also useful.
Change-Id: Ib671dc3bdb9a04a022fd74921f8ccedcdba79643
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395701
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-18 17:36:50 +00:00
1293500b0c
Elements. Migrate AssignmentVerifier.
...
Change-Id: I45a3c4df63250c611f011d61023ed74485145b78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395780
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-18 16:57:21 +00:00
b80fdcb683
Elements. Migrate ErrorDetectionHelpers.
...
Change-Id: I50b08924a4be96210378a9ad56a9d671a030d5f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-11-18 16:56:39 +00:00
73adec7b6f
Migrate bulk_fix_processor.dart
...
Change-Id: I5385c0237d37ddf808609897dc846f100b11cd5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395703
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-11-16 15:26:19 +00:00
052c9852c4
[DAS] Fixes hover for mixin on abstract implemented type
...
R=srawlins@google.com
Bug: https://github.com/dart-lang/sdk/issues/57097
Change-Id: Ia67ebb1dbca9e8b3a63e2a26dbb7234385b4bdf4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395562
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
2024-11-16 00:12:00 +00:00
34d945cb7c
Migrate more server tests
...
Change-Id: Iee3e6b6db9c58e9fcf790e2874f73c8eac6e660d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395404
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-11-15 21:57:47 +00:00
359aa743ff
Elements. Add LibraryElement2.uri
...
We used it often enough, and the question "what is the URI of the library" makes sense.
Change-Id: I58baebd7b32154ae7a2f90770e4edcade8a49a63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-11-15 21:52:00 +00:00
3f7df09ddb
analyzer: Rename analysis options YAML keys variables
...
We rename `AnalyzerOptions` to `AnalysisFileOptions`, and change it's
comment from "`analyzer` analysis options constants." to avoid anyone
thinking it is specifying options for the `analyzer` section.
Additionally I privatize some of the static values that are only
present for validation - they are not meant to be used outside of
`options.dart`: `AnalyzerSection._trueOrFalse`,
`AnalyzerSection._options`, `AnalyzerSection._strongModeOptions`,
`AnalyzerSection._languageOptions`, `LinterSection._options`.
I also rename `_TopLevelAnalyzerOptionsValidator` to
`_AnalyzerTopLevelOptionsValidator` to align with
`_LinterTopLevelOptionsValidator`.
Change-Id: I4f5735d8bda8edbaf066387b473c05969c3ba7d5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395060
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-15 21:41:29 +00:00
8aa0bf58ab
analyzer: move constant-evaluation lint utilities to their own library
...
These utilities are distinct from the base classes like AnalysisRule and
LinterContext. And their import requirements are also distinct. Separating them
in the filesystem should simplify how we slice up the public API.
Change-Id: I365c48c41e5d3db1e3aa649fd70b94cd7da1b069
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395561
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-15 17:55:29 +00:00
7b71ed17b2
Introduce the lint unsafe_variance
...
This CL implements a new lint, `unsafe_variance`. This lint emits a
warning whenever an instance member declaration has a signature where
a type variable declared by the enclosing class/mixin/enum occurs in
a non-covariant position in the return type (including the type of
an instance variable).
Issues: https://github.com/dart-lang/linter/issues/4111 , with goals related to https://github.com/dart-lang/language/issues/296 and https://github.com/dart-lang/language/issues/524 .
Change-Id: I1352d71d61fece03a432ccf0d98825a69e3a457f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/384700
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Erik Ernst <eernst@google.com >
2024-11-15 09:28:52 +00:00
3515a199ce
DAS plugins: Start enforcing an analyzer constraint
...
Change-Id: Ie2f987edfd4da9c2e45298a65e645b9fb9f80670
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395261
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-15 01:04:01 +00:00
843c47b9a1
Migrate more tests in analysis_server
...
Change-Id: I14885a2b5ea4fd89b14ae52124d800a2b24ccad0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395401
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-11-14 21:45:50 +00:00
44371eb9be
Elements. Migrate ConstructorFieldsVerifier.
...
Change-Id: I107ca230fefeca373c64a7ca30a0df3ee99724f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395342
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-11-14 21:28:34 +00:00
a1516ef998
Elements. Remove 'FunctionExpressionImpl.declaredElement2'
...
Change-Id: Ie398dc23d6d5911dd02104ca4b31114d5d657153
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395050
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-11-14 21:24:31 +00:00
fab7e4b643
DAS plugins: Simplify TestPluginManager
...
Using `noSuchMethod` is an idiomatic way to "implement" unimplemented members.
Change-Id: Ifec025fc41bd9965f7461330b27990621a3ad7d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395043
Auto-Submit: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2024-11-13 21:36:15 +00:00
c8ff99dfb3
Elements. Omit '=' at the end of SetterFragment / SetterElement name.
...
Also fixes names where they were previously missing.
Change-Id: I2d16059e3871283de7c9373fb040d939bd5357ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394900
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-11-13 18:37:19 +00:00
8fa66a0a33
Migrate data-driven fix support
...
Change-Id: I8ac392d47c105225b22a32651693c3caa515eda0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/395040
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-11-13 18:36:19 +00:00
2fbb33e4d8
[analysis_server] Fix handling of null responses for LSP requests over DTD
...
The DTD client requires that the `type` field is populated in DTD responses, but this code previously would omit it when the result was `null` (because it used `result?.runtimeType`).
Change-Id: I5a6e0927e9c02f2abb690aefceca8f8b003cd43b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394484
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-11-12 22:34:48 +00:00
dfb25545c4
Rename LibraryFragmentInclude to PartInclude
...
Also renames associated getters, fixes some comments, and removes a
getter (`nameOffset`) that should have been `nameOffset2`.
Change-Id: I0dc4879c37ec14650d94933c14630176e4d1f57e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394386
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-11-12 22:23:28 +00:00
5cd0517bd6
[Element model] Migrate SuggestionBuilder
...
Change-Id: Ia01c196a56facab9ecec4fddbd1c8040bb677fe7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394421
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-11-12 20:50:32 +00:00
01165dfc43
Migrate the diagnostic pages
...
Change-Id: I8f3255bf07154ddc32c89535579dbbaa64351414
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394821
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-11-12 19:55:42 +00:00
fc7f12d3ba
[analysis_server] Add enum support for editableArguments
...
Change-Id: I453d54b837577a96c0459a9e729b16443ba3d7fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394443
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-11-12 19:44:42 +00:00
526c575fef
[analysis_server] Exclude parameter information when hovering over binary operator RHS argument
...
Similar to the previous Hover change that excluded parameter for expressions passed to setters, this does the same for binary operators (where hovering the expression on the right side would also show the parameter info).
Change-Id: I6a2eb0d60ddcc64912b09e7c69bfc44cc700c619
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392940
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-11-12 18:26:13 +00:00
5fcbb32060
[analysis_server] Migrate hovers to new element model
...
(also fixes https://github.com/dart-lang/sdk/issues/56933 )
Change-Id: I0ae66313d9c11012f42093631158c2f2df00d938
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391644
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2024-11-12 17:47:13 +00:00
fd297ae5c2
[analysis_server] Allow cancellation tokens to carry a code/reason
...
This means when we cancel requests ourselves (such as for completion/refactor when another request begins) we can provide more specific codes/reasons.
This change only uses the reason, but when the scheduler is cancelling requests (because of a `/didChange`) it could use the `ContentModified` code preserving existing behaviour where those cancellations are currently handled by the session change.
Change-Id: I48eea55aff08b15a539a1c2c6031598adb4dd069
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394444
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-11-12 17:04:56 +00:00
c1e535031d
analyzer: Simplyify propagating lint rule exceptions
...
I found that the `propagateLinterExceptions` analysis option was
being passed to the AnalysisRuleExceptionHandler class at
approximately the same point where the exception handler is called, and
also that the AnalysisRuleExceptionHandler class's `logException`
method did not _use_ the `propagateLinterExceptions` value; it just
_unconditionally_ returned it. So it gave it back to nearly the same
code that passed it in.
So we can simplify all of this by removing the `propagateExceptions`
field in AnalysisRuleExceptionHandler. But then that class has zero
fields and one method. _And_ that one method is _the only_ ,method
that is ever passed in to AnalysisRuleVisitor as the exception
handler. So remove the class altogether, and inline the method in
AnalysisRuleVisitor.
AnalysisRuleVisitor instead takes the bool value,
`shouldPropagateExceptions`, and does the right thing with it.
Additionally:
* Privatize AnalysisRuleVisitor `registry` property.
* Make AnalysisOptionsImpl `propagateLinterExceptions` property final.
Change-Id: Ia438881a3eccb3e26ebed294a7b7b8329d7961ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393902
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
2024-11-12 17:03:39 +00:00
00a3cdff40
Elements. Remove FragmentDeclaration, add 'declaredFragment' to Declaration.
...
Change-Id: I33398358d1241114b04995767d63188bb314fd6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-11-11 23:39:29 +00:00
8a5862ae66
Elements. Remove FragmentedElement.
...
Change-Id: If73caa44e64f469a16646794f96be044ad25d33f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394561
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-11 20:58:49 +00:00
6be32b412c
Elements. Migrate CiderRenameComputerTest.
...
Change-Id: Id2b113cb30c7cf8680aa79f4a50a438d61088ba5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-11-11 19:05:27 +00:00
04641dcc53
[analysis_server] Allow the client to control whether experimental handlers are registered with DTD
...
This will allow testing in-dev features with a real IDE without having to run/build the server from source.
Change-Id: I62cf732e7c4935c111f312eef25afd247759ae7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394502
Reviewed-by: Keerti Parthasarathy <keertip@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-11 18:57:22 +00:00
5f8a5b1b52
Elements. Migrate SuggestionBuilderTest.
...
Change-Id: I1fffab521aceab1f78724250588822c9e3b95e4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-11-11 18:04:07 +00:00
eb55f44637
[Completion] Do not ask for completion suggestions from plugins
...
Change-Id: I8f856a43e27f67948da249c5aae1cd53657438a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
2024-11-11 16:55:18 +00:00
613bfa673f
[analysis_server] Add a custom LSP handler to fetch editable arguments for the invocation at a position
...
This currently only supports int, double, boolean, string.
Change-Id: I236db8594907d28dc5901a384fbafdb34f243528
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394160
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Elliott Brooks <elliottbrooks@google.com >
2024-11-11 15:38:42 +00:00
36eca4c4e1
[analysis_server] Remove unused AbstractGoToHandler base class
...
As part of the element model migration, the handlers were moved off this base class and just use shared helper functions where they overlap.
Change-Id: I13fcada1cc6b680bed24d3f91ab36e15548ae7c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394482
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-11 15:29:19 +00:00
48d8741451
CQ. Tweaks for InsertOnKeyword and tests.
...
Change-Id: I7dcdcbceb775fbf07c0bc27ab38a94bc02253086
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394343
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-11-09 21:01:01 +00:00
c9391d7f19
Set obvious/property lints to hasFix
...
The lints `omit_obvious_property_types` and
`specify_nonobvious_property_types` previously had error fix status
'needsEvaluation'. This CL changes it to 'hasFix'. This is needed in
order to get access to the fix in IntelliJ.
This CL also corrects a bug whereby a map literal was considered to have an obvious type in cases where there were no actual type arguments and no elements with an obvious type.
Change-Id: Id9305152d086604b78636b696bd97e318ed6bdb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393280
Commit-Queue: Erik Ernst <eernst@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2024-11-09 16:59:49 +00:00
92663b7303
[DAS] Adds fix for expected 'on' keyword
...
R=srawlins@google.com
Fixes https://github.com/dart-lang/sdk/issues/47127
Change-Id: I316a2d29546c9edd3a808785efdbc148007c531b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392540
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2024-11-08 23:57:06 +00:00
e7aaba1254
Elements. Migrate OverrideHelper.
...
Change-Id: I645d901fd0655c33c0c147c2b08a67b4791e6186
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394360
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-11-08 23:05:39 +00:00
15cdbc5eab
Migrate five correction producers
...
Change-Id: I3289e0862797947fadf76d78a2ce27c0cf249dd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394321
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-11-08 21:08:18 +00:00
7b8de02eda
[analysis_server] Update "Go to Imports" to support enhanced parts
...
Instead of looking in a single root unit, we now look in each unit up the tree.
Change-Id: I59b0692438dd73fce7be7790ddc24240761d72c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-11-08 20:02:14 +00:00
cb5c73e06f
linter: Remove unsafe_html rule
...
Fixes https://github.com/dart-lang/linter/issues/5001
Change-Id: I972ea8f9fafda88b6a4836ab92107cebe8a6ad4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391303
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2024-11-08 18:31:59 +00:00
9682da5a45
[analysis_server] Migrate LSP "Go to Imports" command to new element model
...
Change-Id: I07f53420649b5be11088407b0344186bcb741ae8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393861
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2024-11-08 15:37:05 +00:00
ea86e0fe39
Elements. Return nullable 'LibraryFragment?' from 'get libraryFragment'.
...
We can have synthetic 'FormalParameterFragment' and 'TypeParameterFragment'
that don't have any enclosing 'LibraryFragment'.
Change-Id: Icc1a47c308e55b93ed6a2aad70788058e26ee803
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2024-11-07 21:59:29 +00:00
Keerti Parthasarathy