333054ee75
Supporting non-SSVs in CustomEvent.detail
...
BUG=12641
R=vsm@google.com
Review URL: https://codereview.chromium.org//27308006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28758 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 23:09:33 +00:00
19655e4e6b
Revert "Revert "Removing setImmediate and hiding WindowTimers interface""
...
Issue was that requestAnimationFrame got removed from Dartium during a merge conflict :(
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//27441002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28700 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:50:49 +00:00
951dca71cb
Deprecate query and queryAll, also add back querySelector and querySelectorAll.
...
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//27223003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28699 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:44:47 +00:00
8e255ada0f
Revert "Removing setImmediate and hiding WindowTimers interface"
...
This reverts commit 28690.
TBR
BUG=
Review URL: https://codereview.chromium.org//27440002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28696 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:16:59 +00:00
303710040b
Removing setImmediate and hiding WindowTimers interface
...
These timing APIs are all redundant with dart:async and those versions should be used instead.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//26534005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28690 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 23:52:09 +00:00
9baacafa7a
Making all callbacks use zones (take 2)
...
Changes: fixed parameter ordering for RTCPeerConnection.getStats and fixed error for StorageInfo.
Revert "Revert "Making all callbacks use zones""
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//27240004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28674 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 19:07:22 +00:00
c66099f078
Tighter native type annotations for some elements returning Lists
...
We need to be more careful with type annotations on native elements now that some classes implement List<dynamic>.
R=blois@google.com
Review URL: https://codereview.chromium.org//26971005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28626 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 01:45:17 +00:00
035e04fb2d
Making all base class DOM types throw as well (to prevent a default constructor for DOM types that are not constructable).
...
BUG=https://code.google.com/p/dart/issues/detail?id=11620
R=blois@google.com
Review URL: https://codereview.chromium.org//27033009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28615 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 21:58:46 +00:00
e1d441b22f
Revert "Making all callbacks use zones"
...
This reverts commit 28607, running into analyzer issues.
TBR
BUG=
Review URL: https://codereview.chromium.org//27232003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28609 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 20:23:11 +00:00
84a3415e82
Making all callbacks use zones
...
This was primarily converting APIs to use Futures, all appear to be new ones since we did the last pass.
MutationObserver and Window.requestAnimationFrame had to be fixed manually.
BUG=
R=efortuna@google.com , floitsch@google.com
Review URL: https://codereview.chromium.org//27082002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28607 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 19:49:17 +00:00
f51dad91fd
Untyping List types
...
Making all DOM lists implement List rather than List<T>. This is primarily for NodeList which is used in cases where it's just a list of Elements and allows us to assign it to List<Element> without type checks.
BUG=
R=sra@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//27227002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28597 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 18:36:59 +00:00
95c3be5481
Made index_db Cursor.next behavior consistent between JS and vm.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//26703006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28431 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 23:45:59 +00:00
33b96c8696
Pass in domData as a parameter to unwrapDartWrapper.
...
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//26051003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28353 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 03:25:48 +00:00
eaa854b258
Move Rectangle and Point into dart:math.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//25808002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28272 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 17:47:39 +00:00
19a260904e
Generate a library ID instead of a library name, so that the ID can be used
...
to get the library handles from the cache (avoids having to lookup everytime)
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//25626002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28226 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 16:21:17 +00:00
0b53b15b7d
"Reverting 28184"
...
TBR=blois
BUG=
Review URL: https://codereview.chromium.org//25785003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28186 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 22:13:16 +00:00
837c6b6ee3
Move Point and Rect over to dart:math, to be re-exported by dart:html.
...
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org//25623002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28184 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 21:54:02 +00:00
c801e99a65
Adding custom element lifecycle processing to all attribute modifiers.
...
This is needed for the custom element attributeChanged lifecycle event. It appears to be the same thing that V8 is currently doing.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//25666008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28179 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 19:48:10 +00:00
1aa8a7be0e
Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses.
...
This is for post-construction custom element creation.
Element.created is public, then the base classes of that get private ._created constructors.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24653006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 21:26:06 +00:00
d5212a6ac0
Make OptionElement construtor arguments named optional parameters.
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//25585002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28115 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 20:33:49 +00:00
354c4dd5ad
Revert "Revert "Start of dartium custom element lifecycle event support.""
...
Primary changes are that a fast-path has been added for the single-argument Document.createElement and the systemnative.py changes were split out to CL https://codereview.chromium.org/24661002/ .
This is dependent on https://codereview.chromium.org/24677002/
First patch is the original, second is the updates.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24491003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27921 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 23:15:09 +00:00
f4734449cd
Emitting CustomElementCallbackDispatcher for all APIs impacting custom element lifecycle
...
This is part of getting custom element lifecycles working in Dart and follows the same model that V8 is using. Basically it ensures that the lifecycle events are processed after any operations which may have custom element side-effects.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24661002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27910 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 20:34:33 +00:00
3854434797
Removed position and totalSize because HttpRequestProgressEvent has other fields that do the same thing.
...
Turns out position and totalSize were on Firefox 3 and earlier, but we don't
have to worry about backwards compatibility that far.
https://developer.mozilla.org/es/docs/XMLHttpRequest/Usar_XMLHttpRequest
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//24427003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27900 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 18:03:20 +00:00
3fd115d5e3
Revert "Start of dartium custom element lifecycle event support."
...
This reverts commit 27718 to see if it gets performance back down.
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//24479002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27897 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 17:56:53 +00:00
dcd741bd99
Move dart:chrome to dart:_chrome.
...
Turn off doc generation for dart:_chrome.
R=efortuna@google.com
Review URL: https://codereview.chromium.org//23654055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27861 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 23:52:16 +00:00
928894a58c
- Added Dart_GetNativeIsolateData so that the bindings code can access the IsolateCurrentData
...
where possible without having to invoke Isolate::Current()
- Modified lookupWrapper to accept DartDOMData as a parameter so that the return to Dart functions
won't invoke Isolate::Current()
Some Dromaeo numbers before this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr getAttribute runs-per-second 1162.2
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr element_property_access runs-per-second 1255.6
after this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr getAttribute runs-per-second 1237.6
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-attr element_property_access runs-per-second 1385.4
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//24376005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27789 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-23 23:53:39 +00:00
34f58a8209
Start of dartium custom element lifecycle event support.
...
These are the Dart repo changes paired with https://codereview.chromium.org/24294002/
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//23817006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27718 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 18:40:11 +00:00
ca128dea70
- Modify toDart to first do a simple lookup in the appropriate table before going down the templatized
...
morass of switch statements
- Add a returnToDart function so that the WeakPersistent Handle returned from a lookup/create of the wrapper
could be returned as is without the need to call Dart_handleFromWeakPersistentHandle
- Use Dart_SetDoubleReturnValue for doubles
some DromaeoDartium numbers before this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(div) runs-per-second 84240.6
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-traverse nextSibling runs-per-second 207.91683326669332
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(*) runs-per-second 69599.2
some DromaeoDartium numbers after this change:
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(div) runs-per-second 104252.4
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-traverse nextSibling runs-per-second 366.8
CONSOLE MESSAGE: RESULT: Dromaeo-drt dartium-dart dom-query getElementsByTagName(*) runs-per-second 94922.6
R=rmacnak@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//23681014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27710 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 16:25:12 +00:00
2a87dc5402
Give each binding class an id to be used as an index into a cache of handles on the corresponding Dart classes.
...
BUG=
R=asiva@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//23819035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27452 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 21:55:30 +00:00
d312cbbd08
Exposing document.createElement
...
As part of removing all $dom_ APIs, making this one public. There are valid scenarios for creating elements in other documents.
BUG=
R=efortuna@google.com
Review URL: https://codereview.chromium.org//24084004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27415 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-12 00:00:39 +00:00
647d73af0f
Fix for CSS URIs not parsing correctly with innerHTML
...
Chrome has a bug (https://code.google.com/p/chromium/issues/detail?id=229142 ) where CSS URIs are not converting correctly when an element is parsed in one document then moved to another document. This uses a base element to set the baseURI of the parse document so it doesn't need to be converted on clone.
BUG=13147
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23903020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27305 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 19:06:27 +00:00
4d8651f8af
1. Make direct calls to _nativeIndexedGetter in "get last" "get first" "get single" instead of calling the "[]" operator. This avoids one additional native call to the length method for each call to "last" "first" or "single"
...
2. Fix templateloader to deal with nested 'if' conditions
R=vsm@google.com
Review URL: https://codereview.chromium.org//23534050
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27270 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-06 23:22:31 +00:00
dbf675d60d
Adding conversion support for JSON XHR requests.
...
This has been a half-supported feature for Chrome for a while, but popular elsewhere. Appears that recent Dartium behavior broke, so adding a test, but still need to fix Dartium.
BUG=13069
R=efortuna@google.com
Review URL: https://codereview.chromium.org//23454012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27215 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 22:02:22 +00:00
871fbc9189
Fixing Element.shadowRoot to work with webkitShadowRoot
...
Chrome 31 changed it to shadowRoot, need to support the prefixed version as well.
BUG=13061
R=jacobr@google.com
Review URL: https://codereview.chromium.org//23576013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27203 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-05 17:47:37 +00:00
afd3921b76
Fixing JS size regression from Blink roll.
...
BUG=
R=jacobr@google.com , sra@google.com
Review URL: https://codereview.chromium.org//23481010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27163 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 22:37:48 +00:00
9f52a2969c
Added back childNodes and getAttribute and setAttribute.
...
This is a quick check to verify that it was this CL:
https://codereview.chromium.org/23189014/ was the cause of the performance
regression. If it is, I have some ideas of potential performance improvements
going forward that we should investigate, and I'll also investigate why I wasn't
getting this performance behavior on my machine locally. Either way, expect at
least one additional change on these APIs going forward.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23808005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27139 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 19:34:39 +00:00
b14e379d94
Cleaning up a bunch of DOM generation tables
...
Many unused keys and missing events, etc.
BUG=
R=efortuna@google.com , jacobr@google.com
Review URL: https://codereview.chromium.org//23889005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27137 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 18:30:54 +00:00
013e3bb062
Dart binding changes to along with Blink merge 155942-156717
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23829002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26948 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 21:24:02 +00:00
8fe0dd796d
Fixing mouse clicks on IE11 Preview
...
The previous fix works for RTM but not the current version.
TBR
BUG=
Review URL: https://codereview.chromium.org//23483025
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26937 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:27:38 +00:00
47dcd084f3
Removing more dom_ methods (dom_getAttribute and dom_setAttribute.).
...
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23189014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26928 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:18:40 +00:00
944aca6de7
HTML types that don't have [] do not implement JavaScriptIndexingBehavior, that is, the items cannot be accessed through [] in JavaScript.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//23499007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26911 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 13:27:27 +00:00
5eade2a0e6
Fixing mouse events on IE11.
...
IE11 is passing PointerEvents in place of MouseEvents.
BUG=12744
R=sra@google.com
Review URL: https://codereview.chromium.org//23479008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26890 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-29 19:52:21 +00:00
87e39090a1
Exposing native doubles as doubles when they are read-only or method return values.
...
This keeps num for parameters of operations and fields which are settable. Requested because some DOM APIs (such as Performance.now) don't really make sense returning ints.
BUG=11133
R=vsm@google.com
Review URL: https://codereview.chromium.org//21555003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26817 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 21:07:13 +00:00
93c361dd36
This is an updated version of https://codereview.chromium.org/16374007/
...
Original submission is the first patch, fixes are the second.
There were two issues with the original-
- Issue with URI sanitization where relative URIs on IE were being dropped.
- Analyzer issue on missing members for CustomElement.
BUG=
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23525003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:03:01 +00:00
24e9f22c90
Revert "First rev of Safe DOM"
...
This reverts commit 26681.
Some IE issues with URL validation that I need to investigate further.
BUG=
Review URL: https://codereview.chromium.org//23523002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26682 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 02:18:48 +00:00
63ecf1a3fd
First rev of Safe DOM
...
BUG=
R=jacobr@google.com , jmesserly@google.com
Review URL: https://codereview.chromium.org//16374007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26681 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-27 01:48:13 +00:00
90873051ad
Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
...
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.
BUG=
R=blois@google.com
Review URL: https://codereview.chromium.org//23055008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
4f6536ba66
Use new Dart API functions
...
Dart_GetNativeIntegerArgument
Dart_GetNativeBooleanArgument
Dart_GetNativeDoubleArgument
R=vsm@google.com
Review URL: https://codereview.chromium.org//22859038
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26500 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-22 01:15:58 +00:00
0820807ae6
Fixing dart2js codesize regression from blink roll.
...
New ErrorEvent.error was pulling in everything.
BUG=
R=sra@google.com
Review URL: https://codereview.chromium.org//22986022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26468 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 20:27:54 +00:00
ec11e52f62
Revert "Revert "Adding polyfill support for custom elements.""
...
This fixes the issues in the custom elements polyfills.
R=jmesserly@google.com
Review URL: https://codereview.chromium.org//23301012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26412 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 00:08:46 +00:00
blois@google.com