Commit Graph

1167 Commits

Author SHA1 Message Date
blois@google.com 51802fcac3 Fixing custom event test on IE
For some reason, Event.preventDefault on IE is not triggering defaultPrevented back at the call site.
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//27536010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28767 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-17 00:05:39 +00:00
blois@google.com 333054ee75 Supporting non-SSVs in CustomEvent.detail
BUG=12641
R=vsm@google.com

Review URL: https://codereview.chromium.org//27308006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28758 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 23:09:33 +00:00
blois@google.com aa578e1395 Updating element_offset status
Test was marked as flaking on dart2js because of 13296, but is now flaking on Dartium.

BUG=
R=dgrove@google.com

Review URL: https://codereview.chromium.org//26247008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28747 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 20:41:39 +00:00
blois@google.com fc6e40c7e3 Minor tweak to indexeddb_3 test transaction handling
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//26554008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28733 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 16:33:26 +00:00
ajohnsen@google.com c4c19f058a Wait for transaction to complete, before continuing.
This is now required, since futures will be completed within the same
transaction window.

BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//27490003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28720 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 12:16:57 +00:00
blois@google.com 19655e4e6b Revert "Revert "Removing setImmediate and hiding WindowTimers interface""
Issue was that requestAnimationFrame got removed from Dartium during a merge conflict :(

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//27441002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28700 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:50:49 +00:00
blois@google.com 8e255ada0f Revert "Removing setImmediate and hiding WindowTimers interface"
This reverts commit 28690.

TBR
BUG=

Review URL: https://codereview.chromium.org//27440002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28696 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-16 00:16:59 +00:00
blois@google.com 303710040b Removing setImmediate and hiding WindowTimers interface
These timing APIs are all redundant with dart:async and those versions should be used instead.

BUG=
R=efortuna@google.com

Review URL: https://codereview.chromium.org//26534005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28690 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 23:52:09 +00:00
justinfagnani@google.com 03eb80a189 Maintain referential integrity of proxy instances in dart:js
Rename DartProxy to DartObject in JavaScript to be symmetrical with JsObject

R=ahe@google.com, alexandre.ardhuin@gmail.com

Review URL: https://codereview.chromium.org//26092003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28686 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-15 21:43:16 +00:00
blois@google.com ceb07acde3 Fixing status of document.register test for dart2js tests
I added this test for Dartium, but it's failing on dart2js.

TBR
BUG=

Review URL: https://codereview.chromium.org//27220003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28606 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 19:45:07 +00:00
blois@google.com 5a06040888 Dart changes for https://codereview.chromium.org/26571005/
Ensuring that custom elements have correct super classes.

BUG=

Review URL: https://codereview.chromium.org//27222003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28603 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 19:29:42 +00:00
blois@google.com 6d3acc0175 Test fixes for CustomElement upgrade changes
This is the Dart portion of https://codereview.chromium.org/27183006

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//26700003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28598 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 18:38:28 +00:00
ricow@google.com f69c05d133 Remove suppression for failure in html/svgelement_test/supported_feMerge
This is already being considered in issue 13292 and does not seem to be specific to one test

R=floitsch@google.com

Review URL: https://codereview.chromium.org//27158003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28579 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-14 12:32:45 +00:00
floitsch@google.com 0b913e72f6 Mark supported_feMerge test as flaky.
Review URL: https://codereview.chromium.org//27105002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28571 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 17:00:42 +00:00
floitsch@google.com 0f7a0bd7b1 Rename runAsync to scheduleMicrotask.
R=lrn@google.com

Review URL: https://codereview.chromium.org//26151002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28569 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 15:52:17 +00:00
blois@google.com acd549dc41 Fixing status of Dartium custom element tests
Tests were failing because they did not have custom elements enabled, change to enable them by default changed the status.

TBR
BUG=

Review URL: https://codereview.chromium.org//27055006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28559 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 22:03:25 +00:00
justinfagnani@google.com cee2b116ce Revert "Maintain referential integrity of proxy instances in dart:js"
This reverts commit bf87105c535cd2f6fa28904547b4e9f2804bc301.

BUG=

Review URL: https://codereview.chromium.org//26742008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28557 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 21:28:15 +00:00
justinfagnani@google.com b2316c569a Maintain referential integrity of proxy instances in dart:js
Rename DartProxy to DartObject in JavaScript to be symmetrical with JsObject

R=ahe@google.com, alexandre.ardhuin@gmail.com

Review URL: https://codereview.chromium.org//26092003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28547 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-11 20:24:18 +00:00
efortuna@google.com ef9419dc95 Convert keys in dataSet to camelCase instead of dasherized.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//26917002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28482 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 21:42:13 +00:00
blois@google.com c2f5471669 Removing Element.createdCallback
This was a placeholder for before dart2js converted to the constructor, can now be removed.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//26592009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28465 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 16:59:19 +00:00
efortuna@google.com a8f1004971 Add "matchingTarget" function to Event, which is the Element that matched the CSS value selector.
Bug fix for https://code.google.com/p/dart/issues/detail?id=12931

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//26722002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28430 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 23:43:20 +00:00
vsm@google.com 334fd6bf07 Mark spawnFunction tests as Fail on Dartium
See corresponding Dartium CL:
https://chromiumcodereview.appspot.com/26397003/

This disables spawnFunction on DOM enabled isolate (i.e., where
dart:html is available).  spawnFunction should continue to work on
non-DOM enabled isolated.  spawnUri should be unaffected.

R=asiva@google.com

Review URL: https://codereview.chromium.org//26616002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28406 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-09 16:25:28 +00:00
efortuna@google.com 4a96ec62b6 Dartium KeyEvent fix.
BUG=

Review URL: https://codereview.chromium.org//26561004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28377 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 20:31:22 +00:00
efortuna@google.com 79d6ca8285 Reapply KeyEvent improvements.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//26279008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28370 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 18:10:24 +00:00
blois@google.com 108dec86bd Fixing Node.clone not returning upgraded custom elements.
This was an issue for Polymer as the templates are cloned with shallow clones.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//25719003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28363 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-08 16:02:49 +00:00
efortuna@google.com 9c5078b378 "Reverting 28321"
BUG=

Review URL: https://codereview.chromium.org//26334002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28323 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 20:11:16 +00:00
efortuna@google.com 6c98cf8ddf Removed KeyName test since KeyName has gone away.
BUG=

Review URL: https://codereview.chromium.org//26332002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28322 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 19:55:39 +00:00
efortuna@google.com c5fe58c61c Fully polyfill KeyEvent so that you can programmatically create your own "keyboard" events.
Added some test cases as well.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//23455033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28321 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-07 19:40:17 +00:00
efortuna@google.com eaa854b258 Move Rectangle and Point into dart:math.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//25808002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28272 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 17:47:39 +00:00
kustermann@google.com 14dce1057e Second round of status file updates after enabling none-dartium tests on dartium-inc builders
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//25892008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28265 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 14:32:38 +00:00
kustermann@google.com edacf33810 Status file update for none-dartium
R=kasperl@google.com

Review URL: https://codereview.chromium.org//25896005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28254 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 09:25:26 +00:00
blois@google.com c6b1d91f34 Implementing custom element's attributeChanged callback in Dartium
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//25793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28232 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 17:37:51 +00:00
vsm@google.com 8480c79e54 Remove spawnDomIsolate code
This is more or less a straight remove of code.  By disabling print and timers on background isolates in Dartium, we can get rid of the last vestiges of spawnDom*.

R=asiva@google.com

Review URL: https://codereview.chromium.org//25536007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28191 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-03 03:20:00 +00:00
efortuna@google.com 0b53b15b7d "Reverting 28184"
TBR=blois

BUG=

Review URL: https://codereview.chromium.org//25785003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28186 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 22:13:16 +00:00
efortuna@google.com 837c6b6ee3 Move Point and Rect over to dart:math, to be re-exported by dart:html.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//25623002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28184 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 21:54:02 +00:00
justinfagnani@google.com c282ae9d65 Cache the context proxy. Don't use window for global 'this'.
BUG=
R=ahe@google.com, alexandre.ardhuin@gmail.com, vsm@google.com

Review URL: https://codereview.chromium.org//25138003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28181 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 21:06:57 +00:00
blois@google.com 48463b9ba9 Merge issue with html.status test exclusion
Not sure why, but this got added back (I had fixed it yesterday).

TBR
BUG=

Review URL: https://codereview.chromium.org//25456004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28170 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 16:55:19 +00:00
blois@google.com 05bb03642d Implementing CustomElement's attributeChanged callback in dart2js.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//25325004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28168 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 15:57:56 +00:00
kustermann@google.com 9a5ca71a0f Followup status file update after co19-roll to r607: move suppressions to correct status file
TBR=kasperl@google.com

Review URL: https://codereview.chromium.org//25718003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28165 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 14:44:37 +00:00
kustermann@google.com ce566e52d0 Followup status file update for ie9 after co19-roll to r607
TBR=kasperl@google.com

Review URL: https://codereview.chromium.org//25728002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28164 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 14:08:07 +00:00
kustermann@google.com 5e7d3f4a3b Remove status file entries referring to non-existent tests
R=kasperl@google.com

Review URL: https://codereview.chromium.org//25649005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28162 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 13:50:13 +00:00
kustermann@google.com 22d20313b4 Implement testing support for "--compiler=none --runtime=dartium"
This is implemented without the broken unittest-based wrapping of tests.

R=kasperl@google.com

Review URL: https://codereview.chromium.org//25514002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28141 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 07:37:50 +00:00
blois@google.com c71f315c8d Fixing analyzer issues in tests.
BUG=

Review URL: https://codereview.chromium.org//25614002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28124 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 22:01:25 +00:00
blois@google.com 1aa8a7be0e Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses.
This is for post-construction custom element creation.

Element.created is public, then the base classes of that get private ._created constructors.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24653006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 21:26:06 +00:00
blois@google.com 1cd1624b46 Fixing File API test.
This started failing from a chrome roll, and is now half-failing on the bots as the Chrome version upgrades. Appears that the EntryArray type was removed, so this adds it back.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org//25603002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28118 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 21:09:57 +00:00
efortuna@google.com d5212a6ac0 Make OptionElement construtor arguments named optional parameters.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//25585002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28115 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 20:33:49 +00:00
blois@google.com 5eed34b47d Running entered & left view events in Dartium
BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28023 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-27 19:48:53 +00:00
floitsch@google.com 2b550970e6 Run DOM callbacks in the zone they are coming from.
This CL is an adapted version of: https://chromiumcodereview.appspot.com/23054006/

R=blois@google.com

Review URL: https://codereview.chromium.org//24509004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27961 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-26 16:50:25 +00:00
blois@google.com 354c4dd5ad Revert "Revert "Start of dartium custom element lifecycle event support.""
Primary changes are that a fast-path has been added for the single-argument Document.createElement and the systemnative.py changes were split out to CL https://codereview.chromium.org/24661002/.

This is dependent on https://codereview.chromium.org/24677002/

First patch is the original, second is the updates.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24491003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27921 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 23:15:09 +00:00
efortuna@google.com 3854434797 Removed position and totalSize because HttpRequestProgressEvent has other fields that do the same thing.
Turns out position and totalSize were on Firefox 3 and earlier, but we don't
have to worry about backwards compatibility that far.
https://developer.mozilla.org/es/docs/XMLHttpRequest/Usar_XMLHttpRequest

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//24427003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27900 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-25 18:03:20 +00:00