2f0d13af3b
Fix yield statements in catch blocks
...
This is a partial fix for issue 22300. The VM no longer setfaults when
using yield in try statements. Yield in catch blocks work. What’s still
not working right is if a value is yielded before an exception is
propagated to the caller.
R=regis@google.com
Review URL: https://codereview.chromium.org//914303006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43707 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-12 00:12:07 +00:00
ea16b41a0b
Fix race condition an isolate is being added to the isolate list before the name for the isolate is setup, the service isolate starts registering the isolate and accesses the name which is NULL.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//918823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43706 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 23:39:43 +00:00
163f1c2244
Improve _toInt64() and _toUint64() conversions in TypedData.
...
Add missing conversions of exponent and modulus in Bigint.modPow().
Fix typos in Bigint Classic reduction (modPow tests coming in later cl).
Address a few more TODOs.
R=srdjan@google.com
Review URL: https://codereview.chromium.org//916153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43697 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 20:57:33 +00:00
be70a52106
Reorder includes and remove platform/globals include
...
TBR=sgjesse@google.com
Review URL: https://codereview.chromium.org//915083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43693 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 17:24:37 +00:00
dbd56a9b5c
Add unittest for CircularLinkedList + bugfix
...
BUG=
R=whesse@google.com
Review URL: https://codereview.chromium.org//914203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43691 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 16:20:18 +00:00
f7a97fa4d4
VM: Fix slow-path deoptimization environment.
...
The number of pushed arguments needs to be accounted for.
BUG=dartbug.com/22331
R=vegorov@google.com
Review URL: https://codereview.chromium.org//914133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43681 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 13:34:15 +00:00
70ca358a33
Send destroy events for each closed listening socket instead of waiting for all listening sockets to be done
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//914103002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43680 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 11:34:47 +00:00
615d1a01ac
Reland "Introduce optional 'bool shared' parameter to ServerSocket.bind() ..."
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//913753002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43678 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 10:01:20 +00:00
4de5f89b99
Rename IsConstructor to IsGenerativeConstructor.
...
This matches the terminology in the spec, and it avoids confusion with the function kind kConstructor, which indicates either a generative constructor or a factory constructor.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//910313002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43673 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-11 00:59:19 +00:00
58c14696fb
Fix a windows build issue
...
../../dart/runtime/vm/flags.cc:58:26: error: invalid suffix on literal; C++11 requires a space between literal and identifier [-Wreserved-user-defined-literal]
OS::Print("%s: %"Pu64" (%s)\n", name_, *this->uint64_ptr_, comment_);
R=regis@google.com
Review URL: https://codereview.chromium.org//909253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43669 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 21:30:28 +00:00
8c24d57e15
Update test status for slow ASAN bot.
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//916473003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43664 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 19:58:35 +00:00
8e7752f56b
Fix bug in processing of latent breakpoints
...
Debugger hangs when encountering a url that has no match
in any of the loaded libraries.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//872643008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43662 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 19:11:56 +00:00
c2da2d9830
Make ASAN/MSAN ignore Dart frames.
...
Frames initialized by generated code are unknown to ASAN/MSAN, so we must explicitly mark it as initialized.
For some (unknown) reason, this only caused failures on the build bot.
TBR=asiva@google.com
Review URL: https://codereview.chromium.org//915723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43661 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 18:43:27 +00:00
d50fe1db24
Make instruction counter in simulators 64-bit (issue 22302).
...
This requires supporting uint64_t flag values.
R=zra@google.com
Review URL: https://codereview.chromium.org//898093003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43660 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 17:41:01 +00:00
700bea9f78
Parenthesize expression using bit-wise and on windows
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//895533006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43640 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 12:17:54 +00:00
7b7ac3620a
Add support to specify the source address for socket connect
...
BUG=http://dartbug.com/22253
R=kustermann@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//908873002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43638 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 11:56:51 +00:00
f0e8ff5381
Fix mac build: Add new disable_tokens=false value to super constructor call
...
Review URL: https://codereview.chromium.org//899593004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43634 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 10:34:35 +00:00
1c7ef3c4f2
Implement mac support for having multiple Dart_Port's registered on one OS socket
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//908183002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43632 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 10:15:33 +00:00
74c0f65c89
Implement windows support for having multiple Dart_Port's registered on one OS socket
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//910863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43631 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 10:08:49 +00:00
91e7a32eb5
Remove SetNonBlocking/SetBlocking methods from Socket and add missing close-on-exec
...
The methods SetNonBlocking/SetBlocking on Sockets where not implemented on Linux
and not used on Windwsm. Removed and call directly to FDUtils when needed.
In Socket::Accept setting close on exec was missing on OS X and Android.
R=kustermann@google.com
BUG=
Review URL: https://codereview.chromium.org//907883002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43627 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-10 07:29:36 +00:00
20efd2f0c4
Add Log::VPrint and remove duplicated code.
...
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org//913603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43624 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 23:28:47 +00:00
420aa94c56
Split profiler.cc into profiler.cc and profiler_service.cc
...
BUG=
R=asiva@google.com
Review URL: https://codereview.chromium.org//864173008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43623 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 23:22:19 +00:00
81d8099650
Redesign inlining interval computation.
...
Review URL: https://codereview.chromium.org//904763003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43622 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 23:11:05 +00:00
23763129a5
Fix missing new lines in disassembly
...
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org//908853005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43621 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 22:58:16 +00:00
e1f31e1513
Add a working command line debugger to Observatory.
...
Try it!
Review URL: https://codereview.chromium.org//866663003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43618 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 22:03:31 +00:00
22054b3119
Make yield* throw an error if not yielding an Iterable
...
Fixes issue 22323
R=gbracha@google.com
Review URL: https://codereview.chromium.org//910923002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43616 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:47:12 +00:00
ccc8865226
Random-walk fuzzer for the Dart VM.
...
Start with all the classes and libraries and various interesting values. Repeatedly choose one as a receiver, construct a message it is likely to understand, send the message, and add the result.
R=groebert@google.com
Review URL: https://codereview.chromium.org//801113003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43615 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:32:37 +00:00
74469b2a9f
Use printf("%s", str); to avoid glibc assertion
...
BUG=
Review URL: https://codereview.chromium.org//911713002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43614 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 21:28:54 +00:00
ddbefcab7e
Fix disassembly comments
...
BUG=
Review URL: https://codereview.chromium.org//914463002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43610 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 20:57:41 +00:00
635ba4bbd9
Port flow_graph*, disassembler to ISL_Print
...
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org//907093002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43609 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 20:49:32 +00:00
fee26a9bbb
Fix Linux build
...
BUG=
Review URL: https://codereview.chromium.org//901303005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43605 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 19:06:55 +00:00
a6483aefd1
Per isolate Log with block support
...
BUG=
R=srdjan@google.com
Review URL: https://codereview.chromium.org//913503004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43604 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 18:54:20 +00:00
9705799256
Adds dart_debug parameter to GN build.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//905753003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43602 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 17:02:12 +00:00
e5f3e69eeb
Add --print-flow-graph-filter to allow filtering debugging output.
...
Extend filtering pattern with % symbol: xyz% matches names that end at "...xyz".
R=fschneider@google.com
BUG=
Review URL: https://codereview.chromium.org//905363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43598 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 16:26:46 +00:00
56853c6bc9
Undo unnecessary changes to ARM assembler.
...
R=zra@google.com
Review URL: https://codereview.chromium.org//885443012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43596 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 16:14:11 +00:00
df94b27666
VM: Align implementations of assembler constant pools.
...
Add Support for adding patchable/non-patchable entries on ARM/MIPS like
already done for x64/ARM64.
R=vegorov@google.com
Review URL: https://codereview.chromium.org//886173003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43589 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 11:47:36 +00:00
ebde0dbaeb
Extract common Mask/Dart_Port settings of linux event handler implementation to eventhandler.h
...
R=sgjesse@google.com , wibling@google.com
Review URL: https://codereview.chromium.org//905733002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43585 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-09 08:50:32 +00:00
62a1d34c36
Clarify result returned by remainder intrinsics.
...
R=zra@google.com
Review URL: https://codereview.chromium.org//905653004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43576 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 22:42:53 +00:00
f3387ccc3f
In this first version, we just track the set of objects and verify that calls to release match. The next step is to copy the data to a side buffer, which is then unmapped on release to catch use-after-release bugs.
...
Explicitly disallow nested acquires, since the visibility of writes would depend on whether data is acquired in-place.
Also explicitly disallow other access to the data (e.g., trough list accessors) for the same reason.
R=asiva@google.com
Review URL: https://codereview.chromium.org//905823002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43575 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 22:31:46 +00:00
8e5cd57b7e
Add modPow(int exponent, int modulus) method to int abstract class.
...
Provide a dart2js implementation.
R=floitsch@google.com , lrn@google.com
Review URL: https://codereview.chromium.org//896393004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43572 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 21:46:32 +00:00
0edad1cc7c
Fix Dartium DEBUG failures by ensuring proper scoping within GC prologue/epilogue.
...
This ensures that the zone-allocating parts of ScavengeVisitor and MarkingVisitor are destroyed before the Dartium GC epilogue deletes the zone in which they were allocating.
(This only explains DEBUG mode failures, caused by the zapping in the GrowableArray destructor, because the values of the arrays are not used after the epilogue runs.)
BUG=dart:22224
R=asiva@google.com
Review URL: https://codereview.chromium.org//896133003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43558 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 17:38:39 +00:00
253de5e60a
Fix race condition in Redirection global list using CAS.
...
Note that a simple Mutex cannot be used, since the profiler may interrupt the thread at any point, and also walks this list.
Review URL: https://codereview.chromium.org//898123002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43557 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 15:50:08 +00:00
7cfc0d2e78
Fix checked mode failure in _asyncLoadError
...
Fixes dartbug.com/22295
Review URL: https://codereview.chromium.org//877763004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43554 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 14:39:08 +00:00
3ea331e741
Introduce a kSetEventMaskCommand, some cleanups in windows eventhandler
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//900363004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43547 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 09:36:57 +00:00
6898a10c93
- Make sure to fail early if an non-stacktrace is passed into the VM
...
where we expect one.
Review URL: https://codereview.chromium.org//908433002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43546 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 09:23:57 +00:00
96bed4dd79
Add missing call to VerifiedMemory::Accept when initializing Smi field.
...
BUG=dart:22224
R=asiva@google.com
Review URL: https://codereview.chromium.org//898453009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43533 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-06 00:02:29 +00:00
a7f50cd5d2
Move CircularLinkedList to eventhandler.h
...
Move constants and InterruptMessage to eventhandler.h
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43524 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 21:45:47 +00:00
00366dcfa1
Fix Windows build
...
Review URL: https://codereview.chromium.org//903843002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43522 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 21:00:02 +00:00
a28a13d936
Attempt to fix the Windows build
...
Review URL: https://codereview.chromium.org//901263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43518 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:33:37 +00:00
06f06cd029
Fixed Window's Debug warning, results in compilation failure.
...
Reviewers=asiva@google.com
R=asiva@google.com
Review URL: https://codereview.chromium.org//904603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43517 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-05 19:30:16 +00:00
hausner@google.com