- it renames '_postMessage' so that it can be overriden by configurations that don't need it.
- it splits the onDone callback in two: onSummary - a callback with all the results, and onDone - a callback with just the end result. The idea is that onSummary is mostly dedicated to reporting results, while onDone is about notifying that unittest is done. This split is very useful for subclasses that only want to override onSummary or onDone.
Review URL: https://codereview.chromium.org//11829045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16899 260f80e4-7a28-3924-810f-c04153c831b5
Process object only when the process has been successfully started.
This is less error prone since you can use all the methods on a
Process object as soon as you can get your hands on it. Unfortunately,
this change leads to quite a few changes in test.dart. Some of those
changes will fix bugs as well. We used to have a problem with a
timeout that could fire just in between two steps in a chain of
commands that constitute one test run. This change should address
that issue as well.
BUG=dartbug.com/5305
Review URL: https://codereview.chromium.org//11091070
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13729 260f80e4-7a28-3924-810f-c04153c831b5
Here is a simple example test:
#library('sample');
#import('dart:html');
#import('pkg:unittest/unittest.dart');
main() {
group('foo', () {
test('test 1', () {
document.body.nodes.add(new Element.html("<p>Test 1</p>"));
});
test('test 2', () {
document.body.nodes.add(new Element.html("<p>Test 2</p>"));
});
});
}
And a sample matching .render file:
[foo test 1]
RenderBlock {P} at (0,0) size 284x20
RenderText {#text} at (0,0) size 38x19
text run at (0,0) width 38: "Test 1"
[foo test 2]
RenderBlock {P} at (0,0) size 284x20
RenderText {#text} at (0,0) size 38x19
text run at (0,0) width 38: "Test 2"
Note that the render content is only the content inside the <body> element, not including the body element itself.
testrunner can generate render files itself if you use the --generate-renders flag.
Also in this change - rename Configuration.log to trace, to avoid clash with the math log() function.
Review URL: https://chromiumcodereview.appspot.com//10914049
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11994 260f80e4-7a28-3924-810f-c04153c831b5
floitsch@google.com