Commit Graph

5 Commits

Author SHA1 Message Date
ager@google.com 33be759e00 Fix debugger test.
1. Fix JSON import.

2. Add exit code check to catch such errors in the future.

3. Only kill the debugee on errors. If there are no errors
   it will die on its own with exit code 0. If we kill it
   explicitly it can get killed (and give exit code != 0)
   before it has the chance to exit on its own.

R=sgjesse@google.com,tball@google.com,hausner@google.com
BUG=

Review URL: https://codereview.chromium.org//12086080

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17889 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 09:09:05 +00:00
ager@google.com a1a92ba40e Revert "Fix debugger test that broke with the change to the json library."
Unfortunately, the buildbots did not like that. Reverting back to the
broken test.

R=whesse@google.com,hausner@google.com
BUG=

Review URL: https://codereview.chromium.org//12091067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17849 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 15:24:46 +00:00
ager@google.com b8cc58013b Fix debugger test that broke with the change to the json library.
Added checking of the debugger subprocess exit code that would
have caught this.

R=whesse@google.com,hausner@google.com
BUG=

Review URL: https://codereview.chromium.org//12100003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17846 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 14:23:01 +00:00
hausner@google.com ec0d716bdd Address Siva's and Mads' review request in debugger test
Review URL: https://codereview.chromium.org//11645025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16346 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 22:05:58 +00:00
hausner@google.com 1e41380676 Add basic standalone debugger test
Tests the wire protocol API to the VM debugger engine. This is a first,
basic test. Additional functionality will be added later to check the
expected value of variables, list libraries, scripts, breakpoints etc.
Review URL: https://codereview.chromium.org//11576053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16327 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 17:08:43 +00:00