Commit Graph

57 Commits

Author SHA1 Message Date
floitsch@google.com 0672317bec Remove deprecated mappedBy.
Committed: https://code.google.com/p/dart/source/detail?r=18575
Reverted: http://code.google.com/p/dart/source/detail?r=18576

Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18579 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:57:18 +00:00
floitsch@google.com ad839e6957 Revert "Remove deprecated mappedBy."
This reverts commit 18575.

Review URL: https://codereview.chromium.org//12207205

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18576 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:23:22 +00:00
floitsch@google.com b37100770b Remove deprecated mappedBy.
Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18575 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:18:17 +00:00
blois@google.com 432aa0994c Renaming Element.dataAttributes to Element.dataset.
Element.dataset is the DOM version of the API, so we should have ours named the same.

Opened bug #8545 that we should optimize Element.dataset to use the native functionality if present.

BUG=5963

Review URL: https://codereview.chromium.org//12262048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18533 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 19:12:38 +00:00
blois@google.com b4fa823142 Updating Element.scrollIntoView to be platform independent.
BUG=

Review URL: https://codereview.chromium.org//12226129

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18498 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-14 00:40:03 +00:00
blois@google.com 5fbee6d62f Fixes for TransitionEvent changes.
Two changes-
Removed the extends clause for _WebKitTransitionEvent which caused an issues with dartc.
Platform-independent changes for firing the event broke element_test on non-Chrome browsers. This test is actually quite useless.

BUG=

Review URL: https://codereview.chromium.org//12224080

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18278 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-08 21:47:49 +00:00
lrn@google.com 9b23dff467 Reapply "Rename mappedBy to map."
This reverts commit r17907.

TBR.

Review URL: https://codereview.chromium.org//12090093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 15:12:56 +00:00
floitsch@google.com b1a118d5ce Revert "Rename mappedBy to map."
This reverts commit 17899.

Review URL: https://codereview.chromium.org//12087103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17907 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 14:02:27 +00:00
lrn@google.com 0dc2f4b1ba Rename mappedBy to map.
Retain a deprecated mappedBy for now.
Change return type of mappedBy, skip and take on List to Iterable.

BUG= http://dartbug.com/8063
BUG= http://dartbug.com/8064
BUG= http://dartbug.com/6739
BUG= http://dartbug.com/7982

Review URL: https://codereview.chromium.org//12086062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17899 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 12:37:13 +00:00
blois@google.com f46672cb73 Converting tests over to using event streams.
BUG=

Review URL: https://codereview.chromium.org//12040059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17735 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 23:31:15 +00:00
blois@google.com af77086f8a Fixing element_test on Safari.
I changed computedStyle to getComputedStyle, but forgot this location.

But this test was not in a group, which with the individual config should have made the test not execute. But on Safari it's failing all of the element_test tests.

Odd thing is that it's not failing on the rest of the browsers.

Also adding a small delay for the setTimeout case as IE appears to be optimizing the 0 condition (in some cases).

TBR
BUG=

Review URL: https://codereview.chromium.org//12091006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17683 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-26 01:42:29 +00:00
blois@google.com ef8128536a Revert "Adding supported checks for Element.matches."
This reverts commit 17670 which is causing problems for IE9.

For some reason IE9 is failing the matches test but passing the supported check. But I cannot repro on my machine.

BUG=

Review URL: https://codereview.chromium.org//12091005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17678 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-26 00:34:25 +00:00
blois@google.com 7936da179e Adding supported checks for Element.matches.
BUG=

Review URL: https://codereview.chromium.org//12040101

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17670 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-25 23:29:05 +00:00
jmesserly@google.com ab1536427a Fix new Element.html with tables in IE
http://dartbug.com/7902

Review URL: https://codereview.chromium.org//11888019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17104 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 23:17:34 +00:00
blois@google.com 12dbb6aa18 Fixing Element.matches to be cross-platform and follow latest spec.
BUG=4401

Review URL: https://codereview.chromium.org//11665030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16829 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 01:30:44 +00:00
whesse@google.com 8b5189bc81 Fix some failures in html/element_test by changing where(...)[0] to where(...).first.
BUG=

Review URL: https://codereview.chromium.org//11777016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16707 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 15:12:30 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge.
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
blois@google.com 1f8e5c0d5f Updating status of tests.
After my CL to clean up the supported state of elements, element_webkit_test is now passing on all browsers.

Updating the status files and merging this test back into element_test.

TBR=efortuna
BUG=

Review URL: https://codereview.chromium.org//11615038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16554 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 21:19:30 +00:00
blois@google.com caf5849a37 Adding 'supported' checks to elements which are not supported on all platforms and adding annotations as to which platforms they are supported on.
Also refactoring tests to accurately reflect what is and is not supported on the various platforms.

BUG=

Review URL: https://codereview.chromium.org//11679007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16553 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-28 21:00:28 +00:00
blois@google.com 5690418a11 Fixing a bunch of dartc errors in dart:html tests.
BUG=

Review URL: https://codereview.chromium.org//11644061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16413 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 01:38:08 +00:00
blois@google.com 7923521eef Just cleaning up some tests to try to remove some exclusions and unnecessary failures because of acceptable platform differences.
BUG=

Review URL: https://codereview.chromium.org//11576060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16404 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 22:09:47 +00:00
blois@google.com cd347e5346 Adding support for accessing attributes in alternate namespaces.
BUG=5395

Review URL: https://codereview.chromium.org//11348111

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15347 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 21:47:53 +00:00
blois@google.com d1da6affdd Deprecating Element.elements for Element.children.
BUG=3584

Review URL: https://codereview.chromium.org//11413071

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15118 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 23:01:13 +00:00
blois@google.com 759bece562 Dartifying SVG library class names.
This CL is based on my previous CL to split out the SVG library.

Basically it renames most classes, but because of some name conflicts around Element and Document, I've skipped those. Renaming those classes will require some sizable changes to the generation code to emit library prefixes when referencing types across libs.

BUG=

Review URL: https://codereview.chromium.org//11364186

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15107 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 20:38:13 +00:00
blois@google.com ed44b9285d Splitting SVG types out of dart:html.
Beyond this CL I need to remove the SVG prefix for most of the classes, but this is an additional chunk of work.

Review URL: https://codereview.chromium.org//11398002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14808 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 21:15:06 +00:00
blois@google.com f89aca9976 Removing Element.rect.
BUG=

Review URL: https://codereview.chromium.org//11367040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14720 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-09 01:29:09 +00:00
efortuna@google.com 4a23980c8a Take 2 of splitting html tests into subtests. Had to make two changes to drt to
fully work.
Review URL: https://codereview.chromium.org//11368128

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14703 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 18:54:14 +00:00
efortuna@google.com 868b439bc4 Revert run large html tests individually.
Review URL: https://codereview.chromium.org//11406002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14667 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 00:11:09 +00:00
efortuna@google.com 3476d1c528 Run large html tests individually.
Review URL: https://codereview.chromium.org//11293019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14663 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:42:50 +00:00
gram@google.com 981c4b11df Restructure pkg/unittest and pkg/webdriver to follow the pub conventions.
This means all imports of unittest in our test code had to change to include 'lib' in the path.
While doing that change I changed the library/imports to the new syntax in the affected files.
Review URL: https://codereview.chromium.org//11301046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14443 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 23:09:47 +00:00
gram@google.com f7d27f2c64 Modified unittest to use new argument syntax.
Fix affected unit tests.
Clean up unit tests that are using Expect instead of expect.
Get rid of warnings about duplicated library names.
Review URL: https://codereview.chromium.org//11275054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14158 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-26 22:52:03 +00:00
floitsch@google.com 3300f91153 Make first and last getters.
Review URL: https://codereview.chromium.org//11273041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14082 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 15:19:31 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter.
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
lrn@google.com a083c1a108 Removed IllegalAccessException and UnsupportedOperationException.
Both were converted to StateError.

Review URL: https://codereview.chromium.org//11235054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:36:10 +00:00
blois@google.com 06f1665623 Adding synchronous measurement methods to Element. Refactoring unit tests some so element_test passes on all browsers.
Original CL was failing in checked mode because the refactored html/element_test fires multiple mouseWheel event typess to try to validate that the event functions. This causes an assertion elsewhere, which is probably a valid assertion.

I'm not sure how much we get out of this test for mouseWheel, so I don't think it's a big issue to remove it.

BUG=838

Review URL: https://codereview.chromium.org//11065017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13328 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 22:27:43 +00:00
blois@google.com 14db66f26c Revert "Adding synchronous measurement methods to Element."
This reverts commit 13246 as html/element_test is breaking on dartium.

BUG=

Review URL: https://codereview.chromium.org//11036037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13251 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 18:09:50 +00:00
blois@google.com 6ec1dff0db Adding synchronous measurement methods to Element.
I also did some refactoring unit tests some so element_test passes on all browsers- it seems quite bad that element_test was expected to fail on so many configurations. Ideally this gets refactored further when our browser support gets flushed out further.

BUG=838

Review URL: https://codereview.chromium.org//11046025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13246 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-04 17:42:06 +00:00
blois@google.com 1919b5a3ad Removing ElementList.
This includes fixes to make it work properly on Dartium checked (_ChildrenElementList.filter and _FrozenElementList.filter no longer use typed lists).

BUG=2712

Review URL: https://codereview.chromium.org//11016015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13133 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 19:51:08 +00:00
blois@google.com c6c2918caf Revert "Removing ElementList (splitting out removing NodeList into a separate CL)."
This reverts commit 13076 because of issues with queryAll in checked mode.

TBR=vsm
BUG=

Review URL: https://codereview.chromium.org//11033007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13083 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-01 19:03:57 +00:00
blois@google.com 2d71772ff0 Removing ElementList (splitting out removing NodeList into a separate CL).
BUG=2712

Review URL: https://codereview.chromium.org//10979063

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13076 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-01 17:52:52 +00:00
lrn@google.com a1faa6f135 Change IllegalArgumentException to ArgumentError.
Review URL: https://codereview.chromium.org//10989013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12841 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-25 12:27:52 +00:00
efortuna@google.com 9163dfe93c revert 1204. Will investigate when I get a chance.
TBR=rnystrom
Review URL: https://codereview.chromium.org//10928216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12413 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-15 01:21:41 +00:00
rnystrom@google.com 383488ec4f Update unittest to new package layout.
Review URL: https://codereview.chromium.org//10917275

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12404 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 21:12:17 +00:00
rnystrom@google.com 659a57df3e Revert "Make unittest follow the new package layout."
This reverts commit 38f7d16f373832a7bf889192af7845cb602aec01.

Review URL: https://codereview.chromium.org//10911318

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12400 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 19:43:10 +00:00
rnystrom@google.com 2ba81033a6 Make unittest follow the new package layout.
Review URL: https://codereview.chromium.org//10918240

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12396 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-14 18:22:24 +00:00
blois@google.com 4d29efad2f Implementing polyfills for insertAdjacent* to get them working on FF.
Refactoring IE test to pass on IE9.

This is essentially the same CL as before, but had to roll back because it broke on IE9. Specifically, insertAdjacentHTML is not supported on IE9 on table elements. It is fully supported on IE10.

BUG=3600,3685

Review URL: https://chromiumcodereview.appspot.com//10883070

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11480 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-28 21:49:41 +00:00
blois@google.com 77796d2ee3 Revert "Implementing polyfills for insertAdjacent* to get them working on FF."
This reverts commit 802cf18b82edc16584b12e6f8b8ecac2801a8051.

BUG=

Review URL: https://chromiumcodereview.appspot.com//10871088

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11405 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-27 19:04:02 +00:00
blois@google.com 19068aefb9 Implementing polyfills for insertAdjacent* to get them working on FF.
Implementing addHTML and addText.

BUG=3600,3685

Review URL: https://chromiumcodereview.appspot.com//10879080

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11399 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-27 17:27:03 +00:00
blois@google.com ef7c57676a Revert "Adding Element.AddHTML and Element.addText methods."
This reverts commit f1b1dc4f51ebbfa5f37e65cff0a638c80217f5d9.

BUG=

Review URL: https://chromiumcodereview.appspot.com//10878027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11251 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-23 19:04:27 +00:00
blois@google.com 810807a7b3 Adding Element.AddHTML and Element.addText methods.
These are to make it easier to append HTML and text to existing DOM nodes.

BUG=3685

Review URL: https://chromiumcodereview.appspot.com//10854208

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11249 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-23 18:36:29 +00:00