Commit Graph

58 Commits

Author SHA1 Message Date
sra@google.com cbd9a090ab Fix for Issue 8460.
Review URL: https://codereview.chromium.org//12221162

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18556 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 03:10:33 +00:00
erikcorry@google.com c666438c6c dart2js: In minified mode shorter getter and setter names.
Now a field called x has a getter called gx and a setter called sx in minified
mode.  Previously the getter was get$x and the setter was set$x (as in
unminified code).

This CL also fixed an assert caused by using a getter to access a
variable that is a closure object.

R=karlklose@google.com
BUG=

Review URL: https://codereview.chromium.org//12250002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18436 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-13 08:48:38 +00:00
ngeoffray@google.com d4676b580b Restrict some JS names that we might use in our JS blocks. It doesn't break for now because our JS blobs don't clash with local names.
Review URL: https://codereview.chromium.org//12049067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17904 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 13:32:49 +00:00
kasperl@google.com 38696c07a0 Fix minified version of mixin field test.
R=ngeoffray@google.com,sra@google.com
BUG=

Review URL: https://codereview.chromium.org//12082025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17706 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 12:34:02 +00:00
kasperl@google.com 8123e8fa3a Add test for native mixin fields and fix the implementation.
R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//12079022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17701 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 10:23:12 +00:00
kasperl@google.com 2e7da75aab Extends native mixin tests.
R=ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//12079020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17700 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-28 09:58:35 +00:00
johnniwinther@google.com f02c12f3c3 Private libraries used.
Review URL: https://codereview.chromium.org//11973006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17634 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-25 09:05:22 +00:00
kasperl@google.com 3dfe130fdc Allow native classes to mixin behavior from an ordinary Dart class.
This is a little bit wonky so let me know if you have great ideas
on how to make this cleaner. Clearly, we're going to need more test
cases too.

Note that trying to call mixed in methods using super will fail. If
we want that to work we have to introduce aliases for such methods.

R=sra@google.com,ngeoffray@google.com
BUG=

Review URL: https://codereview.chromium.org//12051056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17631 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-25 08:50:00 +00:00
johnniwinther@google.com 229036fa8b Internal libraries supported.
Review URL: https://codereview.chromium.org//11967010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17556 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 13:01:56 +00:00
ngeoffray@google.com c1afbd6afd Add a test that native classes work with operator==.
Review URL: https://codereview.chromium.org//12036009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17350 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-21 13:06:35 +00:00
sra@google.com 8cf801c557 Forbid arguments to functions with 'native' bodies.
This is a step towards minifying all method bodies.

Review URL: https://codereview.chromium.org//11611009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16525 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-27 22:38:37 +00:00
sra@google.com d525d08056 Remove unused variant of native JS class definition.
Remove:
class X native '=Foo' {}

This was used for Console but now we use a Dart class with methods
containing JS code.

Review URL: https://codereview.chromium.org//11660033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16507 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-26 23:49:36 +00:00
erikcorry@google.com 231cb95157 Avoid known native field names when minifying method names.
R=ahe@google.com
BUG=

Review URL: https://codereview.chromium.org//11590018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16248 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 09:57:55 +00:00
sra@google.com 3789561537 Address code-review comments for https://codereview.chromium.org//11553015
Review URL: https://codereview.chromium.org//11552012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16022 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 07:10:49 +00:00
sra@google.com ad5d5b4356 Add a fall-back for novel HTML Elements
Browsers keep adding new HTMLElements, the latest is Chrome 25 with
HTMLTemplateElement.  Rather that dying, treat unknown elements as a
plain HTMLElement.  This at least allows access to basic generic
operations, which is often all that is required.

Review URL: https://codereview.chromium.org//11553015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16020 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 06:37:53 +00:00
erikcorry@google.com 8ee476b878 Minify methods, classes and fields.
R=kasperl@google.com
BUG=

Review URL: https://codereview.chromium.org//11492006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15900 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 12:50:42 +00:00
erikcorry@google.com da08e657bc Revert minification
R=kasperl@google.com
BUG=

Review URL: https://codereview.chromium.org//11478050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15893 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 10:45:29 +00:00
erikcorry@google.com 945cfbdbe1 Reapply class/method/field minification
BUG=

Review URL: https://codereview.chromium.org//11453032

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15892 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 10:20:03 +00:00
sra@google.com bfa5afb2f9 Add @JSName annotation for native fields and methods - second try.
Review URL: https://codereview.chromium.org//11419250

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15569 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 04:45:35 +00:00
erikcorry@google.com 871f690138 Temporarily reverting class field and method name minification.
BUG=6763

Review URL: https://codereview.chromium.org//11428020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15445 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 09:26:57 +00:00
lrn@google.com 22309b260c Remove NullPointerException.
Accessing non-existing members on null now throws NoSuchMethodError.
Throwing a null value fails by throwing a NullThrownError.
Methods checking for null now generally throw new ArgumentError(null).

Committed: https://code.google.com/p/dart/source/detail?r=15061

Review URL: https://codereview.chromium.org//11415028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15136 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 09:21:52 +00:00
lrn@google.com 0c8dce77f1 Revert "Remove NullPointerException."
Crashes in the x64 VM.

Review URL: https://codereview.chromium.org//11417058

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15065 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 09:59:59 +00:00
lrn@google.com 8ff29b1d74 Update dart2js_foreign/native expectations.
TBR=ngeoffray@google.com

Review URL: https://codereview.chromium.org//11413062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15063 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 09:28:50 +00:00
gram@google.com 330ee1eb15 Updated tests/compiler/* to use new library syntax.
Review URL: https://codereview.chromium.org//11368150

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14748 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-09 18:39:05 +00:00
lrn@google.com a8720a6d9c Change signature of noSuchMethod to take an InvocationMirror.
Requires VM and dart2js/dart2dart changes to work.

Committed: https://code.google.com/p/dart/source/detail?r=14198

Committed: https://code.google.com/p/dart/source/detail?r=14254

Review URL: https://codereview.chromium.org//11231074

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14324 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-31 10:32:54 +00:00
lrn@google.com 895d155ab1 Revert "Change signature of noSuchMethod to take an InvocationMirror."
TBR=ager@google.com

Review URL: https://codereview.chromium.org//11339042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14260 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 10:47:42 +00:00
lrn@google.com 4a24ddc1d4 Change signature of noSuchMethod to take an InvocationMirror.
Requires VM and dart2js/dart2dart changes to work.

Committed: https://code.google.com/p/dart/source/detail?r=14198

Review URL: https://codereview.chromium.org//11231074

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14254 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 10:04:12 +00:00
lrn@google.com 778b0dc5e5 Revert "Change signature of noSuchMethod to take an InvocationMirror."
TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//11336011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14199 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 14:07:10 +00:00
lrn@google.com 0bcd2f4f7b Change signature of noSuchMethod to take an InvocationMirror.
Requires VM and dart2js/dart2dart changes to work.

Review URL: https://codereview.chromium.org//11231074

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14198 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 13:34:58 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter.
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
regis@google.com 4d80efdb1a Fix and reenable dart2js extra tests and dart2js native tests.
Review URL: https://codereview.chromium.org//11227038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13910 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 21:27:09 +00:00
regis@google.com f2cb4e6815 Disable failing tests in dart2js_native.
Review URL: https://codereview.chromium.org//11236037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13900 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 18:41:50 +00:00
iposva@google.com 6755ae5020 - Do not pass optional positional parameters with a name.
Review URL: https://codereview.chromium.org//11245002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13896 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 17:30:12 +00:00
floitsch@google.com 9074fd0178 Make hashCode a getter and not a method.
Review URL: https://codereview.chromium.org//11191078

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13866 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 12:41:04 +00:00
ngeoffray@google.com e24c0e7af5 Implement Function.apply in dart2js.
Review URL: https://codereview.chromium.org//11093015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13409 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-09 12:02:04 +00:00
lrn@google.com 37197c2553 Stop using the Hashable interface.
All objects have a hashCode method, so there is no need for a Hashable
interface.
The interface itself is retained for at least two weeks, to give time for
code to remove uses of it.

Review URL: https://codereview.chromium.org//10993059

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12955 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 13:07:54 +00:00
ngeoffray@google.com 6d529a543b Implement the apply functionality for dart2js and currently just put it in a test.
Review URL: https://codereview.chromium.org//10993036

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12909 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-26 13:49:53 +00:00
ahe@google.com d71bc06273 Implement Object.hashCode()
Review URL: https://codereview.chromium.org//10965034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12704 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-21 13:34:57 +00:00
aprelev@gmail.com 9ecad0703b issue 4817 fixed. Implemented raw strings with 'r' instead of '@' for dart2js
BUG=dart:4817

Review URL: https://chromiumcodereview.appspot.com//10920066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12292 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 01:43:23 +00:00
ahe@google.com 7740e6dad6 Revert status file change
Review URL: https://chromiumcodereview.appspot.com//10905212

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12191 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 12:44:48 +00:00
ahe@google.com d1cb4358a2 Run dart2js tests unmodified in drt.
Review URL: https://chromiumcodereview.appspot.com//10918168

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12182 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 11:16:21 +00:00
lrn@google.com f52c24b62f Rename NoSuchMethodException to NoSuchMethodError.
Moved NoSuchMethodError to errors.dart.
No changes in co19 tests, but test status updated.

Review URL: https://chromiumcodereview.appspot.com//10909166

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12172 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 09:52:25 +00:00
ahe@google.com 0e4bf23853 Revert "Run dart2js tests unmodified in browser."
This reverts r12164, r12166, r12167, and r12169.

Review URL: https://chromiumcodereview.appspot.com//10914197

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12170 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 09:05:52 +00:00
ahe@google.com 7d55ed7fdf Run dart2js tests unmodified in browser.
Review URL: https://chromiumcodereview.appspot.com//10919098

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12159 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 07:00:24 +00:00
ngeoffray@google.com 13dd7022b5 num implements Comparable and Hashable.
Review URL: https://chromiumcodereview.appspot.com//10916172

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12037 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-07 14:20:36 +00:00
ngeoffray@google.com a844d14874 Fix status files to make bots green.
Review URL: https://chromiumcodereview.appspot.com//10917112

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11936 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-06 11:41:59 +00:00
efortuna@google.com 07125e549e Remove dart:dom_deprecated from everywhere but the editor, dart2js, lib/dom, and
utils/apidoc.
Review URL: https://chromiumcodereview.appspot.com//10918028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11721 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 21:21:08 +00:00
efortuna@google.com b2f2c43f34 Revert 11715.
Review URL: https://chromiumcodereview.appspot.com//10909035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11718 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 20:01:09 +00:00
efortuna@google.com 7668c86f76 Reapply dom_deprecated removal with non-editor breaking change.
Review URL: https://chromiumcodereview.appspot.com//10916035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11715 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 19:43:13 +00:00
efortuna@google.com 5065c6e7fd Revert 11651
Review URL: https://chromiumcodereview.appspot.com//10916028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11655 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-30 20:59:42 +00:00