Commit Graph

81 Commits

Author SHA1 Message Date
asiva@google.com 80e281a078 Fix for issues 6080 -
- Read the saved context from the entry frame when straddling across C++ frames while iterating over a stack trace in the debugger. This ensures that the correct context is setup in the ActivationFrame structure in these scenarios (instead of the empty context).

- Read the saved context from the caller's frame when iterating over a stack trace in the debugger. The compiler saves the context in the caller frame before invoking closures, we read this saved context when iterating the stack trace.
Review URL: https://codereview.chromium.org//12179020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18235 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 22:43:16 +00:00
asiva@google.com d6c8e4f892 Add unit tests which reliabily reproduces the error condition reported in Issue 6080 without the need for a specialized and inconsistent private environment.
Review URL: https://codereview.chromium.org//12218046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18232 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 20:55:21 +00:00
regis@google.com 5675b85979 Generate first ARM assembler test and execute (simulate) it.
RFC: First draft showing how generated ARM code accesses GC'ed objects and
accesses patched call targets.
Review URL: https://codereview.chromium.org//12224024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18200 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 00:55:47 +00:00
fschneider@google.com 7fc8f72c25 Inline getters of byte array view in the optimized flow graph.
This CL provides inline IL code for the getters _getInt8, _getInt16, etc.
to speed up [] and byte array views.

The code uses the existing LoadIndexed instructions by passing a index
scale factor explicitly: For normal arrays loads, the scale factor is equal
to the element size. For byte array access, the scale factor is always 1.

I'm adding inlined setters in a separate CL.
Review URL: https://codereview.chromium.org//12218008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18173 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-06 15:18:57 +00:00
antonm@google.com 5a9cc92093 Revert changes 17962-3 which break Dartium Debug build.
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//12079117

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17977 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 12:45:42 +00:00
regis@google.com 15495fcd94 Temporarily disabling snapshot tests failing on Windows until further
investigation.
Review URL: https://codereview.chromium.org//12082113

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17963 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 03:21:39 +00:00
fschneider@google.com 77c1e9add5 Fix test status for my new tests running with dartc.
TBR=kmillikin@google.com
Review URL: https://codereview.chromium.org//12094031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17758 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 13:24:22 +00:00
fschneider@google.com dfda7854a8 Fix source position for stack traces with optimized top function.
Fix decoding of the deoptimization info when constructing a stack trace.

Fix stack trace for checked mode exceptions from optimized code.

BUG=dart:8058
TEST=runtime/tests/vm/dart/optimized_stacktrace_test.dart,
     tests/language/stack_overflow_stacktrace_test.dart
Review URL: https://codereview.chromium.org//12049039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17755 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 12:38:27 +00:00
iposva@google.com 57f62dd2e1 - Make sure we can "run" all tests using simarm/simmips.
Review URL: https://codereview.chromium.org//12042065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17516 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 00:42:04 +00:00
asiva@google.com a3515284ae Skip test ExternalizeConstantStrings on windows (investigate crash).
Review URL: https://codereview.chromium.org//12051034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17439 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 06:41:18 +00:00
kustermann@google.com 3ed3bfe040 Status updates for Safari
Review URL: https://codereview.chromium.org//12049004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17363 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-21 16:23:56 +00:00
erikcorry@google.com 961d0a0cc3 Mark a test of stack traces failing on dart2js when minifying.
R=kasperl@google.com
BUG=

Review URL: https://codereview.chromium.org//11969040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17255 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 09:38:23 +00:00
ricow@google.com 707ab317cf Also skip vm/dart/inline_stack_frame_test on ie9.
There is no bug filed for this

Revision 17000 changes the Skip to only apply to ff instead of all dart2js bots. Original review discussing the suppression:
https://codereview.chromium.org//11784033

The ie9 failure on this was hidden by an already red bot.
Review URL: https://codereview.chromium.org//11882039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17045 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 07:43:49 +00:00
asiva@google.com 62115b51fe Fix for issue 7757
- Iterate and collect all the inlined functions in an optimized dart frame
  into the stack frame when throwing an exception.
- Added a OptimizedDartFrameIterator class which iterates over all the inlined
  functions of a single optimized dart frame.
Review URL: https://codereview.chromium.org//11833025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17000 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-12 00:24:28 +00:00
efortuna@google.com 44cedbeef1 Stack frame test probably shouldn't be running on a browser.
BUG=

Review URL: https://codereview.chromium.org//11784033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16781 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 02:42:28 +00:00
asiva@google.com 9c4e6eb72f Added a test to ensure that stack frames are reported correctly when an exception is thrown in a chain which has inlined methods. This test currently fails and I have added an issue 7757 for it and skipped it in the status file.
Review URL: https://codereview.chromium.org//11781007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16778 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 01:53:47 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge.
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
asiva@google.com 2c6de68680 Changed the API in DartEntry for invoking dart code from C++ to make it more compatible with the requirements of the runtime.
Deleted all the code duplication that was added to circumvent the old DartEntry API requirements.
Review URL: https://codereview.chromium.org//11613009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16288 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 21:36:01 +00:00
tball@google.com 3e59a633d0 Suppressed isolate uncaught exception handling tests for non-VM builds.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16188 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-15 00:38:11 +00:00
cshapiro@google.com 392ca92d2d Use the code point iterator when computing 16-bit string hash codes.
Review URL: https://codereview.chromium.org//11412258

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15565 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 02:36:19 +00:00
regis@google.com 91ad9a0180 Remove support for interfaces.
For now, disable tests using obsolete syntax.
Tests disabled in this cl and in previous ones removing default factory classes
will either be deleted or updated in a later cl.
Review URL: https://codereview.chromium.org//11411271

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15562 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 01:26:31 +00:00
regis@google.com 7e9531a1d2 Remove support for default factory classes.
For now, disable tests using obsolete syntax. More will get disabled as support
for interfaces is completely removed. We may then permanently remove some tests,
while updating and reenabling others whose purpose is not related to interfaces.

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15480 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 23:39:27 +00:00
regis@google.com 1de3a5c0f7 Enforce rule in vm that factory name must match enclosing class name.
This is a step towards removing support for obsolete default factory classes.
For now, disable tests using obsolete syntax. More will get disabled as support
is completely removed. We may then permanently remove some tests, while updating
and reenabling others whose purpose is not related to default factory classes.
Review URL: https://codereview.chromium.org//11419191

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15428 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 01:11:29 +00:00
tball@google.com bf5f0db5d0 Added support for isolate unhandled exceptions.
BUG=

Review URL: https://codereview.chromium.org//11413101

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15352 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 23:31:47 +00:00
erikcorry@google.com 359736e97a Fix Unicode issues in dart2js and dart2dart.
R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//11418115

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15254 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-22 12:51:14 +00:00
lrn@google.com 87eec0ef1f Revert "Exception no longer an interface."
Broke more than expected.

TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//11364216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14848 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 14:04:19 +00:00
lrn@google.com def3ee60a5 Exception no longer an interface.
Some tests disabled due to dartbug.com/6697

Review URL: https://codereview.chromium.org//11365226

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14847 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 13:42:51 +00:00
iposva@google.com 48aed26029 Fix bug 6586:
- Attempt to run the Monitor thread_test multiple times before failing
  due to its potential to failure due to timing.
- Use named constants when converting millis to seconds and nanos.
Review URL: https://codereview.chromium.org//11361157

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14695 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 18:07:54 +00:00
cshapiro@google.com dc7ac3d520 Scavenge watched objects by scavenging their watchers.
BUG=http://code.google.com/p/dart/issues/detail?id=5546

Review URL: https://codereview.chromium.org//11055007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13157 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-03 01:40:23 +00:00
iposva@google.com e40f9437ee Fix build: Do not rename test cases just before committing.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13152 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 23:38:37 +00:00
iposva@google.com ab16371668 - Add regression test case for dartbug.com/5546.
Review URL: https://codereview.chromium.org//11047007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13150 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-02 23:31:57 +00:00
iposva@google.com bdeae9a51e - Mark vm/cc/Sleep and vm/cc/Monitor as flaky on Windows debug.
Review URL: https://codereview.chromium.org//10910250

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12303 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 07:04:43 +00:00
asiva@google.com 9ed2e66130 Get rid of support for string interpolation in #import strings.
Review URL: https://chromiumcodereview.appspot.com//10911025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11698 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-31 16:55:03 +00:00
regis@google.com 9efad2644b Re-enable checking of native resolvers.
Review URL: https://chromiumcodereview.appspot.com//10882007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11206 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-23 03:26:20 +00:00
regis@google.com 3e6596ba22 Temporarily disable checking of native resolvers to make Dartium build green.
A more permanent fix will follow.
Review URL: https://chromiumcodereview.appspot.com//10869024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11200 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-23 01:01:14 +00:00
asiva@google.com 630474f412 Update status file.
Review URL: https://chromiumcodereview.appspot.com//10832437

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11111 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-21 22:59:04 +00:00
asiva@google.com d3bf4f62b6 Turn off SNPrintf_BadArgs on linux and windows.
Review URL: https://chromiumcodereview.appspot.com//10860056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11108 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-21 22:35:06 +00:00
dgrove@google.com bacdd20e96 Continued deletion of frog.
Review URL: https://chromiumcodereview.appspot.com//10860071

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11098 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-21 21:09:52 +00:00
turnidge@google.com 2803d78dfd Change the zone allocation api.
Instead of passing a size in bytes to the allocation function, we now
have a templatized Alloc function:

  zone->Alloc<Type>(len)

This is better for security, as we can check for integer overflow in
the size computation before performing the allocation.  Before, we
often failed to check this.
Review URL: https://chromiumcodereview.appspot.com//10836061

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10254 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-03 21:51:44 +00:00
turnidge@google.com 8b68d343c7 Enforce length/size limits for variable size heap object in order to
avoid overflow.

For each variable size heap object, compute the maximum number of
elements and use that in the ::New functions to avoid overflow.  If a
bad length/size reaches a ::New function, that is a FATAL error -- the
problem should have been caught earlier by the dart api or by the
library code.

Add "border guards" in the dart api and in library calls which cause
new variable size heap objects to be allocated.  We check for invalid
length/size and throw explanatory error messages.
Review URL: https://chromiumcodereview.appspot.com//10782016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10130 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-01 18:22:30 +00:00
smok@google.com 4412f8653f dart2dart Skip non-language tests, leave yaml too.
Review URL: https://chromiumcodereview.appspot.com//10823079

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10014 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-30 13:50:54 +00:00
regis@google.com af26648b46 Fix Function::NumberOfImplicitParameters() for closure functions.
Related to cl 10831021.
Review URL: https://chromiumcodereview.appspot.com//10829041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9957 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-26 18:45:54 +00:00
rmacnak@google.com 6d56bfd545 Added a test of Dart_FunctionParameterCounts against a closure inside of an
instance method. It currently gives the wrong answer for the fixed parameter
count because the closure's function is identified as non-static => instance
=> one implicit parameter (receiver) in Function::NumberOfImplicitParameters.
Review URL: https://chromiumcodereview.appspot.com//10831021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9956 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-26 18:30:40 +00:00
antonm@google.com 74d17a16f9 dart2dart compiler support.
R=whesse@google.com

Review URL: https://chromiumcodereview.appspot.com//10809069

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9880 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-25 11:20:41 +00:00
turnidge@google.com 9cbae35238 Don't allow OS::SNPrint or OS::VSNPrint to return negative values.
If we encounter conditions that would have caused vsnprintf to return
a negative value, then something pretty wild is going on.  We choose
to terminate the vm when this occurs.

This fixes security bug 1745.
Review URL: https://chromiumcodereview.appspot.com//10696165

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@9558 260f80e4-7a28-3924-810f-c04153c831b5
2012-07-11 17:54:24 +00:00
vsm@google.com 129369184a Skip failing test on DRT
TBR=turnidge

Review URL: https://chromiumcodereview.appspot.com//10443102

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8139 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-31 05:08:40 +00:00
turnidge@google.com ec36e02c28 Remove the partially completed code for remote IsolateMirrors and
replace it with the beginnings of a local (same isolate) IsolateMirror
implementation.

Removed old mirror tests and added two new mirror tests.

Even though mirrors.cc is part of the vm, I chose to implement most of
it using the dart embedding interface instead of our internal
interfaces because the embedding interface was more convenient.
mirrors.cc is basically all new in this CL -- don't pay any attention
to diffs for that file.

Added dart embedding functions required for the functionality in this
CL: Dart_DebugName, Dart_GetNativeInstanceFieldCount,
Dart_RootLibrary, Dart_RegisteredLibraryUrls, and Dart_LibraryName.

Extended or modified some existing dart api functions, primarily to
make them propagate error handles properly.

Added tests for new dart embedding api functionality.

Added the ability to determine if a port is local to the current isolate.

Extended NotImplementedException to accept an optional string
argument.  I wanted to give more descriptive error messages.
Review URL: https://chromiumcodereview.appspot.com//10416050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@8117 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-30 17:07:19 +00:00
turnidge@google.com d28858f799 Skip some tests that are causing trouble on dartium. I am deleting
these tests (and the code they test) entirely in a different CL, so I
don't see the point in fixing them.
Review URL: https://chromiumcodereview.appspot.com//10383310

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7919 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-23 19:12:44 +00:00
cshapiro@google.com 4ad6942ef1 Fix breakage in the JavaScript compilers.
This change adds a mock "Uint8List" to dart2js, suppresses the new byte
array test on Frog, and renames interface parameters for dartc.

Review URL: https://chromiumcodereview.appspot.com//10383023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7355 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-05 00:07:25 +00:00
asiva@google.com ae552ba870 Fix build break.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@7266 260f80e4-7a28-3924-810f-c04153c831b5
2012-05-03 01:45:31 +00:00