Commit Graph

142 Commits

Author SHA1 Message Date
asiva@google.com 80e281a078 Fix for issues 6080 -
- Read the saved context from the entry frame when straddling across C++ frames while iterating over a stack trace in the debugger. This ensures that the correct context is setup in the ActivationFrame structure in these scenarios (instead of the empty context).

- Read the saved context from the caller's frame when iterating over a stack trace in the debugger. The compiler saves the context in the caller frame before invoking closures, we read this saved context when iterating the stack trace.
Review URL: https://codereview.chromium.org//12179020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18235 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 22:43:16 +00:00
asiva@google.com d6c8e4f892 Add unit tests which reliabily reproduces the error condition reported in Issue 6080 without the need for a specialized and inconsistent private environment.
Review URL: https://codereview.chromium.org//12218046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18232 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 20:55:21 +00:00
regis@google.com 5675b85979 Generate first ARM assembler test and execute (simulate) it.
RFC: First draft showing how generated ARM code accesses GC'ed objects and
accesses patched call targets.
Review URL: https://codereview.chromium.org//12224024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18200 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-07 00:55:47 +00:00
fschneider@google.com 7fc8f72c25 Inline getters of byte array view in the optimized flow graph.
This CL provides inline IL code for the getters _getInt8, _getInt16, etc.
to speed up [] and byte array views.

The code uses the existing LoadIndexed instructions by passing a index
scale factor explicitly: For normal arrays loads, the scale factor is equal
to the element size. For byte array access, the scale factor is always 1.

I'm adding inlined setters in a separate CL.
Review URL: https://codereview.chromium.org//12218008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18173 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-06 15:18:57 +00:00
antonm@google.com 5a9cc92093 Revert changes 17962-3 which break Dartium Debug build.
TBR=ricow@google.com

Review URL: https://codereview.chromium.org//12079117

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17977 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 12:45:42 +00:00
regis@google.com 15495fcd94 Temporarily disabling snapshot tests failing on Windows until further
investigation.
Review URL: https://codereview.chromium.org//12082113

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17963 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 03:21:39 +00:00
fschneider@google.com 77c1e9add5 Fix test status for my new tests running with dartc.
TBR=kmillikin@google.com
Review URL: https://codereview.chromium.org//12094031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17758 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 13:24:22 +00:00
fschneider@google.com dfda7854a8 Fix source position for stack traces with optimized top function.
Fix decoding of the deoptimization info when constructing a stack trace.

Fix stack trace for checked mode exceptions from optimized code.

BUG=dart:8058
TEST=runtime/tests/vm/dart/optimized_stacktrace_test.dart,
     tests/language/stack_overflow_stacktrace_test.dart
Review URL: https://codereview.chromium.org//12049039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17755 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 12:38:27 +00:00
iposva@google.com 57f62dd2e1 - Make sure we can "run" all tests using simarm/simmips.
Review URL: https://codereview.chromium.org//12042065

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17516 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 00:42:04 +00:00
asiva@google.com a3515284ae Skip test ExternalizeConstantStrings on windows (investigate crash).
Review URL: https://codereview.chromium.org//12051034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17439 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-23 06:41:18 +00:00
kustermann@google.com 3ed3bfe040 Status updates for Safari
Review URL: https://codereview.chromium.org//12049004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17363 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-21 16:23:56 +00:00
erikcorry@google.com 961d0a0cc3 Mark a test of stack traces failing on dart2js when minifying.
R=kasperl@google.com
BUG=

Review URL: https://codereview.chromium.org//11969040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17255 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-18 09:38:23 +00:00
ricow@google.com 707ab317cf Also skip vm/dart/inline_stack_frame_test on ie9.
There is no bug filed for this

Revision 17000 changes the Skip to only apply to ff instead of all dart2js bots. Original review discussing the suppression:
https://codereview.chromium.org//11784033

The ie9 failure on this was hidden by an already red bot.
Review URL: https://codereview.chromium.org//11882039

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17045 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 07:43:49 +00:00
asiva@google.com 62115b51fe Fix for issue 7757
- Iterate and collect all the inlined functions in an optimized dart frame
  into the stack frame when throwing an exception.
- Added a OptimizedDartFrameIterator class which iterates over all the inlined
  functions of a single optimized dart frame.
Review URL: https://codereview.chromium.org//11833025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17000 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-12 00:24:28 +00:00
asiva@google.com 09ce352df7 Fix comment in test case.
Review URL: https://codereview.chromium.org//11783035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16821 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 21:04:36 +00:00
efortuna@google.com 44cedbeef1 Stack frame test probably shouldn't be running on a browser.
BUG=

Review URL: https://codereview.chromium.org//11784033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16781 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 02:42:28 +00:00
asiva@google.com 9c4e6eb72f Added a test to ensure that stack frames are reported correctly when an exception is thrown in a chain which has inlined methods. This test currently fails and I have added an issue 7757 for it and skipped it in the status file.
Review URL: https://codereview.chromium.org//11781007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16778 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-08 01:53:47 +00:00
ajohnsen@google.com 32eeecd930 Fix tests for VM in checked mode.
BUG=

Review URL: https://codereview.chromium.org//11801008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16689 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:59:49 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge.
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
asiva@google.com 2c6de68680 Changed the API in DartEntry for invoking dart code from C++ to make it more compatible with the requirements of the runtime.
Deleted all the code duplication that was added to circumvent the old DartEntry API requirements.
Review URL: https://codereview.chromium.org//11613009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16288 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 21:36:01 +00:00
asiva@google.com 8a1b4167bc Changed the test a bit to ensure dart:io is not included as dartium cannot import dart:io
Review URL: https://codereview.chromium.org//11596002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16200 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-15 20:46:26 +00:00
asiva@google.com 482b4dfdc3 Forgot this test in the previous change list.
Review URL: https://codereview.chromium.org//11591004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16198 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-15 19:08:51 +00:00
asiva@google.com 1e665120cc Fix new isolate_unhandled_exception tests to make them compatible for dartium testing.
Review URL: https://codereview.chromium.org//11595002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16197 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-15 18:43:17 +00:00
tball@google.com 3e59a633d0 Suppressed isolate uncaught exception handling tests for non-VM builds.
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16188 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-15 00:38:11 +00:00
tball@google.com 3282ae3f72 Second version of support for specifying an unhandled exception callback
in Dart.  Isolate.spawnFunction optionally takes a callback parameter,
which is not resolved until an unhandled exception occurs.  If a callback
wasn't specified, the VM will then call an "_unhandledExceptionCallback"
function if it is defined in the isolate's source file. If no callback
is provided, the error is logged as the isolate is closed.
Review URL: https://codereview.chromium.org//11558034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16186 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-15 00:20:07 +00:00
johnmccutchan@google.com 1120befff4 s/transferrable/transferable
Review URL: https://codereview.chromium.org//11434077

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15636 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 15:25:07 +00:00
johnmccutchan@google.com 5642ee09f1 Expose transferable constructor to Int8List
Review URL: https://codereview.chromium.org//11414211

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15598 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 20:35:22 +00:00
cshapiro@google.com 392ca92d2d Use the code point iterator when computing 16-bit string hash codes.
Review URL: https://codereview.chromium.org//11412258

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15565 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 02:36:19 +00:00
regis@google.com 91ad9a0180 Remove support for interfaces.
For now, disable tests using obsolete syntax.
Tests disabled in this cl and in previous ones removing default factory classes
will either be deleted or updated in a later cl.
Review URL: https://codereview.chromium.org//11411271

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15562 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 01:26:31 +00:00
regis@google.com 7e9531a1d2 Remove support for default factory classes.
For now, disable tests using obsolete syntax. More will get disabled as support
for interfaces is completely removed. We may then permanently remove some tests,
while updating and reenabling others whose purpose is not related to interfaces.

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15480 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 23:39:27 +00:00
regis@google.com 1de3a5c0f7 Enforce rule in vm that factory name must match enclosing class name.
This is a step towards removing support for obsolete default factory classes.
For now, disable tests using obsolete syntax. More will get disabled as support
is completely removed. We may then permanently remove some tests, while updating
and reenabling others whose purpose is not related to default factory classes.
Review URL: https://codereview.chromium.org//11419191

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15428 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 01:11:29 +00:00
tball@google.com bf5f0db5d0 Added support for isolate unhandled exceptions.
BUG=

Review URL: https://codereview.chromium.org//11413101

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15352 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 23:31:47 +00:00
erikcorry@google.com 359736e97a Fix Unicode issues in dart2js and dart2dart.
R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//11418115

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15254 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-22 12:51:14 +00:00
ajohnsen@google.com 0f367f8894 Make List an abstract class.
This was the last interface in dart:core.

BUG=

Review URL: https://codereview.chromium.org//11417051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15240 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-22 07:40:52 +00:00
lrn@google.com 87eec0ef1f Revert "Exception no longer an interface."
Broke more than expected.

TBR=floitsch@google.com

Review URL: https://codereview.chromium.org//11364216

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14848 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 14:04:19 +00:00
lrn@google.com def3ee60a5 Exception no longer an interface.
Some tests disabled due to dartbug.com/6697

Review URL: https://codereview.chromium.org//11365226

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14847 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 13:42:51 +00:00
floitsch@google.com 8e6f238f86 a === b -> identical(a, b)
Replace === null with == null.

BUG=http://dartbug.com/6380

Review URL: https://codereview.chromium.org//11361190

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14794 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 17:19:58 +00:00
gram@google.com 96016f9034 Fix library syntax
Review URL: https://codereview.chromium.org//11368124

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14701 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 18:41:58 +00:00
iposva@google.com 48aed26029 Fix bug 6586:
- Attempt to run the Monitor thread_test multiple times before failing
  due to its potential to failure due to timing.
- Use named constants when converting millis to seconds and nanos.
Review URL: https://codereview.chromium.org//11361157

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14695 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 18:07:54 +00:00
lrn@google.com 2208fcd208 Change NotImplementedException to UnimplementedError.
Retain a NotImplementedException type for backwards compatibility.
This class will be removed soon.
The constructor of UnimplementedError is currently const in order to
support the NotImplementedException. That will be fixed too.

Review URL: https://codereview.chromium.org//11358060

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14467 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-02 13:18:37 +00:00
lrn@google.com 7e6ae8ea09 Renaming IndexOutOfRangeException to RangeError.
It now extends ArgumentError.

Review URL: https://codereview.chromium.org//11275042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14405 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-01 13:46:30 +00:00
ajohnsen@google.com dbbf15abd8 Move ListImplementation from coreimpl to core, as a private member.
BUG=

Review URL: https://codereview.chromium.org//11189141

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14274 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 13:25:04 +00:00
floitsch@google.com 2e778387b3 Make getKeys, getValues getters (keys, values).
Review URL: https://codereview.chromium.org//11267018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14093 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 19:22:11 +00:00
floitsch@google.com 09f6d09d88 Make isEmpty a getter.
Review URL: https://codereview.chromium.org//11238035

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14022 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 15:04:32 +00:00
lrn@google.com a083c1a108 Removed IllegalAccessException and UnsupportedOperationException.
Both were converted to StateError.

Review URL: https://codereview.chromium.org//11235054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14012 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-24 12:36:10 +00:00
floitsch@google.com 27cadf2b66 isEven, isOdd, isNegative, isMaxValue, isMinValue, isInfinite, isPositive, isSingleValue.
Review URL: https://codereview.chromium.org//11227042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13974 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 16:15:36 +00:00
lrn@google.com e0527ef304 Change StackOverflowException to be an Error.
Also change OutOfMemoryError to actually extend Error.

Review URL: https://codereview.chromium.org//11227021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13857 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-22 09:51:14 +00:00
lrn@google.com 89f5daea9e Rename OutOfMemoryException to OutOfMemoryError.
This is a reapply with missing status file changes.

TBR=kasperl@google.com

Review URL: https://codereview.chromium.org//11233004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13822 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 14:01:24 +00:00
kasperl@google.com f7a56d3f70 Revert "Rename OutOfMemoryException to OutOfMemoryError."
This reverts r13818.

TBR'ed.

R=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//11229003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13820 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 13:11:15 +00:00
lrn@google.com 58f3453267 Rename OutOfMemoryException to OutOfMemoryError.
Also move ExceptionImplementation to core.

Review URL: https://codereview.chromium.org//11228002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13818 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-19 12:20:52 +00:00