ahe@google.com
8d698fdf19
Improve performance of dart2js StringBuffer.
...
Review URL: https://codereview.chromium.org//11565034
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17639 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-25 15:32:10 +00:00
meh@google.com
2c7dfbf982
Implement a native identical function in the VM.
...
Returns true if objects are the same instance.
Adds an identical closure test (disabled for dart2js pending https://chromiumcodereview.appspot.com/11612022/ ).
BUG=7378
Review URL: https://codereview.chromium.org//11613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16461 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-22 00:12:35 +00:00
meh@google.com
2e1ecb18fe
Revert "Implement a native identical function in the VM."
...
This reverts commit 88a0845aedeed15106dcfc8c658ebed37e7e85dd.
BUG=
Review URL: https://codereview.chromium.org//11665016
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16460 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 23:58:48 +00:00
meh@google.com
225d9a724b
Implement a native identical function in the VM.
...
Returns true if objects are the same instance.
BUG=7378
Committed: https://code.google.com/p/dart/source/detail?r=16453
Review URL: https://codereview.chromium.org//11613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16456 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 22:42:21 +00:00
meh@google.com
51dc889ad7
Revert "Implement a native identical function in the VM."
...
This reverts commit 93e88749af841a1b381db6351a7196d35edd554e.
BUG=
Review URL: https://codereview.chromium.org//11578057
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16454 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 21:22:43 +00:00
meh@google.com
5e068fec8f
Implement a native identical function in the VM.
...
Returns true if objects are the same instance.
BUG=7378
Review URL: https://codereview.chromium.org//11613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16453 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 20:34:42 +00:00
meh@google.com
a1bb3a9e51
Revert "Implement a native identical function in the VM."
...
This reverts commit c876c29bf4caa810bfc03c8b8908588168d634fe.
BUG=
Review URL: https://codereview.chromium.org//11664012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16451 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 20:08:59 +00:00
meh@google.com
55596818ac
Implement a native identical function in the VM.
...
Returns true if objects are the same instance.
BUG=7378
Committed: https://code.google.com/p/dart/source/detail?r=16400
Committed: https://code.google.com/p/dart/source/detail?r=16412
Review URL: https://codereview.chromium.org//11613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16450 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 19:07:55 +00:00
meh@google.com
38aa3e1dee
Revert "Implement a native identical function in the VM."
...
This reverts commit 0f29c63d64de37beb5f1b927a492687fde6de58a.
BUG=
Review URL: https://codereview.chromium.org//11645060
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16414 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 01:50:27 +00:00
meh@google.com
585e671819
Implement a native identical function in the VM.
...
Returns true if objects are the same instance.
BUG=7378
Committed: https://code.google.com/p/dart/source/detail?r=16400
Review URL: https://codereview.chromium.org//11613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16412 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 01:14:32 +00:00
meh@google.com
5d390fdf6c
Revert "Implement a native identical function in the VM."
...
This reverts commit b6265dc1f0711711bcd26413826155f338c49c6d.
Merge remote-tracking branch 'git-svn' into revert-identical
Revert "Implement a native identical function in the VM."
This reverts commit b6265dc1f0711711bcd26413826155f338c49c6d.
Merge remote-tracking branch 'git-svn' into identical
Merge remote-tracking branch 'git-svn' into identical
stage for submission
BUG=
Review URL: https://codereview.chromium.org//11649045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16402 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 21:49:54 +00:00
meh@google.com
d59b5937a6
Implement a native identical function in the VM.
...
Takes two objects and returns a boolean.
If the objects are SMIs, then returns true if the values are identical.
If the objects are not SMIs, then returns true if the references are identical.
BUG=7378
Review URL: https://codereview.chromium.org//11613003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16400 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 21:35:38 +00:00
regis@google.com
3ae792bbf4
Implement InvocationMirror.invokeOn method in the vm (issue 7227).
...
Review URL: https://codereview.chromium.org//11570042
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16187 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-15 00:28:41 +00:00
regis@google.com
849585ef7c
Implement Function.apply in vm (issue 5670).
...
Fix a closure parameter count check bug (unveiled by an apply test).
Review URL: https://codereview.chromium.org//11564029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16175 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 19:04:01 +00:00
tball@google.com
67530c6aa1
Added bool.hashCode patch.
...
BUG: 7244
Review URL: https://codereview.chromium.org//11557002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16011 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 00:59:05 +00:00
ngeoffray@google.com
a71ca795d8
Make identical an external function and make it throw in both runtimes, as they both recognize it.
...
Review URL: https://codereview.chromium.org//11489011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15956 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 09:22:45 +00:00
iposva@google.com
7ae807a19c
- Move MathNatives from dart:core to dart:math.
...
- Split out double and integer parsing from MathNatives.
Review URL: https://codereview.chromium.org//11316031
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15032 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 19:42:02 +00:00
regis@google.com
02a8df0c83
Remove private class helping the parser to construct literal lists and maps.
...
Patch List and Map (implementation) classes with literal factories.
Review URL: https://codereview.chromium.org//11369234
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14873 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-14 04:28:02 +00:00
ajohnsen@google.com
970cc5ba68
Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.
...
After this cleanup, RegExp no longer have a const constructor. Use 'new
RegExp(...)' from now on.
BUG=
Review URL: https://codereview.chromium.org//11365196
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14838 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:41:37 +00:00
lrn@google.com
1555c1db26
Convert String to a class.
...
Remove the StringImplementation class.
Review URL: https://codereview.chromium.org//11085003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14779 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 08:16:59 +00:00
ajohnsen@google.com
806fa6fab1
Move StringImplementation from coreimpl to core as _StringImpl.
...
BUG=
Review URL: https://codereview.chromium.org//11348035
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14281 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 14:19:57 +00:00
ajohnsen@google.com
dbbf15abd8
Move ListImplementation from coreimpl to core, as a private member.
...
BUG=
Review URL: https://codereview.chromium.org//11189141
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14274 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-30 13:25:04 +00:00
ajohnsen@google.com
d388e925b3
Move StopwatchImplementation from coreimpl to core as _StopwatchImpl.
...
BUG=
Review URL: https://codereview.chromium.org//11273006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14182 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-29 10:13:25 +00:00
lrn@google.com
d7c160dab5
Add implementation class of InvocationMirror for VM.
...
Review URL: https://codereview.chromium.org//11262029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14063 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-25 08:43:31 +00:00
ajohnsen@google.com
8b6565ceea
Move DateImplementation from coreimpl to core, making it private.
...
BUG=
Review URL: https://codereview.chromium.org//11227055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13980 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-23 17:34:36 +00:00
efortuna@google.com
2262eaa5ed
Reapply r13292 WITH a fix to dartc test status for apply_test.dart
...
Review URL: https://codereview.chromium.org//11035069
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13335 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 23:42:27 +00:00
efortuna@google.com
461f7fb95e
Revert r13292. This is when the first failure showed up on dartc, but dartc
...
didn't actually turn red. Investigating why.
Review URL: https://codereview.chromium.org//11081002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13330 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 23:05:20 +00:00
lrn@google.com
181dc5d3b4
Add apply method signature to Function class.
...
This does not include an implementation for any backend. The
current implementation throws a NotImplementedException when
called.
BUG=5419
Review URL: https://codereview.chromium.org//11027059
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13292 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-05 12:57:51 +00:00
iposva@google.com
b85f604f66
- Implement first class types in the VM.
...
- Make AbstractType a subclass of Instance and map it and its subclasses
to private Dart classes in dart:core implementing the Type interface.
- Avoid dispatching through statics in Object if not strictly needed.
Review URL: https://codereview.chromium.org//10979058
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12981 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 21:19:00 +00:00
ager@google.com
81e81825c9
Make data setter private on GrowableObjectArray.
...
There is no data setter on Lists. Additionally, this allows to
create buffer overflows.
R=vegorov@google.com ,iposva@google.com
BUG=
Review URL: https://codereview.chromium.org//10982045
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12941 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-27 06:21:07 +00:00
ager@google.com
e676e88f81
Introduce a VM-only dart:scalarlist library for byte arrays.
...
Include it in the SDK so users can use it. Create a dummy
implementation and patch file for the library for dart2js so it can be
documented. Johnni, can you think of a nicer way of making
documentation generation work for a VM only library? Also, it seems that
patching kills the documentation comments and they do not show up in
the generated docs.
R=iposva@google.com ,johnniwinther@google.com
BUG=
Review URL: https://codereview.chromium.org//10919267
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12616 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-20 07:08:10 +00:00
ahe@google.com
34c503ae73
Don't invoke user-defined code in NoSuchMethodError.toString.
...
Review URL: https://codereview.chromium.org//10939020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12533 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-19 07:55:50 +00:00
lrn@google.com
26fab5183a
Move parseInt parseDouble to int/double classes as a static method.
...
Remove math dependency from core/coreimpl in dart2js.
The existing Math.parseInt and Math.parseDouble are kept *for now*, but
simply redirect to the static methods.
They will be removed in time (when library code is ready for it).
Review URL: https://codereview.chromium.org//10913271
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12417 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-17 07:25:38 +00:00
iposva@google.com
2f455ce6a4
- Move double and int implementations into dart:core and make them private.
...
Review URL: https://codereview.chromium.org//10918213
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12330 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 14:13:55 +00:00
ager@google.com
665aaf939f
Patch print directly in corelib instead of going through coreimpl.
...
R=ajohnsen@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10928145
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12316 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-13 11:50:19 +00:00
ager@google.com
2e49065159
Reapply changes to Expando patching.
...
R=ajohnsen@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10911201
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12181 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 11:03:50 +00:00
ager@google.com
1adc0b35a2
Revert Expando changes. There are checked-mode errors that I need
...
to sort out.
Revert "Patch expando directly in corelib instead of going through coreimpl."
Revert "Fix merge error."
R=ajohnsen@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10918163
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12158 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 05:39:05 +00:00
ager@google.com
e3f4f6696e
Patch expando directly in corelib instead of going through coreimpl.
...
R=ajohnsen@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10908173
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@12156 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-11 05:27:31 +00:00
ager@google.com
156e6a71b5
First corelib cleanup patch after unification.
...
Do not go through coreimpl for object implementation. Instead, use patching
in core directly.
This leads to error message issues in dart2js which I have patched up
the best way I could find.
R=ajohnsen@google.com ,johnniwinther@google.com ,lrn@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10918047
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11784 260f80e4-7a28-3924-810f-c04153c831b5
2012-09-04 07:26:02 +00:00
dgrove@google.com
4f083c41da
Remove weak_property from lib_sources.gypi, since it's
...
already in lib_impl_sources.gypi
Review URL: https://chromiumcodereview.appspot.com//10870111
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11419 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-27 21:20:59 +00:00
ager@google.com
1cf5d4cc4b
Unify Object implementation across dart2js and VM.
...
R=ajohnsen@google.com ,lrn@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10878050
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11372 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-27 08:54:55 +00:00
ager@google.com
570d769b30
Use patching for Expando so the implementation-specific files are not needed in the SDK.
...
Make extra methods private in VM version.
R=ajohnsen@google.com ,cshapiro@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10870064
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11369 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-27 07:15:18 +00:00
ager@google.com
4a397228dc
Quick fix for SDK after Expando addition in the VM.
...
Two files named expando.dart leads to one overwriting the other in
the SDK. Maybe we should use patching for Expando? In any case, we
are working towards not having the implementation file in the SDK
at which point we can revert this change.
Minor style cleanup.
R=ajohnsen@google.com ,cshapiro@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10872029
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11210 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-23 06:12:06 +00:00
cshapiro@google.com
2e00a80dd5
Provide an Expando implementation for the VM.
...
Review URL: https://chromiumcodereview.appspot.com//10861041
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@11196 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-23 00:03:40 +00:00
ager@google.com
2ebbd99144
Update stopwatch to use patching to share sources instead of exposing
...
a Clock class.
R=lrn@google.com ,ajohnsen@google.com
BUG=
Review URL: https://chromiumcodereview.appspot.com//10831327
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@10715 260f80e4-7a28-3924-810f-c04153c831b5
2012-08-15 12:06:17 +00:00
cshapiro@google.com
569ef3c044
Add ByteArray interface and provide internal and external implementations.
...
The new ByteArray interface supersedes the ByteBuffer type which allowed
only external data storage. This type has been removed and replaced by
the more flexible ByteArray with a default implementation that stores its
elements on the managed heap.
Review URL: https://chromiumcodereview.appspot.com//9195031
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3613 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-26 02:42:08 +00:00
regis@google.com
9f230a34c6
Implement type checking of list literals (issue 220).
...
Remove expose_core_impl flag.
Add tests.
Fix tests.
Cleanup type checking of map literals.
Review URL: http://codereview.chromium.org//8676001
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1809 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-23 19:34:23 +00:00
regis@google.com
a2bb53c7af
Implement type checking of map literals (issue 221).
...
Support proper syntax for map literals (at most one type argument is allowed)
and give a warning when legacy syntax is used.
Add tests.
Fix tests.
Review URL: http://codereview.chromium.org//8637018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1764 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-22 21:42:07 +00:00
cshapiro@google.com
1309ebd16e
Add an external array type to support typed arrays.
...
Review URL: http://codereview.chromium.org//8429027
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1601 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-17 03:18:52 +00:00
dgrove@google.com
4c0f559d23
Initial checkin.
...
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-05 05:20:07 +00:00