Commit Graph

63 Commits

Author SHA1 Message Date
floitsch@google.com 0672317bec Remove deprecated mappedBy.
Committed: https://code.google.com/p/dart/source/detail?r=18575
Reverted: http://code.google.com/p/dart/source/detail?r=18576

Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18579 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:57:18 +00:00
floitsch@google.com ad839e6957 Revert "Remove deprecated mappedBy."
This reverts commit 18575.

Review URL: https://codereview.chromium.org//12207205

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18576 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:23:22 +00:00
floitsch@google.com b37100770b Remove deprecated mappedBy.
Review URL: https://codereview.chromium.org//12212213

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18575 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-15 13:18:17 +00:00
floitsch@google.com cb10990e5a Remove Sink and move CollectionSink to async.
Committed: https://code.google.com/p/dart/source/detail?r=18063
Reverted: https://code.google.com/p/dart/source/detail?r=18067

Review URL: https://codereview.chromium.org//12154006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18144 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 15:32:18 +00:00
nweiz@google.com dbb72ee35d Get the pub oauth2 test passing locally.
Review URL: https://codereview.chromium.org//12191008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18103 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-05 00:57:25 +00:00
floitsch@google.com cb1bff12b6 Revert "Remove Sink and move CollectionSink to async."
This reverts commit 18063.

Review URL: https://codereview.chromium.org//12192021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18067 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-04 19:30:15 +00:00
floitsch@google.com 02f6b1835d Remove Sink and move CollectionSink to async.
Review URL: https://codereview.chromium.org//12154006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@18063 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-04 19:03:55 +00:00
nweiz@google.com 18d274df07 Use the dart:async Stream API thoroughly in Pub.
This was originally submitted as r17822, and rolled back in r17867. There are no
changes, but in preparation for the dart:io Stream changes we're applying this
with the intent to mark Windows tests as failing.

BUG=7807

Review URL: https://codereview.chromium.org//12086110

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17996 260f80e4-7a28-3924-810f-c04153c831b5
2013-02-01 19:42:09 +00:00
lrn@google.com 9b23dff467 Reapply "Rename mappedBy to map."
This reverts commit r17907.

TBR.

Review URL: https://codereview.chromium.org//12090093

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17918 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 15:12:56 +00:00
floitsch@google.com b1a118d5ce Revert "Rename mappedBy to map."
This reverts commit 17899.

Review URL: https://codereview.chromium.org//12087103

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17907 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 14:02:27 +00:00
lrn@google.com 0dc2f4b1ba Rename mappedBy to map.
Retain a deprecated mappedBy for now.
Change return type of mappedBy, skip and take on List to Iterable.

BUG= http://dartbug.com/8063
BUG= http://dartbug.com/8064
BUG= http://dartbug.com/6739
BUG= http://dartbug.com/7982

Review URL: https://codereview.chromium.org//12086062

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17899 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-31 12:37:13 +00:00
nweiz@google.com 8be520740e Roll back Pub stream changes.
These changes are still breaking the Windows bots, so I'm rolling them back
until we figure out what's going on.

TBR

Review URL: https://codereview.chromium.org//12095050

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17867 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 19:26:03 +00:00
nweiz@google.com d56994eb18 Use the dart:async Stream API thoroughly in Pub.
Review URL: https://codereview.chromium.org//12021008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17821 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 01:06:39 +00:00
nweiz@google.com b2a13038b2 Always treat headers as individual strings in pkg/http.
BUG=8049

Review URL: https://codereview.chromium.org//12084052

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17819 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-30 00:06:40 +00:00
sigmund@google.com aeca565ae9 Fix build for throwsStateError: remove duplicate definitions in other tests.
Review URL: https://codereview.chromium.org//12088056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17812 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-29 21:47:05 +00:00
floitsch@google.com ed938af868 Rename new Uri.fromString to Uri.parse.
Review URL: https://codereview.chromium.org//12052038

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17562 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-24 13:26:18 +00:00
hausner@google.com a885f8638b Fix map literals from change 17410
Remove any type arguments from map literals
that had one type argument before change 17410.
Review URL: https://codereview.chromium.org//12045024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17412 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 17:31:29 +00:00
hausner@google.com dc3bf6646a Stop supporting map literals with 1 type argument
To be checked in next week Tue (Jan 22)

Review URL: https://codereview.chromium.org//12021022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17410 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-22 16:48:00 +00:00
nweiz@google.com 03244ffee1 Stop treating StreamController as a Stream.
Apparently StreamController will soon stop extending Stream, so this gets rid of
all uses of it as a Stream in pkg/http and pub.

Review URL: https://codereview.chromium.org//11975017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17163 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 21:35:45 +00:00
nweiz@google.com 013b0104f5 Add an ErrorGroup class to Pub.
Review URL: https://codereview.chromium.org//11941003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17106 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-16 00:12:30 +00:00
lrn@google.com ef13a0822b Make StreamController's unnamed constructor create a single-sub stream.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//11887016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17049 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-15 09:09:47 +00:00
nweiz@google.com 0109fd9664 No longer work around issue 7761.
This also moves Pub's modified _OutputStreamConsumer class into pkg/http.

Review URL: https://codereview.chromium.org//11881030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@17034 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-14 23:30:00 +00:00
lrn@google.com 4868ee2110 Remove Futures class, move methods to Future.
Optimize Future.forEach, Future.delay.

Review URL: https://codereview.chromium.org//11865005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16954 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-11 09:46:45 +00:00
nweiz@google.com fcff2fb2d9 Fix ALL the pub tests.
Review URL: https://codereview.chromium.org//11830017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16888 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 21:37:40 +00:00
nweiz@google.com 5741f611ba Update pkg/http to use the new async APIs.
Review URL: https://codereview.chromium.org//11825010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16834 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-09 03:10:42 +00:00
rnystrom@google.com 021b6438c5 Commit Martin's patch for pub + lib_v2.
Pub is still all kinds of broken with this, but it's slightly
less broken. Some tests pass, and at least the code *parses*
after this.

Review URL: https://codereview.chromium.org//11785028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16763 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 23:11:55 +00:00
sgjesse@google.com feda65bcc4 Update tests for pkg/http for new library
R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//11778021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16703 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 14:52:12 +00:00
ajohnsen@google.com 32eeecd930 Fix tests for VM in checked mode.
BUG=

Review URL: https://codereview.chromium.org//11801008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16689 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:59:49 +00:00
floitsch@google.com 4a7dfd2da3 Big merge from experimental to bleeding edge.
Review URL: https://codereview.chromium.org//11783009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16687 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-07 11:23:16 +00:00
rnystrom@google.com ac04fc6c18 Convert pkg/http to use "package:" imports.
Review URL: https://codereview.chromium.org//11746009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16620 260f80e4-7a28-3924-810f-c04153c831b5
2013-01-04 00:10:47 +00:00
nweiz@google.com 205f8ee5fc Use a semicolon as the separator for multipart form-data requests.
I believe both a semicolon and a comma are valid, but the semicolon seems more
widely-supported.

Review URL: https://codereview.chromium.org//11713003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16567 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-29 00:34:31 +00:00
sgjesse@google.com 7e293aa077 Reapply "Fix URI encoding/decoding of + and space""
Updated test expectations for some tests for pkg/http, pkg/oauth2 and
pub to match the change.

TBR=lrn@google.com

Review URL: https://codereview.chromium.org//11659009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16426 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-21 09:50:05 +00:00
sgjesse@google.com beaf02365a Change the HTTP Content-Length handling
Move the handling of the Content-Length to the HttpHeaders
object. This makes it possible to set the Content-Length through the
headers as well as directly on HttpResponse and HttpClientRequest.

R=ajohnsen@google.com

BUG=

Review URL: https://codereview.chromium.org//11637017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16357 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-20 08:50:00 +00:00
nweiz@google.com de54a75bfc Code review change for r16238.
Review URL: https://codereview.chromium.org//11647010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16344 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 21:41:13 +00:00
floitsch@google.com 319d50ea22 Make request_test wait for its results.
Review URL: https://codereview.chromium.org//11644025

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16341 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-19 21:16:38 +00:00
nweiz@google.com a8eb61fb8b Fix analyzer errors and warnings for pkg/http.
BUG=7458

Review URL: https://codereview.chromium.org//11617004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16238 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 00:26:15 +00:00
sgjesse@google.com 93514a3b28 Reapply "Stop working around issue 6984."
Originally committted in r15804 and reverted in r15825.

Issue 6984 should be fixed by r15951.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//11528005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15961 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 10:03:21 +00:00
rnystrom@google.com 89dbb7be66 Add "toString()" to BaseRequest.
Review URL: https://codereview.chromium.org//11480003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15869 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 21:49:27 +00:00
rnystrom@google.com e3bc775e68 Revert "Add logging system to pub and sprinkle some logging in."
This reverts commit 60468a1a0854389bb3f460cf2368f22013f1af31.

BUG=

Review URL: https://codereview.chromium.org//11472016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15830 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:48:12 +00:00
rnystrom@google.com 578c415134 Add logging system to pub and sprinkle some logging in.
We'll have to tune which things we log over time, but this covers
most IO operations which is where almost all of our problems come
from.

This patch also means that going forward you should no longer call
print() or printError() (which is gone) directly. Instead:

print() -> log.message()
printError() -> log.error()

That ensures all messages will correctly get added to the log's
transcript.

Review URL: https://codereview.chromium.org//11437019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15827 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:29:23 +00:00
nweiz@google.com 29318c2f5c Revert "Stop working around issue 6984."
Review URL: https://codereview.chromium.org//11464015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15825 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:09:19 +00:00
nweiz@google.com 01dd8fcb4e Stop working around issue 6984.
Review URL: https://codereview.chromium.org//11464006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15804 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 20:50:21 +00:00
nweiz@google.com 1855849da1 No longer work around issue 7013 and 7014 in pkg/http.
Review URL: https://codereview.chromium.org//11411327

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15657 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 21:14:07 +00:00
dgrove@google.com 33abe0ef0a Add authors and homepages to packages.
Review URL: https://codereview.chromium.org//11418267

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15601 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 21:16:01 +00:00
nweiz@google.com 5c7323f35d Keep around a copy of the http.Request that triggered each Response.
Review URL: https://codereview.chromium.org//11348309

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15555 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 00:09:18 +00:00
nweiz@google.com 2c1d51db1c Make pkg/http use HttpClient.shutdown(force: true).
Review URL: https://codereview.chromium.org//11434018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15485 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:47:09 +00:00
nweiz@google.com 558ffd19bf Work around issue 6984.
This ensures that before an HTTP response is closed, its corresponding
request is drained of input.

Review URL: https://codereview.chromium.org//11348285

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15476 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 22:43:10 +00:00
nweiz@google.com 295a066707 Use Futures.forEach in http.
BUG=

Review URL: https://codereview.chromium.org//11411241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15475 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 22:39:33 +00:00
nweiz@google.com 06e7344e22 Make #maxRedirects and #followRedirects work for the dart:io HTTP client.
Review URL: https://codereview.chromium.org//11414195

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15433 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 01:54:16 +00:00
sgjesse@google.com 7805f03972 Generate an error for active connections when the HTTP client is shutdown
Before the underlying sockets where just silently closed causing no more IO events on active connections no matter what state they where in.

Also added an optional "force" argument to HttpClient.shutdown. If that is false (the default) The HttpClient will not close active connections until they are done. This causes all pkg/http and pub tests to pass.

R=ager@google.com, nweiz@google.com

BUG=dart:6594

Review URL: https://codereview.chromium.org//11411121

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15275 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-23 09:28:34 +00:00