431761e878
Miscellaneous Observatory UI improvements
...
Update cursor over expander in profiler
Ressurect json-view
Show arrow in profiler tree
Clicking on <code-ref> link in profiler doesn't expand tree
<code-ref> only shows a link for Dart code
Port script-view to use script-inset
Add function source to function view
Add counters to isolate view
Add counters to isolate summary
R=turnidge@google.com
Review URL: https://codereview.chromium.org//221263002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34661 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 18:30:01 +00:00
2fe51715e5
Begins work on ARM64, first assembler test.
...
Most new code is in constants_arm64.h and
{assembler,disassembler,simulator}_arm64.{h,cc}
The rest of the CL just #def's out tests, modifies status files,
and adds UNIMPLEMENTED functions, etc.
R=regis@google.com
Review URL: https://codereview.chromium.org//221133002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34654 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 17:39:32 +00:00
ab19ef4f31
Redo allocationprofile options
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//217323006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34620 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 22:05:39 +00:00
cc82321046
Add <eval-link> - a custom element for evaluating an expression.
...
Use <eval-link> to add a convenience toString() link for instances.
In the future I plan to use <eval-link> to provide easy access to getters.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//213853004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34616 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 20:18:17 +00:00
b373e6c423
Change how we provide value previews in the vm service.
...
Rename the 'preview' property to 'valueAsString'.
Rework printing so that we only add 'valueAsString' when we need it
(num, String, etc.).
Change ToUserCString to be a String-only method. Drop ToUserCString
for lists -- it was hokey and unused. Max string length is now 1024
instead of 40.
Update tests.
BUG=
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//219333011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34612 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 19:45:57 +00:00
59fcec073c
Don't make the signal-pipe non-blocking.
...
This is an attempt to make it run on MIPS. The non-blocking is not
needed here.
BUG=https://code.google.com/p/dart/issues/detail?id=17826
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//220863003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34594 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 12:15:21 +00:00
45d35b1588
Make non-copying version of BytesBuidler and make file-reads faster.
...
The non-copying version is internally, as this is always the behaviour
we want, when receiving data from the system.
File-reads are also further improved, by only reading data in chunks, if
initial length is 0. This is a special case where the file can be a
character device. Overall improvement is around a factor of 6.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//218493012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34589 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 10:56:19 +00:00
e78cc1544d
- Make ports be less predictable.
...
- Limit the range of port numbers to 30-bits.
- Parse the ports as 64-bit values when reading from the wire in the debugger protocol.
R=hausner@google.com
Review URL: https://codereview.chromium.org//217693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34542 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 23:39:36 +00:00
9b814028a3
Minor fix in isolate-view.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//217473004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34530 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 22:09:53 +00:00
3e86631f02
Use tokenPos instead of line/col in the vm service.
...
Add line number information to the Script response.
Parse line number information in the observatory.
Update <script-ref> to take a pos argument
Add a new <script-inset> element which shows a code snippet.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//216883008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34528 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 21:24:24 +00:00
3adcbe1071
Rework the <field-view> page.
...
Give fields/functions a consistent notion of ownership.
Add field's script to the JSON.
Make page reload work again.
Fixup closure printing a bit.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//215213003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34520 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 20:21:09 +00:00
99fca31c02
Support Types in instance-ref/instance-view.
...
Refactor JSON printing for all instances to share more code. This allows Types to act like Instances in Observatory.
Update the look and feel for the function-view page.
Add script info for functions.
Update tests.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//211283004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34435 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 17:13:03 +00:00
862687a1ad
Don't use ThreadSignalBlocker in mac eventhandler.
...
Turns out kevent can modify the current sigmask.
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//212193002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34408 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-26 06:21:38 +00:00
182fcd0921
Add isolate tag-profile model and UI.
...
Distinction between a Dart Error and a ServiceError/ServiceException.
Better Observatory behaviour when a ServiceError/ServiceExceptions occurs.
Display isolate's sticky error.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//205713004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34377 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 18:09:02 +00:00
644e1f50aa
Fix mac part of previous commit.
...
BUG=
Review URL: https://codereview.chromium.org//207553004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34362 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 14:20:45 +00:00
1a8f76beb3
Only return eventhandler tokens in stacks of 8, to avoid runtime calls.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//208653012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34359 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 13:44:01 +00:00
4f613457d6
Speed up GetRandomBytes by only entering signal-blocking scope once.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//209333014
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34356 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 13:06:37 +00:00
ffdca5647a
Fix PrintToJSONStream for oddball functions
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//196173022
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34338 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 21:58:45 +00:00
23d06d9db0
Rework how ServiceObjects are created and cached in Observatory.
...
We now use a single cache, rather than per-type caches which simplifies the get() logic and makes it easier to add more model-types in the future.
Rework how isolates are created/stored/retrieved. IsolateList is gone.
Add canCache and immutable to ServiceObjects and use them to inform when an object should be cached or reloaded.
Remove cache.dart, service.dart.
Add a notion of a ServiceObjectOwner.
Cleanups.
Etc.
Etc.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//204983008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34333 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 21:42:26 +00:00
f79179cbdb
Be sure we to read all bytes requested, in GetRandomBytes.
...
BUG=https://code.google.com/p/dart/issues/detail?id=17723
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//209983002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34305 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 13:40:29 +00:00
f13a5b700f
Allow built in Observatory to work on any port
...
https://code.google.com/p/dart/issues/detail?id=17537
R=turnidge@google.com
Review URL: https://codereview.chromium.org//208243006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34267 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 20:06:24 +00:00
8516b12799
Switch to using pub build instead of custom build_.dart script
...
R=turnidge@google.com
Review URL: https://codereview.chromium.org//199633007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34263 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 18:24:07 +00:00
3529ba0a7e
Modify secure_socket.cc to use new NSS memio api.
...
R=kustermann@google.com
Review URL: https://codereview.chromium.org//207413003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34236 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 09:25:36 +00:00
bfe05a3ca8
Update NSS to NSS 3.16 RTM
...
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//201853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34235 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 09:17:08 +00:00
d302dc431a
Auto delete persistent weak handles during finalization after invoking the callback associated with the weak handle.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org//205153002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34208 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 21:45:43 +00:00
9c5c7040dc
Add a VM page to the observatory.
...
Make the VM a ServiceObject. Some refactoring in the ServiceObject
implementation.
IsolateList is no longer a ServiceObject. It should eventually become more like our caches.
Support the /vm request in the vm. Remove isolate list request.
Improvements to Isolate::PrintToJSONStream: always provide a
reasonable name. Use the same code to produce isolate refs and
non-refs.
Improve isolate status message when the isolate is paused at
start/exit. Add a resume link to the isolate view.
Add a navbar to the error page so that dartium users are less likely
to get stuck.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//206213004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34204 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 21:00:10 +00:00
9a8671276b
Add class and address information to heap map; display on hover.
...
Display a string like "String @ 0xe97c3328" while hovering over the map.
Also add page separators (black).
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//204103009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34195 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 18:56:45 +00:00
e93dd02838
Support doubles in observatory.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//199443008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34190 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 18:17:16 +00:00
9079108be8
Remove previous debug printing.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//206333005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34175 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 15:34:03 +00:00
0244fa2a77
Add debug-printing to file, and remove from test.
...
Adding the debug print made the test stop failing.
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//206263005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34168 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 14:24:20 +00:00
4cf3726fe6
Close(destroy) Socket on user-generated write error.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//204343003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34109 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-19 09:23:17 +00:00
8d5461c2e7
Regenerate Observatory js
...
Review URL: https://codereview.chromium.org//204013004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34075 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 22:35:59 +00:00
6952f5ddfe
Use VM tag in profile and add stack trace trie
...
R=asiva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//201213004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34064 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 21:20:41 +00:00
157bc5719c
Move all service objects to one file ahead of refactor.
...
Review URL: https://codereview.chromium.org//203243006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34051 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 19:14:26 +00:00
e9eb700bfa
Implement isolate view page.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//197873028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33812 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 16:24:00 +00:00
75bc44734f
Fix comments of previous commit.
...
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//200793006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33802 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 12:54:20 +00:00
23aea27441
Prefix io part uri's with 'dart:io/'.
...
BUG=https://code.google.com/p/dart/issues/detail?id=17083
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//203073004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33799 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 11:29:06 +00:00
2493b45413
Make http-imports faster to load, by hinting persistent connection on request.
...
Also avoids a BytesBuilder, if only one chunk is received. This speeds
up e.g. 'pub build' notably (4x speedup).
BUG=
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//203213002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33798 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 08:57:00 +00:00
7fbb7cd5dc
Rework library and class view pages.
...
Add expression evaluation support for libraries and classes.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//199363002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33755 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 17:43:07 +00:00
5790e70744
Visualize heap fragmentation in Observatory.
...
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//197923005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33754 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 17:16:53 +00:00
0c157cd31e
Move signal_blocker to platform and use it by default in TEMP_FAILURE_RETRY.
...
BUG=http://code.google.com/p/dart/issues/detail?id=16927
R=johnmccutchan@google.com , sgjesse@google.com
Review URL: https://codereview.chromium.org//165723007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33745 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 13:51:11 +00:00
09a4f24413
Add exitCode getter counterpart to the existing setter in dart:io.
...
BUG=https://code.google.com/p/dart/issues/detail?id=16217
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//200233002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33737 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 10:40:19 +00:00
f99c83e54a
Show object pool on code page
...
BUG=
R=turnidge@google.com
Review URL: https://codereview.chromium.org//197853005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33702 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 17:03:38 +00:00
0c885fde33
Use mutex around getaddrinfo on windows, as it's not thread-safe.
...
BUG=https://code.google.com/p/dart/issues/detail?id=17237
R=sgjesse@google.com
Review URL: https://codereview.chromium.org//200083002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33690 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 10:25:16 +00:00
6ea46abd34
Create a shadow table to track CodeRegions of reused code address space.
...
R=asiva@google.com , turnidge@google.com
Review URL: https://codereview.chromium.org//197803004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33665 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 21:00:44 +00:00
3b29063492
Don't act on return-token commands on Windows.
...
BUG=
Review URL: https://codereview.chromium.org//199063004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33653 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 15:23:08 +00:00
9a71498127
Make the event-handler handle backpreasure.
...
We now limit the number of active events per fd to 8.
BUG=
R=whesse@google.com
Review URL: https://codereview.chromium.org//198743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33649 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 12:02:47 +00:00
a08b282ee8
Use a sync-writing StreamConsumer for stdout/stderr.
...
This makes stdout.write and stderr.write block, until the write is done.
BUG=https://code.google.com/p/dart/issues/detail?id=17020
R=whesse@google.com
Review URL: https://codereview.chromium.org//195893012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33645 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 11:20:34 +00:00
9b25d2f09b
Make service-view programmatically switch views
...
This has the side effect of fixing most of the Polymer exceptions when switching views.
R=turnidge@google.com
Review URL: https://codereview.chromium.org//195763005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33630 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 23:32:19 +00:00
6ceb9ad3ce
Correct capacity reporting for new space; show external size in Observatory.
...
Before, the reported capacity included *both* semi-spaces, which seems wrong.
Also exclude external size from capacity, to be consistent with old space and
the comment on Heap::CapacityInWords.
R=johnmccutchan@google.com
Review URL: https://codereview.chromium.org//196603009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33625 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 23:12:48 +00:00
johnmccutchan@google.com