Commit Graph

57 Commits

Author SHA1 Message Date
sigmund@google.com c4e9285475 minor fixes in custom_element so we can publish it.
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//217233002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34518 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-28 19:58:32 +00:00
vsm@google.com f334b9591d Fix static warnings in custom_element package
BUG=http://dartbug.com/17773
R=blois@google.com

Review URL: https://codereview.chromium.org//211033008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34372 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-25 17:18:03 +00:00
efortuna@google.com 4bf8e46dcc Remove the html warnings!
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//164743003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32678 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 22:23:21 +00:00
efortuna@google.com f91b102ccb "Reverting 32641"
BUG=

Review URL: https://codereview.chromium.org//162843002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32642 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 05:52:21 +00:00
efortuna@google.com c1e36a1efe Reapply "remove html warnings."
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//162413002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32641 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-13 01:43:25 +00:00
efortuna@google.com 7acd2cc7c7 Revert all html warning changes.
For the sake of ease of cherry-picking, I'm going to back this change out to
apply all at once, once I fix this postMessage test failure on Dartium.

BUG=

Review URL: https://codereview.chromium.org//160963004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32630 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 22:12:18 +00:00
efortuna@google.com dd29511add Fix analyzer test failure.
BUG=

Review URL: https://codereview.chromium.org//153653008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32619 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-12 20:37:53 +00:00
jmesserly@google.com 7d71bc988d introduce web_components pkg to replace shadow_dom, html_import, custom_element. This new package is 100% compatible with the polyfills used by http://www.polymer-project.org/
Deletes:
  pkg/shadow_dom
  pkg/custom_element (except web_ui stuff)
  pkg/html_import

Adds:
  pkg/web_components, with README.md and build instructions

Changes:
  pkg/html5lib -- deprecate queryAll/query in favor of *Selector
  pkg/polymer -- test fixes & a few small changes to work with new polyfills, mostly in build
  tests/html/custom -- can't load the CE polyfill at runtime, must now be injected statically via an HTML page, similar to the style @blois used for some custom element tests.

R=blois@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//158083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32533 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-11 01:15:05 +00:00
blois@google.com bff7179948 Fixing issues from IDL upgrade
* CustomElement update to match new Element syntax fixes analyzer issue
* Document.createTreeWalker/createNodeIterator change to pass in last argument for IE11.

TBR
BUG=

Review URL: https://codereview.chromium.org//153603004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32513 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 19:39:50 +00:00
jmesserly@google.com 6d319d8cc9 move workaround from CE polyfill to custom elements createdCallback
github changes: https://github.com/dart-lang/CustomElements/pull/5

R=sra@google.com

Review URL: https://codereview.chromium.org//149313004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32307 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 04:15:35 +00:00
jmesserly@google.com fdc29a9ed5 regenerate fixed custom_elements polyfill
fixes an issue in the previous package, it was missing MutationObservers which it expects included in the binary generated by Grunt.
This did not happen because the sources are pulled in from a relative path, rather than being included in the repository, and there was unfortunately no error issued.

R=blois@google.com

Review URL: https://codereview.chromium.org//153063003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32263 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 21:52:24 +00:00
jmesserly@google.com 0f277224e8 update custom elements and shadow dom
R=blois@google.com

Review URL: https://codereview.chromium.org//140853005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32171 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 20:56:22 +00:00
jmesserly@google.com 20b120eba2 Fix for dart2js mirrors caching with custom elements
Custom elements code is from https://github.com/dart-lang/CustomElements/pull/4

R=sigmund@google.com

Review URL: https://codereview.chromium.org//112613003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31296 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-19 19:55:57 +00:00
jmesserly@google.com a526b4ed3a update our CustomElement+Shadow DOM patch
https://github.com/dart-lang/CustomElements/pull/3
fixes https://code.google.com/p/dart/issues/detail?id=15354

R=blois@google.com

Review URL: https://codereview.chromium.org//112433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31078 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-11 20:31:26 +00:00
jmesserly@google.com 3c7bece94a restore 30868 and 30873
the only difference from what you already reviewed is the inclusion of:
https://github.com/dart-lang/CustomElements/pull/2

A shame your pull request from 3 months(!) ago hasn't been accepted

(reverts 30875)

R=blois@google.com

Review URL: https://codereview.chromium.org//105783003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30967 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-06 20:51:20 +00:00
jmesserly@google.com e5b35ae519 Reverting 30868 and 30873.
There's still a problem in document_register_type_extensions_test that isn't obvious. Need more time to investigate.

Review URL: https://codereview.chromium.org//105203006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30875 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 22:51:54 +00:00
jmesserly@google.com 84c98a2902 update TemplateBinding to 119bbab376aa4a8ee96a5354e3ebe84395d1da62
* fixes an issue where not having a sub-template results in incorrect custom element upgrade.

update custom elements to 93a27b791d4bfdddad3be17fccda3c5052bf4a16
* needed to work with the latest TemplateBinding (specifically the importNode fix)

Note that custom elements code is from: https://github.com/dart-lang/CustomElements/pull/1

R=blois@google.com

Review URL: https://codereview.chromium.org//98533004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30868 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 20:59:56 +00:00
sigmund@google.com aaf8927792 Fixes in custom_element.dart: some of the code was broken, fixes needed for
those using web-ui

(patch follows from issue 53293003)

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//48713012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29860 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-04 23:47:48 +00:00
lrn@google.com 7a76ad7834 Add @proxy to annotations.dart.
Remove package:meta

R=bak@google.com, brianwilkerson@google.com

Review URL: https://codereview.chromium.org//46593003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29525 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-30 10:25:08 +00:00
jmesserly@google.com 34085ccdb5 port Node.bind to bd0a0591920da9091b326627a46a104a92c7efe7
the first step to fix https://code.google.com/p/dart/issues/detail?id=13950

R=sigmund@google.com

Review URL: https://codereview.chromium.org//42433002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29294 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-25 21:39:06 +00:00
blois@google.com 0e97c7197a Integrating fix for IE9 custom elements upgrade
BUG=13193
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//41083002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29197 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 19:21:46 +00:00
jmesserly@google.com 0acc931fc4 port polymer data binding tests
R=sigmund@google.com

Review URL: https://codereview.chromium.org//25740006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29139 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-24 00:59:31 +00:00
jmesserly@google.com 4194748695 remove old custom_element polyfill
just some cleanup. this was the stopgap xtag polyfill for Polymer; we never used it in web_ui to my knowledge. it's obsolete with document.register

R=blois@google.com

Review URL: https://codereview.chromium.org//36373004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29116 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 20:21:07 +00:00
jmesserly@google.com 04c0d63166 fix build due to mdv -> template_binding rename
BUG=

Review URL: https://codereview.chromium.org//35683006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29058 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 02:25:05 +00:00
sigmund@google.com 996f42cf7a Fixes needed for the deploy step.
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//34623011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29053 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 01:04:09 +00:00
blois@google.com 95d32c5c6b Closing register/upgrade timing hole primarily impacting IE
See Polymer issue https://github.com/Polymer/CustomElements/issues/76

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//36303003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@29052 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-23 00:47:12 +00:00
jmesserly@google.com 821e6fec2a Several fixes here to fix bugs and get our tests into a reliable state:
* customElementsReady future. We don't fire Polymer.onReady until custom elements are ready too

* deploy without dart.js by default. This is the expected deployment mode for real apps. Also make sure we test this on DRT and compiler==js, so Pete can change Dartium without causing build breaks :)

* stop using "package:observe" test "performMicrotaskCheckpoint" hack in Polymer. This was too blunt; it affected timing of all async operations. Instead we only trigger Observable.dirtyCheck. It's using the latest Zone API as well.

* mixin ChangeNotifier explicitly. This is mainly to fix a quirk of our test environment (test server loads "packages/polymer" in untransformed mode, causing it to pick up Observable instead of ChangeNotifier).

* fix change watchers to blacklist "attributeChanged" :)

* fix serializeValue to only use the runtime value

* fix deserializeValue to get the right Type for dart:core types

* cleanup prop_attr_reflection_test to use mutation observer

R=blois@google.com, sigmund@google.com

Review URL: https://codereview.chromium.org//29823005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28956 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-21 21:49:51 +00:00
floitsch@google.com 0f7a0bd7b1 Rename runAsync to scheduleMicrotask.
R=lrn@google.com

Review URL: https://codereview.chromium.org//26151002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28569 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-12 15:52:17 +00:00
blois@google.com 1426a55a47 Adding platform patches to allow custom elements polyfill to work with Shadow DOM.
The specific issue was that elements existing in the page before the tag was registered was causing issues. This is encountered with the <polymer-element> tag.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//26558008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28434 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-10 00:30:08 +00:00
efortuna@google.com eaa854b258 Move Rectangle and Point into dart:math.
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//25808002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28272 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-04 17:47:39 +00:00
blois@google.com 05bb03642d Implementing CustomElement's attributeChanged callback in dart2js.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//25325004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28168 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-02 15:57:56 +00:00
jmesserly@google.com cf3dcfba4c Port Polymer.js Core, the github.com/polymer/polymer code.
Ports all features except where JS interop is blocking us (declaration/path.js and instance/style.js). In particular, this has:
  //   src/declaration/attributes.js
  //   src/declaration/events.js
  //   src/declaration/polymer-element.js
  //   src/declaration/properties.js
  //   src/declaration/prototype.js
  //   src/declaration/styles.js
  //   src/instance/attributes.js
  //   src/instance/base.js
  //   src/instance/events.js
  //   src/instance/mdv.js
  //   src/instance/properties.js
  //   src/instance/utils.js
  //   src/lib/deserialize.js
  //   src/lib/job.js
  //   src/lib/dom.js -- not needed in Dart
  //   src/lib/lang.js -- not needed in Dart
  //   src/lib/super.js -- not needed in Dart

There's also a big architectural change: polymer-element data is now stored in the PolymerDeclaration class, which is separate from PolymerElement. This allows us to avoid duplicate work on every constructor, and should significantly speed up instance creation.

All code is from the same revision:
https://github.com/Polymer/polymer/blob/4dc481c11505991a7c43228d3797d28f21267779

The remaining unported files are for relatively minor features. "declaration/path.js" is for asset URL resolution, and we might have a Pub-based solution instead. "instance/style.js" has an opt-in, advanced style polyfill. It needs "ShadowCSS.shimPolyfillDirectives", and probably isn't too hard to make work in a follow up change.

Other changes:
* attributeChanged lifecycle method is implemented.
* ObservableAnnotation is public so Polymer's @published can subclass it
* bindProperty renamed to onPropertyChange to avoid conflict with Polymer member of the same name.
* polymer/lib/boot.js preload's polymer-element and link[rel=stylesheet]

R=blois@google.com

Review URL: https://codereview.chromium.org//24149003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28134 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 23:45:37 +00:00
blois@google.com 1aa8a7be0e Adding Element.created constructor and .created constructors to all subclasses. Also ensuring generative constructor for all superclasses.
This is for post-construction custom element creation.

Element.created is public, then the base classes of that get private ._created constructors.

BUG=
R=vsm@google.com

Review URL: https://codereview.chromium.org//24653006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@28120 260f80e4-7a28-3924-810f-c04153c831b5
2013-10-01 21:26:06 +00:00
blois@google.com b5bc0e1367 - Fixing analyzer error on legacy custom element polyfill
- Adjsuting IE status (filed bug to investigate)
 - Fixing polymer tests on Dartium

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//24168006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27846 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 20:11:36 +00:00
blois@google.com 209e413a5c Retry of custom element lifecycle events.
First patch is the original, changes were:
 - Shadow DOM upgrade landed as separate CL
 - CustomElement polyfill wasn't always firing WebComponentsLoaded event (causing timeouts on FF and IE), fixed polyfill.
 - Dartium test exclusions were not working

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23498053

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27841 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-24 19:14:16 +00:00
blois@google.com 6def065afd Revert "Dart2js support for custom element lifecycle events"
This reverts commit 27729. Shadow DOM polyfill appears to have regressed some tests and some issues are coming up with the browser controller.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//24251016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27730 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-21 00:46:48 +00:00
blois@google.com fb8f32bcc4 Dart2js support for custom element lifecycle events
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//24096027

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27729 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-20 23:49:12 +00:00
blois@google.com 2ed732dac4 Updating custom elements polyfill to the latest github.com/dart-lang version.
This is just updating the SVN repo to the compiled versions of: https://codereview.appspot.com/13669045/

TBR
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23531051

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27502 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-13 20:53:53 +00:00
kathyw@google.com ef3f516570 one-liners for a few polymer-related libraries
R=jmesserly@google.com, mcampione@google.com

Review URL: https://codereview.chromium.org//23441054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27500 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-13 20:25:19 +00:00
blois@google.com b904bf81ba Revert "Revert "Tag extensions""
Original CL is the first patch, changes follow. Includes fixes for Chrome test failures and Firefox type check issues.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23442011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27313 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-09 22:03:43 +00:00
efortuna@google.com b0e059159f Adjust CustomElement as properties again.
BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23969002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@27146 260f80e4-7a28-3924-810f-c04153c831b5
2013-09-04 20:11:11 +00:00
blois@google.com 6570db562c Revert "Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking."
This reverts commit r26935. Failing in FF checked on type extension and IE9 on synchronous constructor upgrading, need to investigate.

TBR
BUG=

Review URL: https://codereview.chromium.org//23567006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26938 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:37:23 +00:00
blois@google.com 5607d75eca Basic functionality is working with JS native support and polyfill, still some issues with dart2js typechecking.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23190026

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26935 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 19:08:19 +00:00
efortuna@google.com ea773ef953 Update CustomElement as well.
BUG=

Review URL: https://codereview.chromium.org//23819006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26931 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-30 17:41:30 +00:00
blois@google.com 93c361dd36 This is an updated version of https://codereview.chromium.org/16374007/
Original submission is the first patch, fixes are the second.

There were two issues with the original-
  - Issue with URI sanitization where relative URIs on IE were being dropped.
  - Analyzer issue on missing members for CustomElement.

BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23525003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26757 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-28 01:03:01 +00:00
efortuna@google.com 92d2bd8c28 Fix api for dart2js tests that failed.
BUG=

Review URL: https://codereview.chromium.org//23060041

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26606 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 19:15:33 +00:00
efortuna@google.com 90873051ad Making almost all dom_ methods private. Exceptions will be addressed in a later CL.
Current ones that still remain to be made private include createElement(NS),
createRange, all the Element properties, and childNodes.

BUG=
R=blois@google.com

Review URL: https://codereview.chromium.org//23055008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26605 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-23 18:25:40 +00:00
blois@google.com ec11e52f62 Revert "Revert "Adding polyfill support for custom elements.""
This fixes the issues in the custom elements polyfills.

R=jmesserly@google.com

Review URL: https://codereview.chromium.org//23301012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26412 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-21 00:08:46 +00:00
blois@google.com 508affefed Revert "Adding polyfill support for custom elements."
Caused issues with DocumentFragment and some lingering changes from the blink roll.

BUG=

Review URL: https://codereview.chromium.org//22957010

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26410 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 23:28:22 +00:00
blois@google.com 72651260aa Adding polyfill support for custom elements.
BUG=
R=jmesserly@google.com

Review URL: https://codereview.chromium.org//22967006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26405 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-20 22:56:08 +00:00