b4cdb0dc98
Add new performance option to get both cold and warm timings.
...
@Rico: Does it matter that the errors will be written between the two sets of timings?
R=scheglov@google.com
Review URL: https://codereview.chromium.org//227533005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34817 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 11:08:36 +00:00
bd532a6990
Correct or pause previous TimeCounters.
...
R=brianwilkerson@google.com , jwren@google.com
BUG=
Review URL: https://codereview.chromium.org//225183020
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34809 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-08 05:08:08 +00:00
6da7a82a20
Fix for translation of \!= to \!identical(), but use == and \!= for Enum.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//221483002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34636 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-02 03:09:22 +00:00
1145c19860
Rollback pkg/analyzer that breaks code_transformers
...
R=blois@google.com , brianwilkerson@google.com , sigmund@google.com
BUG=
Review URL: https://codereview.chromium.org//214593008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34479 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 20:29:08 +00:00
240b4138ce
Translate Java enums to Dart constants.
...
1. Restore "this.field" field formal initializers.
2. Tweaks for several Java places - mostly to the constructors; but also duplicate HintCode messages (in Dart we cannot get values of constant values final fields).
3. Translate field that are not written to Dart final fields and also to field initializers, even if there are no property for them.
4. And constant enums.
5. pkg/code_transformers/test/resolver_test has to be skipped, I cannot fix it myself.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//214253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34474 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-27 15:37:37 +00:00
eedaae10e6
Optimizations for hashCode.
...
This improves Dart-based analyzer performance.
dart2js: 12500 -> 11600 ms, about 900 ms or 7%.
blueshift: 23500 -> 21500 ms, about 2000 ms or 8%.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//207853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34318 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-24 18:18:14 +00:00
624addf47e
Don't print TODOs in Dart based analyzer.
...
Java based doesn't print them too.
This improves dart2js analysis from 12500 to 11300 ms, i.e. about 1200 ms or 10%.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//207693002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34254 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 16:14:11 +00:00
8be101185a
Fix analysis of parts
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//200783006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34253 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 16:10:17 +00:00
d12545d5fa
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//207023002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34227 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-21 05:09:57 +00:00
3185364c4e
Partial fix for AST cloning. This change won't get made by the translator, but you might want to just copy it into the CL with translator changes in order to reduce the number of times we have to increment the version number.
...
R=scheglov@google.com
Review URL: https://codereview.chromium.org//205243008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34202 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 20:33:50 +00:00
5edf555a9a
New analyzer snapshot.
...
R=blois@google.com , brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//197213036
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34188 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-20 17:38:28 +00:00
2c034bfe3f
Updating code_transformers to not fail on syntax errors
...
Recent changes started using the Analyzer's parseCompilationUnit method which throws exceptions on syntax errors, but this is undesirable in many cases. Adding an option to disable this behavior and using that in code_transformers.
BUG=
R=scheglov@google.com , sigmund@google.com
Review URL: https://codereview.chromium.org//204033003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34070 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 22:09:17 +00:00
ed38678776
Collect analysis errors from change notifications.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//202633002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33780 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-17 22:14:25 +00:00
c3cb70a124
Fix batch mode to now print out errors, this gets us closer to the FYI bot passing
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//200423006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33725 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 22:20:44 +00:00
d160c5b259
Forgotten change in analyzer.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//200613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33711 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 19:44:39 +00:00
b3be009788
Restore batch mode in the Dart-based Dart analyzer
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//200523003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33709 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 19:09:22 +00:00
206c643c4e
Analyzer snapshot with disabled 'this.field' generation.
...
This should help to workaround https://code.google.com/p/dart/issues/detail?id=17483 is Spark.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//200583002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33708 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-14 18:22:14 +00:00
b39018a1ba
New verbose flag for the dart command line analyzer
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//196223004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33656 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 17:13:09 +00:00
b058e9b442
New analyzer snapshot.
...
It includes optimization that Jaime made today.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//198453002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33636 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-13 06:34:29 +00:00
8a54c6f9d2
Fix handling of 'else if' statement blocks (dartbug.com/17363).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//196983003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33613 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 21:11:30 +00:00
84de116968
Nit change in the Dart command line analyzer and analysis server.
...
Logger.logError takes a String, not Error types. This will enable the exception to be printed, instead of the message '<SomeError> is not a String'.
Also, in the command line version of the dart analyzer, I put in a commented out stdout/stderr logger for developers.
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//196373003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33587 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:30:23 +00:00
979ef447b0
Formatter space/tab width configuration fixes (dartbug.com/16969).
...
R=brianwilkerson@google.com , danrubel@google.com
Review URL: https://codereview.chromium.org//196243003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33586 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 16:25:45 +00:00
978872b5ad
Convert the command line dart analyzer to be async.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//195483004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33558 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 22:05:37 +00:00
f68715dd64
Increase Dart based command line analyzer cache size to 512.
...
R=danrubel@google.com
BUG=
Review URL: https://codereview.chromium.org//195563003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33554 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-11 21:07:57 +00:00
0d6637eb53
Translate Java's @Override into Dart's @override.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//192363003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33474 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-10 02:20:23 +00:00
34255da9a2
Support for @DartName and @DartOptional annotations.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//192303002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33472 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-10 01:12:42 +00:00
844751f9ed
Support for DartBlockBody, DartExpressionBody, DartOmit in java2dart.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//189433006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33468 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 23:53:28 +00:00
dbed544450
Analzyzer test fixes
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//189443009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33464 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 23:18:17 +00:00
a674327095
Translate private Java members to private Dart members.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//189803004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33453 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 20:59:57 +00:00
f4a2d2ae9b
Change to dart command line analyzer- Remove the rich toString in AnalyzerError to prevent .contents from being called on a source.
...
R=brianwilkerson@google.com , scheglov@google.com
Review URL: https://codereview.chromium.org//189913004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33452 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-07 20:55:25 +00:00
151c4c3a7d
Improved 'has' properties translation.
...
New analyzer snapshot.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//189043003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33399 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 22:18:26 +00:00
9d622fc1d9
Unroll 'synchronized {}' in java2dart.
...
...and corresponding 'analyzer' snapshot.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//185403018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33318 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-05 02:30:21 +00:00
12558a8511
New analzyer snapshot.
...
Replace isInstanceOf() with a predicate.
Tweaks for other packages.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//186153005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33304 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 21:50:40 +00:00
1f8c20a04d
Update and analyzer snapshot with AST -> Ast rename.
...
R=brianwilkerson@google.com , rnystrom@google.com , blois@google.com , karlklose@google.com
BUG=
Review URL: https://codereview.chromium.org//185603002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33296 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-04 20:02:28 +00:00
79e687be71
Add timing info for file IO into Dart based analyzer.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//179123010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33191 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-01 19:47:36 +00:00
7f73657ad6
New analyzer snapshot.
...
No 'isInstanceOf' changes yet.
Just current state with changes required to adopt to the API changes in Java.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//184893003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33176 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-28 22:52:15 +00:00
a2ff040825
Option to disable Angular in Dart-based Analyzer.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//175793004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32936 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 22:32:28 +00:00
ca7f5ebf71
Support for removing empty statements (dartbug.com/16810).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//169283013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32918 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 19:20:32 +00:00
7b7b87ed97
Fix to ensure decls with initializers get their own lines (dartbug.com/16849).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//170403004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32873 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-20 22:46:24 +00:00
27fcf8df64
Issue 16827. Add 'set length' to NodeList.
...
https://code.google.com/p/dart/issues/detail?id=16827
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//170723002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32746 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-18 17:06:50 +00:00
1c5bdef314
Fixes for exit problems.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//135593009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32446 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 19:32:51 +00:00
79f352e4c2
Constructor initializer indent fixes.
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//141443011
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32396 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-07 00:15:24 +00:00
18c4e5c74e
Fixes for empty class and method bodies.
...
See Kevin's nits CL for more context: https://codereview.chromium.org/153623006/
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//151243003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32378 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 19:28:18 +00:00
bd4d6033ba
New analyzer snapshot.
...
1. Rename WorkManagerPriority -> SourcePriority.
2. Replace CharSequence with String.
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//156763002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32373 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 18:09:20 +00:00
a85da5e2d8
New analyzer snapshot.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//131233009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32362 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 15:31:22 +00:00
5f9e9b47e5
Fix for JavaFile path in DDA.
...
R=brianwilkerson@google.com
BUG=
Review URL: https://codereview.chromium.org//156503002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32361 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-06 15:08:29 +00:00
eaae0b64dc
Fix to ensure no breaks after new and general zero-length space support (dartbug.com/16379).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//156033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32332 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-05 18:41:14 +00:00
5c26be4b49
Indent fix for trailing comments (dartbug.com/16383).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//153203002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32287 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-04 20:50:12 +00:00
07888b2f25
Indent fix for switch statement defaults (dartbug.com/16406).
...
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//150533003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32174 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 21:39:28 +00:00
18ad816d5f
Max line length test fix (dartbug.com/16405).
...
The rub: two off by ones! --- Proof that two wrongs don't make a right! :)
R=brianwilkerson@google.com
Review URL: https://codereview.chromium.org//149913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32166 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-30 18:35:17 +00:00
brianwilkerson@google.com