dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
104,988 Commits 2 Branches 0 Tags
03fd2aaa4eae56cfcfc9d0bcd0ca9f3d5946ca18
Commit Graph

9630 Commits

Author SHA1 Message Date
FMorschel 1c4d7e1d4d [DAS] Fixes multiple fixes for insertions in multi-file library 
Merges the test in https://dart-review.googlesource.com/c/sdk/+/401840 that is related to https://dart-review.googlesource.com/c/sdk/+/401180, but in the LSP handler where it can be more easily debugged.

R=pquitslund@google.com

Fixes https://github.com/dart-lang/sdk/issues/59572

Change-Id: I03874be3671dfbfa65a2f0b9f3916ecafcad9400
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401865
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2025-01-06 13:50:12 -08:00
Brian Wilkerson 36e605d014 [Migrate] flutter.dart (extensions) 
Change-Id: I9546d82fd8bd307a06ca9b56ca38a7c4d8cbbce6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/403140
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2025-01-06 10:39:48 -08:00
Brian Wilkerson 0e880e8084 [Migrate] Remove two files that are already migrated 
Change-Id: I60f83a66cbbeb1f71718f647a6133babb6398a4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402940
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-01-03 11:22:38 -08:00
Brian Wilkerson 8b9428b320 [Migrate] edit_get_available_refactorings.dart 
Change-Id: I18a89fafdd9badd51cb852c840b0da04227ca3d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402901
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2025-01-03 11:05:18 -08:00
Brian Wilkerson 9d040aaea9 [Migrate] move_file.dart 
Also removes an already migrated file from the list.

Change-Id: I76b88802b7867abe77867713166b048ee7b8cb0a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402882
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2025-01-03 10:15:49 -08:00
Sam Rawlins fe9c469a3d DAS: Correct some comment references 
Change-Id: Iec84f23655298662eef0b0e44f7bb8586348833d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402423
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-01-03 09:47:19 -08:00
Brian Wilkerson c02b3a4ea8 [Migration] occurrences_dart.dart 
Change-Id: I55f821655ed5f2430e752748231bdf1a1c0279e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402840
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2025-01-03 09:09:59 -08:00
Konstantin Shcheglov 2d23904694 Issue 57018. Fix for inlining a getter when it is the target of a prefixed identifier. 
Bug: https://github.com/dart-lang/sdk/issues/57018
Change-Id: I5a421d21e12b6b830796383a5dcb97dd01f3dac1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-01-03 08:35:48 -08:00
Devon Carew 7b13bf7541 [analysis_server] move package:matcher to a dev_dependency 
Change-Id: Id4ed2ea8c960ca35bb1abbe74fdf2a711baf3c1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402586
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2025-01-02 18:41:22 -08:00
Brian Wilkerson 242a20e64b Remove an unreferences assist kind 
Change-Id: I4accda710fececceff2fae3ba5a8014a89e504d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402760
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2025-01-02 16:32:59 -08:00
Konstantin Shcheglov 5dc0e3cd3d Issue 57019. Fix for inlining method expression into interpolation. 
Bug: https://github.com/dart-lang/sdk/issues/57019
Change-Id: Ib69093db3fdfb6e8f4cf3d7a8e6036fda59faf97
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402587
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2025-01-02 16:25:58 -08:00
Sam Rawlins d3fed4088b DAS: Clean up some broken comment references 
Change-Id: I319620941b6051b138326cab9bbb8985b43216eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402426
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2024-12-30 11:56:34 -08:00
Sam Rawlins a3ef4553a5 DAS: Small fixes for LegacyAnalysisServer docs and ctor 
* Fix two comment references
* Mark AnalysisServer().enableBlazeWatcher as `@visibleForTesting`.
* Use named super parameters where possible.

Change-Id: Ic2561c7dd1a661857fbe2e7577fb29c55a5d57b4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402440
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-12-26 12:19:14 -08:00
Konstantin Shcheglov c01fe77e57 Elements. Changes for google3. 
Change-Id: Ia0215da239c3948ccd242e583b79df0085109597
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402400
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-12-25 20:10:49 -08:00
Danny Tuppeny 3557eb4a26 [analyzer] Remove Element2.location 
The completion code was no longer using this (we use `ElementLocation2` directly in the completion handler now), and the navigation check was just to ensure we didn't include MultiplyDefinedElements in navigation results.

Change-Id: I8412ec60d3d56386a7ced3d78c3a7428313df5d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-22 12:55:56 -08:00
pq 8a08c1bc56 [element model] migrate session_helper API 
Change-Id: Ia2717bb24c83a409e853fb5271a3d5ed91cd3306
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/402142
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-20 13:56:49 -08:00
Sam Rawlins e4b9170ca4 DAS: Support more possible added return types. 
* If there are no return statements, suggest a `void` or `Future<void>`
  return type.
* Visit yield statements as well, to suggest proper return types in
  generators.
* Combine the 'return type computers' in extract_method.dart and
  add_return_type.dart int one.

Change-Id: I223a50b11e7e77183f166c193fa74b8a2800127e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401862
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-12-20 13:18:00 -08:00
Halil Durmus 1a8afa6bbf [vm/ffi] Allow omitting native types for @Native functions 
This change simplifies working with `@Native`-annotated functions by allowing the native type to be omitted when it can be inferred from the Dart function's signature. While this was previously supported for `@Native` fields, it now applies to functions as well.

Before this change, you needed to specify the native type explicitly:
```
@Native<Void Function(Pointer)>()
external void free(Pointer p);
```

After this change, the native type can now be omitted if it's clear from the Dart signature:
```
@Native()
external void free(Pointer p);
```

TEST=tests/ffi/native_assets/*

CoreLibraryReviewExempt: VM only
Closes: https://github.com/dart-lang/sdk/issues/54810
Change-Id: Ied5407fcd2f49d85284cb7817f0c8cad2a73626b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400840
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Moritz Sümmermann <mosum@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-20 02:05:40 -08:00
Danny Tuppeny 76623a6541 [analysis_server] Extract TypeHierarchyItemLocation as ElementLocation2 and use for completion resolution 
This moves completion resolution off `ElementLocation` onto the class recently created as `TypeHierarchyItemLocation`, which is now renamed to `ElementLocation2` and extracted to its own file.

Change-Id: I1f0b831ded7b08d6c09f97fcfd66f38f1dd4750e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401021
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-19 14:14:53 -08:00
Konstantin Shcheglov 9f82b8595d Elements. Migrate Change Method Signature refactoring. 
Change-Id: I909adf258183d56be98895e07585ab079feafe6e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401940
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-12-19 14:06:50 -08:00
Konstantin Shcheglov 143bbe0a05 Elements. Use identical() to compare ElementImpl(s), other elements. 
Change-Id: If2abddeaea0551fa4646027ad8aa1bb4fd255660
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401760
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-19 13:17:19 -08:00
pq 6456180562 [dart fix] failing test for fixes in parts 
Bug: https://github.com/dart-lang/sdk/issues/59572
Change-Id: I6d70f5801b7e7f27ad944a1335b7f0aeba857e2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401180
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-19 13:05:48 -08:00
Sam Rawlins cc34c05adb DAS: Add a fix for strict_top_level_inference 
Change-Id: I990542bd6455113a70ead1d680f50b1163e6e263
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401800
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-12-19 08:58:29 -08:00
Devon Carew 79b52401f2 Update various packages based on diagnostics from strict_top_level_inference. 
Change-Id: I032d10fd1956b62a9e45ceee9ca2b28c9863d1ce
Tested: diagnostic updates only change
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401560
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
 2024-12-19 08:23:51 -08:00
Danny Tuppeny 922ad1b95e [analyzer/analysis_server] Migrate navigation to new element model 
Change-Id: I5cb132de15e103c5fdba22e7033317ee2013f886
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399106
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Ivan Inozemtsev <iinozemtsev@google.com>
 2024-12-19 04:55:11 -08:00
Konstantin Shcheglov 6494efb192 Elements. Use identical() to compare ElementImpl(s). 
Change-Id: Idbe935bc6ae333d9940d8ea53ad44011eff237ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401384
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-18 14:25:00 -08:00
Brian Wilkerson bda2cbbee3 [Migration] Minor clean-up 
Fixes a couple of the places that would have become errors when
`ElementImpl` no longer implements `Element2`. There are other places
that will break, but some of them are dependent on other changes being
made first.

Change-Id: I1041d70909de27ff33ddabc25ffc92b405b2c6c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401721
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-18 13:56:11 -08:00
FMorschel 4e719de45f [DAS] Adds quick-fix for extension name 
R=pquitslund@google.com

Fixes: https://github.com/dart-lang/sdk/issues/59723
Change-Id: I3679146ac70dd6bcb936c151cb93dacf8273d4b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401040
Auto-Submit: Felipe Morschel <git@fmorschel.dev>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2024-12-18 13:48:56 -08:00
Sam Rawlins 57c4da6911 Make Driver.instrumentationService private and final 
Change-Id: I903c293771c6666e5f1b0f7dc2637abc51943849
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401580
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2024-12-17 17:49:29 -08:00
Sam Rawlins f934e392f2 analyzer: Remove unnecessary Driver.httpServer 
Change-Id: I504f7f2ebf01a1a5e963374f3c0b4a66c2ed9d1d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401383
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-17 17:35:10 -08:00
Danny Tuppeny 9820487a3c [analyzer] Support enclosingFragments that are local variables 
Fixes at least some of https://github.com/Dart-Code/Dart-Code/issues/5369.

Change-Id: I367969335573e4659fc0932a5751d547b0942836
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401100
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-17 13:12:49 -08:00
Sam Rawlins dbf6008297 DAS: Support monospaced text (eg code snippets) in generated doc comments 
We take any `<tt>`-wrapped text, and keep it in some "monospaced" /
"teletype" format. For dartdoc we put it in backticks. For Javadoc
we put it in `<code></code>`, which looks standard for inline text.

This corrects some erroneous doc comment reference-looking text
(`offsets[i]`) which is not meant to be a doc comment.

Change-Id: I1d77a02368e3cde158ce95d3b0095ba09e071370
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-12-17 12:24:58 -08:00
Danny Tuppeny 54d62b478d [analysis_server] Move Type Hierarchy off ElementLocation to its own internal uri/name encoding 
This uses a simplified version of `ElementLocation` for `InterfaceElement`s in Type Hierarchy that are just made of Library URI + Name.

Change-Id: I2b5279f53d8eb199e31b3aed59e113c5f34e941a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400960
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-17 11:25:30 -08:00
Danny Tuppeny a9c3991a7a [analysis_server] Migrate LSP Find References to new element model 
Change-Id: I07c78af854c573a759971ee16c21fdc7de376952
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401060
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2024-12-17 10:27:15 -08:00
Danny Tuppeny 11904ed387 [analyzer] Add LinterContext.currentUnit and use it for content in eol_at_end_of_file 
... instead of potentially reading the file from disk.

Fixes https://github.com/dart-lang/sdk/issues/59704

Change-Id: Id5939dce4d11429a929a4b63611ff1823449b64c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401424
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2024-12-17 10:19:59 -08:00
Sam Rawlins 3fba5fb463 DAS: Seal TypeDecl for simpler switches 
Change-Id: I8b61f7e5fcace3438ae3692ca191975abe132879
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401320
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-12-17 08:52:51 -08:00
Sam Rawlins 4e4fec1830 DAS: Correct some broken comment references 
Change-Id: I55df606eca2e08469ee7c0b8895fab5c7e5afb05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401301
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-12-17 08:32:29 -08:00
Chloe Stefantsova 05b4a8fef4 [analyzer] Add tests for null-aware elements and LSP navigation 
Part of https://github.com/dart-lang/sdk/issues/56989

Change-Id: I24b121ee476f42b2108daddf6c0b63525052434f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399080
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
 2024-12-17 00:03:00 -08:00
Konstantin Shcheglov a829a7e7ac Elements. Rename SearchEngine methods. 
Change-Id: I3ffd1fe3e0983bd2dd0c76d37b3c9a2bb5969ec8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401042
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-12-16 15:09:38 -08:00
Konstantin Shcheglov de1662c292 Elements. Migrate lib/src/services/search/search_engine.dart and related. 
Change-Id: I7c0501eb6e84313d3eb179f41e8bdaf6190004ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400860
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-12-16 09:21:14 -08:00
Danny Tuppeny c8bf2914b7 [analysis_server] Revert to short-mode formatting for pkg:language_server_protocol 
This code generation was previously formatting generated files using the latest version. In 76feb10829 I re-ran the formatter to get the new formatting style.

However recently, a pre-submit hook to verify formatting was enabled and revealed that pkg:language_server_protocol still has an older SDK constraint, so the presubmit fails (if you modify these files).

There are two options:

1. Restore formatting to the previous version for pkg:language_server_protocol
2. Increase the SDK constraint for pkg:language_server_protocol

I picked the first for now, since analyzer_server_plugin also depends on pkg:language_server_protocol and currently has a constraint of 3.3, and I don't want to mess with that just to fix the format presubmit.

Change-Id: I2347577561e659825b444ef6622d646c6e513aea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/401001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2024-12-16 08:54:40 -08:00
Sam Rawlins 4d2e8a9ce7 lint rules: Add strict_top_level_inference rule 
Closes https://github.com/dart-lang/sdk/issues/59562

Change-Id: Ibf7ab6343d15ed328a366960b45cad4242528588
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400164
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-16 08:46:34 -08:00
Brian Wilkerson 789c266979 Migrate the call hierarchy computer 
Change-Id: I373604453f01af52d0a54386b51fdc5b68e4f854
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400700
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-13 13:26:18 -08:00
Keerti Parthasarathy 023473dc6c [Element model] Migrate rename_import_test.dart 
Change-Id: I5ef2722b095f4bbda6598e69c459c011e5005ae3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400520
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2024-12-13 08:42:23 -08:00
Sam Rawlins 9f111ce422 analyzer: look at primitive equality for const lists 
Work towards https://github.com/dart-lang/sdk/issues/54356

Change-Id: I6acfba900597ce3eef4065bf5eff3738aceb5a21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/399881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2024-12-12 18:43:19 -08:00
Konstantin Shcheglov 2862fdfe1b Elements. Migrate test/services/correction/status_test.dart 
Change-Id: Ie0afd64be7b90d68c81b05f2973557a5c562a431
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400165
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-12-12 07:23:48 -08:00
Brian Wilkerson 3bbcf1be96 Migrate move to file refactoring 
Change-Id: I006ac6d11ef712f51ce97c3b310634949bbc1918
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400160
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2024-12-11 11:47:49 -08:00
Konstantin Shcheglov ec7cb0c0b6 Elements. Migrate lib/src/lsp/completion_utils.dart 
Change-Id: I76f97ace7ffdbe77c556a9e4f0030dbb4ff5faf8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400161
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-12-11 11:20:58 -08:00
Brian Wilkerson 4296db0313 Migrate protocol tests 
Change-Id: I70f30a904a0c22a5858febea8550773588ea58d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400141
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2024-12-11 11:07:59 -08:00
Brian Wilkerson 7cac23ae8a Migrate ElementReferencesComputer 
Change-Id: I23ee2bef1c2dc1925cf7a730d0b46583f499067c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400142
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-12-11 08:58:18 -08:00