dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
72,683 Commits 2 Branches 0 Tags
03e504e5fa51731ebda1677d05f4d4702a3e9521
Commit Graph

217 Commits

Author SHA1 Message Date
Mike Fairhurst 2b80aa0f7f [analysis_server] Report angular plugin exceptions to new staging crash product 
Change-Id: I72826fc66ff87acc5003e913483a63081fa2931b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145960
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2020-05-04 18:11:54 +00:00
Mike Fairhurst f1c1dfacb7 [analysis_server] Report to both prod & staging crash reporting 
This CL enables us to have different crash reporters that report to
different backends, this will be useful if we report plugin errors to
staging and server errors to prod.

Currently doing this with server errors so that we can make the switch
over to prod incrementally. For the time being, the staging backend will
have our whole crash history, and continue to get new crashes. Reports
and dashboards can switch over to the prod backend as we get enough
history for those reports to be useful, and when we have switched
everything over we can stop reporting to staging entirely.

Change-Id: Ie29b4e05c89fd57faf1487a2c2eba3701fc319d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145922
Reviewed-by: Devon Carew <devoncarew@google.com>
 2020-05-04 18:11:54 +00:00
Brian Wilkerson 12dcfe63bb Start removing extraneous awaits from server 
Change-Id: I484227773e98d87c915f6dfe6e320dda1a7b8eaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144862
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-04-26 23:45:29 +00:00
Brian Wilkerson 8969b1839c Enable omit_local_variable_types in analysis_server 
Change-Id: I7e5c13d40fd276854601681fc84be321e6031b10
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-30 03:58:44 +00:00
Brian Wilkerson 7e724e70b0 Sort non-generated files in analyis_server and add a test to ensure they stay that way 
Change-Id: I6c7a38cefa69f46737bd50eefe2fbb88c127017b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141520
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-28 17:12:03 +00:00
Janice Collins da1d9eb1bd Add a way for analysis_server to open communication via a IsolateChannel. 
The idea is to pass a SendPort as an optional parameter to
ServerStarter.start(), and if present, key server behavior around
behaving well as an isolate.

Bug: https://github.com/dart-lang/sdk/issues/41056
Change-Id: Ifc6ac2fefcf6aae8bce712e470524d1c06fa2ba6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140373
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2020-03-26 21:37:59 +00:00
Devon Carew 1e45051341 [analyzer] initial implementation of SDK, file based configuration of the analysis server 
Change-Id: Iff3808fb073b062fa566993e7f05e2669a5fde7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140003
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-24 14:07:59 +00:00
Konstantin Shcheglov 83378633e1 Add the attachment with the content of the file being analyzed. 
Change-Id: I75b1c61e2d04cd5e03ef4375e97ef3c9f4add874
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138384
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-10 04:57:20 +00:00
Brian Wilkerson 1c34d8ce57 Add a new command-line flag for server to enable the new relevance computations 
Change-Id: If4c9e95a6e5e804fe480cf8a061ff95ec37651e8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138002
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-03-02 18:55:32 +00:00
Brian Wilkerson f60536c194 Enable slash_for_doc_comments in analysis_server 
Change-Id: Id2734d4c9ce591c5746bb9aa55810c78183db38f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-14 17:17:17 +00:00
Brian Wilkerson 16033f922d Enable prefer_contains in analysis_server 
Change-Id: Idac9828eb452f685452a33e6946ece2ba0d197f4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135583
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-02-13 14:52:08 +00:00
Brian Wilkerson d1ca36aa83 Enable empty_catches in analysis_server 
Change-Id: Ic21556e8118a5b5d3b4a06ed6d3a7002f606f2ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134084
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-31 17:38:02 +00:00
Brian Wilkerson a32e4363cb Fix some lints from function typed parameters that were not converted automatically 
Change-Id: I926b54c298d398e9a316b9c042fcae98f9210815
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132622
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-21 18:01:13 +00:00
Brian Wilkerson 5584c96fde Enable prefer_single_quotes in analysis_server 
All of the changes except in the analysis options file are from dartfix.

Change-Id: Icd9bf02ad07f71d1fc365979c7dfe18a792dc595
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132624
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-21 17:52:52 +00:00
Brian Wilkerson 93ebbe2c7a Enable use_function_type_syntax_for_parameters in analysis_server 
Change-Id: I93cddc986c23e53557c647befc92d118b3d6ed43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132459
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-19 17:11:11 +00:00
Brian Wilkerson e5705943d8 Enable prefer_conditional_assignment in several packages 
Other than the changes to the code generators and the analysis options
files, the changes were all generated by dartfix.

Change-Id: I80055e3992452c5b40eed41ac79807cf5c932976
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-06 05:19:19 +00:00
Brian Wilkerson 91d6e1a0a7 Enable annotate_overrides in several packages 
Other than analysis_server/test/analysis/notification_overrides_test.dart,
which had a naming conflict, all of the changes were made using dartfix.

Change-Id: I911dd75dcdee00420caa48724125e86d47c8857d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130002
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2020-01-01 21:31:40 +00:00
Devon Carew e7f0402ebf [analyzer] disable crash reporting for the AngularDart analysis plugin 
Change-Id: I49dddc4901c9cada643c5c024b8580f06c81a0d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129331
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-12-22 23:04:57 +00:00
Brian Wilkerson 4043a6fce3 Remove unnecessary uses of new in analysis_server 
Other than analysis_options.yaml, all of the changes were from running
dartfix.

Change-Id: I92411642f12a00fc6bd0bfd24dd60fe67f0fed16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128845
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-12-18 19:01:51 +00:00
Konstantin Shcheglov 3172748cb0 Remove ResolverProvider, and its using for fileResolverProvider / packageResolverProvider. 
It does not look that these are used anymore.

Change-Id: Ieafecc306dbf2b53e3366b1ffadc34aa7ba416a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128081
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-12-12 19:54:51 +00:00
Devon Carew 3204295ce1 [analyzer] send the plugin name with crash reports 
Change-Id: I674fe2a80a628bd3c509686f205101be8e081f19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126605
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-27 22:07:21 +00:00
Devon Carew f6a76586de [analyzer] send additional data to crash reporting 
Change-Id: I9f2da85e1c283ed4942ba076c98003aef80b7051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126203
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-27 00:16:50 +00:00
Devon Carew 18b7580944 [analyzer] for 'Failed to handle request' errors, send the exception to crash reporting as well 
Change-Id: Id50543fe6cac0e60ec32bfc6860064b210514dca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125988
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-25 20:20:46 +00:00
Brian Wilkerson f31fb0386b Catch exceptions during ranking and disable smart ranking 
Change-Id: Ib24a5a16da0fdfaf6d8504adab5c087ecec3abf0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125221
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-19 20:06:29 +00:00
Mike Fairhurst 8db87ad6e5 [analysis_server] Report lowest exception to API/crash reporting 
Change-Id: I6db4612e0342c0f5208e7bce420964c7f0de1966
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124912
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-14 16:33:46 +00:00
Johnni Winther 6ed0fcaa12 [analysis_server] Remove last dependency on front_end+kernel 
Change-Id: I0a8d1692ac1c8297bc7848a3f37fe97f8a8d3b29
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123735
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-11-13 10:07:48 +00:00
Mike Fairhurst 942419e6ba [analysis_server] Funnel sendServerErrorNotification through logException 
Change-Id: I266a8b3c404da8c9892aa6e1a49e1f1c9bdcf530
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124163
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-12 21:45:24 +00:00
Devon Carew d355778418 [analyzer] rate limit the crash reports we send 
Change-Id: I9f6af7fbcec653a2a9396d1098bea678777d4b3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124761
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-12 21:37:22 +00:00
Devon Carew be2866b9b1 [analyzer] update lib/crash_reporting.dart 
Change-Id: Ie3b3ffc8a0e0351341f28ff26bbb3c82deb0b5dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124640
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-11-08 23:29:58 +00:00
Mike Fairhurst e68ca9b652 [analyzer] move crash reporting to server because telemetry isn't pulished 
Change-Id: I8fb293632267e7991c578076a43bfbd277fc1ee1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124461
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
 2019-11-07 22:19:07 +00:00
Mike Fairhurst 5134490b78 [analysis_server] add crash reporting 
Change-Id: I8005e87f75eecb0e8320d6db124256c8c7c509d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123549
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-05 21:07:33 +00:00
Mike Fairhurst 1d774abeea [analysis_server] Remove old crash reporting 
Change-Id: Ib725b678dc0c9aa1ec0afec68d586690942c872b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123486
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
 2019-11-05 20:55:33 +00:00
Mike Fairhurst 7ba5584c2e [analysis_server] Fix outdated desin Service->Server, use Service->Logger. 
Also multiplex the service rather than the logger, so that we can
multiplex a crash reporting instrumentation service with a file logging
instrumentation service.

Change-Id: I7720c55e26225c27d2d9447a0156b2ca83da6598
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122100
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-11-04 21:31:26 +00:00
Konstantin Shcheglov 32a9a5f181 Add '--enable-experiment' to DAS. 
Bug: https://github.com/dart-lang/sdk/issues/39103
Change-Id: I37e1897efd044143fd9c2c96611cfa38efc056c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-10-28 16:17:03 +00:00
Ari Aye 95bd6a2888 Fix --completion-model flag 
Either setting --completion-model=/path/to/model/folder explicitly or
setting --enable-completion-model should turn on ML code completion.
This preserves the behavior that --no-enable-completion-model will
override --completion-model but fixes the bug where an omitted
--enable-completion-model flag will also override --completion-model.

Change-Id: I49a40a29c3444192e551fdcc4a51690f26969685
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121803
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-10-15 22:24:13 +00:00
Devon Carew ec86737818 [analyzer] fix an issue where the field analysisServerOptions.enableCompletionModel was not used 
Change-Id: Ib7dd53eb9ff97a0a646b487e4e5d71da0ced07c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120920
Reviewed-by: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-10 21:52:03 +00:00
Devon Carew 50d6a3d022 [analyzer] move the ml model from sdk/model to sdk/bin/model 
Change-Id: I64aad93770c5c0870c1a5052bb5a1192738f1cf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120901
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Ari Aye <ariaye@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-10-09 19:26:34 +00:00
Konstantin Shcheglov e32706ec05 Remove '--use-summary2' from DAS. 
R=brianwilkerson@google.com

Change-Id: I22d99ae50e19d5e1b624a0d807cead676411f58d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/117586
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-17 19:28:01 +00:00
Konstantin Shcheglov c324228c10 Support for ServerService.LOG and 'server.log' notification. 
R=brianwilkerson@google.com

Change-Id: I100105f651998d7837fb807d05531deac7ab3873
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/115061
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-30 20:04:38 +00:00
Konstantin Shcheglov af2e729fca Record request / response statistics. 
If following flags are specified for DAS, in IntelliJ in Registry as
"dart.server.additional.arguments":

--new-analysis-driver-log=file:/Users/scheglov/tmp/das.log
--include-protocol-to-driver-log

then abbreviated requests, and request execution statistics is
written to the file. We also write abbreviated notifications.

The goal is to be able to see what work was requested, what was
analyzed, and identify why some requests took long to get responses.


R=brianwilkerson@google.com

Change-Id: I98e99a73f10f2842c5efb350189a9675f29f45df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113800
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-21 16:47:21 +00:00
Ari Aye 8d1dc8c99b Add a cli flag to enable ML code completion using the default SDK path 
This will make it easier for beta testers to enable ML ranking for
code completion. Setting the --completion-model flag explicitly will
still work but there will also be a shorthand --enable-completion-model
which is equivalent to --completion-model=/path/to/dart-sdk/model/lexeme.

I tested this manually through IntelliJ.

Change-Id: Icd445e233f1eddec29d025769279dc03979cdb79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/113127
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-14 23:09:42 +00:00
Ari Aye 6d2902576b Emit a server.error event if we fail to start the completion model isolate 
Change-Id: Ibcdd4478b7717cf10534d63d94800baa88cc3c04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112408
Commit-Queue: Ari Aye <ariaye@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-08-09 14:41:02 +00:00
lambdabaa 33ce54e45d Don't try to start ML completion isolate on 32 bit systems 
Instead of asking tflite_native to try to load a 32 bit dynamic library only to have it notice that none exist, we can simply disable ML ranking in analysis server.

Change-Id: Ibd001430d3e37f2fe854c72ef9f3f5466c96f46e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-07-30 15:03:47 +00:00
lambdabaa fc82ed2286 Isolate-based CompletionRanking 
Screenshots: https://i.imgur.com/IOLKOCU.png, https://i.imgur.com/dM9VsNr.png

Change-Id: Ieae0f9066b7a349bb4adff6b327b67bcae49aab2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-07-29 13:45:23 +00:00
Ari Aye 939cce78b9 Create analysis server flag --completion-model 
This flag will take a path to a folder where completion language model
files can be located. Omitting this flag will signal to analysis server
that it should not use ML ranking for code completion, and the plan is
for this capability to initially be opt-in / disabled by default.

Change-Id: Ied18cd1e378c11607778fc116a7e0c3d72091e44
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/110401
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Ari Aye <ariaye@google.com>
 2019-07-24 23:15:39 +00:00
pq 52abcd3dd2 apply prefer_equal_for_default_values 
Change-Id: I9b6fd3ee18ec834a5db3d0d25455b6db9ea4fbe2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108664
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2019-07-10 19:31:40 +00:00
Konstantin Shcheglov d24b407568 Add --use-summary2 flag to AnalysisServer. 
So that we can start dogfooding it.

I noticed that we logged too much data, so I reworked what we
log in LibraryContext.

Currently performance will be subpar, due to using content hash as
file's API signature. So, any change to a file, even in a method
body will cause the whole library cycle (and everything that depends
on it) invalidation. I will implement computing API signatures for
parsed unit (hopefully reusing something already existing) in a
following CL.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ifb77e29188484b6784edbaa6a6d5daca6800ef2a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/104603
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-06-04 02:58:29 +00:00
Devon Carew 9081f28fbb [analyzer] fix a copy paste doc issue and 2 unused imports 
Change-Id: I20f4ae5454c2bceafd3b86e279357dee3b321006
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103644
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2019-05-24 16:31:25 +00:00
Dan Rubel dfbc3923e4 add default CompilerContext in analysis server 
This should uncover the underlying error occurring in
Fix https://github.com/dart-lang/sdk/issues/37055

Change-Id: I633da211b943e5c4262a2f3d83ef0a2217c5b8a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103562
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Dan Rubel <danrubel@google.com>
 2019-05-23 22:46:15 +00:00
Konstantin Shcheglov 181685b852 Allow disabling individual server features. 
Change-Id: I4d06eaf76300c6784b88bd64ad322c306a276488
Bug: https://github.com/dart-lang/sdk/issues/36881
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/103182
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-05-21 18:40:26 +00:00