8fd4647032
Iterate until all fixable diagnostics have been fixed
...
Change-Id: Ibd8bcf36f7813fd39a2c3733ac2a933971a8cce9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221140
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-23 18:23:01 +00:00
b3e029ddc5
Produce fix details when fixing imports
...
Change-Id: Ia4a4796f46ce49a6c330f8edde8b0103dcca8f8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221022
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2021-11-23 15:43:21 +00:00
3b89039454
Deprecate Source.isInSystemLibrary
...
Change-Id: Ifb76cc37e5b0aa86713675cf27086f6ce7625fbd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220822
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-11-19 20:30:37 +00:00
ab55396c25
Remove FileBasedSource, deprecate source_io.
...
Change-Id: I42c79a1c46711a9427d8716df91cd6980f0c57c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220842
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-19 19:07:37 +00:00
fb05622b3b
Deprecate Source.uriKind
...
We almost can remove it.
Unfortunately surveyor/lib/src/analysis.dart uses it, so we need to
update it first.
Change-Id: I239d24506f99183147bf45744a6f8d66d3eb4f94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220826
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
2021-11-19 18:29:07 +00:00
9d7df725f6
Deprecated restoreAbsolute(), use pathToUri().
...
Change-Id: Id705e4f0eda7beba4c3d2dd2f6ba4b82691ef1f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220480
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Samuel Rawlins <srawlins@google.com >
2021-11-18 21:17:17 +00:00
3dbd06bdfc
[analysis_server] Use relative imports for completion imports when prefer_relative_imports lint is enabled
...
Change-Id: Ib72066102db1883a21cf7a42e18a81efcfb47c54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220200
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-16 20:05:51 +00:00
327389b86f
[analysis_server] Prevent duplicate parens on completion for members without prefix
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3672 .
Change-Id: I3c4bab180ecf27bfddf590d0f0915e916e701773
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-16 17:06:51 +00:00
b74e8e5cec
[analysis_server] Fix stack overflow when generating minimal edits for LSP range formatting
...
Fixes https://github.com/dart-lang/sdk/issues/47702 .
Change-Id: I221427cb78eb6346fe6c78bf09c41bb22c78e8d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220324
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-16 15:35:42 +00:00
7bc9ca5ee9
Allow import fixes to run after other fixes
...
Change-Id: I820332ac17b7e2d9d981271ce2c6f544dc2b2080
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220041
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Phil Quitslund <pquitslund@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-15 19:20:01 +00:00
ad5da2976b
Add optional 'timeout' field to 'completion.getSuggestions2'.
...
The intended use is in benchmarking, to specify a long timeout, so that
the first time, when we warm up, we do necessary one time work,
which would usually run out of budget the first few times. So, the
requests that we do measure are more stable.
Change-Id: I22e870b84dcd6f2ac201c5ec57081c39c6529ea1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220129
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-11-15 16:48:42 +00:00
37bdd74758
[analysis_server] Add support for more common Flutter color formats for LSP textDocument/colorPresentation
...
Change-Id: I6b9bba312a4f0c7c6a2cee2f8eeb74b8dabb3cc6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/220007
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-12 19:26:42 +00:00
3238b2c09c
[analysis_server] Add LSP support for documentColor/colorPresentation
...
Fixes https://github.com/dart-lang/sdk/issues/44682 .
Fixes https://github.com/Dart-Code/Dart-Code/issues/3240 .
Change-Id: I5ccb24247e6cf8e0078699ec7527c0ccd0c0fa74
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219701
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-12 17:51:02 +00:00
2001b00c07
[analysis_server] Add ColorComputer for locating color references in user code
...
Change-Id: I166f87135a9b15821e5f65cfea33b8a15fa7aa03
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-11 21:50:41 +00:00
6ae2506f18
Revert "Add a lock mechanism for quick fixes"
...
This reverts commit 6732808c40https://github.com/flutter/flutter/pull/93406 under the checks section.
Original change's description:
> Add a lock mechanism for quick fixes
>
> I'm not fond of this approach, so if you have alternative suggestions
> I'd be very interested in hearing them.
>
> Change-Id: I9646d564b63d921f5eed77bdfa4de082b65d9148
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219126
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I6d6fd2511a80e5fd457eed234baa4eb41210467e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219901
Reviewed-by: Siva Annamalai <asiva@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2021-11-10 18:15:03 +00:00
f322513baa
Add a check for local elements to find references
...
Change-Id: Id90f719172270aa9b213af09efcdd113381ae6cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219800
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-11-10 17:03:23 +00:00
7ff9282868
Precompute FileState.uri properties.
...
Working with Uri, in form of _SimpleUri, was taking about 11%.
Now it _PubFilter is about 1%.
Change-Id: I35cd426d9c79e57cf85dcfe751ac57556f1a8b42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219849
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-10 05:29:14 +00:00
a2fd0da4f9
Use synchronous getLibraryByFile() for not yet imported.
...
This cuts the time to produce not yet imported suggestions 2x.
We don't check for abort anymore, will use the given budget.
Change-Id: Id02b0dcd894f89affa00e4a67fc1e93dc7745215
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219845
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-10 01:25:13 +00:00
93ac98d662
Change find refernces to accept an Element
...
Change-Id: I3d9f6456fe352ca423d63cd71d9408ce678066b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219821
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-11-10 00:35:04 +00:00
20c379ebe3
Use AnalysisDriver.resolveForCompletion() for getSuggestions2.
...
Change-Id: Ibc751b1c5315c5f16e25d2135d02d5f94d0c5bf1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219360
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-11-09 18:52:26 +00:00
8b14aba413
Revert "Reland Support overlapping deletions in quick fixes"
...
This reverts commit c1d4af3049https://github.com/flutter/flutter/issues/93206 for more details.
Original change's description:
> Reland Support overlapping deletions in quick fixes
>
> This relands both
> - https://dart-review.googlesource.com/c/sdk/+/217280 , and
> - https://dart-review.googlesource.com/c/sdk/+/217287
>
> Change-Id: Icd32df8e5bdc64514e4383f2e5625c0b093f862c
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219285
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I282a7ea79777ca257333bb3c4b97d780695df902
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219820
Reviewed-by: Siva Annamalai <asiva@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Siva Annamalai <asiva@google.com >
2021-11-09 18:05:03 +00:00
445ac5d803
[analysis_server] Improve handling of library-target annotations when organizing imports
...
+ handle comments between the last annotation and the directive code.
Fixes https://github.com/Dart-Code/Dart-Code/issues/3598 .
Change-Id: I868c832c8fcb2bf67aab83400ef2e57a5f14ce45
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219783
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-09 17:16:52 +00:00
5ffec0e46e
Create DartCompletionRequest with values, currently using forResolvedUnit() constructor.
...
Change-Id: Ie3db8617ed882d9561f9ea49b23dd5f8d3b4cf5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219753
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-09 16:17:55 +00:00
00ca3283c0
[analysis_server] Correct sorting of fixes, inverting priorities to maintain order
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3646 .
Change-Id: I9784bbda8aa62d3506810fc7768d58a4cd2bf064
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219706
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-08 19:55:02 +00:00
fe050f709b
Abort completion requests if we see another one in the queue.
...
Change-Id: I211a7614d66965d23f25274e1fd2fb0f314b48d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219383
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-11-05 17:23:37 +00:00
c1d4af3049
Reland Support overlapping deletions in quick fixes
...
This relands both
- https://dart-review.googlesource.com/c/sdk/+/217280 , and
- https://dart-review.googlesource.com/c/sdk/+/217287
Change-Id: Icd32df8e5bdc64514e4383f2e5625c0b093f862c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219285
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-05 14:20:09 +00:00
b0bca6ae6a
Replace ServerCommunicationChannel.listen() with Stream of requests.
...
So, we could add a StreamTransformer to debounce.
Change-Id: I04da366222cc30524e303c6a652de966c247e98f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219380
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-11-05 03:05:56 +00:00
acf08de8e9
Abort completion requests on another completion request or 'updateContent'.
...
Change-Id: Iecbb24808d2a7dc6b426488b6c56d1103d016d36
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219220
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-05 03:02:56 +00:00
bea4742bc1
Don't access ResolvedUnitResult from DartCompletionRequest.
...
When we resolve partially for completion, there is no fully
resolved unit. But we still know its path, content, element.
Change-Id: I57a21eb764ecd0b4c82ade33ad633bb2cd632b7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-05 02:29:06 +00:00
dd3759d9cc
Revert "Remove ServerService.LOG"
...
This reverts commit 41397cbb9ahttps://dart-review.googlesource.com/c/sdk/+/219362
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
TBR=scheglov@google.com ,jwren@google.com ,brianwilkerson@google.com
Change-Id: If5b807bf40adb8527aa801608fac6b1052adf67f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219382
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-05 02:18:28 +00:00
41397cbb9a
Remove ServerService.LOG
...
It looks that it is not used. We have a way to turn it on in
DartAnalysisServerService.java in Dart plugin for IntelliJ, but
setServerLogSubscription is not used in the plugin, marked as to be
used in the Flutter plugin, but actually is not used there.
Change-Id: If851044385100543ec0ff30e02dee3d99f1558e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-04 22:56:26 +00:00
6732808c40
Add a lock mechanism for quick fixes
...
I'm not fond of this approach, so if you have alternative suggestions
I'd be very interested in hearing them.
Change-Id: I9646d564b63d921f5eed77bdfa4de082b65d9148
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/219126
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-11-04 14:36:23 +00:00
56e7532f99
Implement rename method for Cider
...
Change-Id: I48d65146b9a7f1687f9afc437aebae3aaa6f533b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218785
Commit-Queue: Keerti Parthasarathy <keertip@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
2021-11-03 23:33:13 +00:00
6097294e9b
Add --report-protocol-version option for DAS.
...
Change-Id: Ifdd0b28e60a13ce12b6952c5220228f1cc337e4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218981
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-02 18:49:33 +00:00
96f49663cd
Support completion in yaml files in getSuggestions2.
...
Change-Id: Ieb5c23ccff260ee2f17efc11f6b040aec71be5da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218820
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-01 22:57:51 +00:00
03cdd766bb
Change the way of tracking not-yet-imported suggestions.
...
The previous implementation was somewhat slow.
Change-Id: Ic210cfa7c425a7e23d68da147671cd259e590bf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218790
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-01 22:15:31 +00:00
1ab3b36649
Make CompletionPerformance a wrapper around existing OperationPerformance.
...
Change-Id: I787ba5b47a2660d606dcc6c5015e9c9d83f73b31
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218784
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-11-01 18:49:31 +00:00
2f66c077c9
Extract CompletionSuggestion.copyWith() into an extension.
...
Change-Id: I7cc391f91f74b5f9d37435a78d04c773f3672fcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218744
Reviewed-by: Samuel Rawlins <srawlins@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-31 22:02:20 +00:00
cd59d39fe3
Remove some unused code from the fix support
...
Change-Id: Ia5f04d51e92d0dea0f1b44878a3f268f1f629f96
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218670
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-10-29 21:02:39 +00:00
0908835478
Tests for extension members completion, support not yet imported.
...
Change-Id: Idd0d2ad814f2365fa724b246f8d84e56e7dedd25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218669
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-29 20:54:09 +00:00
f706631f63
Move dotTarget to CompletionTarget.
...
Change-Id: Idaf40cdedcb90fd68f00fd3ab994ac53c7fe1ae2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218665
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-29 18:34:15 +00:00
8f756bf96b
Add CommentReferableExpression, for expressions which can be used in a CommentReference
...
* Replace `identifier` field with `expression`, which means deprecating
`identifier`, redirecting users to `expression`. For now, `expression`
always returns an Identifier. In a future breaking release, it will
return other CommentReferableExpressions.
* SimpleIdentifier, PrefixedIdentifier, PropertyAccess,
ConstructorReference, FunctionReference, and TypeLiteral are all
CommentReferableExpressions, but support is not implemented yet to
parse CommentReferences with those contained expressions.
Bug: https://github.com/dart-lang/sdk/issues/47444
Change-Id: I1905afecf3878cd7dca6e275ef0a2ab80500eb4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/216320
Commit-Queue: Samuel Rawlins <srawlins@google.com >
Reviewed-by: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Reviewed-by: Janice Collins <jcollins@google.com >
2021-10-29 16:38:09 +00:00
132f16b3b0
Implement completion.getSuggestionDetails2
...
Change-Id: Ic4b39c723d0cf90936a1db3ad3716533e6e8ca79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218542
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-28 20:55:48 +00:00
61e60eefd2
Abort not-yet-imported suggestions on a new completion request.
...
Change-Id: Id08b7ca328253ea5190038d2204cbfb2015aac01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218541
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-28 20:23:31 +00:00
ec1118ead7
Use CompletionBudget.defaultDuration
...
Change-Id: Ic4da5ac8b5d8dc9911feecdfa4a8ab4e2e4da778
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218524
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-28 18:17:48 +00:00
294aaab9c1
Use time budget in NotImportedContributor.
...
Change-Id: Ief0ef8185accd68c7b99132393fa0a4db6be31c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-28 17:37:18 +00:00
5135547aad
Use Duration for waitForResponses() from plugins.
...
Change-Id: I5cf1203559f601c0f5458e278a89b1fd83750ee7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-28 15:24:12 +00:00
9243b20dcf
Remove TODO for replacementOffset/Length, use them.
...
Change-Id: I44c6e3f30ad29e3de7ab9a66ae2d18310a6315c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218328
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
2021-10-28 15:20:28 +00:00
810dbd7fb2
[analysis_server] Fix dynamic registrations not occurring when onlyAnalyzeProjectsWithOpenFiles=true
...
Fixes https://github.com/Dart-Code/Dart-Code/issues/3638 .
Change-Id: I2749210a209fb0321f4833cf39c4d5fea55b579b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218441
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com >
2021-10-28 15:16:08 +00:00
0adfe513c0
Wait for completions from plugins with the remaining budget.
...
If we wait for a fixed time, then we would spend any time we have
already spent, plus this fixed time. We probably want to restrict
how much we spend in total.
Change-Id: I457774456d7bac7d9d110784afd087f4a3d540eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/218323
Commit-Queue: Konstantin Shcheglov <scheglov@google.com >
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com >
2021-10-27 22:11:38 +00:00
Brian Wilkerson