dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
55,629 Commits 2 Branches 0 Tags
02cd63eefd64330c95895b740d5bdc20dbd9d3d0
Commit Graph

2304 Commits

Author SHA1 Message Date
Danny Tuppeny a1a2711120 Remove references to deprecated class 
Change-Id: Ie61ae31e2366f3e26601839d1b9e7a100797f894
Reviewed-on: https://dart-review.googlesource.com/54760
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-05-12 15:42:57 +00:00
Danny Tuppeny 68229b862f NPE fix for annotations with no arguments 
Change-Id: I93254aeef708157566a3adf942ebc84902e3c02c
Reviewed-on: https://dart-review.googlesource.com/54680
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-05-11 13:38:27 +00:00
Devon Carew d078e6599d Remove some flutter specific analysis code. 
Change-Id: Ib48f8527c40d9f9cb9349cadcf94e7bc82330222
Reviewed-on: https://dart-review.googlesource.com/49831
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-05-10 23:54:46 +00:00
Danny Tuppeny d5f76cc963 Add annotations to folding regions 
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: Ie1917e3bd29b5cc2b6ecbed1238818e4e49f822a
Reviewed-on: https://dart-review.googlesource.com/54580
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-05-10 14:22:41 +00:00
Danny Tuppeny 46043004d6 Move folding regions to actual blocks 
This puts the region inside the braces; eg. the bit the user would expect to disappear when the region is collapsed.

Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: I58b347d2e1582bb4a6a35cf45c17085ea1739816
Reviewed-on: https://dart-review.googlesource.com/54402
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-05-10 07:44:10 +00:00
Konstantin Shcheglov 310745ca8b Add support for adding missing named parameters to constructors. 
I expected it to be more complex than it turned out to be.

R=brianwilkerson@google.com

Change-Id: I2a41204ea615ec7b65d7858bc4ed3908af17b2c1
Reviewed-on: https://dart-review.googlesource.com/54523
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-09 19:32:27 +00:00
Konstantin Shcheglov e8c8557fcb Switch the fix for adding not named required/positional parameter to using _ExecutableParameters. 
R=brianwilkerson@google.com

Change-Id: I7804e2847733b4c4a6effa2c5818e2533454f1c9
Reviewed-on: https://dart-review.googlesource.com/54521
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-09 19:32:08 +00:00
Danny Tuppeny a65dc90bd0 Improve error message for invalid characters 
The order of checks has been swapped so invlaid characters (which give a more specific message) are returned over those for first letters.

Bug: https://github.com/dart-lang/sdk/issues/32678
Change-Id: I784191ea7a0e072cc8994bbb47b03421e33aa90e
Reviewed-on: https://dart-review.googlesource.com/54244
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-05-09 09:56:42 +00:00
Konstantin Shcheglov fd9823ae9e Issue 21965. Add Quick Fix for adding missing named parameter. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/21965
Change-Id: I81a39df6fd38f9f562b494483b3fe0f67f9a627b
Reviewed-on: https://dart-review.googlesource.com/54360
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-05-09 06:44:38 +00:00
Danny Tuppeny b73541cffe Add a skeleton for Dart Folding 
Only currently adds a single region around Directives.

Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: Ibde0400c5815c00b1f94bf592d8cc9eb7cb592cf
Reviewed-on: https://dart-review.googlesource.com/54232
Commit-Queue: Danny Tuppeny <dantup@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-05-08 16:59:03 +00:00
Konstantin Shcheglov 179b31c157 Allow built-in identifiers for non-type entities, with a warning. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32893
Change-Id: I0d3d25b24d68e9cf30bfd69e6818aaa2a24b6f90
Reviewed-on: https://dart-review.googlesource.com/54100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-07 23:22:53 +00:00
Konstantin Shcheglov 1b8a3b1045 Implement support for overridden elements that are declared in mixins. 
R=brianwilkerson@google.com

Change-Id: I70ca606b23b928481f24d1322cfbd01a9b3d3e5f
Reviewed-on: https://dart-review.googlesource.com/54071
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-07 21:56:25 +00:00
Konstantin Shcheglov 8515d74332 Add ImportElement.namespace and use it in completion. 
R=brianwilkerson@google.com

Change-Id: I58cadf0e3239ad4ae8584d79485f4d9ebda10eba
Reviewed-on: https://dart-review.googlesource.com/54064
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-07 21:23:48 +00:00
Konstantin Shcheglov f62302b8ee Make extracted widgets follow Flutter style - const constructor and @required named parameters. 
R=brianwilkerson@google.com, pquitslund@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2166
Change-Id: I28f548c8e814ac5b9585dd46fbb9a8f84f70f418
Reviewed-on: https://dart-review.googlesource.com/54066
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-07 20:59:04 +00:00
Konstantin Shcheglov 92f50475b8 Issue 32849. Use export namespace for import prefix and combinator completions. 
R=brianwilkerson@google.com

Closes https://github.com/dart-lang/sdk/issues/32849
Change-Id: I43621a1c917095fab6be1f1798ea8596f7c3a173
Reviewed-on: https://dart-review.googlesource.com/53863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-07 16:14:40 +00:00
Konstantin Shcheglov e5e83a29fb Revert "Add a fix for prefer_single_quotes" 
This reverts commit eb2fbf501f.

Reason for revert: there is already corresponding quick assist, and it might be confusing to have both. Sorry.

Original change's description:
> Add a fix for prefer_single_quotes
> 
> Change-Id: Ifb59ec4c6822858e019adf780bfd7726b229542e
> Reviewed-on: https://dart-review.googlesource.com/53824
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
> Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

TBR=devoncarew@google.com,scheglov@google.com,brianwilkerson@google.com,jmesserly@google.com,ianloic@google.com

Change-Id: I880c7188ba25eef66c704ade4b61de3be1b55eb9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/53880
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-05 00:42:59 +00:00
Ian McKellar eb2fbf501f Add a fix for prefer_single_quotes 
Change-Id: Ifb59ec4c6822858e019adf780bfd7726b229542e
Reviewed-on: https://dart-review.googlesource.com/53824
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-05-05 00:01:06 +00:00
Konstantin Shcheglov f6a1f48450 Allow using pseudo keywords for names in refactorings. 
The specification does not diallow them (actually does not say anything
at all).

R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32893
Change-Id: I963b01aaf123bbf51d74dfcad6daf82cdb911bea
Reviewed-on: https://dart-review.googlesource.com/53841
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-04 23:23:16 +00:00
Konstantin Shcheglov 332dc7f3e9 Issue 32935. Fix NPE in 'Make final' quick fix. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/dart-lang/sdk/issues/32935
Change-Id: I980ffebe48050f7835664fa4d7d798c6f48e755c
Reviewed-on: https://dart-review.googlesource.com/53840
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-04 21:19:26 +00:00
Konstantin Shcheglov 67d3e4e3a1 Use actual names of the @isTest of isTestGroup executable in outlines. 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: Ifcd9d2398ca4e80cdace115e36f0d27df1afaad4
Reviewed-on: https://dart-review.googlesource.com/53825
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2018-05-04 20:11:16 +00:00
Konstantin Shcheglov b7a63c8d52 Use @isTest and @isTestGroup to understand executable element as a test/group. 
R=brianwilkerson@google.com, devoncarew@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2055
Change-Id: I7c8e7639d111eca63df0780ebdec182573493047
Reviewed-on: https://dart-review.googlesource.com/53690
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-04 17:09:06 +00:00
Konstantin Shcheglov 3d688deba7 Bump analysis server version to 1.20.2 
Bug: https://github.com/dart-lang/sdk/issues/33034
Change-Id: I1dc4bfb97d2fae7a4c57baa056749fa520f7ea88
Reviewed-on: https://dart-review.googlesource.com/53684
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-03 20:02:53 +00:00
Konstantin Shcheglov 9d10a6ad4a Issue 33034. Fix statement completion with missing condition right parenthesis. 
Bug: https://github.com/dart-lang/sdk/issues/33034
Change-Id: I87a47e5ddc41596b4bcd0c07d250a7afb00546ef
Reviewed-on: https://dart-review.googlesource.com/53680
Reviewed-by: Steve Messick <messick@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-05-03 17:48:53 +00:00
Konstantin Shcheglov b7d8ae30e2 Change 'Extract Widget' to generate named constructor parameters, with 'key'. 
R=devoncarew@google.com, paulberry@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2166
Change-Id: Ie698dc27a1328b7e18e92f46583f84c22c84de57
Reviewed-on: https://dart-review.googlesource.com/53060
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-30 16:49:00 +00:00
Konstantin Shcheglov da49615c2c Don't filter out references to constructors. 
Even if we assign to something that wants a different type, we might
chain some property access on it later on, so it is not nice to don't
suggest anything at all. Instead, we should give higher relevance to
compatible types, but keep all the rest with default relevance, as we
did already for everything other than instance creations.

R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/1107
Change-Id: I86c3c5dded4ad4cbbf28a60c0ae2847f07a3373b
Reviewed-on: https://dart-review.googlesource.com/52863
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-26 23:43:26 +00:00
Brian Wilkerson 9e9b50d19d Improve error messages for annotations involving undefined names (issue 27788) 
Change-Id: Iccfcb73b7671f50353b57a81817dec013b997a53
Reviewed-on: https://dart-review.googlesource.com/52640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-25 17:48:49 +00:00
Brian Wilkerson 7054d92a02 Remove some classes from the analyzer public API 
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-24 15:28:15 +00:00
Brian Wilkerson bf1d0efde2 Revert "Improve error messages for annotations involving undefined names (issue 27788)" 
Change-Id: I017592bf8982ff51bb73eb5fe892f8d9cffb9c9d
Reviewed-on: https://dart-review.googlesource.com/52400
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-23 21:05:53 +00:00
Konstantin Shcheglov 7b3a9c9aec Issue 2111. Copy documentation comments when 'Encapsulate Field'. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2111
Change-Id: If971e72b2cde15b7183f148da9da4d0dfed4ae05
Reviewed-on: https://dart-review.googlesource.com/52267
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-23 16:46:22 +00:00
Brian Wilkerson 1ffd7e529a Improve error messages for annotations involving undefined names (issue 27788) 
Change-Id: Ib7af4bdd97e9f775646c90e8f49f021836125b78
Reviewed-on: https://dart-review.googlesource.com/52240
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-04-22 20:11:11 +00:00
Konstantin Shcheglov 818c4b5bfd Remove AbsolutePathContext and use package:path instead. 
I see however that linter/test/rule_test.dart uses it, but as far as I
can see, that's it. All other usages are from analyzer and
analysis_server.

R=brianwilkerson@google.com

Change-Id: I2b82870a4a4ec6f155326d8ee6dc1c1028f84793
Reviewed-on: https://dart-review.googlesource.com/52265
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-20 21:01:06 +00:00
Konstantin Shcheglov f755d9dc33 Don't specify 'void' return type for setters in 'Encapsulate Field'. 
R=brianwilkerson@google.com

Bug: https://github.com/flutter/flutter-intellij/issues/2104
Change-Id: Ib7fe60e27f37726be5131c8a2e915b7911773855
Reviewed-on: https://dart-review.googlesource.com/52180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-20 17:40:39 +00:00
Brian Wilkerson a456753267 Move a library only used by tests into the test directory 
Change-Id: Ie8dcadc6313b3745ef874954da968839eb460c71
Reviewed-on: https://dart-review.googlesource.com/52020
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-20 15:56:00 +00:00
Brian Wilkerson 9a7168a2bf Clean up dead code in quick assist support 
Change-Id: I983c78a9ad131e5ae35a83abf2f455608b3ae835
Reviewed-on: https://dart-review.googlesource.com/52060
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-20 14:23:29 +00:00
Brian Wilkerson bdc727d49b Fix npe in quick fix computation (issue 32926) 
Change-Id: Ic93da063758513f101d753516cb61c351dae2501
Reviewed-on: https://dart-review.googlesource.com/51940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Danny Tuppeny <dantup@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-19 17:05:20 +00:00
Konstantin Shcheglov 1b533921ce Use synchronous broadcasts for notifications about file changes. 
R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/32914
Change-Id: I18bdccdcbeb553fe7df5ddd062abd825999eae22
Reviewed-on: https://dart-review.googlesource.com/51702
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-18 21:25:03 +00:00
Brian Wilkerson b936ffb329 Move several libraries out of the public API 
Change-Id: I8259de00134310f25b1c6168940aea5190488999
Reviewed-on: https://dart-review.googlesource.com/51443
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-04-17 17:35:27 +00:00
Danny Tuppeny 1855c6ef27 Increase analysis server version to 1.20.1 
So clients can detect when the workaround for #29414 is not required.

Closes #32902
https://github.com/dart-lang/sdk/pull/32902

GitOrigin-RevId: e6476b24b905fa718f94516d8ca28dafdc5aa38b
Change-Id: I3aafb29ad5ad92962dfd79373842159deb5994b6
Reviewed-on: https://dart-review.googlesource.com/51400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2018-04-17 08:11:31 +00:00
Brian Wilkerson 5460ddbab5 Move three more libraries out of the public API 
Change-Id: I8e6aeaea35c739fb26e22ffcfc30a343ebbb5424
Reviewed-on: https://dart-review.googlesource.com/51363
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-16 22:15:28 +00:00
Konstantin Shcheglov afbaf0c4a6 Add 'Extract Widget' to getAvailableRefactorings(). 
R=brianwilkerson@google.com

Change-Id: Ieb6faa63de75d64edd317bf8b5276f775c634e3c
Reviewed-on: https://dart-review.googlesource.com/51361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-16 20:13:08 +00:00
Brian Wilkerson dd897d35a2 Move the task API out of the public API 
Change-Id: I0fbafb4965ced89fb9a063edb773c3f1cb3a39fa
Reviewed-on: https://dart-review.googlesource.com/51242
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2018-04-16 18:18:08 +00:00
Brian Wilkerson c214c43758 Make LineInfo a public class 
Change-Id: I1bc7f5302797374609752ea5293b96c30719b41f
Reviewed-on: https://dart-review.googlesource.com/51101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-13 16:23:47 +00:00
Devon Carew 77116c14be Show isolate memory usage in the analysis server diagnostics page. 
Change-Id: I7d27adc840892897f74da5bb2d590133a8628c3d
Reviewed-on: https://dart-review.googlesource.com/50820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2018-04-11 22:05:19 +00:00
Mike Fairhurst a35bf88f9d Run pub upgrade on analyis plugins before (re)start. 
Change-Id: If3f550d2a5812e47fc527c237384abb9cb0b79a7
Reviewed-on: https://dart-review.googlesource.com/49837
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-11 19:16:36 +00:00
Devon Carew 7cbd0f55b5 Remove the special casing of 'packages' files from the analyzer and analysis server. 
Change-Id: I11fa2f73f7cdba8c53478c9002cefe82e58c09d6
Reviewed-on: https://dart-review.googlesource.com/49822
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-06 14:57:42 +00:00
Konstantin Shcheglov 6e25b9b2d3 Add flutter.getChangeAddForDesignTimeConstructor to API. 
R=brianwilkerson@google.com

Change-Id: I91e40c447d32e603026de337ec2d36983174a8cd
Reviewed-on: https://dart-review.googlesource.com/49826
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2018-04-06 02:40:00 +00:00
Konstantin Shcheglov a6bd6fe047 Fix for generating forDesignTime(), must be factory. 
R=brianwilkerson@google.com

Change-Id: Ie4a81511f52ee883da458ae9c029cc619013a433
Reviewed-on: https://dart-review.googlesource.com/49825
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-06 02:12:00 +00:00
Konstantin Shcheglov 618077cfee Implement FlutterCorrections.addForDesignTimeConstructor(). 
R=brianwilkerson@google.com, devoncarew@google.com

Change-Id: I1318020e9feab79ac1403e5d76c7e15483fc9a8e
Reviewed-on: https://dart-review.googlesource.com/49545
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-04 22:27:25 +00:00
Konstantin Shcheglov 1ff525c7f4 Add tests and fix a problem in inverting expressions. 
R=brianwilkerson@google.com, danrubel@google.com

Change-Id: I4085efd1a4457f01ccb6cf62bd535fed61a1217a
Reviewed-on: https://dart-review.googlesource.com/49541
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
 2018-04-04 18:29:05 +00:00
Konstantin Shcheglov 4089111540 Revert "Revert "Don't do implicit new/const code generation with --preview-dart-2 enabled."" 
This reverts commit e5ed23fdb5.

R=brianwilkerson@google.com

Change-Id: Ida33856e965f06f773025f3c625d6ab3bace80a8
Reviewed-on: https://dart-review.googlesource.com/49280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2018-04-03 22:29:09 +00:00