Commit Graph

5167 Commits

Author SHA1 Message Date
koda@google.com 016666613f Revert r42934.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//850343005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42939 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 22:45:26 +00:00
scheglov@google.com ad01eca4e2 Fix NPE in tests.
TBR

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//846383004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42937 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 22:09:00 +00:00
floitsch@google.com 20950adb02 dart2js: more uses of the model in the old emitter.
Some renamings.

R=ahe@google.com

Committed: https://code.google.com/p/dart/source/detail?r=42917
Reverted: https://code.google.com/p/dart/source/detail?r=42922

Review URL: https://codereview.chromium.org//787233006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42934 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 21:12:39 +00:00
scheglov@google.com ef7456f199 Update cache size on analysis start/stop.
This reduces time of dart2js analysis after rename form 16000 ms
to about 1200 ms, i.e. about 13 times ;-)

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//844493005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42933 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 20:55:57 +00:00
floitsch@google.com 98bf79104d Don't clear the global metadata during incremental compilation.
Review URL: https://codereview.chromium.org//850343004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42930 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 20:08:42 +00:00
floitsch@google.com 4ea72f94af Fix typo in caching compiler.
Review URL: https://codereview.chromium.org//812033013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42925 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 19:01:36 +00:00
pquitslund@google.com 807a4fa8fa Delegating AST Visitor and Linter refactoring.
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//813483007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42923 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 18:09:42 +00:00
floitsch@google.com d23f2ab1ca Revert "dart2js: more uses of the model in the old emitter."
This reverts commit r42917.

Review URL: https://codereview.chromium.org//852583003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42922 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 18:05:45 +00:00
jwren@google.com 4d1507935d Addition of the optional FileReadMode into the server spec.
R=brianwilkerson@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//825393005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42921 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 18:01:46 +00:00
floitsch@google.com 98a50ea6db dart2js: more uses of the model in the old emitter.
Some renamings.

R=ahe@google.com

Review URL: https://codereview.chromium.org//787233006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42917 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 16:28:30 +00:00
ahe@google.com 8319fbbfbf Add option --generate-code-with-compile-time-errors.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//854633004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42916 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 16:26:46 +00:00
ahe@google.com 6c25b15802 Error recovery broke host checked mode, fix it.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//852983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42915 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 16:16:52 +00:00
asgerf@google.com 73d063e5f4 Fix some bugs that blocked optimizations in the new IRs.
- Bad reference counting in tree IR builder.
- Incorrect visit order in StatementRewriter.visitSetField.
- Bad hint assigned in IR builder for GetClosureVariable.

BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//807573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42913 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 15:50:36 +00:00
ahe@google.com dae8aed3d8 Register throwRuntimeError when creating an ErroneousConstructorElementX
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//848333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42912 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 15:02:37 +00:00
sgjesse@google.com c831cdf97f Revert "Revert "Make stdout/stderr async""
This reverts commit r42909

TBR=ricow@google.com
BUG=

Review URL: https://codereview.chromium.org//850333002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42910 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 14:33:35 +00:00
sgjesse@google.com bc1be9c45f Revert "Make stdout/stderr async"
This makes writes to the stdout and stderr IOSinks in dart:io blocking again.

To get the non-blocking behaviour the getter "nonBlocking" will return an
IOSink with real non-blocking behaviour.

Updated the class exposed for stderr to also support checking for whether it
is connected to a terminal and checking the terminal size.

R=ajohnsen@google.com, iposva@google.com

BUG=

Review URL: https://codereview.chromium.org//807833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42909 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 14:18:16 +00:00
floitsch@google.com 884599197e dart2js: Remove unused function.
R=zarah@google.com

Review URL: https://codereview.chromium.org//853923002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42906 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 13:46:06 +00:00
ahe@google.com c179b70426 Don’t exit prematurely if compilation failed.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//828413004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42905 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 12:12:22 +00:00
ahe@google.com 8e39d5fed8 Recover from crash in language/async_test/constructor4.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//840723003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42904 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 12:04:33 +00:00
ahe@google.com aa760547b4 Avoid duplicated messages.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//822423005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42903 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 11:59:35 +00:00
floitsch@google.com 12eaf70732 dart2js: start using the model in the old emitter.
R=zarah@google.com

Review URL: https://codereview.chromium.org//849623003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42902 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 11:55:30 +00:00
karlklose@google.com 7e80e7dfea Remove tracking of factories used with type arguments.
R=floitsch@google.com

Review URL: https://codereview.chromium.org//794933004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42899 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 08:39:45 +00:00
danrubel@google.com cbd16a7336 add local parameter info to completion suggestions
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//850003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42894 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 02:26:45 +00:00
scheglov@google.com dc96eabde3 Display overlays at /overlays URI.
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//823123004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42891 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-15 00:22:44 +00:00
vegorov@google.com a45ed14472 Fix build broken by r42878.
Remove parameter name left at internalError invocation.

TBR=johnniwinther@google.com
BUG=

Review URL: https://codereview.chromium.org//852833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42881 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 18:53:39 +00:00
paulberry@google.com 81b8596681 Add indication of instrumentation active/inactive to analysis server status.
The instrumentation status shows up when querying the "/status" page, when analysis server is started with the "--port" option.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//847963003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42879 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 18:23:22 +00:00
vegorov@google.com a805ce5c5f Wrap standalone invariant() calls in assert().
To avoid unnecessary allocation: some of them have closure as an
argument.

R=floitsch@google.com, johnniwinther@google.com
BUG=

Review URL: https://codereview.chromium.org//819183005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42878 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 18:06:37 +00:00
ahe@google.com 3ca1728f97 Recover from read errors.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//841653004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42872 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 14:16:10 +00:00
floitsch@google.com c67d68e399 dart2js: remove spurious semicolon.
R=zarah@google.com

Review URL: https://codereview.chromium.org//854543003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42869 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 13:39:20 +00:00
floitsch@google.com 240853c756 dart2js: Temporarily store output unit in Fragment.
R=zarah@google.com

Review URL: https://codereview.chromium.org//835233003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42867 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 13:03:29 +00:00
floitsch@google.com 6e769d9c7f dart2js: register output units explicitly in the program builder.
R=zarah@google.com

Review URL: https://codereview.chromium.org//851683004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42866 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 13:02:37 +00:00
floitsch@google.com e6aa0d67a5 dart2js: Clear tables during incremental compilation.
R=ahe@google.com

Review URL: https://codereview.chromium.org//845663005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42865 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 13:01:42 +00:00
floitsch@google.com f072c6319b dart2js: register static non final fields in the model.
R=zarah@google.com

Review URL: https://codereview.chromium.org//849933003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42864 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 13:00:47 +00:00
floitsch@google.com 6eaf30d3d0 dart2js: Rename Fragment to LibrariesMap and Output to Fragment.
Fragment is the better name and is now used more often.

R=zarah@google.com

Review URL: https://codereview.chromium.org//851793002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42863 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 12:56:55 +00:00
ahe@google.com 5ec13e7ab7 Remove CompilerCancelledException.
Review URL: https://codereview.chromium.org//848003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42862 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 12:51:41 +00:00
ahe@google.com 4c2121a9bd Recover from fatal parser errors.
BUG=https://code.google.com/p/dart/issues/detail?id=22022
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//808953004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42861 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 12:48:28 +00:00
jwren@google.com 8a495697e6 Move the class TypeTestProvider from the test directory into the lib directory so that other tools can use the class and other tools such as the ElementFactory which require a TypeProvider
R=scheglov@google.com

Review URL: https://codereview.chromium.org//853553005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42855 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 06:59:51 +00:00
jwren@google.com 806e0fc181 Have the analysis server not send error notifications when NO_ERROR_NOTIFICATION has been set to true.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//854493002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42851 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 04:00:41 +00:00
danrubel@google.com 01a1ea75b8 fix function type alias conversion to protocol element
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//848943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42850 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-14 01:58:15 +00:00
scheglov@google.com 036b652dd1 Use all library units for hints during incremental resolution.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//818173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42846 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 23:23:20 +00:00
pquitslund@google.com e8d04b5d1e Remove dart_style pub dep in quest for build greenness [TBR].
Review URL: https://codereview.chromium.org//848003007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42843 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 21:49:25 +00:00
scheglov@google.com 93eea56a86 Catch and report exceptions in computers.
So, they will not cause the server crash anymore.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//854443002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42841 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 21:14:08 +00:00
pquitslund@google.com e034c062cf Server dart_style package version dep fix.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//806133004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42840 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 21:05:47 +00:00
pquitslund@google.com 8e91d1abec Fix server pubspec.
R=jwren@google.com

Review URL: https://codereview.chromium.org//849943002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42839 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 20:57:51 +00:00
pquitslund@google.com 6fb12789e7 Analysis server format service wiring (and protocol doc update).
R=brianwilkerson@google.com, danrubel@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//833903005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42835 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 20:34:10 +00:00
scheglov@google.com 493f5bbd00 When the file content is the same as the being removed overlay contents, ignore the change.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//845813006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42833 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 20:02:39 +00:00
danrubel@google.com 79cfcc3ac8 cleanup NO_RETURN_TYPE
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//845363003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42830 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 19:23:33 +00:00
scheglov@google.com 20e0b4b556 Match some constructor-based annotations.
It doesn't validate argments (we don't have them in annotation, and even if we had,
it is still not cheap to compare nodes with values, but we could remember source
strings, as we do for default parameter values), but it should not cause
invalid resolution, because we resolve incrementally only changes in methods bodies.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//847173002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42822 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:13:43 +00:00
scheglov@google.com a38a503d86 Replace @ReflectiveTestCase() with @reflectiveTest.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//849863002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42821 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 17:11:24 +00:00
asgerf@google.com 9748ac4ac4 Avoid boxing loop variables that are only mutated in initializer or update
For example:

for (int i=0; i<10; i++) {
  getFoo(i).then((x) {
    x.doBar(i);
  });
}

BUG=
R=floitsch@google.com, karlklose@google.com

Review URL: https://codereview.chromium.org//802813004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42809 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-13 14:11:13 +00:00