Commit Graph

316 Commits

Author SHA1 Message Date
nweiz@google.com 14c52ba5f1 Make listDir always emit paths within the given directory.
BUG=7346

Review URL: https://codereview.chromium.org//11553043

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16275 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 19:00:12 +00:00
nweiz@google.com e2036dea9c Add a pub command for managing uploaders for packages.
BUG=7363

Review URL: https://codereview.chromium.org//11569046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16230 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 21:47:37 +00:00
nweiz@google.com 3ea1942248 Validate that a single library has the same name as the package.
BUG=7045

Review URL: https://codereview.chromium.org//11519049

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16139 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 20:57:30 +00:00
nweiz@google.com 899b1a7d1f A few small changes to the "pub lish" confirmation UI.
* Don't collapse the root directory of a directory tree, since this is usually
  going to be a very heterogeneous set of files and directories.

* Indent "(N more...)" two fewer spaces. This makes it clearer at what level
  things are collapsed when it comes immediately after a directory. E.g.

      |-- dir
      |   '-- file
      | (6 more...)
      |-- other-dir

  vs

      |-- dir
      |   '-- file
      |   (6 more...)
      |-- other-dir

Review URL: https://codereview.chromium.org//11442068

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16085 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 01:11:47 +00:00
rnystrom@google.com 0f9bed70a5 Make pub publish more user friendly:
- Show the contents of their package.
- Let the confirm the upload even if there are no warnings.
- Make the error/warning text less scary.
- Validate that the pubspec has a version client-side.

Addresses #7175 and #7219.

Review URL: https://codereview.chromium.org//11557008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16068 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 22:22:38 +00:00
nweiz@google.com 7a2155fd65 Move path-manipulation code from io.dart into path.dart.
Review URL: https://codereview.chromium.org//11553005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16063 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 21:24:09 +00:00
rnystrom@google.com f0154d3b5a Fix #7330.
Review URL: https://codereview.chromium.org//11558022

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16056 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 19:49:26 +00:00
nweiz@google.com 8c3148b8b8 Mark the Pub validator test as failing on mac.
Review URL: https://codereview.chromium.org//11552004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16013 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 01:47:38 +00:00
nweiz@google.com 6e4bb05e59 Add a validator that checks that the lib directory is not empty.
BUG=7045

Review URL: https://codereview.chromium.org//11543006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16010 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-12 00:54:17 +00:00
sgjesse@google.com 93514a3b28 Reapply "Stop working around issue 6984."
Originally committted in r15804 and reverted in r15825.

Issue 6984 should be fixed by r15951.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//11528005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15961 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 10:03:21 +00:00
rnystrom@google.com 67367bf7df Handle relative paths where the trailing directory has an extension.
Review URL: https://codereview.chromium.org//11512011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15946 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 03:22:15 +00:00
rnystrom@google.com 9125bd4591 Clean up command help.
It was missing a newline before which made it look busted:

some command helpUsage: pub foo

Review URL: https://codereview.chromium.org//11485012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15944 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-11 02:15:05 +00:00
rnystrom@google.com e025df43ea Revise path library.
BUG=

Review URL: https://codereview.chromium.org//11471048

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15937 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 23:56:19 +00:00
rnystrom@google.com 10f914c414 Get pub_lish tests running on Windows.
There were two issues:

1. We were printing 7zip's stderr to pub's stderr which confuses the tests that look for certain errors.
2. Sometimes deleting the sandbox fails because the spawned pub process hasn't shut down yet. To handle that, we just retry the delete a few times. <sigh>

Review URL: https://codereview.chromium.org//11522006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15935 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-10 23:11:21 +00:00
rnystrom@google.com c9bacbbdb4 Fix path tests on windows.
BUG=

Review URL: https://codereview.chromium.org//11472045

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15883 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 05:11:32 +00:00
nweiz@google.com f813520a0a Add Bob's path library to pub.
BUG=7215

Review URL: https://codereview.chromium.org//11475046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15881 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:47:03 +00:00
nweiz@google.com 3b8e03576e Validate that an uploaded package has a LICENSE file.
BUG=7045

Review URL: https://codereview.chromium.org//11474047

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15879 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:24:44 +00:00
nweiz@google.com 55ad513b3b Work around issue 7218 in Pub.
Review URL: https://codereview.chromium.org//11470030

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15878 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 03:21:15 +00:00
rnystrom@google.com 30d0a0356d Fix type annotation and comment.
Review URL: https://codereview.chromium.org//11464040

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15875 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 02:46:07 +00:00
rnystrom@google.com 015bb89346 Make sure to drain stderr in tests so that spawned process doesn't hang.
Review URL: https://codereview.chromium.org//11474046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15874 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-08 02:18:06 +00:00
rnystrom@google.com 2b9281fe14 Add in basic logging system.
Review URL: https://codereview.chromium.org//11470023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15870 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 22:13:47 +00:00
nweiz@google.com 97f425b7de Add a validator that checks package names.
BUG=7045

Review URL: https://codereview.chromium.org//11444018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15857 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 19:30:51 +00:00
nweiz@google.com e15d4788ce Require a description field in pubspecs.
BUG=7045

Review URL: https://codereview.chromium.org//11466020

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15856 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 19:27:03 +00:00
rnystrom@google.com cf5ab6030e Revert "By default use current code page on Windows for decoding string"
This reverts commit c247cd299958d0ee713dcfef8aaf44d230a3a7e0.

Revert "Fix memory leaks in system string patch"

This reverts commit 5e533a0c383518fc1851fbdc01a796f7d6b077f8.

Review URL: https://codereview.chromium.org//11446067

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15854 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 18:49:52 +00:00
rnystrom@google.com e3bc775e68 Revert "Add logging system to pub and sprinkle some logging in."
This reverts commit 60468a1a0854389bb3f460cf2368f22013f1af31.

BUG=

Review URL: https://codereview.chromium.org//11472016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15830 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:48:12 +00:00
rnystrom@google.com 578c415134 Add logging system to pub and sprinkle some logging in.
We'll have to tune which things we log over time, but this covers
most IO operations which is where almost all of our problems come
from.

This patch also means that going forward you should no longer call
print() or printError() (which is gone) directly. Instead:

print() -> log.message()
printError() -> log.error()

That ensures all messages will correctly get added to the log's
transcript.

Review URL: https://codereview.chromium.org//11437019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15827 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:29:23 +00:00
nweiz@google.com 83fa5c203c Stop working around issue 7044.
Review URL: https://codereview.chromium.org//11478004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15826 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:11:35 +00:00
nweiz@google.com 29318c2f5c Revert "Stop working around issue 6984."
Review URL: https://codereview.chromium.org//11464015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15825 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-07 00:09:19 +00:00
nweiz@google.com 01dd8fcb4e Stop working around issue 6984.
Review URL: https://codereview.chromium.org//11464006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15804 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 20:50:21 +00:00
rnystrom@google.com 39dc1b5323 Better error messages for dependency conflicts.
BUG=

Review URL: https://codereview.chromium.org//11445034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15768 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 02:04:30 +00:00
nweiz@google.com 0e9b2ef0bd Add validation infrastructure for "pub lish".
This also adds a simple validator.

BUG=7045

Review URL: https://codereview.chromium.org//11434118

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15765 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-06 00:25:41 +00:00
nweiz@google.com 4ba4e92937 Handle OAuth2 AuthorizationExceptions in pub.
BUG=6950

Review URL: https://codereview.chromium.org//11416352

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15747 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-05 19:47:32 +00:00
rnystrom@google.com 2b3c4cd639 Make directory renaming more resilient on Windows.
BUG=

Review URL: https://codereview.chromium.org//11348332

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15608 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 22:39:45 +00:00
rnystrom@google.com 0c0d8d9dc7 Get curl uploads working on Mac.
Review URL: https://codereview.chromium.org//11411273

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15592 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 18:21:41 +00:00
nweiz@google.com 6a6c381b91 Use pkg/http pervasively in pub.
Review URL: https://codereview.chromium.org//11280246

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15559 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-30 01:15:23 +00:00
nweiz@google.com f7f4e8c458 Give all async exceptions in pub some sort of stack trace.
Review URL: https://codereview.chromium.org//11421159

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15547 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 22:45:51 +00:00
nweiz@google.com 806e8a5432 Mark pub oauth2 and curl_client tests as skip on Windows.
Review URL: https://codereview.chromium.org//11308262

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15488 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:52:00 +00:00
nweiz@google.com ff3ab9a439 Mark the pub oauth2_test as failing on Windows.
Review URL: https://codereview.chromium.org//11418227

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15483 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:39:07 +00:00
rnystrom@google.com e7382431ba Get archive creation working on Windows.
Review URL: https://codereview.chromium.org//11348288

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15482 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 00:20:28 +00:00
nweiz@google.com 2df3fd15b2 The macos pub tests are working again.
BUG=

Review URL: https://codereview.chromium.org//11421136

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15479 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 23:34:34 +00:00
nweiz@google.com 558ffd19bf Work around issue 6984.
This ensures that before an HTTP response is closed, its corresponding
request is drained of input.

Review URL: https://codereview.chromium.org//11348285

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15476 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 22:43:10 +00:00
nweiz@google.com a964e37605 Don't require users to copy-paste authorization codes when authorizing pub.
BUG=6951

Review URL: https://codereview.chromium.org//11348268

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15468 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 19:45:06 +00:00
nweiz@google.com 3b5ab2e81e Add support for pub command aliases.
BUG=6949

Review URL: https://codereview.chromium.org//11416222

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15434 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 01:57:30 +00:00
nweiz@google.com c2d351b552 Mark pub Windows tests as failing.
Review URL: https://codereview.chromium.org//11348266

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15432 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-28 01:46:55 +00:00
rnystrom@google.com d2213763e0 Make pub git tests fast on windows again.
BUG=

Review URL: https://codereview.chromium.org//11428037

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15424 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 23:21:04 +00:00
nweiz@google.com 8161b23167 Fix or mark "pub lish" build failures.
Review URL: https://codereview.chromium.org//11411201

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15423 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 23:10:47 +00:00
nweiz@google.com e67b17723c Add an initial "pub lish" command.
BUG=6177

Review URL: https://codereview.chromium.org//11308212

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15422 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 22:48:59 +00:00
rnystrom@google.com 8ce4fd1895 Mark the pub tests as slow/timeout on Windows.
Review URL: https://codereview.chromium.org//11421085

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15361 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 00:57:36 +00:00
rnystrom@google.com d824a21ef4 Git tests on Windows are fast now.
Review URL: https://codereview.chromium.org//11414170

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15348 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-26 22:03:36 +00:00
erikcorry@google.com 359736e97a Fix Unicode issues in dart2js and dart2dart.
R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//11418115

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15254 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-22 12:51:14 +00:00