e8323c2d0b
Fixed bug in r16247: variable naming issues
...
Review URL: https://codereview.chromium.org//11573061
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16249 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 10:15:32 +00:00
a18994679b
Call DumpRenderTree directly from test.dart instead of using the drt-trampoline.py indirection
...
Currently drt-trampoline.py is used to call DRT. Unfortunately this causes
problems on Windows: If drt-trampoline.py times out, it is killed by test.dart.
But drt-trampoline.py has no way of installing a signal handler on Windows which
would kill the actual DumpRenderTree process. So sometimes we're left with one
hanging DumpRenderTree process on the Windows buildbots.
This change removes the drt-trampoline.py indirection and calls DRT directly
from test.dart.
Committed: https://code.google.com/p/dart/source/detail?r=16214
Review URL: https://codereview.chromium.org//11586012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16247 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-18 09:52:54 +00:00
0be2cb3fa5
Revert "Call DumpRenderTree directly from test.dart instead of using the drt-trampoline.py indirection"
...
TBR=ricow@google.com
Review URL: https://codereview.chromium.org//11591017
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16215 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 17:21:48 +00:00
8071e88618
Call DumpRenderTree directly from test.dart instead of using the drt-trampoline.py indirection
...
Currently drt-trampoline.py is used to call DRT. Unfortunately this causes
problems on Windows: If drt-trampoline.py times out, it is killed by test.dart.
But drt-trampoline.py has no way of installing a signal handler on Windows which
would kill the actual DumpRenderTree process. So sometimes we're left with one
hanging DumpRenderTree process on the Windows buildbots.
This change removes the drt-trampoline.py indirection and calls DRT directly
from test.dart.
Review URL: https://codereview.chromium.org//11586012
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16214 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 16:27:11 +00:00
e87e99992d
Enable the "skip command compilation if output is already up-to-date" feature in dart2dart
...
Review URL: https://codereview.chromium.org//11593008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16209 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-17 14:26:41 +00:00
14de8ec666
Avoid timeouts when DRT fails to find a file.
...
Review URL: https://codereview.chromium.org//11565018
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16177 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 19:15:00 +00:00
62c83a4443
Moved the testing scripts to the new import/library/part syntax
...
Review URL: https://codereview.chromium.org//11575028
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16163 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 14:19:01 +00:00
c01e393aa5
Added support for skipping redundant dart2js compilations.
...
Currently, the buildbots run tests on every commit. But often neither
the tests nor the dart2js compiler did change (e.g. on status file updates).
The added code will check if the dependencies (i.e. files listed in
test.js.deps) or the dart2js snapshot did change. If not, the output
of the previous dart2js compilation is up to date and the compilation
step is skipped.
The skipping of redundant dart2js compilations works only if the '--use-sdk'
option was specified (because in this case the dart2js snapshot is used).
Committed: https://code.google.com/p/dart/source/detail?r=15080
Review URL: https://codereview.chromium.org//11369216
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16158 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-14 11:56:00 +00:00
ce0c5e350d
Revert drt-trampoline.py
...
That was completely broken. :)
However, the worst problem is that it doesn't actually
work for the problem that we have.
R=kustermann@google.com ,ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//11568013
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16115 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 14:50:17 +00:00
873746a904
Handle timeouts in drt-trampoline on Windows.
...
This will make timeout of drt tests work on Windows. Killing
dtr-trampoline did not kill DumpRenderTree on Windows.
R=kustermann@google.com ,ricow@google.com
BUG=
Review URL: https://codereview.chromium.org//11578003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16110 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-13 14:14:08 +00:00
ca260ce79e
Reduce debug printing from test script when testing --build-directory option.
...
Cleanup fix to mkdirRecursive.
BUG=
Review URL: https://codereview.chromium.org//11411356
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15686 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-04 14:25:04 +00:00
54a7829c3f
Fix test scripts to work with an absolute build directory path on Windows.
...
BUG=
Review URL: https://codereview.chromium.org//11421220
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15683 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-04 11:01:42 +00:00
86ce280398
Another try.
...
TBR=whesse@google.com
Review URL: https://codereview.chromium.org//11411345
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15675 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-04 01:49:59 +00:00
25f9de94b0
Some more diagnostics.
...
TBR=whesse@google.com
Review URL: https://codereview.chromium.org//11428153
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15672 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-04 01:16:44 +00:00
b46a5b2b41
Properly create paths.
...
TBR=whesse@google.com
Review URL: https://codereview.chromium.org//11415275
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15671 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-04 00:11:49 +00:00
80ce8347ac
Use Directory, not a string.
...
TBR=whesse@google.com
Review URL: https://codereview.chromium.org//11414300
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15669 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 23:20:26 +00:00
7526c02dab
Fix string concatenation.
...
TBR=whesse@google.com
Review URL: https://codereview.chromium.org//11299313
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15659 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 21:46:52 +00:00
a229522c74
Hacky fix for paths with drive names on Windows.
...
TBR=whesse@google.com
Review URL: https://codereview.chromium.org//11412306
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15654 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 20:52:41 +00:00
0522fc0442
Add some diagnostics to understand what goes on.
...
TBR=whesse@google.com
Review URL: https://codereview.chromium.org//11308328
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15651 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 20:23:27 +00:00
ac192a1c52
Add some diagnostics to understand what goes on.
...
TBR=whesse@google.com
Review URL: https://codereview.chromium.org//11299306
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15650 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 19:19:45 +00:00
2b929563ed
Fix test.dart's --build-directory option to accept absolute paths.
...
BUG=
Review URL: https://codereview.chromium.org//11308293
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15632 260f80e4-7a28-3924-810f-c04153c831b5
2012-12-03 12:35:00 +00:00
3f9aaca941
Don't run pub and pkg as default, explicitly add these to the test command for running
...
Review URL: https://codereview.chromium.org//11428084
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15520 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 15:22:04 +00:00
c17990a886
Call dart2js directly from sdk/bin.
...
Review URL: https://codereview.chromium.org//11299206
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15512 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 12:15:29 +00:00
a799a7e402
Add --checked or --minified to test directory name when generating output.
...
Currently the compiled output will simply be overwritten if you run
non-checked mode followed by checked mode.
Review URL: https://codereview.chromium.org//11280085
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15503 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-29 09:12:10 +00:00
dd76d416c2
Make the PackageRoot test file option relative to the test file.
...
BUG=http://dartbug.com/6817
Review URL: https://codereview.chromium.org//11411150
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15387 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 12:30:30 +00:00
438a21c698
Allow passing in command-line options to co19_test.dart.
...
Review URL: https://codereview.chromium.org//11299161
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15372 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-27 09:14:08 +00:00
6220720429
Add --build-directory option to test.py.
...
Fix problem when no --step-name option is present.
BUG=dart:6885
Review URL: https://codereview.chromium.org//11308179
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15280 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-23 12:54:04 +00:00
8f86ec778d
Remove the legacy --additional-compiler-flags option from test.py
...
The --additional-compiler-flags option is no longer used. The buildbots
use the --minified option now.
Review URL: https://codereview.chromium.org//11299102
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15148 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 13:24:37 +00:00
072625732c
Pass --minify to dart2dart if --minified was specified on test.py
...
Currently --minified on test.py has only an effect on dart2js commands.
The dart2dart commands use the legacy --additional-compiler-flags="--minify"
option.
This change is the first one of two CLs, where we pass --minify to dart2dart
if --minified was specified on test.py.
The second change will then remove the --additional-compiler-flags option
as soon as the build bots have been updated to use the new scheme for dart2dart.
Review URL: https://codereview.chromium.org//11419089
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15144 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 12:21:04 +00:00
cc3ef5ed38
Make SummaryReport.addCompileErrorSkipTest() depend on --report
...
Review URL: https://codereview.chromium.org//11316100
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15138 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-20 09:29:13 +00:00
52077af7fa
Revert "Added support for skipping redundant dart2js compilations."
...
We must disable this feature until we've made sure that the boolean
dart2js flags (e.g. --checked) are included in the directory names.
TBR=ahe
Review URL: https://codereview.chromium.org//11280061
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15087 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 15:47:59 +00:00
f4bc6a5f3f
Added support for skipping redundant dart2js compilations.
...
Currently, the buildbots run tests on every commit. But often neither
the tests nor the dart2js compiler did change (e.g. on status file updates).
The added code will check if the dependencies (i.e. files listed in
test.js.deps) or the dart2js snapshot did change. If not, the output
of the previous dart2js compilation is up to date and the compilation
step is skipped.
The skipping of redundant dart2js compilations works only if the '--use-sdk'
option was specified (because in this case the dart2js snapshot is used).
Review URL: https://codereview.chromium.org//11369216
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15080 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 13:56:11 +00:00
bbddb15ea2
Pass package-root option to dart2js in browser tests.
...
Review URL: https://codereview.chromium.org//11414056
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15076 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 13:08:17 +00:00
f4ca9548c9
Allow tests to specify a package root.
...
Use a shared package root if none is specified.
Committed: https://code.google.com/p/dart/source/detail?r=15064
Review URL: https://codereview.chromium.org//11359187
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15070 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 11:35:57 +00:00
88a921030d
Revert "Allow tests to specify a package root."
...
Revert "Add dependencies for bots that doesn't build everything."
This reverts r15066 and r15064.
Review URL: https://codereview.chromium.org//11414055
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15068 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 10:42:55 +00:00
89cc5a2d23
Allow tests to specify a package root.
...
Use a shared package root if none is specified.
Review URL: https://codereview.chromium.org//11359187
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15064 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-19 09:51:17 +00:00
42b89c9f77
Changed: TestCase.output -> TestCase.commandOutputs[]
...
Currently the TestCase has exactly one TestOutput. This worked
until now, since we were only interested in the output of the
last command.
This change introduces one CommandOutput for each command which
has been run. Doing so enables us to fetch output (stdin,stderr)
information as well as exitCode ... for all commands.
See also 11293278.
Review URL: https://codereview.chromium.org//11348088
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15006 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-16 11:17:47 +00:00
3dc5c7056a
Revert of commit 14947
...
Review URL: https://codereview.chromium.org//11348060
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14949 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 09:15:43 +00:00
5ec78286df
Changed: TestCase.output -> TestCase.commandOutputs[]
...
Currently the TestCase has exactly one TestOutput. This worked
until now, since we were only interested in the output of the
last command.
This change introduces one CommandOutput for each command which
has been run. Doing so enables us to fetch output (stdin,stderr)
information as well as exitCode ... for all commands.
Review URL: https://codereview.chromium.org//11293278
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14947 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-15 09:05:41 +00:00
970cc5ba68
Move JSSyntaxRegExp to core as a private member. This removes the last refrences to dart:coreimpl.
...
After this cleanup, RegExp no longer have a const constructor. Use 'new
RegExp(...)' from now on.
BUG=
Review URL: https://codereview.chromium.org//11365196
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14838 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:41:37 +00:00
ab69873a42
Make RegExp constructor non-const.
...
Another take of https://codereview.chromium.org/11410033/ with status changes applied for co19 tests.
BUG=
Review URL: https://codereview.chromium.org//11369210
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14837 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 10:18:06 +00:00
ec9fee9858
"Reverting 14829-14832"
...
BUG=
Review URL: https://codereview.chromium.org//11312203
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14833 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 07:28:13 +00:00
8dc3edd7ce
Make RegExp's constructor non-const.
...
BUG=
Review URL: https://codereview.chromium.org//11410033
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14829 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-13 06:48:43 +00:00
8e6f238f86
a === b -> identical(a, b)
...
Replace === null with == null.
BUG=http://dartbug.com/6380
Review URL: https://codereview.chromium.org//11361190
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14794 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 17:19:58 +00:00
1ba6e54811
Do not generate multiple tests for vm options.
...
R=ahe@google.com ,ager@google.com
BUG=6436
Review URL: https://codereview.chromium.org//11358175
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14786 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-12 13:26:30 +00:00
f30fb024ce
The goal here is to rearrange StandardTestSuite so that it's possible override some of its behavior for running package tests while still keeping the rest of the behavior.
...
This patch is just the refactoring. I'll do the actual pub stuff in a separate patch.
Review URL: https://codereview.chromium.org//11275217
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14757 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-09 20:56:59 +00:00
e78ad924f6
Added support for logging the output of failed flaky tests.
...
Failed flaky tests will be logged to 'failed_flaky_tests.log'.
The default behavior is that the old log file gets deleted before
any tests are run. To prevent this, the '--append_flaky_log' option
can be set.
Review URL: https://codereview.chromium.org//11364129
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14735 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-09 12:08:00 +00:00
4a23980c8a
Take 2 of splitting html tests into subtests. Had to make two changes to drt to
...
fully work.
Review URL: https://codereview.chromium.org//11368128
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14703 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 18:54:14 +00:00
868b439bc4
Revert run large html tests individually.
...
Review URL: https://codereview.chromium.org//11406002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14667 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-08 00:11:09 +00:00
bf9cd05e79
Move html_individual_config to correct location after tree rearranging.
...
Review URL: https://codereview.chromium.org//11362147
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14664 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-07 23:53:11 +00:00
kustermann@google.com