dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 2 Packages Projects Releases Wiki Activity
10,539 Commits 2 Branches 0 Tags
00a552c3d40b6facfdca1261fe2b60e4872c2025
Commit Graph

28 Commits

Author SHA1 Message Date
nweiz@google.com a8eb61fb8b Fix analyzer errors and warnings for pkg/http. 
BUG=7458

Review URL: https://codereview.chromium.org//11617004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@16238 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-18 00:26:15 +00:00
sgjesse@google.com 93514a3b28 Reapply "Stop working around issue 6984." 
Originally committted in r15804 and reverted in r15825.

Issue 6984 should be fixed by r15951.

R=ager@google.com

BUG=

Review URL: https://codereview.chromium.org//11528005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15961 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-11 10:03:21 +00:00
rnystrom@google.com 89dbb7be66 Add "toString()" to BaseRequest. 
Review URL: https://codereview.chromium.org//11480003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15869 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-07 21:49:27 +00:00
rnystrom@google.com e3bc775e68 Revert "Add logging system to pub and sprinkle some logging in." 
This reverts commit 60468a1a0854389bb3f460cf2368f22013f1af31.

BUG=

Review URL: https://codereview.chromium.org//11472016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15830 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-07 00:48:12 +00:00
rnystrom@google.com 578c415134 Add logging system to pub and sprinkle some logging in. 
We'll have to tune which things we log over time, but this covers
most IO operations which is where almost all of our problems come
from.

This patch also means that going forward you should no longer call
print() or printError() (which is gone) directly. Instead:

print() -> log.message()
printError() -> log.error()

That ensures all messages will correctly get added to the log's
transcript.

Review URL: https://codereview.chromium.org//11437019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15827 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-07 00:29:23 +00:00
nweiz@google.com 29318c2f5c Revert "Stop working around issue 6984." 
Review URL: https://codereview.chromium.org//11464015

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15825 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-07 00:09:19 +00:00
nweiz@google.com 01dd8fcb4e Stop working around issue 6984. 
Review URL: https://codereview.chromium.org//11464006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15804 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-06 20:50:21 +00:00
nweiz@google.com 1855849da1 No longer work around issue 7013 and 7014 in pkg/http. 
Review URL: https://codereview.chromium.org//11411327

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15657 260f80e4-7a28-3924-810f-c04153c831b5
 2012-12-03 21:14:07 +00:00
dgrove@google.com 33abe0ef0a Add authors and homepages to packages. 
Review URL: https://codereview.chromium.org//11418267

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15601 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-30 21:16:01 +00:00
nweiz@google.com 5c7323f35d Keep around a copy of the http.Request that triggered each Response. 
Review URL: https://codereview.chromium.org//11348309

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15555 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-30 00:09:18 +00:00
nweiz@google.com 2c1d51db1c Make pkg/http use HttpClient.shutdown(force: true). 
Review URL: https://codereview.chromium.org//11434018

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15485 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-29 00:47:09 +00:00
nweiz@google.com 558ffd19bf Work around issue 6984. 
This ensures that before an HTTP response is closed, its corresponding
request is drained of input.

Review URL: https://codereview.chromium.org//11348285

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15476 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-28 22:43:10 +00:00
nweiz@google.com 295a066707 Use Futures.forEach in http. 
BUG=

Review URL: https://codereview.chromium.org//11411241

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15475 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-28 22:39:33 +00:00
nweiz@google.com 06e7344e22 Make #maxRedirects and #followRedirects work for the dart:io HTTP client. 
Review URL: https://codereview.chromium.org//11414195

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15433 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-28 01:54:16 +00:00
sgjesse@google.com 7805f03972 Generate an error for active connections when the HTTP client is shutdown 
Before the underlying sockets where just silently closed causing no more IO events on active connections no matter what state they where in.

Also added an optional "force" argument to HttpClient.shutdown. If that is false (the default) The HttpClient will not close active connections until they are done. This causes all pkg/http and pub tests to pass.

R=ager@google.com, nweiz@google.com

BUG=dart:6594

Review URL: https://codereview.chromium.org//11411121

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15275 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-23 09:28:34 +00:00
nweiz@google.com 70e056e7ae Refactor http.Client and http.BaseClient to allow http.Client in type annotations. 
Review URL: https://codereview.chromium.org//11308111

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15124 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-19 23:54:31 +00:00
nweiz@google.com f4e557d746 Move CurlClient to Pub so that it can access resources. 
This CL also enables tests for the client on Linux and OS X.

Review URL: https://codereview.chromium.org//11299028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@15047 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-17 01:15:45 +00:00
nweiz@google.com f1624e45a5 Make the HTTP MockClient work with GET requests. 
Review URL: https://codereview.chromium.org//11293289

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14976 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-15 20:44:32 +00:00
ajohnsen@google.com ab69873a42 Make RegExp constructor non-const. 
Another take of https://codereview.chromium.org/11410033/ with status changes applied for co19 tests.

BUG=

Review URL: https://codereview.chromium.org//11369210

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14837 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-13 10:18:06 +00:00
ajohnsen@google.com ec9fee9858 "Reverting 14829-14832" 
BUG=

Review URL: https://codereview.chromium.org//11312203

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14833 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-13 07:28:13 +00:00
ajohnsen@google.com 8dc3edd7ce Make RegExp's constructor non-const. 
BUG=

Review URL: https://codereview.chromium.org//11410033

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14829 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-13 06:48:43 +00:00
nweiz@google.com 47393b62a0 Add an HTTP client based on Curl. 
Review URL: https://codereview.chromium.org//11394003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14811 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-12 22:01:14 +00:00
nweiz@google.com 7058600a3a Add a multipart HTTP request class. 
Review URL: https://codereview.chromium.org//11363094

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14651 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-07 20:59:59 +00:00
sgjesse@google.com ada7ba7414 Add debug print to try to find the issue with test pkg/http/test/request_test.dart 
The flakines of the test have not been reproduced locally (neither on
Linux nor on Windows). Adding debug print for more diagnstics.

R=ahe@google.com

BUG=

Review URL: https://codereview.chromium.org//11369096

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14579 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-06 15:57:39 +00:00
nweiz@google.com 64c2c67a79 Add a mock HTTP client class. 
Review URL: https://codereview.chromium.org//11362097

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14546 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-05 23:47:00 +00:00
nweiz@google.com 549efe3bdf Add an HTTP library that wraps dart:io. 
Review URL: https://codereview.chromium.org//11363063

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14502 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-02 20:55:01 +00:00
nweiz@google.com e6a33d23fb Reverting 14496 
Review URL: https://codereview.chromium.org//11293075

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14498 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-02 20:13:14 +00:00
nweiz@google.com f6f3e1d556 Add an HTTP library that wraps dart:io. 
Review URL: https://codereview.chromium.org//11338054

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14496 260f80e4-7a28-3924-810f-c04153c831b5
 2012-11-02 19:45:04 +00:00