dart-lang/sdk
1
0
Fork 0
Code Issues Pull Requests Actions 3 Packages Projects Releases Wiki Activity
104,148 Commits 2 Branches 0 Tags
00a3cdff40833b10a1bc00a639f3d653ffe2b5f4
Commit Graph

49559 Commits

Author SHA1 Message Date
Konstantin Shcheglov 00a3cdff40 Elements. Remove FragmentDeclaration, add 'declaredFragment' to Declaration. 
Change-Id: I33398358d1241114b04995767d63188bb314fd6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-11-11 23:39:29 +00:00
Robert Nystrom 82afcb4edd Make the static error test updater not write comments at column zero. 
The old formatter had a special rule that if a line comment as at the
left edge of the page, it would stay there regardless of the surrounding
indentation. So if you had:

```
class C {
  m() {
// comment
  }
}
```

After formatting, the comment would still be there instead of being
indented. The intent of that was to not shift over code that had been
commented out.

But all of the IDEs I tested don't actually work that way. When they
comment out code, they tend to put the `//` at the indentation of the
surrounding code. So the new formatter doesn't have this special rule
and always indents line comments following the surrounding indentation.
This is good because it also means that code generators that don't write
any leading whitespace will still get nicely formatted comments.

However, the static error test updater took advantage of this rule and
would write static error marker comments at column zero if needed to
get the carets to align with the code on the previous line and assume
that the formatter wouldn't move the comment.

This fixes the static error test updater. It always writes comments
using indentation from the previous line of code and if the caret
doesn't fit that way, it uses an explicit column marker.

Fix #57042.

Change-Id: I40fd7cd19d08dc228b6a6797e6a26965d1343d32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394363
Reviewed-by: Nate Bosch <nbosch@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
 2024-11-11 23:36:35 +00:00
Konstantin Shcheglov 0df705aafb Elements. Don't store 'InstanceElementImpl2.methods', build from 'methods2'. 
Change-Id: I5804fe3f0b246bf8184c06d6ca05763c751e6139
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394563
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-11 23:10:48 +00:00
pq e0e4b411ef [element model] migrate unnecessary_this 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I46c62d689518c1091d4aa9262b6939948f6be515
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394562
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-11 22:34:18 +00:00
Sam Rawlins 0b41ef13e5 lint rules: Migrate tests for two rules: 
* unawaited_futures
* void_checks

Change-Id: I7746c3f66d178a84fc8996dac09d53efc664d14a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394560
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
 2024-11-11 22:29:00 +00:00
Kenzie Davisson d18d32d46c Rev tools in SDK DEPS 
This was bumped manually instead of from the rev_sdk_deps.dart script due to https://github.com/dart-lang/sdk/issues/57050.

Change-Id: I2bdd3fc6ab13d8a637d8c138e6ee2709a28f3010
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394006
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
 2024-11-11 22:10:40 +00:00
Devon Carew d1611c39e6 [deps] rev core 
Revisions updated by `dart tools/rev_sdk_deps.dart`.

core (https://github.com/dart-lang/core/compare/1156cfe..6af0821):
  6af0821d  2024-11-07  Devon Carew  add links to the package issue trackers (dart-lang/core#720)

Change-Id: I29a8a64b81a3159dc2ca7dd8d07056bc7c0061ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394402
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
 2024-11-11 21:11:50 +00:00
Konstantin Shcheglov 8a5862ae66 Elements. Remove FragmentedElement. 
Change-Id: If73caa44e64f469a16646794f96be044ad25d33f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394561
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-11 20:58:49 +00:00
Konstantin Shcheglov f33de62674 Elements. Build more Element2 objects. 
Change-Id: I1856610e12c19c2e0fb502fbc324b562cbbe0006
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-11-11 20:53:14 +00:00
pq 0095085914 [element model] migrate avoid_types_as_parameter_names 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I279df798db88bec35276e5e0c66793da9d45fde0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394601
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-11 20:49:55 +00:00
pq 9a76ff8c9f [element model] migrate cascade_invocations 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Ic70839e4c56da27fbc7b3e336d790605e1cf97c2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394600
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-11 20:45:11 +00:00
Danny Tuppeny d131404ddd [DAP] Normalize Directory.current in DAP before launching the process 
We normalize paths to have uppercase drive letters in many places in DAP to avoid mismatches of things like breakpoint paths if the client sends mixed casing.

It's not clear why the change to not host DDS internally affected this, but it seems sensible to perform this normalization here because we're normalizing everywhere else and right now the paths are treated as case-sensitive in many places.

Fixes https://github.com/dart-lang/sdk/issues/56965
Fixes https://github.com/dart-lang/sdk/issues/57011

Change-Id: Ie63ef66058ff9d37955659a780f7bd40cdfc2dc6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392442
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Derek Xu <derekx@google.com>
 2024-11-11 20:19:55 +00:00
pq c861015f9b [element model] migrate obvious_types 
Change-Id: I6a16000296cd8da9b46f8186ba705e0d9ecb9358
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394341
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2024-11-11 19:17:17 +00:00
Konstantin Shcheglov 6be32b412c Elements. Migrate CiderRenameComputerTest. 
Change-Id: Id2b113cb30c7cf8680aa79f4a50a438d61088ba5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394362
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-11-11 19:05:27 +00:00
Danny Tuppeny 04641dcc53 [analysis_server] Allow the client to control whether experimental handlers are registered with DTD 
This will allow testing in-dev features with a real IDE without having to run/build the server from source.

Change-Id: I62cf732e7c4935c111f312eef25afd247759ae7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394502
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-11 18:57:22 +00:00
Konstantin Shcheglov bc54bbc052 Elements. Migrate SelectionCoverageTest. 
Change-Id: Ic2789362bd28da779c685ac80dcfc3bdbb73f9c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394323
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-11 18:31:15 +00:00
Konstantin Shcheglov 5f8a5b1b52 Elements. Migrate SuggestionBuilderTest. 
Change-Id: I1fffab521aceab1f78724250588822c9e3b95e4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2024-11-11 18:04:07 +00:00
Keerti Parthasarathy eb55f44637 [Completion] Do not ask for completion suggestions from plugins 
Change-Id: I8f856a43e27f67948da249c5aae1cd53657438a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
 2024-11-11 16:55:18 +00:00
Danny Tuppeny 613bfa673f [analysis_server] Add a custom LSP handler to fetch editable arguments for the invocation at a position 
This currently only supports int, double, boolean, string.

Change-Id: I236db8594907d28dc5901a384fbafdb34f243528
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394160
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Elliott Brooks <elliottbrooks@google.com>
 2024-11-11 15:38:42 +00:00
Danny Tuppeny 36eca4c4e1 [analysis_server] Remove unused AbstractGoToHandler base class 
As part of the element model migration, the handlers were moved off this base class and just use shared helper functions where they overlap.

Change-Id: I13fcada1cc6b680bed24d3f91ab36e15548ae7c8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394482
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-11 15:29:19 +00:00
Jens Johansen 9a5eed7bd8 [CFE] Fix crash on AmbiguousBuilder in metadata with name 
Change-Id: I9d0c4ef9e5699f4ab916c00def9523929f3da04d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394480
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2024-11-11 13:37:22 +00:00
Jens Johansen 0512c58348 [parser] Use allowCascades when calling parseThrowExpression in _parsePrecedenceExpressionLoop instead of just false 
For now, see what happens.

Bug: https://github.com/dart-lang/sdk/issues/54284
Change-Id: I8e9f081ae3aa5caff7e155ef628e90547cc8afe6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392561
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2024-11-11 09:08:40 +00:00
Johnni Winther 4177d28464 [_fe_analyzer_shared] Support deferencing of StaticGet 
This adds support for replacement a [StaticGet] with the constant
initializer of the referenced constant during evaluation of macro
metadata. Currently constants defined in the same library or
compilation is supported. For full support the constant initializers
need to be included in the outlines/summaries.

Change-Id: I219f85dded63342d4e3f957f0b7321badbe376a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392907
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
 2024-11-11 07:04:20 +00:00
Konstantin Shcheglov 48d8741451 CQ. Tweaks for InsertOnKeyword and tests. 
Change-Id: I7dcdcbceb775fbf07c0bc27ab38a94bc02253086
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394343
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2024-11-09 21:01:01 +00:00
Erik Ernst c9391d7f19 Set obvious/property lints to hasFix 
The lints `omit_obvious_property_types` and
`specify_nonobvious_property_types` previously had error fix status
'needsEvaluation'. This CL changes it to 'hasFix'. This is needed in
order to get access to the fix in IntelliJ.

This CL also corrects a bug whereby a map literal was considered to have an obvious type in cases where there were no actual type arguments and no elements with an obvious type.

Change-Id: Id9305152d086604b78636b696bd97e318ed6bdb5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393280
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-09 16:59:49 +00:00
FMorschel 92663b7303 [DAS] Adds fix for expected 'on' keyword 
R=srawlins@google.com

Fixes https://github.com/dart-lang/sdk/issues/47127

Change-Id: I316a2d29546c9edd3a808785efdbc148007c531b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392540
Auto-Submit: Felipe Morschel <fmorschel.dev@gmail.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2024-11-08 23:57:06 +00:00
Konstantin Shcheglov 6867428db6 Elements. Migrate CiderCompletionComputerTest. 
Change-Id: I9401e2262caee9903c7473afcbb9f68c2f2b84ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394324
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-11-08 23:35:13 +00:00
Konstantin Shcheglov a43ee5d98f Elements. Migrate FlutterTest. 
Change-Id: Ia6f7cfb2e88c8790cdd5324727be154eec409979
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394342
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2024-11-08 23:20:41 +00:00
Konstantin Shcheglov a9ceaf4d6c Elements. Use more 'asElement2' in InheritanceManager3. 
Use '.asElement' to map InterfaceElement2 into 'InterfaceElement'.

Add and use `mapValue` extension method.

Change-Id: I63eb5401d33a696c688a522b463434ef5f3f8ed9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394322
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2024-11-08 23:20:38 +00:00
Konstantin Shcheglov e7aaba1254 Elements. Migrate OverrideHelper. 
Change-Id: I645d901fd0655c33c0c147c2b08a67b4791e6186
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394360
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-11-08 23:05:39 +00:00
Brian Wilkerson 15cdbc5eab Migrate five correction producers 
Change-Id: I3289e0862797947fadf76d78a2ce27c0cf249dd2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394321
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2024-11-08 21:08:18 +00:00
pq 25f8cc52a6 [element model] migrate unreachable_from_main 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I31ee1aff4cbca63b8b66d6fe31a6e901d104fa71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394005
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2024-11-08 21:04:49 +00:00
Danny Tuppeny 7b8de02eda [analysis_server] Update "Go to Imports" to support enhanced parts 
Instead of looking in a single root unit, we now look in each unit up the tree.

Change-Id: I59b0692438dd73fce7be7790ddc24240761d72c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-08 20:02:14 +00:00
Konstantin Shcheglov 73e13d7c79 Elements. Store classes / enums / etc directly in LibraryElementImpl. 
Add them when building or reading.

Change-Id: I11b57f28c4803f7e60d280d6fd4a925b0c46fb60
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393908
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-11-08 19:19:49 +00:00
pq 305c0f3119 [element model] migrate prefer_int_literals 
Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: I539a4612ff5dd6b9df2194b8be4477ea9035c867
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394004
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
 2024-11-08 19:08:26 +00:00
pq c38244e7b6 [element model] migrate void_checks 
Blocked until `ExpressionImpl.correspondingParameter` properly handles members.

Bug: https://github.com/dart-lang/linter/issues/5099
Change-Id: Ia97283f8fcf9873a9a8e2e4dc319c1c5c89ffc4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/392982
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Auto-Submit: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-08 19:04:25 +00:00
Sam Rawlins cb5c73e06f linter: Remove unsafe_html rule 
Fixes https://github.com/dart-lang/linter/issues/5001

Change-Id: I972ea8f9fafda88b6a4836ab92107cebe8a6ad4b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/391303
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2024-11-08 18:31:59 +00:00
Konstantin Shcheglov 39e5e0fdac Elements. Add DynamicElementImpl2, make DynamicElementImpl its fragment. 
Change-Id: I1d88f84f59d2ebdf7e0a5bc3b54d2145b0cb42b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394241
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-08 17:31:26 +00:00
Robert Nystrom 73117f0576 Reformat sdk/ using the new style. 
There should be no actual code changes here, just formatting.

Change-Id: Id7356fdd9a0963ec0965b92e5ca1b218085f162e
CoreLibraryReviewExempt: No behavioral changes
Tested: No meaningful changes, ran on bots
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394000
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
 2024-11-08 15:46:36 +00:00
Danny Tuppeny 9682da5a45 [analysis_server] Migrate LSP "Go to Imports" command to new element model 
Change-Id: I07f53420649b5be11088407b0344186bcb741ae8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393861
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-08 15:37:05 +00:00
Chloe Stefantsova 41db3ab735 [analyzer][cfe] Share constraint generation for record types 
Part of https://github.com/dart-lang/sdk/issues/54902

Change-Id: I90ac37472e14f9d00ef5e7d20a41f2878fb2b8f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393100
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2024-11-08 13:12:55 +00:00
Jens Johansen a9469269d7 [kernel] BinaryReader takes Uint8List, not List<int> 
In AOT this makes reading faster:

Output from `out/ReleaseX64/dart pkg/front_end/tool/benchmarker.dart --iterations=10 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.1 --snapshot=pkg/front_end/test/kernel_binary_bench.aot.2 --arguments="--warmups=10" --arguments="--iterations=5" --arguments="AstFromBinaryEager" --arguments="out/ReleaseX64/vm_platform_strong.dill"`:

```
msec task-clock:u: -8.6925% +/- 0.5737% (-167.09 +/- 11.03)
page-faults:u: 0.1410% +/- 0.0051% (243.00 +/- 8.71)
cycles:u: -10.2918% +/- 0.6161% (-732576747.50 +/- 43853449.16)
instructions:u: -14.4988% +/- 0.0004% (-1636799813.90 +/- 39902.18)
branch-misses:u: -3.4891% +/- 2.1142% (-1166085.00 +/- 706582.35)
seconds time elapsed: -8.7005% +/- 0.5634% (-0.17 +/- 0.01)
seconds user: -9.9752% +/- 1.5104% (-0.17 +/- 0.03)
```

Stats running manually (run as e.g. `out/ReleaseX64/dart-sdk/bin/dartaotruntime pkg/front_end/test/kernel_binary_bench.aot.1 --warmups=10 --iterations=5 AstFromBinaryEager out/ReleaseX64/vm_platform_strong.dill`):

```
AstFromBinaryEagerCold: -12.5174% +/- 3.10688%
AstFromBinaryEagerWarmup: -8.33675% +/- 2.62433%
AstFromBinaryEager: -10.3432% +/- 3.68375%
```

I don't expect there to be much of a change (if any) in JIT as the actual type was in practise always Uint8List anyway.

TEST=Existing tests.

Change-Id: I86b16ed207343848dee2e376f42598c223bbc48f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393740
Reviewed-by: Mayank Patke <fishythefish@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Morgan :) <davidmorgan@google.com>
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
 2024-11-08 08:23:42 +00:00
Ben Konyi 90b52f8aeb [ Frontend Server ] Clear error count before compiling expressions 
Updated FrontendCompiler.compileExpression() to clear previous errors before
compiling the expression. This matches the behavior of
FrontendCompiler.compileExpressionToJs().

Related issue: https://github.com/flutter/flutter/issues/157922

Change-Id: I7bbc163c3f02758be4a495fd753a4ef6cf03c3ce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394220
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
 2024-11-08 07:11:29 +00:00
asiva 8b2b6b2440 Reland ""[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory"" 
This reverts commit 74c5aa3a7a.

Reason for revert: Fix golem breakage by not changing the script dart_precompiled_runtime2

TEST=ci

Original change's description:
> Revert ""[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory""
>
> This reverts commit f81a402aa1.
>
> Reason for revert: golem benchmarks are failing to run
>
> TEST=ci
>
> Original change's description:
> > "[SDK/VM] - Rename dart_precompiled_runtime to dartaotruntime, ensures we have a uniform name for the executable between the build directories and the SDK directory"
> >
> > Fixed golem breakage by temporarily copying dartaotruntime to dart_precompiled_runtime
> >
> > This reverts commit 75e6a748f7.
> >
> > TEST=ci
> >

Change-Id: I9efe40643c59bc617f6fb484b89b038deaffbb93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393941
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
 2024-11-08 04:36:23 +00:00
Brian Wilkerson 365941b268 Document some lint diagnostics 
Change-Id: I38ba6f77a7d25e3f4716c2b2432b790c973c5650
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/390303
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2024-11-08 00:49:18 +00:00
Jonas Finnemann Jensen d2d5de63a4 Avoid context confusion in ServerPlugin.analyzeFiles 
Change-Id: Ib2500c17e4abe2a485fb8325134276f803113db4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/388701
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
 2024-11-07 23:47:12 +00:00
Konstantin Shcheglov f35cbc95e3 Elements. Add NeverElementImpl2, make NeverElementImpl its fragment. 
Change-Id: I3ef636dec6a678e30c44f0551276a8b3557a7641
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394240
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
 2024-11-07 22:58:46 +00:00
Konstantin Shcheglov 0b22187189 Issue 57043. Fix infinite FileKind recursion when part references itself. 
Bug: https://github.com/dart-lang/sdk/issues/57043
Change-Id: I8bde1d5f6b1d2eb9bd3e42ec74261d492e9303e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393906
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-11-07 22:08:39 +00:00
Konstantin Shcheglov ea86e0fe39 Elements. Return nullable 'LibraryFragment?' from 'get libraryFragment'. 
We can have synthetic 'FormalParameterFragment' and 'TypeParameterFragment'
that don't have any enclosing 'LibraryFragment'.

Change-Id: Icc1a47c308e55b93ed6a2aad70788058e26ee803
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/393500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-11-07 21:59:29 +00:00
Konstantin Shcheglov 3e6e13dee8 Element. Implement MultiplyDefinedElement2 and MultiplyDefinedFragment. 
Bug: https://github.com/dart-lang/sdk/issues/57041
Change-Id: I4272137f6b48dfa784d23d0f9fc206b3bad12819
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/394180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2024-11-07 20:54:49 +00:00