Commit Graph

10 Commits

Author SHA1 Message Date
Robert Nystrom e5194dae87 Reformat tools/ and utils/ using the 3.8 style.
Change-Id: I7b28583eb928f60a45d1f476194d197b4df88062
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/425184
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Lasse Nielsen <lrn@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2025-04-29 10:40:59 -07:00
Halil Durmus 1a8afa6bbf [vm/ffi] Allow omitting native types for @Native functions
This change simplifies working with `@Native`-annotated functions by allowing the native type to be omitted when it can be inferred from the Dart function's signature. While this was previously supported for `@Native` fields, it now applies to functions as well.

Before this change, you needed to specify the native type explicitly:
```
@Native<Void Function(Pointer)>()
external void free(Pointer p);
```

After this change, the native type can now be omitted if it's clear from the Dart signature:
```
@Native()
external void free(Pointer p);
```

TEST=tests/ffi/native_assets/*

CoreLibraryReviewExempt: VM only
Closes: https://github.com/dart-lang/sdk/issues/54810
Change-Id: Ied5407fcd2f49d85284cb7817f0c8cad2a73626b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/400840
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Moritz Sümmermann <mosum@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2024-12-20 02:05:40 -08:00
Devon Carew dd5b9cd7d7 [tools/] remove many uses of dynamic in the tools/ directory
Change-Id: I1bd930c11e0463ba0de1938ba417b6664c8cdb28
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/376023
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2024-07-17 15:38:50 +00:00
Oleh Prypin e9df8dceab Revert "[tool] tools/find_builders.dart cbuild opt in"
This reverts commit 86c41c9c77.

Reason for revert: This builder is now included by default

Original change's description:
> [tool] `tools/find_builders.dart` cbuild opt in
>
> Opt in to CBuild being green.
>
> Remove denylisted bots now that issue is resolved.
>
> Change-Id: I89c23720eaed78b317067bbdb065fe0cef8ecd75
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356022
> Commit-Queue: Daco Harkes <dacoharkes@google.com>
> Reviewed-by: William Hesse <whesse@google.com>

Change-Id: Ife49afc47f576901d2b8bb5523d2c8ed5224a761
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/359862
Auto-Submit: Oleh Prypin <oprypin@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2024-03-27 13:01:49 +00:00
Oleh Prypin fc5f82c244 [tool] Use new builder name syntax for tools/find_builders.dart
See mentions of migrating from legacy syntax from back when it was ongoing: https://g-issues.chromium.org/issues/40170614#comment36

Change-Id: If592c5bcf40b2e56f9b18fcf27f74d767f97375a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356041
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>
2024-03-06 15:49:54 +00:00
Daco Harkes 86c41c9c77 [tool] tools/find_builders.dart cbuild opt in
Opt in to CBuild being green.

Remove denylisted bots now that issue is resolved.

Change-Id: I89c23720eaed78b317067bbdb065fe0cef8ecd75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356022
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2024-03-06 14:03:19 +00:00
Daco Harkes 3105c841d4 [tool] find_builders skip flaky builders
Bug: https://github.com/dart-lang/sdk/issues/51170
Change-Id: I5fbc97838b78f8efdab3a16c907976afaac43d4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/349660
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2024-02-01 11:20:47 +00:00
Daco Harkes 2e87f8c95a [tools] Fixes to find_builders.dart
Fixes the Gerrit CL footer.

Denylists some builders which are not available on CQ but only on CI.

Change-Id: Ie0716c52366a8be429c2b6aca030e61769ceca80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/316382
Reviewed-by: William Hesse <whesse@google.com>
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
2023-07-26 16:02:56 +00:00
William Hesse dab8ab7420 [tools] Use pattern matching in find_builders.dart
Minor changes to find_builders.dart script to use pattern
matching, drop duplicate builders, and drop some type casts.

Change-Id: I463ba8352622dc66678aa71627d84130308da9a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/315261
Reviewed-by: Daco Harkes <dacoharkes@google.com>
2023-07-25 09:30:16 +00:00
Daco Harkes 87aba00a12 [tool] find_builders.dart
A script to find all try jobs for a set of tests.

Usage:

```
$ tools/find_builders.dart ffi/regress_51504_test ffi/regress_51913_test
Cq-Include-Trybots: luci.dart.try:vm-kernel-linux-debug-x64,...
```

Change-Id: I85abd3ca2b2adf4e184a38f5ef821d40fbd97bf2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/314800
Auto-Submit: Daco Harkes <dacoharkes@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
2023-07-24 09:07:04 +00:00