Commit Graph

9 Commits

Author SHA1 Message Date
Ryan Macnak c1f11fed3f [tools] Fix binary_size to work with Dart AOT snapshots.
- Make the size tools less dependent on quirks mode.
 - Add explicit language attribute so Chrome stops offering to translate.
 - Add zip_size to look at the Dart SDK and Flutter APKs.

Change-Id: I0017bd68145344e2427644fcccd13f9b9f307218
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/428064
Reviewed-by: Brian Quinlan <bquinlan@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2025-05-12 15:29:08 -07:00
Josh Soref f7a2ea5e06 Spelling
Closes https://github.com/dart-lang/sdk/pull/50922

GitOrigin-RevId: 58fd7cfd5ef470a65a52ea28e0407244d853c917
Change-Id: I2e5a5ed991cb05270170a18b8f0169daa9eabdb7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/278537
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2023-01-24 18:00:25 +00:00
Ryan Macnak a1089367cc [graphexplorer] Rename bounds variables for successor and predecessor iteration.
Based on suggestion from code review.

Change-Id: I51b3dbbd6f9822842f154cd90c9a020194ed16f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/266443
Reviewed-by: Derek Xu <derekx@google.com>
2022-10-28 20:07:24 +00:00
Ryan Macnak b7f4afaf27 [graphexplorer] Use owned size instead of retained size for groups.
Unlike retained size, owned size is a partitioning, so it can be naively summed. This replaces an almost quadratic step with a linear step.

TEST=load a large snapshot, such as from dart2js
Change-Id: I49479f6e17b911965def62e9b44fc202ce6a9b9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265961
Reviewed-by: Derek Xu <derekx@google.com>
2022-10-28 18:03:30 +00:00
Ryan Macnak 419d6381bb [graphexplorer] Use an explicit stack in forest compression to prevent JS stack overflow.
Compare Observatory's object_graph.dart.

TEST=load a large snapshot, such as from dart2js
Change-Id: Ifea2ff4c06f5103d6f1f709fa79183398df90687
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/265404
Reviewed-by: Derek Xu <derekx@google.com>
2022-10-25 16:15:48 +00:00
Ryan Macnak 77487355b7 [graphexplorer] Support Dart heap snapshot format and merged dominators.
Change-Id: I492b7662054c64030d36aba2e236aea4127101ab
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205200
Reviewed-by: Ben Konyi <bkonyi@google.com>
2021-07-07 15:44:22 +00:00
Ryan Macnak 83eeab1e63 Miscellaneous documentation updates.
Change-Id: I9cc022443ba70b0a450a86943f7636dc6f8c975c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128373
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2019-12-13 23:10:55 +00:00
Ryan Macnak afb8747fc2 [vm/tools] Add option in Graph Explorer to rewrite the graph to be more hierarchical.
Helps to reveal more struction in the dominator tree that is normally lost from cross links added by call sites, allocation sites, inlining, etc.

Change-Id: Ib59350f9926324e6c53333388709ce4964c3f88b
Reviewed-on: https://dart-review.googlesource.com/c/94300
Reviewed-by: Aart Bik <ajcbik@google.com>
2019-02-25 21:21:02 +00:00
Ryan Macnak 7329247892 [vm/tools] Add Graph Explorer to visualize output of --write_v8_snapshot_profile_to.
In particular, this tool can produce treemap visualizations of the dominator tree.

Change-Id: If582c80213b4bdec9ff8ee4d5d61a1e15bf342e5
Reviewed-on: https://dart-review.googlesource.com/c/92900
Reviewed-by: Aart Bik <ajcbik@google.com>
2019-02-13 19:30:37 +00:00