Commit Graph

8 Commits

Author SHA1 Message Date
Paul Berry 3186c708a2 [testing] Migrate to new constructor decl syntax.
(Part of https://github.com/dart-lang/sdk/issues/63288)

This change migrates the testing package to use the new constructor
declaration syntax, described in
https://github.com/dart-lang/language/blob/main/accepted/future-releases/primary-constructors/feature-specification.md#abbreviations-of-in-body-constructor-declarations.

This change was performed in an automated fashion, by (a) bumping the
package's SDK constraint to `3.13.0-0`, (b) enabling the lints
`unnecessary_type_name_in_constructor` and
`unnecessary_const_in_enum_constructor`, (c) fixing the resulting lint
failures using `dart fix`, and then (d) reformatting the affected
files.

To ease code review, I've reverted unrelated formatting changes.

Change-Id: I01dab822f08d804d5c7ce997dee6d7866a6a6964
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/508427
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2026-06-01 18:04:45 -07:00
Parker Lougheed ffc82e6f17 Stop enabling the package_api_docs lint
The lint is non-functional and will be deprecated soon.

Bug: https://github.com/dart-lang/linter/issues/5107
Change-Id: I4d4b75a6c7978f584bef37351514391f55761c55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/389594
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Auto-Submit: Parker Lougheed <parlough@gmail.com>
2024-10-14 21:22:19 +00:00
Devon Carew 828e6032b3 [pkg/testing] restore analysis options settings
Use package:lints/recommended.yaml for pkg/testing.

Change-Id: I15aedcc4c82447a9d033b575adae745eb138f6f5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/363484
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2024-04-19 14:45:41 +00:00
Jens Johansen 6c897ba077 Remove unused options from package:testing (batch 2)
Change-Id: I7f9227f3b00d84db5c29e8e5da88dba69def91cc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/346760
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2024-01-19 08:15:03 +00:00
Devon Carew 0bed5e0398 [pkg/testing] use package:lints/recommended.yaml
Change-Id: If3836cb1758671ccd53bfe2b227b7489a9855fa5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283460
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2023-02-17 01:34:34 +00:00
Devon Carew b27709f1b8 [pkg/testing] analyze using package:lints
Change-Id: If43bc64029ac00575dc154b797fc7630d4dac82e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250764
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2022-07-06 18:55:40 +00:00
Devon Carew 770436d477 More options files cleanup.
Change-Id: I12d067c8b3f52fe95026a642d83bb226405b5c45
Reviewed-on: https://dart-review.googlesource.com/c/81723
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-10-26 23:05:44 +00:00
Peter von der Ahé 964384424a Analyze package:testing.
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2941493002 .
2017-06-13 15:46:04 +02:00