This commit was generated by the following steps:
- Manually change the SDK constraint in `pkg/front_end/pubspec.yaml`
- Run `gclient sync`
- Run `find pkg/front_end/benchmarks pkg/front_end/lib
pkg/front_end/presubmit_helper.dart
pkg/front_end/presubmit_helper_spawn.dart pkg/front_end/test
pkg/front_end/tool -iname '*.dart' | xargs
tools/sdks/dart-sdk/bin/dart format`
- Manually fix remaining long lines and add dead code ignore comments.
- Fix coverage by running `dart --enable-asserts
pkg/front_end/test/coverage_suite.dart --tasks=5
--add-and-remove-comments`
- Fix `pkg/front_end/test/coverage_merger/assert_message_auto_ignored`
by running `dart pkg/front_end/test/unit_test_suites.dart -p
pkg/front_end/test/coverage_merger/assert_message_auto_ignored
-DupdateExpectations=true`
The diff is large because the version bump causes the formatter to
switch into "tall mode".
Change-Id: I6a6a696410da8b168060acfe0e4d6e91e294c4f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/447628
Auto-Submit: Paul Berry <paulberry@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
This updates the datatypes benchmark to include a strategy that
uses pattern matching. This show that pattern matching is
comparable to if-then-else and should be used.
Change-Id: Icaf7644e5817767959c639ce655be7d4012ea5d2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/377980
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Chloe Stefantsova <cstefantsova@google.com>
This CL adds an initial framework for testing performance of programming
patterns. Included is a test of the pattern used to choose
implementation based on a runtime type, using either an if-then-else
sequence, dynamic dispatch on the runtime object, or visitor pattern.
The test framework runs the patterns on a range of inputs using a
predefined set of scenarios and outputs a table of the measurements which
can be copied into Google Sheets to visualize the results.
Further work is to use statistics to quantify the results, and expand
the framework to be used to detect asymptotic performance of algorithms
used in the compiler itself.
Change-Id: Ic99588d13adead309715957e1bc0aa6def46c9dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/226104
Reviewed-by: Jens Johansen <jensj@google.com>
Paul Berry